[{"id":1767532,"web_url":"http://patchwork.ozlabs.org/comment/1767532/","msgid":"<20170912.204557.891051979478318768.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-13T03:45:57","subject":"Re: [PATCH v4 2/2] ip6_tunnel: fix ip6 tunnel lookup in collect_md\n\tmode","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Haishuang Yan \nDate: Tue, 12 Sep 2017 17:47:57 +0800\n\n> In collect_md mode, if the tun dev is down, it still can call\n> __ip6_tnl_rcv to receive on packets, and the rx statistics increase\n> improperly.\n> \n> When the md tunnel is down, it's not neccessary to increase RX drops\n> for the tunnel device, packets would be recieved on fallback tunnel,\n> and the RX drops on fallback device will be increased as expected.\n> \n> Fixes: 8d79266bc48c (\"ip6_tunnel: add collect_md mode to IPv6 tunnels\")\n> Cc: Alexei Starovoitov \n> Signed-off-by: Haishuang Yan \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsSJ3662vz9sNr\n\tfor ;\n\tWed, 13 Sep 2017 13:46:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751868AbdIMDqD (ORCPT );\n\tTue, 12 Sep 2017 23:46:03 -0400","from shards.monkeyblade.net ([184.105.139.130]:37310 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751832AbdIMDp6 (ORCPT\n\t); Tue, 12 Sep 2017 23:45:58 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 8EF5610241E28;\n\tTue, 12 Sep 2017 20:45:57 -0700 (PDT)"],"Date":"Tue, 12 Sep 2017 20:45:57 -0700 (PDT)","Message-Id":"<20170912.204557.891051979478318768.davem@davemloft.net>","To":"yanhaishuang@cmss.chinamobile.com","Cc":"kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org, ast@fb.com","Subject":"Re: [PATCH v4 2/2] ip6_tunnel: fix ip6 tunnel lookup in collect_md\n\tmode","From":"David Miller ","In-Reply-To":"<1505209677-12728-2-git-send-email-yanhaishuang@cmss.chinamobile.com>","References":"<1505209677-12728-1-git-send-email-yanhaishuang@cmss.chinamobile.com>\n\t<1505209677-12728-2-git-send-email-yanhaishuang@cmss.chinamobile.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 12 Sep 2017 20:45:57 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]