[{"id":1766587,"web_url":"http://patchwork.ozlabs.org/comment/1766587/","msgid":"<1827777248.5103399.1505166447511.JavaMail.zimbra@redhat.com>","list_archive_url":null,"date":"2017-09-11T21:47:27","subject":"Re: [Qemu-devel] [PATCH v2 3/5] tcg: move tcg-runtime to accel/tcg/","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"----- Original Message -----\n> From: \"Philippe Mathieu-Daudé\" \n> To: \"Paolo Bonzini\" , \"Richard Henderson\" , \"Peter Crosthwaite\"\n> , \"Thomas Huth\" \n> Cc: \"Philippe Mathieu-Daudé\" , qemu-devel@nongnu.org\n> Sent: Monday, September 11, 2017 11:33:26 PM\n> Subject: [PATCH v2 3/5] tcg: move tcg-runtime to accel/tcg/\n> \n> Suggested-by: Paolo Bonzini \n> Signed-off-by: Philippe Mathieu-Daudé \n\nTo make this better, the \"#ifndef CONFIG_SOFTMMU\" part at the\nend of this should be moved to user-exec.c. Feel free to just\npost a sixth patch for it.\n\nPaolo\n\n> ---\n> Makefile.target | 2 +-\n> {tcg => accel/tcg}/tcg-runtime.h | 0\n> {tcg => accel/tcg}/tcg-runtime.c | 0\n> accel/tcg/Makefile.objs | 1 +\n> 4 files changed, 2 insertions(+), 1 deletion(-)\n> rename {tcg => accel/tcg}/tcg-runtime.h (100%)\n> rename {tcg => accel/tcg}/tcg-runtime.c (100%)\n> \n> diff --git a/Makefile.target b/Makefile.target\n> index 520305b025..6361f957fb 100644\n> --- a/Makefile.target\n> +++ b/Makefile.target\n> @@ -94,7 +94,7 @@ all: $(PROGS) stap\n> obj-y += exec.o\n> obj-y += accel/\n> obj-$(CONFIG_TCG) += tcg/tcg.o tcg/tcg-op.o tcg/optimize.o\n> -obj-$(CONFIG_TCG) += tcg/tcg-common.o tcg/tcg-runtime.o\n> +obj-$(CONFIG_TCG) += tcg/tcg-common.o\n> obj-$(CONFIG_TCG_INTERPRETER) += tcg/tci.o\n> obj-$(CONFIG_TCG_INTERPRETER) += disas/tci.o\n> obj-y += fpu/softfloat.o\n> diff --git a/tcg/tcg-runtime.h b/accel/tcg/tcg-runtime.h\n> similarity index 100%\n> rename from tcg/tcg-runtime.h\n> rename to accel/tcg/tcg-runtime.h\n> diff --git a/tcg/tcg-runtime.c b/accel/tcg/tcg-runtime.c\n> similarity index 100%\n> rename from tcg/tcg-runtime.c\n> rename to accel/tcg/tcg-runtime.c\n> diff --git a/accel/tcg/Makefile.objs b/accel/tcg/Makefile.objs\n> index f2422d0fb3..228cd84fa4 100644\n> --- a/accel/tcg/Makefile.objs\n> +++ b/accel/tcg/Makefile.objs\n> @@ -1,5 +1,6 @@\n> obj-$(CONFIG_SOFTMMU) += tcg-all.o\n> obj-$(CONFIG_SOFTMMU) += cputlb.o\n> +obj-y += tcg-runtime.o\n> obj-y += cpu-exec.o cpu-exec-common.o translate-all.o\n> obj-y += translator.o\n> \n> --\n> 2.14.1\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=pbonzini@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrhP93Kdqz9s7F\n\tfor ;\n\tTue, 12 Sep 2017 07:47:57 +1000 (AEST)","from localhost ([::1]:60768 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drWYd-0001fT-Ij\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 17:47:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49533)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drWYI-0001f3-JR\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:47:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drWYD-0004hY-LR\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:47:34 -0400","from mx1.redhat.com ([209.132.183.28]:38634)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drWYD-0004gS-C5\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:47:29 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 29BB365141;\n\tMon, 11 Sep 2017 21:47:28 +0000 (UTC)","from colo-mx.corp.redhat.com\n\t(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0EE7060FC8;\n\tMon, 11 Sep 2017 21:47:28 +0000 (UTC)","from zmail18.collab.prod.int.phx2.redhat.com\n\t(zmail18.collab.prod.int.phx2.redhat.com [10.5.83.21])\n\tby colo-mx.corp.redhat.com (Postfix) with ESMTP id CD0B51800C89;\n\tMon, 11 Sep 2017 21:47:27 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 29BB365141","Date":"Mon, 11 Sep 2017 17:47:27 -0400 (EDT)","From":"Paolo Bonzini ","To":"Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= ","Message-ID":"<1827777248.5103399.1505166447511.JavaMail.zimbra@redhat.com>","In-Reply-To":"<20170911213328.9701-4-f4bug@amsat.org>","References":"<20170911213328.9701-1-f4bug@amsat.org>\n\t<20170911213328.9701-4-f4bug@amsat.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Originating-IP":"[78.12.246.117, 10.4.196.23, 10.4.195.12]","Thread-Topic":"move tcg-runtime to accel/tcg/","Thread-Index":"reDJ0MB+0NdJ9FMmOjqs0EQGwZfkEg==","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 11 Sep 2017 21:47:28 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 3/5] tcg: move tcg-runtime to accel/tcg/","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Thomas Huth ,\n\tPeter Crosthwaite ,\n\tqemu-devel@nongnu.org, Richard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]