[{"id":1766591,"web_url":"http://patchwork.ozlabs.org/comment/1766591/","msgid":"<003201d32b48$b2dfafc0$189f0f40$@ovn.org>","list_archive_url":null,"date":"2017-09-11T21:55:35","subject":"Re: [ovs-dev] [PATCH] test: Avoid using 'truncate' command","submitter":{"id":72181,"url":"http://patchwork.ozlabs.org/api/people/72181/","name":"Alin-Gabriel Serdean","email":"aserdean@ovn.org"},"content":"Tested-by: Alin Gabriel Serdean \nAcked-by: Alin Gabriel Serdean \n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Mark Michelson\n> Sent: Monday, September 11, 2017 11:58 PM\n> To: dev@openvswitch.org\n> Subject: [ovs-dev] [PATCH] test: Avoid using 'truncate' command\n> \n> The 'truncate' command is not available on all platforms. Since the\ncommand\n> was being used to zero out a file, there are other easy options available.\nIn\n> this case, I've replaced 'truncate' with a redirection.\n> \n> Reported-by: Alin Gabriel Serdean \n> Signed-off-by: Mark Michelson \n> ---\n> tests/ovn.at | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/tests/ovn.at b/tests/ovn.at index 2a00232ed..6c38b973f 100644\n> --- a/tests/ovn.at\n> +++ b/tests/ovn.at\n> @@ -8501,7 +8501,7 @@ ovn-nbctl --wait=hv --timeout=3 sync # doesn't\n> have the same effect because \"name\" is conserved, and the # Chassis entry\n> is not replaced.\n> \n> -truncate -s 0 gw1/ovn-controller.log\n> +> gw1/ovn-controller.log\n> \n> gw2_chassis=$(ovn-sbctl --bare --columns=_uuid find Chassis name=gw2)\n> ovn-sbctl destroy Chassis $gw2_chassis\n> --\n> 2.13.5\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrhZ46kXXz9s7F\n\tfor ;\n\tTue, 12 Sep 2017 07:55:40 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id C67BBC7A;\n\tMon, 11 Sep 2017 21:55:38 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 06481504\n\tfor ; Mon, 11 Sep 2017 21:55:38 +0000 (UTC)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 1CBBBE0\n\tfor ; Mon, 11 Sep 2017 21:55:37 +0000 (UTC)","from cloudbasealin (unknown [79.114.118.98])\n\t(Authenticated sender: aserdean@ovn.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id CC5D0FB881;\n\tMon, 11 Sep 2017 23:55:34 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"79.114.118.98","From":"","To":"\"'Mark Michelson'\" ,\n\t","References":"<20170911205812.19415-1-mmichels@redhat.com>","In-Reply-To":"<20170911205812.19415-1-mmichels@redhat.com>","Date":"Tue, 12 Sep 2017 00:55:35 +0300","Message-ID":"<003201d32b48$b2dfafc0$189f0f40$@ovn.org>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 16.0","thread-index":"AQHTK0C3G2TOJpNzNkyUWJYeWVyB4aKwOo+g","Content-Language":"ro","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] test: Avoid using 'truncate' command","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1766617,"web_url":"http://patchwork.ozlabs.org/comment/1766617/","msgid":"<20170911230233.GJ6175@ovn.org>","list_archive_url":null,"date":"2017-09-11T23:02:33","subject":"Re: [ovs-dev] [PATCH] test: Avoid using 'truncate' command","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"Alin, since Mark isn't a committer, and you are, it's probably best to\njust apply this yourself.\n\nOn Tue, Sep 12, 2017 at 12:55:35AM +0300, aserdean@ovn.org wrote:\n> Tested-by: Alin Gabriel Serdean \n> Acked-by: Alin Gabriel Serdean \n> \n> > -----Original Message-----\n> > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> > bounces@openvswitch.org] On Behalf Of Mark Michelson\n> > Sent: Monday, September 11, 2017 11:58 PM\n> > To: dev@openvswitch.org\n> > Subject: [ovs-dev] [PATCH] test: Avoid using 'truncate' command\n> > \n> > The 'truncate' command is not available on all platforms. Since the\n> command\n> > was being used to zero out a file, there are other easy options available.\n> In\n> > this case, I've replaced 'truncate' with a redirection.\n> > \n> > Reported-by: Alin Gabriel Serdean \n> > Signed-off-by: Mark Michelson \n> > ---\n> > tests/ovn.at | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/tests/ovn.at b/tests/ovn.at index 2a00232ed..6c38b973f 100644\n> > --- a/tests/ovn.at\n> > +++ b/tests/ovn.at\n> > @@ -8501,7 +8501,7 @@ ovn-nbctl --wait=hv --timeout=3 sync # doesn't\n> > have the same effect because \"name\" is conserved, and the # Chassis entry\n> > is not replaced.\n> > \n> > -truncate -s 0 gw1/ovn-controller.log\n> > +> gw1/ovn-controller.log\n> > \n> > gw2_chassis=$(ovn-sbctl --bare --columns=_uuid find Chassis name=gw2)\n> > ovn-sbctl destroy Chassis $gw2_chassis\n> > --\n> > 2.13.5\n> > \n> > _______________________________________________\n> > dev mailing list\n> > dev@openvswitch.org\n> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrk3Z4j6vz9s7B\n\tfor ;\n\tTue, 12 Sep 2017 09:02:49 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id C5CBDD07;\n\tMon, 11 Sep 2017 23:02:45 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id E2760CD4\n\tfor ; Mon, 11 Sep 2017 23:02:44 +0000 (UTC)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 4A77A479\n\tfor ; Mon, 11 Sep 2017 23:02:44 +0000 (UTC)","from ovn.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 643B6FB88B;\n\tTue, 12 Sep 2017 01:02:40 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.2.3","Date":"Mon, 11 Sep 2017 16:02:33 -0700","From":"Ben Pfaff ","To":"aserdean@ovn.org","Message-ID":"<20170911230233.GJ6175@ovn.org>","References":"<20170911205812.19415-1-mmichels@redhat.com>\n\t<003201d32b48$b2dfafc0$189f0f40$@ovn.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<003201d32b48$b2dfafc0$189f0f40$@ovn.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] test: Avoid using 'truncate' command","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1766627,"web_url":"http://patchwork.ozlabs.org/comment/1766627/","msgid":"<004c01d32b59$363cbbf0$a2b633d0$@ovn.org>","list_archive_url":null,"date":"2017-09-11T23:53:47","subject":"Re: [ovs-dev] [PATCH] test: Avoid using 'truncate' command","submitter":{"id":72181,"url":"http://patchwork.ozlabs.org/api/people/72181/","name":"Alin-Gabriel Serdean","email":"aserdean@ovn.org"},"content":"Thanks Mark! I applied this on master and branch-2.8.\n\nBen: Thanks for the encouragement 😊.\n\nAlin.\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Ben Pfaff\n> Sent: Tuesday, September 12, 2017 2:03 AM\n> To: aserdean@ovn.org\n> Cc: dev@openvswitch.org\n> Subject: Re: [ovs-dev] [PATCH] test: Avoid using 'truncate' command\n> \n> Alin, since Mark isn't a committer, and you are, it's probably best to just apply\n> this yourself.\n> \n> On Tue, Sep 12, 2017 at 12:55:35AM +0300, aserdean@ovn.org wrote:\n> > Tested-by: Alin Gabriel Serdean \n> > Acked-by: Alin Gabriel Serdean \n> >\n> > > -----Original Message-----\n> > > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> > > bounces@openvswitch.org] On Behalf Of Mark Michelson\n> > > Sent: Monday, September 11, 2017 11:58 PM\n> > > To: dev@openvswitch.org\n> > > Subject: [ovs-dev] [PATCH] test: Avoid using 'truncate' command\n> > >\n> > > The 'truncate' command is not available on all platforms. Since the\n> > command\n> > > was being used to zero out a file, there are other easy options available.\n> > In\n> > > this case, I've replaced 'truncate' with a redirection.\n> > >\n> > > Reported-by: Alin Gabriel Serdean \n> > > Signed-off-by: Mark Michelson ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrlBk71Fzz9sBZ\n\tfor ;\n\tTue, 12 Sep 2017 09:54:06 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 02004B7D;\n\tMon, 11 Sep 2017 23:53:51 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 4E55C98A\n\tfor ; Mon, 11 Sep 2017 23:53:49 +0000 (UTC)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id AC6F0113\n\tfor ; Mon, 11 Sep 2017 23:53:48 +0000 (UTC)","from cloudbasealin (unknown [79.114.118.98])\n\t(Authenticated sender: aserdean@ovn.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id EA41AA80C1;\n\tTue, 12 Sep 2017 01:53:46 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"79.114.118.98","From":"","To":"\"'Ben Pfaff'\" ,\n\t","References":"<20170911205812.19415-1-mmichels@redhat.com>\t<003201d32b48$b2dfafc0$189f0f40$@ovn.org>\n\t<20170911230233.GJ6175@ovn.org>","In-Reply-To":"<20170911230233.GJ6175@ovn.org>","Date":"Tue, 12 Sep 2017 02:53:47 +0300","Message-ID":"<004c01d32b59$363cbbf0$a2b633d0$@ovn.org>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 16.0","thread-index":"AQHTK0C3G2TOJpNzNkyUWJYeWVyB4aKwOo+g///xgoCAAC3I4A==","Content-Language":"ro","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] test: Avoid using 'truncate' command","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]