[{"id":1766897,"web_url":"http://patchwork.ozlabs.org/comment/1766897/","msgid":"<E1dripb-0006lw-6v@mail.theobroma-systems.com>","list_archive_url":null,"date":"2017-09-12T10:54:15","subject":"Re: [U-Boot] [U-Boot,v3,04/19] dm: core: add dev_read_addr_ptr()","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"> The dev_read_addr_ptr() mimics the behaviour of the devfdt_get_addr_ptr(),\n> retrieving the first address of the node's reg-property and returning\n> it as a pointer (or NULL on failure).\n> \n> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>\n> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>\n> ---\n> \n> Changes in v3: None\n> Changes in v2:\n> - implements the dev_read_addr_ptr() function\n> \n>  drivers/core/read.c |  7 +++++++\n>  include/dm/read.h   | 15 +++++++++++++++\n>  2 files changed, 22 insertions(+)\n> \n\nApplied to u-boot-rockchip, thanks!","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs25d75Spz9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 21:05:41 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C2F0CC2209F; Tue, 12 Sep 2017 10:55:35 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A88B3C22053;\n\tTue, 12 Sep 2017 10:54:43 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2BA49C21EF0; Tue, 12 Sep 2017 10:54:16 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 64FA9C22025\n\tfor <u-boot@lists.denx.de>; Tue, 12 Sep 2017 10:54:16 +0000 (UTC)","from [86.59.122.178] (port=52457 helo=vpn-10-11-0-14.lan)\n\tby mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from <philipp.tomsich@theobroma-systems.com>)\n\tid 1dripb-0006lw-6v; Tue, 12 Sep 2017 12:54:15 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","MIME-Version":"1.0","From":"Philipp Tomsich <philipp.tomsich@theobroma-systems.com>","To":"Philipp Tomsich <philipp.tomsich@theobroma-systems.com>","In-Reply-To":"<1505160270-10650-5-git-send-email-philipp.tomsich@theobroma-systems.com>","References":"<1505160270-10650-5-git-send-email-philipp.tomsich@theobroma-systems.com>","Message-Id":"<E1dripb-0006lw-6v@mail.theobroma-systems.com>","Date":"Tue, 12 Sep 2017 12:54:15 +0200","Cc":"u-boot@lists.denx.de, Klaus Goger <klaus.goger@theobroma-systems.com>","Subject":"Re: [U-Boot] [U-Boot,v3,04/19] dm: core: add dev_read_addr_ptr()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1781478,"web_url":"http://patchwork.ozlabs.org/comment/1781478/","msgid":"<12491177-209e-c6c4-e4be-7ff565b84982@gmx.de>","list_archive_url":null,"date":"2017-10-06T11:47:42","subject":"Re: [U-Boot] [U-Boot,v3,04/19] dm: core: add dev_read_addr_ptr()","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 09/11/2017 10:04 PM, Philipp Tomsich wrote:\n> The dev_read_addr_ptr() mimics the behaviour of the devfdt_get_addr_ptr(),\n> retrieving the first address of the node's reg-property and returning\n> it as a pointer (or NULL on failure).\n> \n> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>\n> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>\n> ---\n> \n> Changes in v3: None\n> Changes in v2:\n> - implements the dev_read_addr_ptr() function\n> \n>  drivers/core/read.c |  7 +++++++\n>  include/dm/read.h   | 15 +++++++++++++++\n>  2 files changed, 22 insertions(+)\n> \n> diff --git a/drivers/core/read.c b/drivers/core/read.c\n> index 6acb333..065589a 100644\n> --- a/drivers/core/read.c\n> +++ b/drivers/core/read.c\n> @@ -57,6 +57,13 @@ fdt_addr_t dev_read_addr(struct udevice *dev)\n>  \treturn dev_read_addr_index(dev, 0);\n>  }\n>  \n> +void *dev_read_addr_ptr(struct udevice *dev)\n> +{\n> +\tfdt_addr_t addr = dev_read_addr(dev);\n> +\n> +\treturn (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr;\n\nHello Philipp,\n\nthis line produces a compiler warning:\n\n   sandbox:  +   sandbox\n+  return (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr;\n+                                            ^\nw+drivers/core/read.c: In function ?dev_read_addr_ptr?:\nw+drivers/core/read.c:64:44: warning: cast to pointer from integer of\ndifferent size [-Wint-to-pointer-cast]\n\nCould you, please, provide a follow-up patch.\n\nRegards\n\nHeinrich\n\n> +}\n> +\n>  fdt_addr_t dev_read_addr_size(struct udevice *dev, const char *property,\n>  \t\t\t\tfdt_size_t *sizep)\n>  {\n> diff --git a/include/dm/read.h b/include/dm/read.h\n> index 49d69c9..e7f7125 100644\n> --- a/include/dm/read.h\n> +++ b/include/dm/read.h\n> @@ -113,6 +113,16 @@ fdt_addr_t dev_read_addr_index(struct udevice *dev, int index);\n>  fdt_addr_t dev_read_addr(struct udevice *dev);\n>  \n>  /**\n> + * dev_read_addr_ptr() - Get the reg property of a device\n> + *                       as a pointer\n> + *\n> + * @dev: Device to read from\n> + *\n> + * @return pointer or NULL if not found\n> + */\n> +void *dev_read_addr_ptr(struct udevice *dev);\n> +\n> +/**\n>   * dev_read_addr_size() - get address and size from a device property\n>   *\n>   * This does no address translation. It simply reads an property that contains\n> @@ -417,6 +427,11 @@ static inline fdt_addr_t dev_read_addr(struct udevice *dev)\n>  \treturn devfdt_get_addr(dev);\n>  }\n>  \n> +static inline void *dev_read_addr_ptr(struct udevice *dev)\n> +{\n> +\treturn devfdt_get_addr_ptr(dev);\n> +}\n> +\n>  static inline fdt_addr_t dev_read_addr_size(struct udevice *dev,\n>  \t\t\t\t\t    const char *propname,\n>  \t\t\t\t\t    fdt_size_t *sizep)\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y7nvf6gvQz9t48\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  6 Oct 2017 22:48:14 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid C87F2C21D75; Fri,  6 Oct 2017 11:48:07 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 10B91C21C4C;\n\tFri,  6 Oct 2017 11:48:05 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 3EB9DC21C4C; Fri,  6 Oct 2017 11:48:03 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.15.15])\n\tby lists.denx.de (Postfix) with ESMTPS id AEC7BC21C40\n\tfor <u-boot@lists.denx.de>; Fri,  6 Oct 2017 11:48:02 +0000 (UTC)","from [192.168.123.82] ([94.114.42.150]) by mail.gmx.com (mrgmx002\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id\n\t0Md3ZK-1diDjU2TOE-00IAnB; Fri, 06 Oct 2017 13:47:54 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM\n\tautolearn=unavailable autolearn_force=no version=3.4.0","To":"Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,\n\tu-boot@lists.denx.de","References":"<1505160270-10650-5-git-send-email-philipp.tomsich@theobroma-systems.com>","From":"Heinrich Schuchardt <xypron.glpk@gmx.de>","Message-ID":"<12491177-209e-c6c4-e4be-7ff565b84982@gmx.de>","Date":"Fri, 6 Oct 2017 13:47:42 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505160270-10650-5-git-send-email-philipp.tomsich@theobroma-systems.com>","Content-Language":"en-US","X-Provags-ID":"V03:K0:2+impfhjJgVK88ZZnW9mMMhiLk+0MjcDNMkXd7eEry6vZA7JaNB\n\tAofLvTTOWuzdeDjv+TEfn2K+JXUP8pA90m5Qd7tVXpE4OHklQvshw2jEVqFaUUUKgqNZXp9\n\tmF2jOkqIwiA1uKwetGj+WYNJfHwRsK33EoGsGWeC+1a/CkkKAn3zYbRyxEBoopnnCdSEKFs\n\tvsLY+oJQGmBPUZJYeOuPQ==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:sMoD7JjxCgI=:4/Gwl5YrzMLzTHnh4lf5ef\n\tBGU0d5B14FHIuxFhet9hXQ3E2KvzNZ7r1/4JItlq9+FkGTYEMhnRjLGNYMCjc0rH6M1wKTIB4\n\t5ZHlPTPew3xvuILef2GbLQREtIxINpzyz+Lqq3/d+T/6QuaXSEtvjcSaSB2RWsMcW1WB2G2B/\n\ttiw1hdlcai95TEEnAEM5GuGSbLI9Ab7dzAWqd3mFqWnzTNInTrDnTVFei3xx6rB57lknZewJk\n\t4o6BRyyT8CmGAe/3OeXwBPID1GfW23zwWb8ljly/f4d0LzKWmgIBIm/BMHAAkcSmzOugRO/B/\n\tgLD2wSw3BPtaE9SZ1bYoOoKCYA3c+OudJHkUxHmEmXEywPtJxmUWhgxWhA2Wr3i00dk58IIvg\n\tP1n7mK2QSO43T2RvV16urzh+xbgjZM+ybHTlFJfKo6FWHLun2xctVu+GVEJzj5y1V8DJJA+2O\n\tweZhUWe5tgeFwos2F9+KrqwfzWgIfpvmfaQA95oU6nmImDhHZ0RTtv6X+NkfVLTN+dlmnhUFc\n\taDA8tEVW+tD/gjCVqEqzkAnSsFFFCvVKaAPu11nfu2vDlXYx0vRlS8NG/93JYgQwMqZhLrrKZ\n\tt1WEhzUVRpYS57AYIeZjCoa/zT9qdOkO81oqgGdzacNU/V7wJA/BGUa/2vh4suQN9RhUZHb4p\n\t106bEsy/r2D+vZrD0UTDeLHRUSSGoRPb1fs6g5PFaMQSkrPG4k9Zbh9HwoseUF+frAAp5t9Yx\n\t4RrDRRWQOQ4f1w487mReDnT4jkmfnvResOlfl6Fb5xG8j/ez7tN5e0TnVIOaFtHVayzrCr2zL\n\tzVvwUDRor74wgRCspKVyoe7QY9nDHzDA1dRRZP27I78LBDp0Sw=","Cc":"Klaus Goger <klaus.goger@theobroma-systems.com>","Subject":"Re: [U-Boot] [U-Boot,v3,04/19] dm: core: add dev_read_addr_ptr()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1781490,"web_url":"http://patchwork.ozlabs.org/comment/1781490/","msgid":"<341D0494-62C7-4C0B-8644-9DD63ADB540B@theobroma-systems.com>","list_archive_url":null,"date":"2017-10-06T12:00:45","subject":"Re: [U-Boot] [U-Boot,v3,04/19] dm: core: add dev_read_addr_ptr()","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"> On 6 Oct 2017, at 13:47, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:\n> \n> On 09/11/2017 10:04 PM, Philipp Tomsich wrote:\n>> The dev_read_addr_ptr() mimics the behaviour of the devfdt_get_addr_ptr(),\n>> retrieving the first address of the node's reg-property and returning\n>> it as a pointer (or NULL on failure).\n>> \n>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>\n>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>\n>> ---\n>> \n>> Changes in v3: None\n>> Changes in v2:\n>> - implements the dev_read_addr_ptr() function\n>> \n>> drivers/core/read.c |  7 +++++++\n>> include/dm/read.h   | 15 +++++++++++++++\n>> 2 files changed, 22 insertions(+)\n>> \n>> diff --git a/drivers/core/read.c b/drivers/core/read.c\n>> index 6acb333..065589a 100644\n>> --- a/drivers/core/read.c\n>> +++ b/drivers/core/read.c\n>> @@ -57,6 +57,13 @@ fdt_addr_t dev_read_addr(struct udevice *dev)\n>> \treturn dev_read_addr_index(dev, 0);\n>> }\n>> \n>> +void *dev_read_addr_ptr(struct udevice *dev)\n>> +{\n>> +\tfdt_addr_t addr = dev_read_addr(dev);\n>> +\n>> +\treturn (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr;\n> \n> Hello Philipp,\n> \n> this line produces a compiler warning:\n> \n>   sandbox:  +   sandbox\n> +  return (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr;\n> +                                            ^\n> w+drivers/core/read.c: In function ?dev_read_addr_ptr?:\n> w+drivers/core/read.c:64:44: warning: cast to pointer from integer of\n> different size [-Wint-to-pointer-cast]\n> \n> Could you, please, provide a follow-up patch.\n\nHeinrich,\n\nI don’t fully understand what exactly to do here, as there is a patch to\naddress this in flight (https://patchwork.ozlabs.org/patch/819567/) and\nyou had even been on the CC-list for that one…\n\nRegards,\nPhilipp.\n\n> \n> Regards\n> \n> Heinrich\n> \n>> +}\n>> +\n>> fdt_addr_t dev_read_addr_size(struct udevice *dev, const char *property,\n>> \t\t\t\tfdt_size_t *sizep)\n>> {\n>> diff --git a/include/dm/read.h b/include/dm/read.h\n>> index 49d69c9..e7f7125 100644\n>> --- a/include/dm/read.h\n>> +++ b/include/dm/read.h\n>> @@ -113,6 +113,16 @@ fdt_addr_t dev_read_addr_index(struct udevice *dev, int index);\n>> fdt_addr_t dev_read_addr(struct udevice *dev);\n>> \n>> /**\n>> + * dev_read_addr_ptr() - Get the reg property of a device\n>> + *                       as a pointer\n>> + *\n>> + * @dev: Device to read from\n>> + *\n>> + * @return pointer or NULL if not found\n>> + */\n>> +void *dev_read_addr_ptr(struct udevice *dev);\n>> +\n>> +/**\n>>  * dev_read_addr_size() - get address and size from a device property\n>>  *\n>>  * This does no address translation. It simply reads an property that contains\n>> @@ -417,6 +427,11 @@ static inline fdt_addr_t dev_read_addr(struct udevice *dev)\n>> \treturn devfdt_get_addr(dev);\n>> }\n>> \n>> +static inline void *dev_read_addr_ptr(struct udevice *dev)\n>> +{\n>> +\treturn devfdt_get_addr_ptr(dev);\n>> +}\n>> +\n>> static inline fdt_addr_t dev_read_addr_size(struct udevice *dev,\n>> \t\t\t\t\t    const char *propname,\n>> \t\t\t\t\t    fdt_size_t *sizep)\n>> \n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y7pCh3fqkz9t3m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri,  6 Oct 2017 23:02:08 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 32466C21D75; Fri,  6 Oct 2017 12:02:04 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AF3FAC21D57;\n\tFri,  6 Oct 2017 12:01:44 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 4F142C21D75; Fri,  6 Oct 2017 12:01:43 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 091E0C21D8C\n\tfor <u-boot@lists.denx.de>; Fri,  6 Oct 2017 12:00:48 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:64953\n\thelo=[192.168.2.129]) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from <philipp.tomsich@theobroma-systems.com>)\n\tid 1e0RJ9-0007GL-24; Fri, 06 Oct 2017 14:00:47 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"*","X-Spam-Status":"No, score=1.0 required=5.0 tests=HK_NAME_DR autolearn=no\n\tautolearn_force=no version=3.4.0","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"\"Dr. Philipp Tomsich\" <philipp.tomsich@theobroma-systems.com>","In-Reply-To":"<12491177-209e-c6c4-e4be-7ff565b84982@gmx.de>","Date":"Fri, 6 Oct 2017 14:00:45 +0200","Message-Id":"<341D0494-62C7-4C0B-8644-9DD63ADB540B@theobroma-systems.com>","References":"<1505160270-10650-5-git-send-email-philipp.tomsich@theobroma-systems.com>\n\t<12491177-209e-c6c4-e4be-7ff565b84982@gmx.de>","To":"Heinrich Schuchardt <xypron.glpk@gmx.de>","X-Mailer":"Apple Mail (2.3273)","Cc":"U-Boot Mailing List <u-boot@lists.denx.de>,\n\tKlaus Goger <klaus.goger@theobroma-systems.com>","Subject":"Re: [U-Boot] [U-Boot,v3,04/19] dm: core: add dev_read_addr_ptr()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1781856,"web_url":"http://patchwork.ozlabs.org/comment/1781856/","msgid":"<c0f18e80-77c6-a9f9-9cbf-27526293352c@gmx.de>","list_archive_url":null,"date":"2017-10-06T18:50:08","subject":"Re: [U-Boot] [U-Boot,v3,04/19] dm: core: add dev_read_addr_ptr()","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 10/06/2017 02:00 PM, Dr. Philipp Tomsich wrote:\n> \n>> On 6 Oct 2017, at 13:47, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:\n>>\n>> On 09/11/2017 10:04 PM, Philipp Tomsich wrote:\n>>> The dev_read_addr_ptr() mimics the behaviour of the devfdt_get_addr_ptr(),\n>>> retrieving the first address of the node's reg-property and returning\n>>> it as a pointer (or NULL on failure).\n>>>\n>>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>\n>>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>\n>>> ---\n>>>\n>>> Changes in v3: None\n>>> Changes in v2:\n>>> - implements the dev_read_addr_ptr() function\n>>>\n>>> drivers/core/read.c |  7 +++++++\n>>> include/dm/read.h   | 15 +++++++++++++++\n>>> 2 files changed, 22 insertions(+)\n>>>\n>>> diff --git a/drivers/core/read.c b/drivers/core/read.c\n>>> index 6acb333..065589a 100644\n>>> --- a/drivers/core/read.c\n>>> +++ b/drivers/core/read.c\n>>> @@ -57,6 +57,13 @@ fdt_addr_t dev_read_addr(struct udevice *dev)\n>>> \treturn dev_read_addr_index(dev, 0);\n>>> }\n>>>\n>>> +void *dev_read_addr_ptr(struct udevice *dev)\n>>> +{\n>>> +\tfdt_addr_t addr = dev_read_addr(dev);\n>>> +\n>>> +\treturn (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr;\n>>\n>> Hello Philipp,\n>>\n>> this line produces a compiler warning:\n>>\n>>   sandbox:  +   sandbox\n>> +  return (addr == FDT_ADDR_T_NONE) ? NULL : (void *)addr;\n>> +                                            ^\n>> w+drivers/core/read.c: In function ?dev_read_addr_ptr?:\n>> w+drivers/core/read.c:64:44: warning: cast to pointer from integer of\n>> different size [-Wint-to-pointer-cast]\n>>\n>> Could you, please, provide a follow-up patch.\n> \n> Heinrich,\n> \n> I don’t fully understand what exactly to do here, as there is a patch to\n> address this in flight (https://patchwork.ozlabs.org/patch/819567/) and\n> you had even been on the CC-list for that one…\n> \n> Regards,\n> Philipp.\n\nSorry for the noise.\n\nRegards\n\nHeinrich\n\n> \n>>\n>> Regards\n>>\n>> Heinrich\n>>\n>>> +}\n>>> +\n>>> fdt_addr_t dev_read_addr_size(struct udevice *dev, const char *property,\n>>> \t\t\t\tfdt_size_t *sizep)\n>>> {\n>>> diff --git a/include/dm/read.h b/include/dm/read.h\n>>> index 49d69c9..e7f7125 100644\n>>> --- a/include/dm/read.h\n>>> +++ b/include/dm/read.h\n>>> @@ -113,6 +113,16 @@ fdt_addr_t dev_read_addr_index(struct udevice *dev, int index);\n>>> fdt_addr_t dev_read_addr(struct udevice *dev);\n>>>\n>>> /**\n>>> + * dev_read_addr_ptr() - Get the reg property of a device\n>>> + *                       as a pointer\n>>> + *\n>>> + * @dev: Device to read from\n>>> + *\n>>> + * @return pointer or NULL if not found\n>>> + */\n>>> +void *dev_read_addr_ptr(struct udevice *dev);\n>>> +\n>>> +/**\n>>>  * dev_read_addr_size() - get address and size from a device property\n>>>  *\n>>>  * This does no address translation. It simply reads an property that contains\n>>> @@ -417,6 +427,11 @@ static inline fdt_addr_t dev_read_addr(struct udevice *dev)\n>>> \treturn devfdt_get_addr(dev);\n>>> }\n>>>\n>>> +static inline void *dev_read_addr_ptr(struct udevice *dev)\n>>> +{\n>>> +\treturn devfdt_get_addr_ptr(dev);\n>>> +}\n>>> +\n>>> static inline fdt_addr_t dev_read_addr_size(struct udevice *dev,\n>>> \t\t\t\t\t    const char *propname,\n>>> \t\t\t\t\t    fdt_size_t *sizep)\n>>>\n>>\n> \n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y7zGt6G7rz9t2Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat,  7 Oct 2017 05:50:29 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 3E897C21DDD; Fri,  6 Oct 2017 18:50:24 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 95581C21C54;\n\tFri,  6 Oct 2017 18:50:21 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 12FEEC21C54; Fri,  6 Oct 2017 18:50:20 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\tby lists.denx.de (Postfix) with ESMTPS id B0A9AC21C4C\n\tfor <u-boot@lists.denx.de>; Fri,  6 Oct 2017 18:50:19 +0000 (UTC)","from [192.168.123.82] ([94.114.42.150]) by mail.gmx.com (mrgmx003\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id\n\t0Ln7wj-1dNd7P1EMP-00hJmj; Fri, 06 Oct 2017 20:50:10 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM\n\tautolearn=unavailable autolearn_force=no version=3.4.0","To":"\"Dr. Philipp Tomsich\" <philipp.tomsich@theobroma-systems.com>","References":"<1505160270-10650-5-git-send-email-philipp.tomsich@theobroma-systems.com>\n\t<12491177-209e-c6c4-e4be-7ff565b84982@gmx.de>\n\t<341D0494-62C7-4C0B-8644-9DD63ADB540B@theobroma-systems.com>","From":"Heinrich Schuchardt <xypron.glpk@gmx.de>","Message-ID":"<c0f18e80-77c6-a9f9-9cbf-27526293352c@gmx.de>","Date":"Fri, 6 Oct 2017 20:50:08 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<341D0494-62C7-4C0B-8644-9DD63ADB540B@theobroma-systems.com>","Content-Language":"en-US","X-Provags-ID":"V03:K0:RnUHc4xE1ecB67/N8iHANvdCfWAY173rJd60ncRuazR2og5tM5X\n\tyicpxeIquR/B+W+l0Rh40rCvvZ85BYtQl8fOWO4DegTtSZONhhkt7gUlMCqYSuSTnJ3/SOE\n\t1t3BNAvC9TjWXBPLH4HFr42T/5N4zA3DWos0ibBwLeR8BdGe9okBPXOo4yEK+x2Qk8IZ3mt\n\tZfd0fHtclAJs7twUJzdZg==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:Ps1Ju8r4gGI=:Q2pmHyJHL6d/H5nUInnm0a\n\tXKY+Y1+gSagbEL9CKCPrANvbFqWkqb6i/B1+712T8Oc8Ggt93N9HFKFJ9b5KDxravVrWSuCHq\n\tPQP9J5Tqy6jKGt7THJLruqKGWvZSnz433WsO0jlVTFHpeFv4WNt5wmoO50FBOrKp6fXEmicaR\n\tpB22HIYgxrqMx5JpgLtOysScloVrr0PKOMlvTaPuREJ4lMcJcT4U2iHmezewDZEeZhgM8YzrA\n\t1ZKfKxSJ8DPZ6vetU/V2iiN1CTCp0IFLzAUimdP10KqQgPX2831eJw2NAgWSWUBxF4WQP9V+b\n\tccW0fIqnsn2NEPaFDT89wPq2wnGftfM1eXJ/CHaiO+RmA9NhnJh63VLalBMToez4K8i9bHE+3\n\tydGyOyHqUQxORLFuqhXrfTLCqZRlvXQEkmX8Dj4hi/nyJkpX3Vg1L6gZz+kwecPRTwURplU7E\n\tLKQo6y7BuClciB8/c5JsisKodZQVmG2MVNJSXjMy5LEaEVAOvrDk9/qjASrur0QilD7V7SiGY\n\tsySwbz2aYa/S7IaWFJosWdxBCJrev9ulGzw9S//e9YMdsHpH1ZzQTEWseO4wMhPrgNSrzSD7q\n\tTd7Q9aQLvLZbaCdXFZnuGz1dNDSKGii8dRT8++URsJ9lE7uGOzije8XcJpBicTDDsYs1I6W7v\n\tSUIyyiEWIn66+4l9djt41guIiQ6bPuZr83UiLmoPeuxbJS3XeWL5FxoZpxU/xseOw/D+sE0sa\n\tiKEbkGUCn78St0hiEzWeAR9zB71eZizZ9KNXSLTWc9jczYvb8z3279MPjHiIfXmplR+jG6KCI\n\tsakxOEXJsn7ehAj6nhHL/UdyIdiLbEHT9fXoyNy4bM2pI2lOn4=","Cc":"U-Boot Mailing List <u-boot@lists.denx.de>,\n\tKlaus Goger <klaus.goger@theobroma-systems.com>","Subject":"Re: [U-Boot] [U-Boot,v3,04/19] dm: core: add dev_read_addr_ptr()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]