[{"id":1766583,"web_url":"http://patchwork.ozlabs.org/comment/1766583/","msgid":"<54d9d7e5-b28e-092d-5579-d35e60c55240@amsat.org>","list_archive_url":null,"date":"2017-09-11T21:43:32","subject":"Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock\n\tupdate prints to warn_report","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"(Cc'ing Yongbok and Aurelien from get_maintainer.pl)\n\nOn 09/11/2017 04:52 PM, Alistair Francis wrote:\n> Convert the fprintf() messages in kvm_mips_update_state() to use\n> warn_report() as they aren't errors, but are just warnings.\n> \n> Signed-off-by: Alistair Francis \n\nReviewed-by: Philippe Mathieu-Daudé \n\n> Cc: James Hogan \n> ---\n> \n> target/mips/kvm.c | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/target/mips/kvm.c b/target/mips/kvm.c\n> index a23aa438d2..3b7b1d962a 100644\n> --- a/target/mips/kvm.c\n> +++ b/target/mips/kvm.c\n> @@ -526,7 +526,7 @@ static void kvm_mips_update_state(void *opaque, int running, RunState state)\n> if (!cs->vcpu_dirty) {\n> ret = kvm_mips_save_count(cs);\n> if (ret < 0) {\n> - fprintf(stderr, \"Failed saving count\\n\");\n> + warn_report(\"Failed saving count\");\n> }\n> }\n> } else {\n> @@ -535,14 +535,14 @@ static void kvm_mips_update_state(void *opaque, int running, RunState state)\n> ret = kvm_mips_put_one_ureg64(cs, KVM_REG_MIPS_COUNT_RESUME,\n> &count_resume);\n> if (ret < 0) {\n> - fprintf(stderr, \"Failed setting COUNT_RESUME\\n\");\n> + warn_report(\"Failed setting COUNT_RESUME\");\n> return;\n> }\n> \n> if (!cs->vcpu_dirty) {\n> ret = kvm_mips_restore_count(cs);\n> if (ret < 0) {\n> - fprintf(stderr, \"Failed restoring count\\n\");\n> + warn_report(\"Failed restoring count\");\n> }\n> }\n> }\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"R/bO9NBQ\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrhK15LG8z9s7M\n\tfor ;\n\tTue, 12 Sep 2017 07:44:21 +1000 (AEST)","from localhost ([::1]:60751 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drWV9-0008Fv-SG\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 17:44:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48377)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1drWUd-0008CX-IO\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:43:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1drWUY-0007Y4-95\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:43:46 -0400","from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:35245)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1drWUY-0007XO-4I\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:43:42 -0400","by mail-qk0-x242.google.com with SMTP id o77so6195495qke.2\n\tfor ; Mon, 11 Sep 2017 14:43:42 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\ta12sm6889270qta.3.2017.09.11.14.43.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 14:43:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=bXfD4Wr6TCry2pOLYn1yLHq45T/waD7K5Dp8qtkmDSM=;\n\tb=R/bO9NBQ/ST5vf9NTjYyoiugEtCKdlmTL6VUR1BHsLWh6o9NC7M6wJxveU13aV7n0s\n\tcROEL7i/XJXjOHBqgLtNBp/eymKSzCubibgvbKX/xRWATWWFz9O3BvdrHSVRDp+xHJzI\n\tTl4ER+dCCrvsqQq+03RInioI0vof9udVFc9zOOmD+RpGENc2Bjy6hBvfcvnORpNKSQlS\n\tjMryM/YXfegMyhm3DaM1I5Lx1B/d+aUSVDG6YHJI+Y2qodvdDriKQzhu+14+Istb8kx3\n\tUWM8lmMSPz+C77LhWjwbHHAuC9kiuyGcew2bhwq3GA2rXvCqdKwS1QJN7wV9fNLxHzn5\n\t149Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=bXfD4Wr6TCry2pOLYn1yLHq45T/waD7K5Dp8qtkmDSM=;\n\tb=UUXPSoxuPnCNd7WSx6Sbtl2txXal2gMXQJtKCYPoIjl5jfs/ijf+5zgbqZgIkDWWJg\n\tncM538Q1yOkeXl8Pjv4hTTP338jzc4BDsJS5k3wCHNeOLuXpQ/olNrV8eo9zbovSdJ+E\n\tPv2xFU8GxZosKflQbdGzwx5KRGsxj+aDhPn/8llB9k9b2cFliIRdQrw2r1UJE5iispUK\n\tTR5TZ98I6S1TDQkolcyTqCzGBzqPkQvy+Q5VeiMdW7CuXNZC9BxXdKKZ4SHWq51W306T\n\tQHCIUMEahObvY4rhIbDAa2wyh9QzoW4qtkBR4jf2Cd3O+EkZprpD363MyBnslt+7K7/K\n\txXGg==","X-Gm-Message-State":"AHPjjUjE6B6knZVpGIR7ByOQkRkhSgViTvzdEh0f08l9EjROTjK/Yoan\n\t6H/Us6IBlLnE8w==","X-Google-Smtp-Source":"AOwi7QCuZY/0oS0ng6jiiVBPXQOPjl3L6Nu1WlSNLtCUR1V5zQLvx0k8KMVDIfbodmiEZ6pT7b5+AQ==","X-Received":"by 10.55.190.5 with SMTP id o5mr18145310qkf.241.1505166221497;\n\tMon, 11 Sep 2017 14:43:41 -0700 (PDT)","To":"Alistair Francis ,\n\tYongbok Kim ,\n\tAurelien Jarno ","References":"\n\t","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<54d9d7e5-b28e-092d-5579-d35e60c55240@amsat.org>","Date":"Mon, 11 Sep 2017 18:43:32 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::242","Subject":"Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock\n\tupdate prints to warn_report","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alistair23@gmail.com, James Hogan ,\n\tqemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766585,"web_url":"http://patchwork.ozlabs.org/comment/1766585/","msgid":"<20170911214343.GC17077@jhogan-linux.le.imgtec.org>","list_archive_url":null,"date":"2017-09-11T21:43:43","subject":"Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock\n\tupdate prints to warn_report","submitter":{"id":18920,"url":"http://patchwork.ozlabs.org/api/people/18920/","name":"James Hogan","email":"james.hogan@imgtec.com"},"content":"On Mon, Sep 11, 2017 at 12:52:59PM -0700, Alistair Francis wrote:\n> Convert the fprintf() messages in kvm_mips_update_state() to use\n> warn_report() as they aren't errors, but are just warnings.\n> \n> Signed-off-by: Alistair Francis \n> Cc: James Hogan \n\nAcked-by: James Hogan \n\nThanks\nJames\n\n> ---\n> \n> target/mips/kvm.c | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/target/mips/kvm.c b/target/mips/kvm.c\n> index a23aa438d2..3b7b1d962a 100644\n> --- a/target/mips/kvm.c\n> +++ b/target/mips/kvm.c\n> @@ -526,7 +526,7 @@ static void kvm_mips_update_state(void *opaque, int running, RunState state)\n> if (!cs->vcpu_dirty) {\n> ret = kvm_mips_save_count(cs);\n> if (ret < 0) {\n> - fprintf(stderr, \"Failed saving count\\n\");\n> + warn_report(\"Failed saving count\");\n> }\n> }\n> } else {\n> @@ -535,14 +535,14 @@ static void kvm_mips_update_state(void *opaque, int running, RunState state)\n> ret = kvm_mips_put_one_ureg64(cs, KVM_REG_MIPS_COUNT_RESUME,\n> &count_resume);\n> if (ret < 0) {\n> - fprintf(stderr, \"Failed setting COUNT_RESUME\\n\");\n> + warn_report(\"Failed setting COUNT_RESUME\");\n> return;\n> }\n> \n> if (!cs->vcpu_dirty) {\n> ret = kvm_mips_restore_count(cs);\n> if (ret < 0) {\n> - fprintf(stderr, \"Failed restoring count\\n\");\n> + warn_report(\"Failed restoring count\");\n> }\n> }\n> }\n> -- \n> 2.11.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrhK72dvYz9s7M\n\tfor ;\n\tTue, 12 Sep 2017 07:44:27 +1000 (AEST)","from localhost ([::1]:60753 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drWVF-0008K9-Fo\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 17:44:25 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48430)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drWUi-0008HC-4c\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:43:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drWUd-0007i5-LK\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:43:52 -0400","from mailapp01.imgtec.com ([195.59.15.196]:39021)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drWUd-0007dQ-Dy\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:43:47 -0400","from hhmail02.hh.imgtec.org (unknown [10.100.10.20])\n\tby Forcepoint Email with ESMTPS id 19C18815D0368;\n\tMon, 11 Sep 2017 22:43:39 +0100 (IST)","from localhost (192.168.154.110) by hhmail02.hh.imgtec.org\n\t(10.100.10.21) with Microsoft SMTP Server (TLS) id 14.3.294.0;\n\tMon, 11 Sep 2017 22:43:43 +0100"],"Date":"Mon, 11 Sep 2017 22:43:43 +0100","From":"James Hogan ","To":"Alistair Francis ","Message-ID":"<20170911214343.GC17077@jhogan-linux.le.imgtec.org>","References":"\n\t","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"R+My9LyyhiUvIEro\"","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.7.2 (2016-11-26)","X-Originating-IP":"[192.168.154.110]","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"195.59.15.196","Subject":"Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock\n\tupdate prints to warn_report","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alistair23@gmail.com, pbonzini@redhat.com, qemu-devel@nongnu.org,\n\tarmbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]