[{"id":1766499,"web_url":"http://patchwork.ozlabs.org/comment/1766499/","msgid":"<20170911200821.GG6175@ovn.org>","list_archive_url":null,"date":"2017-09-11T20:08:21","subject":"Re: [ovs-dev] [PATCH] tests: Fix MSVC compiler error on test-ovn.c","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Mon, Sep 11, 2017 at 10:36:53PM +0300, Alin Gabriel Serdean wrote:\n> MSVC doesn't like an empty initializer for a flexible array.\n> \n> Add a zero initializer to keep the compiler happy.\n> \n> Fixes current build on Windows.\n> \n> Signed-off-by: Alin Gabriel Serdean \n\nAcked-by: Ben Pfaff ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrfBR2nl8z9sBZ\n\tfor ;\n\tTue, 12 Sep 2017 06:08:31 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 302EAC24;\n\tMon, 11 Sep 2017 20:08:29 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 1E03FBEB\n\tfor ; Mon, 11 Sep 2017 20:08:28 +0000 (UTC)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id AA3BEA1\n\tfor ; Mon, 11 Sep 2017 20:08:27 +0000 (UTC)","from ovn.org (unknown [208.91.2.3])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id C27461720A1;\n\tMon, 11 Sep 2017 22:08:24 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.2.3","Date":"Mon, 11 Sep 2017 13:08:21 -0700","From":"Ben Pfaff ","To":"Alin Gabriel Serdean ","Message-ID":"<20170911200821.GG6175@ovn.org>","References":"<20170911193653.18840-1-aserdean@ovn.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170911193653.18840-1-aserdean@ovn.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] tests: Fix MSVC compiler error on test-ovn.c","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1766565,"web_url":"http://patchwork.ozlabs.org/comment/1766565/","msgid":"<002a01d32b43$00d26cf0$027746d0$@ovn.org>","list_archive_url":null,"date":"2017-09-11T21:14:48","subject":"Re: [ovs-dev] [PATCH] tests: Fix MSVC compiler error on test-ovn.c","submitter":{"id":72181,"url":"http://patchwork.ozlabs.org/api/people/72181/","name":"Alin-Gabriel Serdean","email":"aserdean@ovn.org"},"content":"Thanks for the quick review. I applied it on master, branch-2.8, branch-2.7\nand branch-2.6.\n\nAlin.\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-\n> bounces@openvswitch.org] On Behalf Of Ben Pfaff\n> Sent: Monday, September 11, 2017 11:08 PM\n> To: Alin Gabriel Serdean \n> Cc: dev@openvswitch.org\n> Subject: Re: [ovs-dev] [PATCH] tests: Fix MSVC compiler error on\ntest-ovn.c\n> \n> On Mon, Sep 11, 2017 at 10:36:53PM +0300, Alin Gabriel Serdean wrote:\n> > MSVC doesn't like an empty initializer for a flexible array.\n> >\n> > Add a zero initializer to keep the compiler happy.\n> >\n> > Fixes current build on Windows.\n> >\n> > Signed-off-by: Alin Gabriel Serdean \n> \n> Acked-by: Ben Pfaff \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrgqW5b7nz9s7M\n\tfor ;\n\tTue, 12 Sep 2017 07:22:15 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 27B5BCB4;\n\tMon, 11 Sep 2017 21:14:52 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id B26F2BAD\n\tfor ; Mon, 11 Sep 2017 21:14:50 +0000 (UTC)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2F6F9D3\n\tfor ; Mon, 11 Sep 2017 21:14:50 +0000 (UTC)","from cloudbasealin (unknown [79.114.118.98])\n\t(Authenticated sender: aserdean@ovn.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 6E9B4C5A61;\n\tMon, 11 Sep 2017 23:14:48 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"79.114.118.98","From":"","To":"\"'Ben Pfaff'\" , \"'Alin Gabriel Serdean'\" ","References":"<20170911193653.18840-1-aserdean@ovn.org>\n\t<20170911200821.GG6175@ovn.org>","In-Reply-To":"<20170911200821.GG6175@ovn.org>","Date":"Tue, 12 Sep 2017 00:14:48 +0300","Message-ID":"<002a01d32b43$00d26cf0$027746d0$@ovn.org>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 16.0","thread-index":"AQHTKzVfpNXeb1HHuUyh040Qn74JLKKv+3yAgAAz06A=","Content-Language":"ro","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] tests: Fix MSVC compiler error on test-ovn.c","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]