[{"id":1766505,"web_url":"http://patchwork.ozlabs.org/comment/1766505/","msgid":"<9235D6609DB808459E95D78E17F2E43D40B1E6CE@CHN-SV-EXMX02.mchp-main.com>","list_archive_url":null,"date":"2017-09-11T20:13:54","subject":"RE: [PATCH v2 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","submitter":{"id":66705,"url":"http://patchwork.ozlabs.org/api/people/66705/","name":"","email":"Woojung.Huh@microchip.com"},"content":"Nisar,\n\n>@@ -1290,8 +1290,8 @@ static int lan78xx_ethtool_set_eeprom(struct net_device *netdev,\n>\n>        /* Allow entire eeprom update only */\n>        if ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\n>-           (ee->offset == 0) &&\n>-           (ee->len == 512) &&\n>+           (ee->offset >= 0 && ee->offset < MAX_EEPROM_SIZE) &&\n>+           (ee->len > 0 && (ee->offset + ee->len) <= MAX_EEPROM_SIZE) &&\n>            (data[0] == EEPROM_INDICATOR))\nThis patch is for writing  any len at any offset.\nHowever, \"(data[0] == EEPROM_INDICATOR)\" prevents it.\n\n>                ret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len, data);\n>        else if ((ee->magic == LAN78XX_OTP_MAGIC) &&\n\n- Woojung","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrfKk3jQvz9s8J\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 12 Sep 2017 06:14:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751443AbdIKUOs convert rfc822-to-8bit (ORCPT\n\t<rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 11 Sep 2017 16:14:48 -0400","from esa3.microchip.iphmx.com ([68.232.153.233]:30667 \"EHLO\n\tesa3.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751076AbdIKUOr (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 11 Sep 2017 16:14:47 -0400","from exsmtp01.microchip.com (HELO email.microchip.com)\n\t([198.175.253.37])\n\tby esa3.microchip.iphmx.com with ESMTP/TLS/AES128-SHA;\n\t11 Sep 2017 13:13:55 -0700","from CHN-SV-EXMX02.mchp-main.com ([fe80::7dfe:3761:863e:3963]) by\n\tCHN-SV-EXCH01.mchp-main.com ([fe80::9840:ffdf:ec5:1335%29]) with\n\tmapi id 14.03.0352.000; Mon, 11 Sep 2017 13:13:55 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,379,1500966000\"; d=\"scan'208\";a=\"6953393\"","From":"<Woojung.Huh@microchip.com>","To":"<Nisar.Sayed@microchip.com>, <davem@davemloft.net>","CC":"<UNGLinuxDriver@microchip.com>, <netdev@vger.kernel.org>","Subject":"RE: [PATCH v2 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","Thread-Topic":"[PATCH v2 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","Thread-Index":"AdMrLHzJhj+t03S+RiumpCdOatvCpgADZPRD","Date":"Mon, 11 Sep 2017 20:13:54 +0000","Message-ID":"<9235D6609DB808459E95D78E17F2E43D40B1E6CE@CHN-SV-EXMX02.mchp-main.com>","References":"<CE371C1263339941885964188A0225FA335C94@CHN-SV-EXMX03.mchp-main.com>","In-Reply-To":"<CE371C1263339941885964188A0225FA335C94@CHN-SV-EXMX03.mchp-main.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.215.90]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]