[{"id":1766522,"web_url":"http://patchwork.ozlabs.org/comment/1766522/","msgid":"<20170911202428.GB5983@lunn.ch>","list_archive_url":null,"date":"2017-09-11T20:24:28","subject":"Re: [PATCH v2 net 1/3] lan78xx: Fix for eeprom read/write when\n\tdevice auto suspend","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Mon, Sep 11, 2017 at 06:51:49PM +0000, Nisar.Sayed@microchip.com wrote:\n> From: Nisar Sayed \n> \n> Fix for eeprom read/write when device auto suspend\n> \n> Fixes: 55d7de9de6c3 (\"Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver\")\n> Signed-off-by: Nisar Sayed \n> ---\n> drivers/net/usb/lan78xx.c | 22 ++++++++++++++++++----\n> 1 file changed, 18 insertions(+), 4 deletions(-)\n> \n> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c\n> index b99a7fb..baf91c7 100644\n> --- a/drivers/net/usb/lan78xx.c\n> +++ b/drivers/net/usb/lan78xx.c\n> @@ -1265,30 +1265,44 @@ static int lan78xx_ethtool_get_eeprom(struct net_device *netdev,\n> \t\t\t\t struct ethtool_eeprom *ee, u8 *data)\n> {\n> \tstruct lan78xx_net *dev = netdev_priv(netdev);\n> +\tint ret = -EINVAL;\n> +\n> +\tif (usb_autopm_get_interface(dev->intf) < 0)\n> +\t\treturn ret;\n\nHi Nisar\n\nIt is better to do\n\n ret = usb_autopm_get_interface(dev->intf;\n if (ret)\n return ret;\n\ni.e. use the error code usb_autopm_get_interface() gives you.\n\n> \tee->magic = LAN78XX_EEPROM_MAGIC;\n> \n> -\treturn lan78xx_read_raw_eeprom(dev, ee->offset, ee->len, data);\n> +\tret = lan78xx_read_raw_eeprom(dev, ee->offset, ee->len, data);\n> +\n> +\tusb_autopm_put_interface(dev->intf);\n> +\n> +\treturn ret;\n> }\n> \n> static int lan78xx_ethtool_set_eeprom(struct net_device *netdev,\n> \t\t\t\t struct ethtool_eeprom *ee, u8 *data)\n> {\n> \tstruct lan78xx_net *dev = netdev_priv(netdev);\n> +\tint ret = -EINVAL;\n> +\n> +\tif (usb_autopm_get_interface(dev->intf) < 0)\n> +\t\treturn ret;\n\nSame here.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrfY30ldFz9s8J\n\tfor ;\n\tTue, 12 Sep 2017 06:24:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751251AbdIKUYf (ORCPT );\n\tMon, 11 Sep 2017 16:24:35 -0400","from vps0.lunn.ch ([178.209.37.122]:37521 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751214AbdIKUYe (ORCPT );\n\tMon, 11 Sep 2017 16:24:34 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1drVFs-0001hd-FT; Mon, 11 Sep 2017 22:24:28 +0200"],"Date":"Mon, 11 Sep 2017 22:24:28 +0200","From":"Andrew Lunn ","To":"Nisar.Sayed@microchip.com","Cc":"davem@davemloft.net, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org","Subject":"Re: [PATCH v2 net 1/3] lan78xx: Fix for eeprom read/write when\n\tdevice auto suspend","Message-ID":"<20170911202428.GB5983@lunn.ch>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1767003,"web_url":"http://patchwork.ozlabs.org/comment/1767003/","msgid":"","list_archive_url":null,"date":"2017-09-12T13:01:17","subject":"RE: [PATCH v2 net 1/3] lan78xx: Fix for eeprom read/write when\n\tdevice auto suspend","submitter":{"id":71648,"url":"http://patchwork.ozlabs.org/api/people/71648/","name":"Nisar Sayed","email":"Nisar.Sayed@microchip.com"},"content":"> > From: Nisar Sayed \n> >\n> > Fix for eeprom read/write when device auto suspend\n> >\n> > Fixes: 55d7de9de6c3 (\"Microchip's LAN7800 family USB 2/3 to\n> > 10/100/1000 Ethernet device driver\")\n> > Signed-off-by: Nisar Sayed \n> > ---\n> > drivers/net/usb/lan78xx.c | 22 ++++++++++++++++++----\n> > 1 file changed, 18 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c\n> > index b99a7fb..baf91c7 100644\n> > --- a/drivers/net/usb/lan78xx.c\n> > +++ b/drivers/net/usb/lan78xx.c\n> > @@ -1265,30 +1265,44 @@ static int lan78xx_ethtool_get_eeprom(struct\n> net_device *netdev,\n> > \t\t\t\t struct ethtool_eeprom *ee, u8 *data) {\n> > \tstruct lan78xx_net *dev = netdev_priv(netdev);\n> > +\tint ret = -EINVAL;\n> > +\n> > +\tif (usb_autopm_get_interface(dev->intf) < 0)\n> > +\t\treturn ret;\n> \n> Hi Nisar\n> \n> It is better to do\n> \n> ret = usb_autopm_get_interface(dev->intf;\n> if (ret)\n> return ret;\n> \n> i.e. use the error code usb_autopm_get_interface() gives you.\n> \n> > \tee->magic = LAN78XX_EEPROM_MAGIC;\n> >\n> > -\treturn lan78xx_read_raw_eeprom(dev, ee->offset, ee->len, data);\n> > +\tret = lan78xx_read_raw_eeprom(dev, ee->offset, ee->len, data);\n> > +\n> > +\tusb_autopm_put_interface(dev->intf);\n> > +\n> > +\treturn ret;\n> > }\n> >\n> > static int lan78xx_ethtool_set_eeprom(struct net_device *netdev,\n> > \t\t\t\t struct ethtool_eeprom *ee, u8 *data) {\n> > \tstruct lan78xx_net *dev = netdev_priv(netdev);\n> > +\tint ret = -EINVAL;\n> > +\n> > +\tif (usb_autopm_get_interface(dev->intf) < 0)\n> > +\t\treturn ret;\n> \n> Same here.\n> \n> Andrew\n\nThanks Andrew, will update it.\n\n- Nisar","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4h26m4Xz9rxl\n\tfor ;\n\tTue, 12 Sep 2017 23:02:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751861AbdILNCI convert rfc822-to-8bit (ORCPT\n\t);\n\tTue, 12 Sep 2017 09:02:08 -0400","from esa5.microchip.iphmx.com ([216.71.150.166]:55396 \"EHLO\n\tesa5.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751843AbdILNCF (ORCPT\n\t); Tue, 12 Sep 2017 09:02:05 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa5.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t12 Sep 2017 06:01:20 -0700","from CHN-SV-EXMX03.mchp-main.com ([fe80::58f5:b949:4b1:3df4]) by\n\tCHN-SV-EXCH05.mchp-main.com ([fe80::c1bf:7679:c1f8:4560%15]) with\n\tmapi id 14.03.0352.000; Tue, 12 Sep 2017 06:01:18 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,383,1500966000\"; d=\"scan'208\";a=\"4623962\"","From":"","To":"","CC":", ,\n\t","Subject":"RE: [PATCH v2 net 1/3] lan78xx: Fix for eeprom read/write when\n\tdevice auto suspend","Thread-Topic":"[PATCH v2 net 1/3] lan78xx: Fix for eeprom read/write when\n\tdevice auto suspend","Thread-Index":"AdMrLEHWVFz+MwRFT1uEbIfV2plLnAASmIQAABQfbAA=","Date":"Tue, 12 Sep 2017 13:01:17 +0000","Message-ID":"","References":"\n\t<20170911202428.GB5983@lunn.ch>","In-Reply-To":"<20170911202428.GB5983@lunn.ch>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.76.4]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]