[{"id":1766667,"web_url":"http://patchwork.ozlabs.org/comment/1766667/","msgid":"<59B7624F.3060600@denx.de>","list_archive_url":null,"date":"2017-09-12T04:27:59","subject":"Re: [U-Boot] [PATCH v2] i2c: muxes: pca954x: Add support for GPIO\n\treset line","submitter":{"id":99,"url":"http://patchwork.ozlabs.org/api/people/99/","name":"Heiko Schocher","email":"hs@denx.de"},"content":"Hello Moritz,\n\nAm 11.09.2017 um 20:19 schrieb Moritz Fischer:\n> This commit adds support for GPIO reset lines matching the\n> common linux \"reset-gpios\" devicetree binding.\n>\n> Signed-off-by: Moritz Fischer \n> ---\n>\n> Changes from v1:\n> - Simon's feedback on ifdef vs IS_ENABLED()\n>\n> ---\n> drivers/i2c/muxes/pca954x.c | 42 +++++++++++++++++++++++++++++++++++++++++-\n> 1 file changed, 41 insertions(+), 1 deletion(-)\n\nReviewed-by: Heiko Schocher \n\nbye,\nHeiko","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrsH324hLz9s8J\n\tfor ;\n\tTue, 12 Sep 2017 14:28:13 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 493B2C21D76; Tue, 12 Sep 2017 04:28:08 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9C91DC21D56;\n\tTue, 12 Sep 2017 04:28:05 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 29FABC21D56; Tue, 12 Sep 2017 04:28:04 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 22A92C21CB3\n\tfor ; Tue, 12 Sep 2017 04:28:03 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xrsGp0Lsdz1qvBg;\n\tTue, 12 Sep 2017 06:28:02 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xrsGn6XWBz3jgYK;\n\tTue, 12 Sep 2017 06:28:01 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 8jG1ii6oAHOE; Tue, 12 Sep 2017 06:28:00 +0200 (CEST)","from localhost.localdomain (91.82.144.174.pool.invitel.hu\n\t[91.82.144.174])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tTue, 12 Sep 2017 06:28:00 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"aNqwZ/mRqawEl93EVdXHwbmNVY9dgEnRUD0yabr9zCc=","To":"Moritz Fischer ","References":"<20170911181948.11062-1-moritz.fischer@ettus.com>","From":"Heiko Schocher ","Message-ID":"<59B7624F.3060600@denx.de>","Date":"Tue, 12 Sep 2017 06:27:59 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101\n\tThunderbird/38.1.0","MIME-Version":"1.0","In-Reply-To":"<20170911181948.11062-1-moritz.fischer@ettus.com>","Cc":"u-boot@lists.denx.de, sr@denx.de, mdf@kernel.org","Subject":"Re: [U-Boot] [PATCH v2] i2c: muxes: pca954x: Add support for GPIO\n\treset line","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"hs@denx.de","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1766840,"web_url":"http://patchwork.ozlabs.org/comment/1766840/","msgid":"<59B7B380.9030909@denx.de>","list_archive_url":null,"date":"2017-09-12T10:14:24","subject":"Re: [U-Boot] [PATCH v2] i2c: muxes: pca954x: Add support for GPIO\n\treset line","submitter":{"id":99,"url":"http://patchwork.ozlabs.org/api/people/99/","name":"Heiko Schocher","email":"hs@denx.de"},"content":"Hallo Moritz,\n\nAm 12.09.2017 um 06:27 schrieb Heiko Schocher:\n> Hello Moritz,\n>\n> Am 11.09.2017 um 20:19 schrieb Moritz Fischer:\n>> This commit adds support for GPIO reset lines matching the\n>> common linux \"reset-gpios\" devicetree binding.\n>>\n>> Signed-off-by: Moritz Fischer \n>> ---\n>>\n>> Changes from v1:\n>> - Simon's feedback on ifdef vs IS_ENABLED()\n>>\n>> ---\n>> drivers/i2c/muxes/pca954x.c | 42 +++++++++++++++++++++++++++++++++++++++++-\n>> 1 file changed, 41 insertions(+), 1 deletion(-)\n>\n> Reviewed-by: Heiko Schocher \n\nHmm.. your patch\n\nhttp://patchwork.ozlabs.org/patch/812541/\n\nbreaks the mvebu travis build, see:\n\nhttps://travis-ci.org/hsdenx/u-boot-i2c/jobs/274457946\n\nfor example:\n arm: + turris_omnia\n+drivers/i2c/muxes/pca954x.c: In function ?pca954x_probe?:\n+drivers/i2c/muxes/pca954x.c:120:10: error: ?struct pca954x_priv? has no member named ?gpio_mux_reset?\n+ &priv->gpio_mux_reset, GPIOD_IS_OUT);\n+ ^~\n\nbut your patch seems to do it correct:\n\n+\tif (IS_ENABLED(CONFIG_DM_GPIO)) {\n\nHmm... I know Simon suggested exactly this change ... but this seems\nto produce errors here ... when I look into the \".config\" file after\n\n\"make turris_omnia_defconfig\"\n\nI see:\n\n# CONFIG_DM_GPIO is not set\n\nHmm... using\n\n#ifdef CONFIG_DM_GPIO\n\ninstead \"if (IS_ENABLED(CONFIG_DM_GPIO)) {\" and it compiles clean.\n\nSo it seems we have a problem here with \"IS_ENABLED()\" ...\n\n@Simon, Masahiro: any ideas?\n\nbye,\nHeiko","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs0yq0FNtz9s4q\n\tfor ;\n\tTue, 12 Sep 2017 20:14:41 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 6611CC21FB0; Tue, 12 Sep 2017 10:14:34 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AE2FEC21C57;\n\tTue, 12 Sep 2017 10:14:31 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 6ACFBC21C40; Tue, 12 Sep 2017 10:14:30 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id ACE23C21C57\n\tfor ; Tue, 12 Sep 2017 10:14:27 +0000 (UTC)","from frontend03.mail.m-online.net (unknown [192.168.6.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xs0yV6D2Hz1qwqP;\n\tTue, 12 Sep 2017 12:14:26 +0200 (CEST)","from localhost (dynscan3.mnet-online.de [192.168.6.84])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xs0yV5fgbz1qsQH;\n\tTue, 12 Sep 2017 12:14:26 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id macZ_a7ocDPO; Tue, 12 Sep 2017 12:14:25 +0200 (CEST)","from localhost.localdomain (91.82.144.174.pool.invitel.hu\n\t[91.82.144.174])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tTue, 12 Sep 2017 12:14:25 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"iPsiSVXWN7oPHni9YH6fEJm1ES8jQfvco03Fvc0ARkM=","To":"Moritz Fischer ","References":"<20170911181948.11062-1-moritz.fischer@ettus.com>\n\t<59B7624F.3060600@denx.de>","From":"Heiko Schocher ","Message-ID":"<59B7B380.9030909@denx.de>","Date":"Tue, 12 Sep 2017 12:14:24 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101\n\tThunderbird/38.1.0","MIME-Version":"1.0","In-Reply-To":"<59B7624F.3060600@denx.de>","Cc":"u-boot@lists.denx.de, sr@denx.de, mdf@kernel.org","Subject":"Re: [U-Boot] [PATCH v2] i2c: muxes: pca954x: Add support for GPIO\n\treset line","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"hs@denx.de","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1766959,"web_url":"http://patchwork.ozlabs.org/comment/1766959/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:30:47","subject":"Re: [U-Boot] [PATCH v2] i2c: muxes: pca954x: Add support for GPIO\n\treset line","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 11 September 2017 at 12:19, Moritz Fischer wrote:\n> This commit adds support for GPIO reset lines matching the\n> common linux \"reset-gpios\" devicetree binding.\n>\n> Signed-off-by: Moritz Fischer \n> ---\n>\n> Changes from v1:\n> - Simon's feedback on ifdef vs IS_ENABLED()\n>\n> ---\n> drivers/i2c/muxes/pca954x.c | 42 +++++++++++++++++++++++++++++++++++++++++-\n> 1 file changed, 41 insertions(+), 1 deletion(-)\n>\n> diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c\n> index 383f72f552..7dee12166d 100644\n> --- a/drivers/i2c/muxes/pca954x.c\n> +++ b/drivers/i2c/muxes/pca954x.c\n> @@ -1,5 +1,6 @@\n> /*\n> * Copyright (C) 2015 - 2016 Xilinx, Inc.\n> + * Copyright (C) 2017 National Instruments Corp\n> * Written by Michal Simek\n> *\n> * SPDX-License-Identifier: GPL-2.0+\n> @@ -9,7 +10,8 @@\n> #include \n> #include \n> #include \n> -#include \n> +\n> +#include \n>\n> DECLARE_GLOBAL_DATA_PTR;\n>\n> @@ -30,6 +32,9 @@ struct chip_desc {\n> struct pca954x_priv {\n> u32 addr; /* I2C mux address */\n> u32 width; /* I2C mux width - number of busses */\n> +#ifdef CONFIG_DM_GPIO\n> + struct gpio_desc gpio_mux_reset;\n> +#endif /* CONFIG_DM_GPIO */\n\nYou should drop the #ifdef here.\n\nOtherwise:\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Zcb7dSnI\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"RIs6A47i\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs46Y55zmz9t7R\n\tfor ;\n\tTue, 12 Sep 2017 22:36:36 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 58F41C22043; Tue, 12 Sep 2017 12:35:24 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 39774C21DC5;\n\tTue, 12 Sep 2017 12:35:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0AF2EC21FCD; Tue, 12 Sep 2017 12:31:14 +0000 (UTC)","from mail-qt0-f172.google.com (mail-qt0-f172.google.com\n\t[209.85.216.172])\n\tby lists.denx.de (Postfix) with ESMTPS id B2F60C2200B\n\tfor ; Tue, 12 Sep 2017 12:31:09 +0000 (UTC)","by mail-qt0-f172.google.com with SMTP id i50so25183279qtf.0\n\tfor ; Tue, 12 Sep 2017 05:31:09 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:30:47 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=gj7EsbD54Qg9MSTG8LTM9vaH/yNZC1RA4byHiEUtNIk=;\n\tb=Zcb7dSnIUfosKIfygjPYoyRqe+gDz+yS2JQW/2PTwgx99w5+zBeu86iIEe2O5mllut\n\tRneSukCnBWBnUsfkMZ1v/0LcC0r1JMwaijwUYtK7JJKM3sNwZAajYOfELeyTWOnA13uJ\n\t/nVbx6V+rtfugWRe+MHk+GrQqmeGwUKOKO0xmSa4DoVEH+jSqPZFIkPwnhb9l2io94Po\n\tOrsormAUmv4KmVYoQa8VADR28gVK/bFPHreEq6WhcvVRZu9FXvi557AuUy35EfRwErCT\n\t66GnnzmPGYSFt9+G1Ayyu30G6KTeMw9kAtmHYW+OmBFca/VcStZ4af02tBYJFIfOkCel\n\tYMMg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=gj7EsbD54Qg9MSTG8LTM9vaH/yNZC1RA4byHiEUtNIk=;\n\tb=RIs6A47iCqyQpfvZbF1PPVChZuTbEGOnRdAfbjeEb1s1RjhWg7+O6qEacUQdJdNKXo\n\tKxB6XIZRvNDFNuww5z8l9HYMwtLXleT4WXX/CAzrt9yfnW9eXBKhyfASPIUKYlaqQZJ9\n\tEYeCVKQg+kGI0yGfkLmlvEzLWpkSlPcsaqW5M="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=gj7EsbD54Qg9MSTG8LTM9vaH/yNZC1RA4byHiEUtNIk=;\n\tb=E6bP1ykrdI9/D+m6BT6IKGhBQ4zd6cosoBBo7vKFD1AvTcr80QaA9XFvBJ/nuZk7DS\n\t1Sk1C8U5tJ/33xtz7cUnhwQo9w7NALhUmwgPncbLnsyRyI4xLncpeXLEJuF8aXOFofEK\n\tJGu3gsF65JnKVczk4zCgA8OS7YWfXcdiKS2oY9opWUaVeYyv9ZiSGExNGu99iZCdM3L2\n\tZC6ovlkgI8dEXnzBDIiA+KpzJHciQMzGIORVZHiiCXNLMdbDaAMRqC8oI6scEPcXdPvO\n\tT4v91Uevgf14MFSOwV3QHh2Su2TCs+WF2lZcmTGRnEZNwpsaGQ2eC1umphxkHrj3g8eg\n\tpAMA==","X-Gm-Message-State":"AHPjjUhtKxp4z2xdBbBrbEh94q0DjSpUQiw+IUv1NytBdJj+Ytug55xs\n\ttRVvZKNP6n4Lpz+p7Z6wFutsKdxl2F9ppDbaEtgkVw==","X-Google-Smtp-Source":"AOwi7QCkLoGiafeSAQdexCCUh+Y/GedlluXxqatNfwiNZuE4N43kAaf6h6Xs+dRYKnvy81mkL44hSs0zpZmp42LAIYo=","X-Received":"by 10.200.23.252 with SMTP id r57mr21813505qtk.76.1505219468484; \n\tTue, 12 Sep 2017 05:31:08 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170911181948.11062-1-moritz.fischer@ettus.com>","References":"<20170911181948.11062-1-moritz.fischer@ettus.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:30:47 -0600","X-Google-Sender-Auth":"J62RBGeJIez-85Qx0Qq2iish9v0","Message-ID":"","To":"Moritz Fischer ","Cc":"U-Boot Mailing List , Stefan Roese ,\n\tmdf@kernel.org","Subject":"Re: [U-Boot] [PATCH v2] i2c: muxes: pca954x: Add support for GPIO\n\treset line","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]