[{"id":1766873,"web_url":"http://patchwork.ozlabs.org/comment/1766873/","msgid":"","list_archive_url":null,"date":"2017-09-12T10:49:50","subject":"Re: [Qemu-devel] [PATCH v7 33/38] libqtest: Merge qtest_{in,\n\tout}[bwl]() with {in, out}[bwl]()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 11.09.2017 19:20, Eric Blake wrote:\n> Maintaining two layers of libqtest APIs, one that takes an explicit\n> QTestState object, and the other that uses the implicit global_qtest,\n> is annoying. In the interest of getting rid of global implicit\n> state and having less code to maintain, merge:\n> qtest_outb()\n> qtest_outw()\n> qtest_outl()\n> qtest_inb()\n> qtest_inw()\n> qtest_inl()\n> with their short counterparts. All callers that previously\n> used the short form now make it explicit that they are relying on\n> global_qtest, and later patches can then clean things up to remove\n> the global variable.\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/libqtest.h | 99 ++++++-------------------------------------------\n> tests/multiboot/libc.h | 2 +-\n> tests/libqtest.c | 14 +++----\n> tests/boot-order-test.c | 4 +-\n> tests/endianness-test.c | 12 +++---\n> tests/fdc-test.c | 77 ++++++++++++++++++++------------------\n> tests/hd-geo-test.c | 4 +-\n> tests/ipmi-bt-test.c | 12 +++---\n> tests/ipmi-kcs-test.c | 8 ++--\n> tests/libqos/fw_cfg.c | 4 +-\n> tests/libqos/pci-pc.c | 44 +++++++++++-----------\n> tests/libqos/pci.c | 2 +-\n> tests/m48t59-test.c | 8 ++--\n> tests/multiboot/libc.c | 2 +-\n> tests/pvpanic-test.c | 4 +-\n> tests/rtc-test.c | 8 ++--\n> tests/wdt_ib700-test.c | 8 ++--\n> 17 files changed, 120 insertions(+), 192 deletions(-)\n> \n> diff --git a/tests/libqtest.h b/tests/libqtest.h\n> index 8398c0fd07..520f745e7b 100644\n> --- a/tests/libqtest.h\n> +++ b/tests/libqtest.h\n> @@ -205,61 +205,61 @@ void irq_intercept_in(QTestState *s, const char *string);\n> void irq_intercept_out(QTestState *s, const char *string);\n> \n> /**\n> - * qtest_outb:\n> + * outb:\n> * @s: #QTestState instance to operate on.\n> * @addr: I/O port to write to.\n> * @value: Value being written.\n> *\n> * Write an 8-bit value to an I/O port.\n> */\n> -void qtest_outb(QTestState *s, uint16_t addr, uint8_t value);\n> +void outb(QTestState *s, uint16_t addr, uint8_t value);\n\nCould we please also keep the qtest prefix here? ... same applies for\nall your other following \"Merge ...\" patches in this series...\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs1mM0L0Mz9s7M\n\tfor ;\n\tTue, 12 Sep 2017 20:50:43 +1000 (AEST)","from localhost ([::1]:34872 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drim9-00070l-6T\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 06:50:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42903)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drilZ-0006tp-SB\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 06:50:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drilY-0000e3-VQ\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 06:50:05 -0400","from mx1.redhat.com ([209.132.183.28]:36886)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drilR-0000ZN-LM; Tue, 12 Sep 2017 06:49:57 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id ACC0C13A9D;\n\tTue, 12 Sep 2017 10:49:56 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5BFCB5E1D5;\n\tTue, 12 Sep 2017 10:49:52 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com ACC0C13A9D","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-34-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 12 Sep 2017 12:49:50 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-34-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 12 Sep 2017 10:49:56 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 33/38] libqtest: Merge qtest_{in,\n\tout}[bwl]() with {in, out}[bwl]()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, John Snow , armbru@redhat.com,\n\t\"open list:Floppy\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]