[{"id":1766443,"web_url":"http://patchwork.ozlabs.org/comment/1766443/","msgid":"<07e6505f-d795-3d84-4d1d-85728351058c@gmail.com>","list_archive_url":null,"date":"2017-09-11T18:19:21","subject":"Re: [ovs-dev] [PATCH 09/15] acinclude: Check for extended netlink\n\tack presence","submitter":{"id":69140,"url":"http://patchwork.ozlabs.org/api/people/69140/","name":"Gregory Rose","email":"gvrose8192@gmail.com"},"content":"On 09/11/2017 10:56 AM, Greg Rose wrote:\n> RTNL ops validate and newlink now include the extended netlink\n> ack feature. Check for it and set HAVE_EXT_ACK_IN_RTNL_LINKOPS\n> if found.\n> \n> Signed-off-by: Greg Rose \n> ---\n> acinclude.m4 | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/acinclude.m4 b/acinclude.m4\n> index 772ff03..46efa69 100644\n> --- a/acinclude.m4\n> +++ b/acinclude.m4\n> @@ -771,6 +771,12 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [\n> [OVS_DEFINE([HAVE_SKB_GSO_UDP])])\n> OVS_GREP_IFELSE([$KSRC/include/net/dst.h],[DST_NOCACHE],\n> [OVS_DEFINE([HAVE_DST_NOCACHE])])\n> + OVS_FIND_FIELD_IFELSE([$KSRC/include/net/rtnetlink.h], [rtnl_link_ops],\n> + [extack],\n> + [OVS_DEFINE([HAVE_EXT_ACK_IN_RTNL_LINKOPS])])\n\nThis part below for nf_hook_ops got munged into this patch but should should have been in\nits own separate patch.\n\nI'll follow up with a V2 of the series.\n\n- Greg\n\n> + OVS_FIND_FIELD_IFELSE([$KSRC/include/linux/netfilter.h], [nf_hook_ops],\n> + [list],\n> + [OVS_DEFINE([HAVE_LIST_IN_NF_HOOK_OPS])])\n> \n> \n> if cmp -s datapath/linux/kcompat.h.new \\\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"oaI1Khgz\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrbmc0Bj8z9sNr\n\tfor ;\n\tTue, 12 Sep 2017 04:19:27 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id B6840BD8;\n\tMon, 11 Sep 2017 18:19:25 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 00E14BD6\n\tfor ; Mon, 11 Sep 2017 18:19:25 +0000 (UTC)","from mail-pg0-f67.google.com (mail-pg0-f67.google.com\n\t[74.125.83.67])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id CC139124\n\tfor ; Mon, 11 Sep 2017 18:19:24 +0000 (UTC)","by mail-pg0-f67.google.com with SMTP id v82so4992548pgb.1\n\tfor ; Mon, 11 Sep 2017 11:19:24 -0700 (PDT)","from gizo.bigblue.kilchis.com (67-5-132-83.ptld.qwest.net.\n\t[67.5.132.83]) by smtp.gmail.com with ESMTPSA id\n\tp63sm14460418pga.82.2017.09.11.11.19.22 for \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 11:19:22 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=W4+BwMB85sH8frSIMoE58mpdph0CvGMMco5zNJ0VHGw=;\n\tb=oaI1KhgzajRhgqtxndVe3UADE2NT5lbKwv3f/dnP2M1HiAFZe+ee4mw84Jgzb8JL5q\n\tPiTcy0UXOxNR2U/bsvLRensci/jPYIBQL6zh+08ufbDWqxOujAC6lW5mmYYSa2KkMp84\n\tGT/Nlon3AObno3Icna4IsRwz4g58pVGzZTzzU9bsWfQZJf5rMNewD398ck8Afnbj4J5n\n\t29/0UG3LVP7uB0Xh1nKM9XnClZDN7eWHzRpwGNGmDF8otM5+YJx7lhpA4iwKHrpvvjaw\n\tnpoSlvXypJ2SaGvo/dR5MOoJkOHIildvhkogYEs4VGylShbN7gpa/Zkf1U/gb6YMDDHG\n\t00dg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=W4+BwMB85sH8frSIMoE58mpdph0CvGMMco5zNJ0VHGw=;\n\tb=WNV4TjNnt09YB7Gr++NDM/+d0f0Zg7nHVfXCwxFsb08tDnQ9pjpzMIorzvh3BQ3pAG\n\taDyBxMYAmt4hjVDoq7Yn7dlQ7SBWToenqmX2ikduwGWKyOrqRk2HE1l8W0GZpZacSKOE\n\tE4uUKgvXKvF2SXHVgWxHdT4GBs2wJds5BYbsSgkGFung3ZUuqs9dXN0qirY0ymlALh5i\n\tuNQ8zc3ZE60DMTGlyDVQU/GcYY99KW7PCG09i+8Yll1cRFfEt0tyuY8k+mn4DfHEcIXe\n\t/CdXqHBxl7xtoaMHWglfJYX21lGYud8dlVp9gEfPOTHqK5trOv8+1QkfSv97PptmyZzb\n\t4+MA==","X-Gm-Message-State":"AHPjjUjLEyzKDdzGWbyE/80LlNFU1mBs7s2OxBJgBtQrVtz3/AEmFRVn\n\tOgmYdzANBiEyjVxJMns=","X-Google-Smtp-Source":"ADKCNb7XoUI6oHOEuw8haOoO9oBp9n1OokRcfAS117b+YpWC7COp4Fytgv9edYEmpWTXBn9cYARJGQ==","X-Received":"by 10.101.90.68 with SMTP id z4mr12460797pgs.76.1505153964012;\n\tMon, 11 Sep 2017 11:19:24 -0700 (PDT)","To":"\"dev@openvswitch.org\" ","References":"<1505152570-6143-1-git-send-email-gvrose8192@gmail.com>\n\t<1505152570-6143-9-git-send-email-gvrose8192@gmail.com>","From":"Greg Rose ","Message-ID":"<07e6505f-d795-3d84-4d1d-85728351058c@gmail.com>","Date":"Mon, 11 Sep 2017 11:19:21 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"<1505152570-6143-9-git-send-email-gvrose8192@gmail.com>","Content-Language":"en-US","X-Spam-Status":"No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, \n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 09/15] acinclude: Check for extended netlink\n\tack presence","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]