[{"id":1766872,"web_url":"http://patchwork.ozlabs.org/comment/1766872/","msgid":"<39007427-a185-1cb3-a0d8-8d0d3954c8b1@redhat.com>","list_archive_url":null,"date":"2017-09-12T10:47:38","subject":"Re: [Qemu-devel] [PATCH v7 32/38] libqtest: Merge qtest_irq*() with\n\tirq*()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 11.09.2017 19:20, Eric Blake wrote:\n> Maintaining two layers of libqtest APIs, one that takes an explicit\n> QTestState object, and the other that uses the implicit global_qtest,\n> is annoying. In the interest of getting rid of global implicit\n> state and having less code to maintain, merge:\n> qtest_get_irq()\n> qtest_irq_intercept_in()\n> qtest_irq_intercept_out()\n> with their short counterparts. All callers that previously\n> used the short form now make it explicit that they are relying on\n> global_qtest, and later patches can then clean things up to remove\n> the global variable.\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/libqtest.h | 47 ++++++-----------------------------------------\n> tests/libqtest.c | 6 +++---\n> tests/fdc-test.c | 48 ++++++++++++++++++++++++------------------------\n> tests/ide-test.c | 17 +++++++++--------\n> tests/ipmi-bt-test.c | 6 +++---\n> tests/ipmi-kcs-test.c | 8 ++++----\n> tests/libqos/libqos-pc.c | 2 +-\n> tests/rtc-test.c | 10 +++++-----\n> tests/tco-test.c | 2 +-\n> tests/wdt_ib700-test.c | 8 ++++----\n> 10 files changed, 60 insertions(+), 94 deletions(-)\n> \n> diff --git a/tests/libqtest.h b/tests/libqtest.h\n> index 26d5f37bc9..8398c0fd07 100644\n> --- a/tests/libqtest.h\n> +++ b/tests/libqtest.h\n> @@ -176,33 +176,33 @@ char *qtest_hmp(QTestState *s, const char *fmt, ...) GCC_FMT_ATTR(2, 3);\n> char *qtest_hmpv(QTestState *s, const char *fmt, va_list ap);\n> \n> /**\n> - * qtest_get_irq:\n> + * get_irq:\n> * @s: #QTestState instance to operate on.\n> * @num: Interrupt to observe.\n> *\n> * Returns: The level of the @num interrupt.\n> */\n> -bool qtest_get_irq(QTestState *s, int num);\n> +bool get_irq(QTestState *s, int num);\n> \n> /**\n> - * qtest_irq_intercept_in:\n> + * irq_intercept_in:\n> * @s: #QTestState instance to operate on.\n> * @string: QOM path of a device.\n> *\n> * Associate qtest irqs with the GPIO-in pins of the device\n> * whose path is specified by @string.\n> */\n> -void qtest_irq_intercept_in(QTestState *s, const char *string);\n> +void irq_intercept_in(QTestState *s, const char *string);\n> \n> /**\n> - * qtest_irq_intercept_out:\n> + * irq_intercept_out:\n> * @s: #QTestState instance to operate on.\n> * @string: QOM path of a device.\n> *\n> * Associate qtest irqs with the GPIO-out pins of the device\n> * whose path is specified by @string.\n> */\n> -void qtest_irq_intercept_out(QTestState *s, const char *string);\n> +void irq_intercept_out(QTestState *s, const char *string);\n\nCould we please also keep the qtest prefix here?\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs1jt4pl5z9s7M\n\tfor ;\n\tTue, 12 Sep 2017 20:48:34 +1000 (AEST)","from localhost ([::1]:34854 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drik4-0005XW-P3\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 06:48:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42074)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drijU-0005Vp-Ga\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 06:47:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drijQ-0007TB-J4\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 06:47:56 -0400","from mx1.redhat.com ([209.132.183.28]:45602)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drijJ-0007Mt-OM; Tue, 12 Sep 2017 06:47:45 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B2C3E8553D;\n\tTue, 12 Sep 2017 10:47:44 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id DBB0962662;\n\tTue, 12 Sep 2017 10:47:40 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B2C3E8553D","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-33-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"<39007427-a185-1cb3-a0d8-8d0d3954c8b1@redhat.com>","Date":"Tue, 12 Sep 2017 12:47:38 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-33-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 12 Sep 2017 10:47:44 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 32/38] libqtest: Merge qtest_irq*() with\n\tirq*()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, John Snow , armbru@redhat.com,\n\t\"open list:Floppy\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]