[{"id":1766634,"web_url":"http://patchwork.ozlabs.org/comment/1766634/","msgid":"<5b23e7b5-b8f7-72c2-a7b7-73ba504abd06@redhat.com>","list_archive_url":null,"date":"2017-09-12T00:31:36","subject":"Re: [Qemu-devel] [PATCH v7 26/38] libqtest: Merge qtest_end() into\n\tqtest_quit()","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/11/2017 01:20 PM, Eric Blake wrote:\n> Rather than have two similar shutdown functions, where one requires\n> the use of global_qtest in the header, it is better to have a single\n> shutdown function that still takes care of cleaning up global_qtest\n> if it is set. All callers are updated.\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/libqtest.h | 11 -----------\n> tests/libqtest.c | 6 +++++-\n[...]\n> tests/fdc-test.c | 2 +-\n[...]\n> tests/ide-test.c | 2 +-\n\nReviewed-by: John Snow \n\nThe rest: \"ACK.\" Change looks sane and I assume the rest of the patch is\nfairly straightforward mechanical changes. Everything still compiles and\nruns successfully.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrm2w6jr9z9sBZ\n\tfor ;\n\tTue, 12 Sep 2017 10:32:24 +1000 (AEST)","from localhost ([::1]:32954 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drZ7n-0002TL-3o\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 20:32:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36550)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drZ7J-0002S3-31\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 20:31:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drZ7I-0000Yt-CI\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 20:31:53 -0400","from mx1.redhat.com ([209.132.183.28]:51578)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drZ7D-0000X1-Ba; Mon, 11 Sep 2017 20:31:47 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D1EF1753C1;\n\tTue, 12 Sep 2017 00:31:45 +0000 (UTC)","from [10.18.17.231] (dhcp-17-231.bos.redhat.com [10.18.17.231])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BD4AB600C4;\n\tTue, 12 Sep 2017 00:31:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D1EF1753C1","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-27-eblake@redhat.com>","From":"John Snow ","Message-ID":"<5b23e7b5-b8f7-72c2-a7b7-73ba504abd06@redhat.com>","Date":"Mon, 11 Sep 2017 20:31:36 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-27-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 12 Sep 2017 00:31:46 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 26/38] libqtest: Merge qtest_end() into\n\tqtest_quit()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, \"open list:Floppy\" , Amit Shah\n\t, Jason Wang , \"Michael S.\n\tTsirkin\" , armbru@redhat.com, Alexander Graf\n\t, Keith Busch , \"open list:sPAPR\"\n\t, Gerd Hoffmann , Stefan\n\tHajnoczi , pbonzini@redhat.com, =?utf-8?q?Andrea?=\n\t=?utf-8?b?cyBGw6RyYmVy?= ,\n\t\"Dr. David Alan Gilbert\" , David Gibson\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766818,"web_url":"http://patchwork.ozlabs.org/comment/1766818/","msgid":"<677602b8-99a2-4117-c0ee-72a752d588f8@redhat.com>","list_archive_url":null,"date":"2017-09-12T09:30:10","subject":"Re: [Qemu-devel] [PATCH v7 26/38] libqtest: Merge qtest_end() into\n\tqtest_quit()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 11.09.2017 19:20, Eric Blake wrote:\n> Rather than have two similar shutdown functions, where one requires\n> the use of global_qtest in the header, it is better to have a single\n> shutdown function that still takes care of cleaning up global_qtest\n> if it is set. All callers are updated.\n> \n> Signed-off-by: Eric Blake \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs00J3GDWz9s82\n\tfor ;\n\tTue, 12 Sep 2017 19:30:56 +1000 (AEST)","from localhost ([::1]:34520 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drhWw-0000VS-J6\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 05:30:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48401)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drhWb-0000Rc-3l\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 05:30:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drhWa-0008RS-B2\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 05:30:33 -0400","from mx1.redhat.com ([209.132.183.28]:39960)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drhWV-0008Po-WD; Tue, 12 Sep 2017 05:30:28 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D6F93A798;\n\tTue, 12 Sep 2017 09:30:26 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 3193117DE6;\n\tTue, 12 Sep 2017 09:30:11 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D6F93A798","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-27-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"<677602b8-99a2-4117-c0ee-72a752d588f8@redhat.com>","Date":"Tue, 12 Sep 2017 11:30:10 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-27-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 12 Sep 2017 09:30:27 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 26/38] libqtest: Merge qtest_end() into\n\tqtest_quit()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"open list:Floppy\" , \"Michael S. Tsirkin\"\n\t, Jason Wang ,\n\tAmit Shah , armbru@redhat.com,\n\tAlexander Graf , \tKeith Busch ,\n\t\"open list:sPAPR\"\n\t, Gerd Hoffmann , Stefan\n\tHajnoczi , pbonzini@redhat.com, John Snow\n\t, =?utf-8?q?Andreas_F=C3=A4rber?= ,\n\t\"Dr. David Alan Gilbert\" , David Gibson\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]