[{"id":1766628,"web_url":"http://patchwork.ozlabs.org/comment/1766628/","msgid":"<46e51e9e-aa23-5f0f-cdfb-c25dafdfe23d@redhat.com>","list_archive_url":null,"date":"2017-09-11T23:54:15","subject":"Re: [Qemu-devel] [PATCH v7 16/38] libqos: Use explicit QTestState\n\tfor ahci operations","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/11/2017 01:20 PM, Eric Blake wrote:\n> Drop one more client of global_qtest by teaching all ahci test\n> functionality to pass in an explicit QTestState. The state was\n> already available, so no callers had to be adjusted.\n> \n> Signed-off-by: Eric Blake \n\nI should admit that this makes my urge to write a wrapper/macro increase\njust a little bit, but ... admitting you have a problem is the first\nstep to recovery.\n\nReviewed-by: John Snow ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrlCZ4B79z9sBZ\n\tfor ;\n\tTue, 12 Sep 2017 09:54:49 +1000 (AEST)","from localhost ([::1]:32855 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drYXP-0007Ku-0d\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 19:54:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56072)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drYX1-0007Ij-OL\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 19:54:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drYX0-0000VD-Um\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 19:54:23 -0400","from mx1.redhat.com ([209.132.183.28]:56002)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drYWw-0000UK-J2; Mon, 11 Sep 2017 19:54:18 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8D817118B09;\n\tMon, 11 Sep 2017 23:54:16 +0000 (UTC)","from [10.18.17.231] (dhcp-17-231.bos.redhat.com [10.18.17.231])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CC4D4669F7;\n\tMon, 11 Sep 2017 23:54:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8D817118B09","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-17-eblake@redhat.com>","From":"John Snow ","Message-ID":"<46e51e9e-aa23-5f0f-cdfb-c25dafdfe23d@redhat.com>","Date":"Mon, 11 Sep 2017 19:54:15 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-17-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tMon, 11 Sep 2017 23:54:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 16/38] libqos: Use explicit QTestState\n\tfor ahci operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, thuth@redhat.com, armbru@redhat.com,\n\t\"open list:IDE\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766788,"web_url":"http://patchwork.ozlabs.org/comment/1766788/","msgid":"","list_archive_url":null,"date":"2017-09-12T09:09:25","subject":"Re: [Qemu-devel] [PATCH v7 16/38] libqos: Use explicit QTestState\n\tfor ahci operations","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 11.09.2017 19:20, Eric Blake wrote:\n> Drop one more client of global_qtest by teaching all ahci test\n> functionality to pass in an explicit QTestState. The state was\n> already available, so no callers had to be adjusted.\n> \n> Signed-off-by: Eric Blake \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrzXb17d8z9s81\n\tfor ;\n\tTue, 12 Sep 2017 19:10:23 +1000 (AEST)","from localhost ([::1]:34413 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drhD3-0001TZ-9H\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 05:10:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41212)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drhCQ-0001Oy-Tk\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 05:09:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drhCM-00064c-Vt\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 05:09:42 -0400","from mx1.redhat.com ([209.132.183.28]:54842)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drhCF-0005qx-VT; Tue, 12 Sep 2017 05:09:32 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 09BC6C04B930;\n\tTue, 12 Sep 2017 09:09:31 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 48D716C52A;\n\tTue, 12 Sep 2017 09:09:27 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 09BC6C04B930","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-17-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 12 Sep 2017 11:09:25 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-17-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 12 Sep 2017 09:09:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 16/38] libqos: Use explicit QTestState\n\tfor ahci operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, John Snow , armbru@redhat.com,\n\t\"open list:IDE\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]