[{"id":1766722,"web_url":"http://patchwork.ozlabs.org/comment/1766722/","msgid":"","list_archive_url":null,"date":"2017-09-12T07:38:42","subject":"Re: [Qemu-devel] [PATCH v7 12/38] libqos: Use explicit QTestState\n\tfor virtio operations","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 11.09.2017 19:19, Eric Blake wrote:\n> Now that QVirtioDevice and QVirtQueue point back to QVirtioBus,\n> we can reuse the explicit QTestState stored there rather than\n> relying on implicit global_qtest. We also have to pass QTestState\n> through a few functions that can't trace back through\n> QVirtioDevice, and update those callers.\n> \n> Drop some useless casts while touching things.\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/libqos/virtio.h | 6 ++--\n> tests/libqos/virtio-mmio.c | 57 ++++++++++++++++++-------------\n> tests/libqos/virtio-pci.c | 8 ++---\n> tests/libqos/virtio.c | 84 ++++++++++++++++++++++++++--------------------\n> tests/virtio-blk-test.c | 11 +++---\n> 5 files changed, 94 insertions(+), 72 deletions(-)\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrxWk38NMz9s7B\n\tfor ;\n\tTue, 12 Sep 2017 17:39:26 +1000 (AEST)","from localhost ([::1]:34083 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drfn1-0004FX-BJ\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 03:39:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45235)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drfmf-0004Cp-NF\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 03:39:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drfme-0007wh-UY\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 03:39:01 -0400","from mx1.redhat.com ([209.132.183.28]:44432)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drfmU-0007uY-Ht; Tue, 12 Sep 2017 03:38:50 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4AC3180F6C;\n\tTue, 12 Sep 2017 07:38:49 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 91377756A7;\n\tTue, 12 Sep 2017 07:38:45 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4AC3180F6C","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-13-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 12 Sep 2017 09:38:42 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-13-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 12 Sep 2017 07:38:49 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 12/38] libqos: Use explicit QTestState\n\tfor virtio operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, \"open list:virtio-blk\" ,\n\tarmbru@redhat.com, Stefan Hajnoczi ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]