[{"id":1766834,"web_url":"http://patchwork.ozlabs.org/comment/1766834/","msgid":"","list_archive_url":null,"date":"2017-09-12T09:57:14","subject":"Re: [Qemu-devel] [PATCH v7 27/38] libqtest: Swap order of\n\tqtest_init() and qtest_start()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 11.09.2017 19:20, Eric Blake wrote:\n> We already have another qtest_init() in the tree (namely, as part\n> of the device initialization of the qtest device at the top level\n> qtest.c), with a different signature; having two different\n> qtest_init() is confusing, so an upcoming patch will consolidate\n> all testsuite callers onto a unified spelling. But the\n> consolidation is easier if qtest_start() is further down the call\n> chain, rather than an intermediate wrapper, so swap the call chain\n> around. This includes renaming qtest_init_without_qmp_handshake()\n> into qtest_start_without_qmp_handshake(), as it remains the lowest\n> point in the call stack.\n> \n> Note that qtest_init() now asserts that global_qtest was not set\n> on entry, and clears it on exit, to preserve the behavior of\n> existing tests that assert the same (and also proving that we\n> fixed all tests that had parallel connections); but later patches\n> will eventually simplify things by getting rid of qtest_init()\n> and global_qtest altogether.\n> \n> Signed-off-by: Eric Blake \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs0bD28Kkz9s4s\n\tfor ;\n\tTue, 12 Sep 2017 19:57:44 +1000 (AEST)","from localhost ([::1]:34630 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drhws-0002Y6-EX\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 05:57:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55409)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drhwa-0002Xu-JO\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 05:57:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drhwV-00048X-PQ\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 05:57:24 -0400","from mx1.redhat.com ([209.132.183.28]:46810)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drhwV-00047j-Iq\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 05:57:19 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8C0E5C04B317\n\tfor ; Tue, 12 Sep 2017 09:57:18 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0132B6F9F9;\n\tTue, 12 Sep 2017 09:57:16 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8C0E5C04B317","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-28-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 12 Sep 2017 11:57:14 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-28-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 12 Sep 2017 09:57:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 27/38] libqtest: Swap order of\n\tqtest_init() and qtest_start()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]