[{"id":1766625,"web_url":"http://patchwork.ozlabs.org/comment/1766625/","msgid":"<217d9771-dba2-7ab1-3d52-4863ae74fe56@redhat.com>","list_archive_url":null,"date":"2017-09-11T23:46:56","subject":"Re: [Qemu-devel] [PATCH v7 08/38] libqos: Track QTestState with\n\tQPCIBus","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/11/2017 01:19 PM, Eric Blake wrote:\n> When initializing a QPCIBus, track which QTestState the bus is\n> associated with (so that a later patch can then explicitly use\n> that test state for all communication on the bus, rather than\n> blindly relying on global_qtest). Update the initialization\n> functions to take another parameter, and update all callers to\n> pass in state (for now, most callers get away with passing the\n> current global_qtest as the current state, although this required\n> fixing the order of initialization to ensure qtest_start() is\n> called before qpci_init*() in rtl8139-test, and provided an\n> opportunity to pass in the allocator in e1000e-test).\n> \n> Touch up some allocations to use g_new0() rather than g_malloc()\n> while in the area, and simplify some code (all implementations\n> of QOSOps provide a .init_allocator() that never fails).\n> \n> Signed-off-by: Eric Blake \n\nReviewed-by: John Snow ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrl3N59tqz9s7g\n\tfor ;\n\tTue, 12 Sep 2017 09:47:44 +1000 (AEST)","from localhost ([::1]:32830 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drYQY-0003vn-PI\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 19:47:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54100)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drYPz-0003rq-DW\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 19:47:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drYPy-0006a9-NS\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 19:47:07 -0400","from mx1.redhat.com ([209.132.183.28]:50978)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drYPu-0006Z2-AJ; Mon, 11 Sep 2017 19:47:02 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E520D36C1CA;\n\tMon, 11 Sep 2017 23:47:00 +0000 (UTC)","from [10.18.17.231] (dhcp-17-231.bos.redhat.com [10.18.17.231])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 801EA707BD;\n\tMon, 11 Sep 2017 23:46:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E520D36C1CA","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-9-eblake@redhat.com>","From":"John Snow ","Message-ID":"<217d9771-dba2-7ab1-3d52-4863ae74fe56@redhat.com>","Date":"Mon, 11 Sep 2017 19:46:56 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-9-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tMon, 11 Sep 2017 23:47:01 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 08/38] libqos: Track QTestState with\n\tQPCIBus","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, \"open list:IDE\" ,\n\tarmbru@redhat.com, Alexander Graf ,\n\t\"open list:sPAPR\" ,\n\tGerd Hoffmann , pbonzini@redhat.com,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766711,"web_url":"http://patchwork.ozlabs.org/comment/1766711/","msgid":"<0f14c31c-a1f2-7bed-e9fb-e8b7149b3867@redhat.com>","list_archive_url":null,"date":"2017-09-12T07:05:44","subject":"Re: [Qemu-devel] [PATCH v7 08/38] libqos: Track QTestState with\n\tQPCIBus","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 11.09.2017 19:19, Eric Blake wrote:\n> When initializing a QPCIBus, track which QTestState the bus is\n> associated with (so that a later patch can then explicitly use\n> that test state for all communication on the bus, rather than\n> blindly relying on global_qtest). Update the initialization\n> functions to take another parameter, and update all callers to\n> pass in state (for now, most callers get away with passing the\n> current global_qtest as the current state, although this required\n> fixing the order of initialization to ensure qtest_start() is\n> called before qpci_init*() in rtl8139-test, and provided an\n> opportunity to pass in the allocator in e1000e-test).\n> \n> Touch up some allocations to use g_new0() rather than g_malloc()\n> while in the area, and simplify some code (all implementations\n> of QOSOps provide a .init_allocator() that never fails).\n> \n> Signed-off-by: Eric Blake \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrwp62Nx0z9s83\n\tfor ;\n\tTue, 12 Sep 2017 17:06:50 +1000 (AEST)","from localhost ([::1]:33984 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drfHT-0001tn-AY\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 03:06:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37244)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drfGo-0001sB-Pu\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 03:06:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drfGi-0003pj-W0\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 03:06:06 -0400","from mx1.redhat.com ([209.132.183.28]:37586)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drfGd-0003n8-Qr; Tue, 12 Sep 2017 03:05:55 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E37B313A88;\n\tTue, 12 Sep 2017 07:05:53 +0000 (UTC)","from [10.36.116.90] (ovpn-116-90.ams2.redhat.com [10.36.116.90])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id E4F6C6A836;\n\tTue, 12 Sep 2017 07:05:45 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E37B313A88","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-9-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"<0f14c31c-a1f2-7bed-e9fb-e8b7149b3867@redhat.com>","Date":"Tue, 12 Sep 2017 09:05:44 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-9-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 12 Sep 2017 07:05:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 08/38] libqos: Track QTestState with\n\tQPCIBus","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"open list:IDE\" , Alexander Graf , \n\tarmbru@redhat.com, \"open list:sPAPR\" ,\n\tGerd Hoffmann , pbonzini@redhat.com,\n\tJohn Snow , David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]