[{"id":1766626,"web_url":"http://patchwork.ozlabs.org/comment/1766626/","msgid":"<850a02c8-080a-1d54-11c9-8470f9394c03@redhat.com>","list_archive_url":null,"date":"2017-09-11T23:49:44","subject":"Re: [Qemu-devel] [PATCH v7 13/38] libqos: Use explicit QTestState\n\tfor fw_cfg operations","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/11/2017 01:19 PM, Eric Blake wrote:\n> Drop one more client of global_qtest by teaching all fw_cfg test\n> functionality (invoked through alloc-pc) to pass in an explicit\n> QTestState, adjusting all callers. In particular, fw_cfg-test\n> had to reorder things to create the test state prior to creating\n> the fw_cfg (and drop a pointless strdup in the meantime), but that\n> test now no longer depends on global_qtest.\n> \n> Signed-off-by: Eric Blake \n> \nReviewed-by: John Snow ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrl6P6qg0z9s7g\n\tfor ;\n\tTue, 12 Sep 2017 09:50:21 +1000 (AEST)","from localhost ([::1]:32843 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drYT6-0005Z4-4a\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 19:50:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54945)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drYSd-0005WT-V0\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 19:49:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drYSd-0007Yt-AJ\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 19:49:52 -0400","from mx1.redhat.com ([209.132.183.28]:57146)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drYSZ-0007XU-76; Mon, 11 Sep 2017 19:49:47 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2BF9313AAD;\n\tMon, 11 Sep 2017 23:49:46 +0000 (UTC)","from [10.18.17.231] (dhcp-17-231.bos.redhat.com [10.18.17.231])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 08A85669F7;\n\tMon, 11 Sep 2017 23:49:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2BF9313AAD","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-14-eblake@redhat.com>","From":"John Snow ","Message-ID":"<850a02c8-080a-1d54-11c9-8470f9394c03@redhat.com>","Date":"Mon, 11 Sep 2017 19:49:44 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-14-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tMon, 11 Sep 2017 23:49:46 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 13/38] libqos: Use explicit QTestState\n\tfor fw_cfg operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, \"open list:IDE\" ,\n\tarmbru@redhat.com, Alexander Graf ,\n\t\"open list:sPAPR\" , pbonzini@redhat.com,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766779,"web_url":"http://patchwork.ozlabs.org/comment/1766779/","msgid":"<409e4c1f-80f3-5548-c829-8f49edc3d4e7@redhat.com>","list_archive_url":null,"date":"2017-09-12T08:55:00","subject":"Re: [Qemu-devel] [PATCH v7 13/38] libqos: Use explicit QTestState\n\tfor fw_cfg operations","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 11.09.2017 19:19, Eric Blake wrote:\n> Drop one more client of global_qtest by teaching all fw_cfg test\n> functionality (invoked through alloc-pc) to pass in an explicit\n> QTestState, adjusting all callers. In particular, fw_cfg-test\n> had to reorder things to create the test state prior to creating\n> the fw_cfg (and drop a pointless strdup in the meantime), but that\n> test now no longer depends on global_qtest.\n> \n> Signed-off-by: Eric Blake \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrzD44TX3z9ryQ\n\tfor ;\n\tTue, 12 Sep 2017 18:56:04 +1000 (AEST)","from localhost ([::1]:34331 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drgzC-0002Qp-Qq\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 04:56:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36138)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drgyc-0002Hg-0a\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 04:55:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drgyb-0005KP-83\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 04:55:26 -0400","from mx1.redhat.com ([209.132.183.28]:42970)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drgyV-0005Bl-2q; Tue, 12 Sep 2017 04:55:19 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E6C3A7E420;\n\tTue, 12 Sep 2017 08:55:17 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 6B89C6E214;\n\tTue, 12 Sep 2017 08:55:02 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E6C3A7E420","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-14-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"<409e4c1f-80f3-5548-c829-8f49edc3d4e7@redhat.com>","Date":"Tue, 12 Sep 2017 10:55:00 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-14-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 12 Sep 2017 08:55:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 13/38] libqos: Use explicit QTestState\n\tfor fw_cfg operations","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"open list:IDE\" , Alexander Graf , \n\tarmbru@redhat.com, \"open list:sPAPR\" ,\n\tpbonzini@redhat.com, John Snow ,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]