[{"id":1766717,"web_url":"http://patchwork.ozlabs.org/comment/1766717/","msgid":"<65cb854d-5915-dc23-cb5d-0d8b5cecb6ea@redhat.com>","list_archive_url":null,"date":"2017-09-12T07:29:54","subject":"Re: [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename\n\tqpci_unplug_acpi_device_test() to pci.c","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 11.09.2017 19:19, Eric Blake wrote:\n> Commit 2f8b2767 originally added qpci_plug_device_test() and\n> qpci_unplug_acpi_device_test() as a pair, both in pci-pc.c.\n> Later, commit cf716b31 moved one half of the pair to pci.c\n> when adding PPC64 support. Keep the implementations of the\n> two functions together, and shorten the name to\n> qpci_unplug_device_test(), since all callers use the two\n> functions in tandem.\n> \n> Signed-off-by: Eric Blake \n> ---\n> tests/libqos/pci.h | 2 +-\n> tests/e1000e-test.c | 2 +-\n> tests/ivshmem-test.c | 2 +-\n> tests/libqos/pci-pc.c | 23 -----------------------\n> tests/libqos/pci.c | 23 +++++++++++++++++++++++\n> tests/virtio-blk-test.c | 2 +-\n> tests/virtio-net-test.c | 2 +-\n> tests/virtio-rng-test.c | 2 +-\n> 8 files changed, 29 insertions(+), 29 deletions(-)\n> \n> diff --git a/tests/libqos/pci.h b/tests/libqos/pci.h\n> index 429c382282..fdda7eca6e 100644\n> --- a/tests/libqos/pci.h\n> +++ b/tests/libqos/pci.h\n> @@ -111,5 +111,5 @@ QPCIBar qpci_legacy_iomap(QPCIDevice *dev, uint16_t addr);\n> \n> void qpci_plug_device_test(const char *driver, const char *id,\n> uint8_t slot, const char *opts);\n> -void qpci_unplug_acpi_device_test(const char *id, uint8_t slot);\n> +void qpci_unplug_device_test(const char *id, uint8_t slot);\n> #endif\n> diff --git a/tests/e1000e-test.c b/tests/e1000e-test.c\n> index d8085d944e..4c663a3019 100644\n> --- a/tests/e1000e-test.c\n> +++ b/tests/e1000e-test.c\n> @@ -461,7 +461,7 @@ static void test_e1000e_hotplug(gconstpointer data)\n> qtest_start(\"-device e1000e\");\n> \n> qpci_plug_device_test(\"e1000e\", \"e1000e_net\", slot, NULL);\n> - qpci_unplug_acpi_device_test(\"e1000e_net\", slot);\n> + qpci_unplug_device_test(\"e1000e_net\", slot);\n> \n> qtest_end();\n> }\n> diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c\n> index 37763425ee..8c9ed6a568 100644\n> --- a/tests/ivshmem-test.c\n> +++ b/tests/ivshmem-test.c\n> @@ -427,7 +427,7 @@ static void test_ivshmem_hotplug(void)\n> \n> qpci_plug_device_test(\"ivshmem\", \"iv1\", PCI_SLOT_HP, opts);\n> if (strcmp(arch, \"ppc64\") != 0) {\n> - qpci_unplug_acpi_device_test(\"iv1\", PCI_SLOT_HP);\n> + qpci_unplug_device_test(\"iv1\", PCI_SLOT_HP);\n> }\n> \n> qtest_end();\n> diff --git a/tests/libqos/pci-pc.c b/tests/libqos/pci-pc.c\n> index e267fd1a44..6305d142a5 100644\n> --- a/tests/libqos/pci-pc.c\n> +++ b/tests/libqos/pci-pc.c\n> @@ -19,9 +19,6 @@\n> #include \"qemu-common.h\"\n> \n> \n> -#define ACPI_PCIHP_ADDR 0xae00\n> -#define PCI_EJ_BASE 0x0008\n> -\n> typedef struct QPCIBusPC\n> {\n> QPCIBus bus;\n> @@ -156,23 +153,3 @@ void qpci_free_pc(QPCIBus *bus)\n> \n> g_free(s);\n> }\n> -\n> -void qpci_unplug_acpi_device_test(const char *id, uint8_t slot)\n> -{\n> - QDict *response;\n> - char *cmd;\n> -\n> - cmd = g_strdup_printf(\"{'execute': 'device_del',\"\n> - \" 'arguments': {\"\n> - \" 'id': '%s'\"\n> - \"}}\", id);\n> - response = qmp(cmd);\n> - g_free(cmd);\n> - g_assert(response);\n> - g_assert(!qdict_haskey(response, \"error\"));\n> - QDECREF(response);\n> -\n> - outb(ACPI_PCIHP_ADDR + PCI_EJ_BASE, 1 << slot);\n> -\n> - qmp_eventwait(\"DEVICE_DELETED\");\n> -}\n> diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c\n> index 2dcdeade2a..9f36ec73ef 100644\n> --- a/tests/libqos/pci.c\n> +++ b/tests/libqos/pci.c\n> @@ -16,6 +16,9 @@\n> #include \"hw/pci/pci_regs.h\"\n> #include \"qemu/host-utils.h\"\n> \n> +#define ACPI_PCIHP_ADDR 0xae00\n> +#define PCI_EJ_BASE 0x0008\n> +\n> void qpci_device_foreach(QPCIBus *bus, int vendor_id, int device_id,\n> void (*func)(QPCIDevice *dev, int devfn, void *data),\n> void *data)\n> @@ -412,3 +415,23 @@ void qpci_plug_device_test(const char *driver, const char *id,\n> g_assert(!qdict_haskey(response, \"error\"));\n> QDECREF(response);\n> }\n> +\n> +void qpci_unplug_device_test(const char *id, uint8_t slot)\n> +{\n> + QDict *response;\n> + char *cmd;\n> +\n> + cmd = g_strdup_printf(\"{'execute': 'device_del',\"\n> + \" 'arguments': {\"\n> + \" 'id': '%s'\"\n> + \"}}\", id);\n> + response = qmp(cmd);\n> + g_free(cmd);\n> + g_assert(response);\n> + g_assert(!qdict_haskey(response, \"error\"));\n> + QDECREF(response);\n> +\n> + outb(ACPI_PCIHP_ADDR + PCI_EJ_BASE, 1 << slot);\n> +\n> + qmp_eventwait(\"DEVICE_DELETED\");\n> +}\n\nNo, that's a bad idea. ACPI and that outb() is clearly something\nspecific to x86, so this should not reside in pci.c but in pci-pc.c\n\nWe might be able to unify this - I've had a similar patch here:\n\n https://patchwork.kernel.org/patch/9905031/\n\n... but I think this needs some more careful thinking and discussion, so\nI'd suggest that you remove this from your already huge patch series for\nnow and we fix it later instead.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrxKd52HWz9s83\n\tfor ;\n\tTue, 12 Sep 2017 17:30:44 +1000 (AEST)","from localhost ([::1]:34055 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drfec-00013Z-4e\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 03:30:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42068)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drfeB-000132-RG\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 03:30:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drfe5-000403-M6\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 03:30:15 -0400","from mx1.redhat.com ([209.132.183.28]:39692)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drfdx-0003se-Sn; Tue, 12 Sep 2017 03:30:02 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B627581DEE;\n\tTue, 12 Sep 2017 07:30:00 +0000 (UTC)","from [10.36.116.90] (ovpn-116-90.ams2.redhat.com [10.36.116.90])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 7F1675C540;\n\tTue, 12 Sep 2017 07:29:56 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B627581DEE","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-11-eblake@redhat.com>","From":"Thomas Huth ","Message-ID":"<65cb854d-5915-dc23-cb5d-0d8b5cecb6ea@redhat.com>","Date":"Tue, 12 Sep 2017 09:29:54 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911172022.4738-11-eblake@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 12 Sep 2017 07:30:00 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename\n\tqpci_unplug_acpi_device_test() to pci.c","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier ,\n\t\"open list:virtio-blk\" ,\n\tAmit Shah , Jason Wang ,\n\tarmbru@redhat.com, Stefan Hajnoczi ,\n\tpbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767034,"web_url":"http://patchwork.ozlabs.org/comment/1767034/","msgid":"","list_archive_url":null,"date":"2017-09-12T13:28:49","subject":"Re: [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename\n\tqpci_unplug_acpi_device_test() to pci.c","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/12/2017 02:29 AM, Thomas Huth wrote:\n> On 11.09.2017 19:19, Eric Blake wrote:\n>> Commit 2f8b2767 originally added qpci_plug_device_test() and\n>> qpci_unplug_acpi_device_test() as a pair, both in pci-pc.c.\n>> Later, commit cf716b31 moved one half of the pair to pci.c\n>> when adding PPC64 support. Keep the implementations of the\n>> two functions together, and shorten the name to\n>> qpci_unplug_device_test(), since all callers use the two\n>> functions in tandem.\n>>\n\n> \n> No, that's a bad idea. ACPI and that outb() is clearly something\n> specific to x86, so this should not reside in pci.c but in pci-pc.c\n> \n> We might be able to unify this - I've had a similar patch here:\n> \n> https://patchwork.kernel.org/patch/9905031/\n> \n> ... but I think this needs some more careful thinking and discussion, so\n> I'd suggest that you remove this from your already huge patch series for\n> now and we fix it later instead.\n\nOkay, I'm fine dropping this patch, and can base my respin on top of\nyour cleanup instead.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs5Hx2307z9s4s\n\tfor ;\n\tTue, 12 Sep 2017 23:29:49 +1000 (AEST)","from localhost ([::1]:35881 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drlG7-00043A-F0\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 09:29:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44212)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drlFR-0003yH-TM\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:29:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drlFN-0008Sn-HH\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:29:05 -0400","from mx1.redhat.com ([209.132.183.28]:45694)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drlFH-0008OJ-Bb; Tue, 12 Sep 2017 09:28:55 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 656FC66C4A;\n\tTue, 12 Sep 2017 13:28:54 +0000 (UTC)","from [10.10.120.44] (ovpn-120-44.rdu2.redhat.com [10.10.120.44])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7244E6E21F;\n\tTue, 12 Sep 2017 13:28:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 656FC66C4A","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-11-eblake@redhat.com>\n\t<65cb854d-5915-dc23-cb5d-0d8b5cecb6ea@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Tue, 12 Sep 2017 08:28:49 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<65cb854d-5915-dc23-cb5d-0d8b5cecb6ea@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"NLFwP5WSMR7R7UXFiTsAvbFQ9mj8ajjT6\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 12 Sep 2017 13:28:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename\n\tqpci_unplug_acpi_device_test() to pci.c","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier ,\n\t\"open list:virtio-blk\" ,\n\tAmit Shah , Jason Wang ,\n\tarmbru@redhat.com, Stefan Hajnoczi ,\n\tpbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767615,"web_url":"http://patchwork.ozlabs.org/comment/1767615/","msgid":"<2f0a077a-b62b-5a05-1cf5-88ca80d1640b@redhat.com>","list_archive_url":null,"date":"2017-09-13T07:15:54","subject":"Re: [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename\n\tqpci_unplug_acpi_device_test() to pci.c","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 12.09.2017 15:28, Eric Blake wrote:\n> On 09/12/2017 02:29 AM, Thomas Huth wrote:\n>> On 11.09.2017 19:19, Eric Blake wrote:\n>>> Commit 2f8b2767 originally added qpci_plug_device_test() and\n>>> qpci_unplug_acpi_device_test() as a pair, both in pci-pc.c.\n>>> Later, commit cf716b31 moved one half of the pair to pci.c\n>>> when adding PPC64 support. Keep the implementations of the\n>>> two functions together, and shorten the name to\n>>> qpci_unplug_device_test(), since all callers use the two\n>>> functions in tandem.\n>>>\n> \n>>\n>> No, that's a bad idea. ACPI and that outb() is clearly something\n>> specific to x86, so this should not reside in pci.c but in pci-pc.c\n>>\n>> We might be able to unify this - I've had a similar patch here:\n>>\n>> https://patchwork.kernel.org/patch/9905031/\n>>\n>> ... but I think this needs some more careful thinking and discussion, so\n>> I'd suggest that you remove this from your already huge patch series for\n>> now and we fix it later instead.\n> \n> Okay, I'm fine dropping this patch, and can base my respin on top of\n> your cleanup instead.\n\nNote that my patches are currently on halt since I'm waiting for your\nqemu_startf() reworks to get included first :-) ... so feel free to pick\nup ideas or patches from my series into your series if that helps.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsXyr30d9z9sNw\n\tfor ;\n\tWed, 13 Sep 2017 17:16:35 +1000 (AEST)","from localhost ([::1]:40526 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds1uS-0004pS-Dv\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 03:16:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49040)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds1u2-0004oD-Tu\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 03:16:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds1u1-0001tZ-TQ\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 03:16:06 -0400","from mx1.redhat.com ([209.132.183.28]:13502)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1ds1tx-0001pH-Bp; Wed, 13 Sep 2017 03:16:01 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 49BD3C0587D6;\n\tWed, 13 Sep 2017 07:16:00 +0000 (UTC)","from [10.36.116.123] (ovpn-116-123.ams2.redhat.com [10.36.116.123])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 59C265D976;\n\tWed, 13 Sep 2017 07:15:56 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 49BD3C0587D6","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170911172022.4738-1-eblake@redhat.com>\n\t<20170911172022.4738-11-eblake@redhat.com>\n\t<65cb854d-5915-dc23-cb5d-0d8b5cecb6ea@redhat.com>\n\t","From":"Thomas Huth ","Message-ID":"<2f0a077a-b62b-5a05-1cf5-88ca80d1640b@redhat.com>","Date":"Wed, 13 Sep 2017 09:15:54 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"7Dp7N8El3Xa3dic0KU3Nq5vbJKxw6V3nK\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 13 Sep 2017 07:16:00 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename\n\tqpci_unplug_acpi_device_test() to pci.c","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier ,\n\t\"open list:virtio-blk\" ,\n\tAmit Shah , Jason Wang ,\n\tarmbru@redhat.com, Stefan Hajnoczi ,\n\tpbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]