[{"id":1770867,"web_url":"http://patchwork.ozlabs.org/comment/1770867/","msgid":"<20170919084406.GX27153@umbus>","list_archive_url":null,"date":"2017-09-19T08:44:06","subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Mon, Sep 11, 2017 at 07:12:32PM +0200, Cédric Le Goater wrote:\n> Like for XICS, the XIVE interface for the guest is described in the\n> device tree under the \"interrupt-controller\" node. A couple of new\n> properties are specific to XIVE :\n> \n> - \"reg\"\n> \n> contains the base address and size of the thread interrupt\n> managnement areas (TIMA), also called rings, for the User level and\n> for the Guest OS level. Only the Guest OS level is taken into\n> account today.\n> \n> - \"ibm,xive-eq-sizes\"\n> \n> the size of the event queues. One cell per size supported, contains\n> log2 of size, in ascending order.\n> \n> - \"ibm,xive-lisn-ranges\"\n> \n> the interrupt numbers ranges assigned to the guest. These are\n> allocated using a simple bitmap.\n> \n> and also under the root node :\n> \n> - \"ibm,plat-res-int-priorities\"\n> \n> contains a list of priorities that the hypervisor has reserved for\n> its own use. Simulate ranges as defined by the PowerVM Hypervisor.\n> \n> Signed-off-by: Cédric Le Goater \n> ---\n> hw/intc/spapr_xive_hcall.c | 54 +++++++++++++++++++++++++++++++++++++++++++++\n> include/hw/ppc/spapr_xive.h | 1 +\n> 2 files changed, 55 insertions(+)\n> \n> diff --git a/hw/intc/spapr_xive_hcall.c b/hw/intc/spapr_xive_hcall.c\n> index 4c77b65683de..7b19ea6373dd 100644\n> --- a/hw/intc/spapr_xive_hcall.c\n> +++ b/hw/intc/spapr_xive_hcall.c\n> @@ -874,3 +874,57 @@ void spapr_xive_hcall_init(sPAPRMachineState *spapr)\n> spapr_register_hypercall(H_INT_SYNC, h_int_sync);\n> spapr_register_hypercall(H_INT_RESET, h_int_reset);\n> }\n> +\n> +void spapr_xive_populate(sPAPRXive *xive, void *fdt, uint32_t phandle)\n> +{\n> + int node;\n> + uint64_t timas[2 * 2];\n> + uint32_t lisn_ranges[] = {\n> + cpu_to_be32(xive->nr_irqs - xive->nr_targets + xive->ics->offset),\n> + cpu_to_be32(xive->nr_targets),\n> + };\n> + uint32_t eq_sizes[] = {\n> + cpu_to_be32(12), /* 4K */\n> + cpu_to_be32(16), /* 64K */\n> + cpu_to_be32(21), /* 2M */\n> + cpu_to_be32(24), /* 16M */\n> + };\n> +\n> + /* Use some ranges to exercise the Linux driver, which should\n> + * result in Linux choosing priority 6. This is not strictly\n> + * necessary\n> + */\n> + uint32_t reserved_priorities[] = {\n> + cpu_to_be32(1), /* start */\n> + cpu_to_be32(2), /* count */\n> + cpu_to_be32(7), /* start */\n> + cpu_to_be32(0xf8), /* count */\n> + };\n> + int i;\n> +\n> + /* Thread Interrupt Management Areas : User and OS */\n> + for (i = 0; i < 2; i++) {\n> + timas[i * 2] = cpu_to_be64(xive->tm_base + i * (1 << xive->tm_shift));\n> + timas[i * 2 + 1] = cpu_to_be64(1 << xive->tm_shift);\n> + }\n> +\n> + _FDT(node = fdt_add_subnode(fdt, 0, \"interrupt-controller\"));\n> +\n> + _FDT(fdt_setprop_string(fdt, node, \"name\", \"interrupt-controller\"));\n\nShouldn't need this - SLOF will figure it out from the node name above.\n\n> + _FDT(fdt_setprop_string(fdt, node, \"device_type\", \"power-ivpe\"));\n> + _FDT(fdt_setprop(fdt, node, \"reg\", timas, sizeof(timas)));\n> +\n> + _FDT(fdt_setprop_string(fdt, node, \"compatible\", \"ibm,power-ivpe\"));\n> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-eq-sizes\", eq_sizes,\n> + sizeof(eq_sizes)));\n> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-lisn-ranges\", lisn_ranges,\n> + sizeof(lisn_ranges)));\n\nI note this doesn't have the interrupt-controller or #interrupt-cells\nproperties. So what acts as the interrupt parent for all the devices\nin the tree with XIVE?\n\n> + /* For SLOF */\n> + _FDT(fdt_setprop_cell(fdt, node, \"linux,phandle\", phandle));\n> + _FDT(fdt_setprop_cell(fdt, node, \"phandle\", phandle));\n> +\n> + /* top properties */\n> + _FDT(fdt_setprop(fdt, 0, \"ibm,plat-res-int-priorities\",\n> + reserved_priorities, sizeof(reserved_priorities)));\n> +}\n> diff --git a/include/hw/ppc/spapr_xive.h b/include/hw/ppc/spapr_xive.h\n> index ae5ff89533c0..0a156f2d8591 100644\n> --- a/include/hw/ppc/spapr_xive.h\n> +++ b/include/hw/ppc/spapr_xive.h\n> @@ -69,5 +69,6 @@ struct sPAPRXive {\n> typedef struct sPAPRMachineState sPAPRMachineState;\n> \n> void spapr_xive_hcall_init(sPAPRMachineState *spapr);\n> +void spapr_xive_populate(sPAPRXive *xive, void *fdt, uint32_t phandle);\n> \n> #endif /* PPC_SPAPR_XIVE_H */","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"MJzz9sRc\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxKf64MsHz9s7m\n\tfor ;\n\tTue, 19 Sep 2017 21:00:14 +1000 (AEST)","from localhost ([::1]:41481 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duGGC-0003Lp-KE\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 07:00:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51370)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duFtb-0001KQ-R1\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 06:36:54 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duFtY-00030A-0v\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 06:36:51 -0400","from ozlabs.org ([103.22.144.67]:44849)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duFtX-0002un-Ip; Tue, 19 Sep 2017 06:36:47 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xxK6r207Kz9t5P; Tue, 19 Sep 2017 20:36:34 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1505817396;\n\tbh=SYDS+ClP3m//8Wop+ToTEwPkmamAgHzHsqfKKZPoEyg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MJzz9sRcXBJZ8kNzKBqOdKj1EzSRSkisTiRH7tAidc0NMOOdYf99antbK8ySpHFvL\n\tOh+dikSsBhaqca2JR8nbmwnhUAnBGut4ZHeRpNGWmo0eWZ2Rz+vU4SAL+/LjVJ8WPb\n\tO/slmBq2dTTm4rHIn3vTVBG1xiF39ajgyLyC/WSE=","Date":"Tue, 19 Sep 2017 18:44:06 +1000","From":"David Gibson ","To":"=?iso-8859-1?q?C=E9dric?= Le Goater ","Message-ID":"<20170919084406.GX27153@umbus>","References":"<20170911171235.29331-1-clg@kaod.org>\n\t<20170911171235.29331-19-clg@kaod.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"Ca23f2aBZR6YDKM9\"","Content-Disposition":"inline","In-Reply-To":"<20170911171235.29331-19-clg@kaod.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771949,"web_url":"http://patchwork.ozlabs.org/comment/1771949/","msgid":"<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>","list_archive_url":null,"date":"2017-09-20T12:26:32","subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 09/19/2017 10:44 AM, David Gibson wrote:\n> On Mon, Sep 11, 2017 at 07:12:32PM +0200, Cédric Le Goater wrote:\n>> Like for XICS, the XIVE interface for the guest is described in the\n>> device tree under the \"interrupt-controller\" node. A couple of new\n>> properties are specific to XIVE :\n>>\n>> - \"reg\"\n>>\n>> contains the base address and size of the thread interrupt\n>> managnement areas (TIMA), also called rings, for the User level and\n>> for the Guest OS level. Only the Guest OS level is taken into\n>> account today.\n>>\n>> - \"ibm,xive-eq-sizes\"\n>>\n>> the size of the event queues. One cell per size supported, contains\n>> log2 of size, in ascending order.\n>>\n>> - \"ibm,xive-lisn-ranges\"\n>>\n>> the interrupt numbers ranges assigned to the guest. These are\n>> allocated using a simple bitmap.\n>>\n>> and also under the root node :\n>>\n>> - \"ibm,plat-res-int-priorities\"\n>>\n>> contains a list of priorities that the hypervisor has reserved for\n>> its own use. Simulate ranges as defined by the PowerVM Hypervisor.\n>>\n>> Signed-off-by: Cédric Le Goater \n>> ---\n>> hw/intc/spapr_xive_hcall.c | 54 +++++++++++++++++++++++++++++++++++++++++++++\n>> include/hw/ppc/spapr_xive.h | 1 +\n>> 2 files changed, 55 insertions(+)\n>>\n>> diff --git a/hw/intc/spapr_xive_hcall.c b/hw/intc/spapr_xive_hcall.c\n>> index 4c77b65683de..7b19ea6373dd 100644\n>> --- a/hw/intc/spapr_xive_hcall.c\n>> +++ b/hw/intc/spapr_xive_hcall.c\n>> @@ -874,3 +874,57 @@ void spapr_xive_hcall_init(sPAPRMachineState *spapr)\n>> spapr_register_hypercall(H_INT_SYNC, h_int_sync);\n>> spapr_register_hypercall(H_INT_RESET, h_int_reset);\n>> }\n>> +\n>> +void spapr_xive_populate(sPAPRXive *xive, void *fdt, uint32_t phandle)\n>> +{\n>> + int node;\n>> + uint64_t timas[2 * 2];\n>> + uint32_t lisn_ranges[] = {\n>> + cpu_to_be32(xive->nr_irqs - xive->nr_targets + xive->ics->offset),\n>> + cpu_to_be32(xive->nr_targets),\n>> + };\n>> + uint32_t eq_sizes[] = {\n>> + cpu_to_be32(12), /* 4K */\n>> + cpu_to_be32(16), /* 64K */\n>> + cpu_to_be32(21), /* 2M */\n>> + cpu_to_be32(24), /* 16M */\n>> + };\n>> +\n>> + /* Use some ranges to exercise the Linux driver, which should\n>> + * result in Linux choosing priority 6. This is not strictly\n>> + * necessary\n>> + */\n>> + uint32_t reserved_priorities[] = {\n>> + cpu_to_be32(1), /* start */\n>> + cpu_to_be32(2), /* count */\n>> + cpu_to_be32(7), /* start */\n>> + cpu_to_be32(0xf8), /* count */\n>> + };\n>> + int i;\n>> +\n>> + /* Thread Interrupt Management Areas : User and OS */\n>> + for (i = 0; i < 2; i++) {\n>> + timas[i * 2] = cpu_to_be64(xive->tm_base + i * (1 << xive->tm_shift));\n>> + timas[i * 2 + 1] = cpu_to_be64(1 << xive->tm_shift);\n>> + }\n>> +\n>> + _FDT(node = fdt_add_subnode(fdt, 0, \"interrupt-controller\"));\n>> +\n>> + _FDT(fdt_setprop_string(fdt, node, \"name\", \"interrupt-controller\"));\n> \n> Shouldn't need this - SLOF will figure it out from the node name above.\n\nIt is in the specs. phyp has it. we might as well keep it.\n\n> \n>> + _FDT(fdt_setprop_string(fdt, node, \"device_type\", \"power-ivpe\"));\n>> + _FDT(fdt_setprop(fdt, node, \"reg\", timas, sizeof(timas)));\n>> +\n>> + _FDT(fdt_setprop_string(fdt, node, \"compatible\", \"ibm,power-ivpe\"));\n>> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-eq-sizes\", eq_sizes,\n>> + sizeof(eq_sizes)));\n>> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-lisn-ranges\", lisn_ranges,\n>> + sizeof(lisn_ranges)));\n> \n> I note this doesn't have the interrupt-controller or #interrupt-cells\n> properties. So what acts as the interrupt parent for all the devices\n> in the tree with XIVE?\n\nthese properties are not in the specs anymore for the interrupt-controller\nnode and I don't think Linux makes use of them (even for XICS). So \nit just works fine.\n\nC. \n\n>> + /* For SLOF */\n>> + _FDT(fdt_setprop_cell(fdt, node, \"linux,phandle\", phandle));\n>> + _FDT(fdt_setprop_cell(fdt, node, \"phandle\", phandle));\n>> +\n>> + /* top properties */\n>> + _FDT(fdt_setprop(fdt, 0, \"ibm,plat-res-int-priorities\",\n>> + reserved_priorities, sizeof(reserved_priorities)));\n>> +}\n>> diff --git a/include/hw/ppc/spapr_xive.h b/include/hw/ppc/spapr_xive.h\n>> index ae5ff89533c0..0a156f2d8591 100644\n>> --- a/include/hw/ppc/spapr_xive.h\n>> +++ b/include/hw/ppc/spapr_xive.h\n>> @@ -69,5 +69,6 @@ struct sPAPRXive {\n>> typedef struct sPAPRMachineState sPAPRMachineState;\n>> \n>> void spapr_xive_hcall_init(sPAPRMachineState *spapr);\n>> +void spapr_xive_populate(sPAPRXive *xive, void *fdt, uint32_t phandle);\n>> \n>> #endif /* PPC_SPAPR_XIVE_H */\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy2py0bwxz9sNr\n\tfor ;\n\tThu, 21 Sep 2017 00:55:22 +1000 (AEST)","from localhost ([::1]:48624 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dugPI-0000Cy-5a\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 10:55:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47321)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dufKJ-0002OY-N3\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:46:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dufKD-0001Sj-Rw\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:46:07 -0400","from 5.mo2.mail-out.ovh.net ([87.98.181.248]:58981)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dufKD-0001S3-Jc\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:46:01 -0400","from player157.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo2.mail-out.ovh.net (Postfix) with ESMTP id 8F5D9ABDB0\n\tfor ; Wed, 20 Sep 2017 14:26:40 +0200 (CEST)","from zorba.kaod.org (LFbn-1-2231-173.w90-76.abo.wanadoo.fr\n\t[90.76.52.173]) (Authenticated sender: postmaster@kaod.org)\n\tby player157.ha.ovh.net (Postfix) with ESMTPSA id 274585000AC;\n\tWed, 20 Sep 2017 14:26:33 +0200 (CEST)"],"To":"David Gibson ","References":"<20170911171235.29331-1-clg@kaod.org>\n\t<20170911171235.29331-19-clg@kaod.org> <20170919084406.GX27153@umbus>","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>","Date":"Wed, 20 Sep 2017 14:26:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919084406.GX27153@umbus>","Content-Type":"text/plain; charset=windows-1252","Content-Language":"en-US","X-Ovh-Tracer-Id":"6809442639335426936","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledriedtgddvfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"87.98.181.248","Subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772356,"web_url":"http://patchwork.ozlabs.org/comment/1772356/","msgid":"<20170921013548.GB4998@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-21T01:35:48","subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Wed, Sep 20, 2017 at 02:26:32PM +0200, Cédric Le Goater wrote:\n> On 09/19/2017 10:44 AM, David Gibson wrote:\n> > On Mon, Sep 11, 2017 at 07:12:32PM +0200, Cédric Le Goater wrote:\n> >> Like for XICS, the XIVE interface for the guest is described in the\n> >> device tree under the \"interrupt-controller\" node. A couple of new\n> >> properties are specific to XIVE :\n> >>\n> >> - \"reg\"\n> >>\n> >> contains the base address and size of the thread interrupt\n> >> managnement areas (TIMA), also called rings, for the User level and\n> >> for the Guest OS level. Only the Guest OS level is taken into\n> >> account today.\n> >>\n> >> - \"ibm,xive-eq-sizes\"\n> >>\n> >> the size of the event queues. One cell per size supported, contains\n> >> log2 of size, in ascending order.\n> >>\n> >> - \"ibm,xive-lisn-ranges\"\n> >>\n> >> the interrupt numbers ranges assigned to the guest. These are\n> >> allocated using a simple bitmap.\n> >>\n> >> and also under the root node :\n> >>\n> >> - \"ibm,plat-res-int-priorities\"\n> >>\n> >> contains a list of priorities that the hypervisor has reserved for\n> >> its own use. Simulate ranges as defined by the PowerVM Hypervisor.\n> >>\n> >> Signed-off-by: Cédric Le Goater \n> >> ---\n> >> hw/intc/spapr_xive_hcall.c | 54 +++++++++++++++++++++++++++++++++++++++++++++\n> >> include/hw/ppc/spapr_xive.h | 1 +\n> >> 2 files changed, 55 insertions(+)\n> >>\n> >> diff --git a/hw/intc/spapr_xive_hcall.c b/hw/intc/spapr_xive_hcall.c\n> >> index 4c77b65683de..7b19ea6373dd 100644\n> >> --- a/hw/intc/spapr_xive_hcall.c\n> >> +++ b/hw/intc/spapr_xive_hcall.c\n> >> @@ -874,3 +874,57 @@ void spapr_xive_hcall_init(sPAPRMachineState *spapr)\n> >> spapr_register_hypercall(H_INT_SYNC, h_int_sync);\n> >> spapr_register_hypercall(H_INT_RESET, h_int_reset);\n> >> }\n> >> +\n> >> +void spapr_xive_populate(sPAPRXive *xive, void *fdt, uint32_t phandle)\n> >> +{\n> >> + int node;\n> >> + uint64_t timas[2 * 2];\n> >> + uint32_t lisn_ranges[] = {\n> >> + cpu_to_be32(xive->nr_irqs - xive->nr_targets + xive->ics->offset),\n> >> + cpu_to_be32(xive->nr_targets),\n> >> + };\n> >> + uint32_t eq_sizes[] = {\n> >> + cpu_to_be32(12), /* 4K */\n> >> + cpu_to_be32(16), /* 64K */\n> >> + cpu_to_be32(21), /* 2M */\n> >> + cpu_to_be32(24), /* 16M */\n> >> + };\n> >> +\n> >> + /* Use some ranges to exercise the Linux driver, which should\n> >> + * result in Linux choosing priority 6. This is not strictly\n> >> + * necessary\n> >> + */\n> >> + uint32_t reserved_priorities[] = {\n> >> + cpu_to_be32(1), /* start */\n> >> + cpu_to_be32(2), /* count */\n> >> + cpu_to_be32(7), /* start */\n> >> + cpu_to_be32(0xf8), /* count */\n> >> + };\n> >> + int i;\n> >> +\n> >> + /* Thread Interrupt Management Areas : User and OS */\n> >> + for (i = 0; i < 2; i++) {\n> >> + timas[i * 2] = cpu_to_be64(xive->tm_base + i * (1 << xive->tm_shift));\n> >> + timas[i * 2 + 1] = cpu_to_be64(1 << xive->tm_shift);\n> >> + }\n> >> +\n> >> + _FDT(node = fdt_add_subnode(fdt, 0, \"interrupt-controller\"));\n> >> +\n> >> + _FDT(fdt_setprop_string(fdt, node, \"name\", \"interrupt-controller\"));\n> > \n> > Shouldn't need this - SLOF will figure it out from the node name above.\n> \n> It is in the specs. phyp has it. we might as well keep it.\n\nYou misunderstand. SLOF will *create* the name property based on the\nnode name. Adding it here has *no effect*.\n\n> >> + _FDT(fdt_setprop_string(fdt, node, \"device_type\", \"power-ivpe\"));\n> >> + _FDT(fdt_setprop(fdt, node, \"reg\", timas, sizeof(timas)));\n> >> +\n> >> + _FDT(fdt_setprop_string(fdt, node, \"compatible\", \"ibm,power-ivpe\"));\n> >> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-eq-sizes\", eq_sizes,\n> >> + sizeof(eq_sizes)));\n> >> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-lisn-ranges\", lisn_ranges,\n> >> + sizeof(lisn_ranges)));\n> > \n> > I note this doesn't have the interrupt-controller or #interrupt-cells\n> > properties. So what acts as the interrupt parent for all the devices\n> > in the tree with XIVE?\n> \n> these properties are not in the specs anymore for the interrupt-controller\n> node and I don't think Linux makes use of them (even for XICS). So \n> it just works fine.\n\nUm.. what!? Are you saying that the PAPR XIVE spec completely broke\nhow interrupt specifiers have worked in the device tree since forever?\n\nAnd I'm pretty sure Linux does make use of them. Without\n#interrupt-cells, there's no way it can properly interpret the\ninterrupts properties in the device nodes.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"nIy3bFNv\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyK5C6xJ9z9s81\n\tfor ;\n\tThu, 21 Sep 2017 11:38:39 +1000 (AEST)","from localhost ([::1]:51368 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duqRq-0003IT-3t\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 21:38:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47626)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duqRA-0003Gx-Sc\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 21:37:58 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duqR7-0006YO-Oe\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 21:37:56 -0400","from ozlabs.org ([103.22.144.67]:52663)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duqR7-0006UD-0y; Wed, 20 Sep 2017 21:37:53 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xyK4F1Qvyz9s81; Thu, 21 Sep 2017 11:37:49 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1505957869;\n\tbh=aoTE90pvX2VFX1al9GYGAT1RpSe9S7XZ/kJSz1WIBFw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nIy3bFNv/eNbUy0LWy0mD6rTzqxMzEeJQj1JCDD7qxGP5pzuJ1+gBDeeP+uH261h/\n\t3JIJgbCGKocLEHkP+n+PYcwqxDxSOu/aXw6d9OQDO9h4FJ304MMABK6huo6Mhd+IJJ\n\tNM/iVFDW6vteKeuyVNUXYBykBiqx2N9w3Nn9Ppf8=","Date":"Thu, 21 Sep 2017 11:35:48 +1000","From":"David Gibson ","To":"=?iso-8859-1?q?C=E9dric?= Le Goater ","Message-ID":"<20170921013548.GB4998@umbus.fritz.box>","References":"<20170911171235.29331-1-clg@kaod.org>\n\t<20170911171235.29331-19-clg@kaod.org>\n\t<20170919084406.GX27153@umbus>\n\t<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"mxv5cy4qt+RJ9ypb\"","Content-Disposition":"inline","In-Reply-To":"<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772711,"web_url":"http://patchwork.ozlabs.org/comment/1772711/","msgid":"<50588b22-8081-c353-9d83-70cf29a4daa4@kaod.org>","list_archive_url":null,"date":"2017-09-21T11:21:10","subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 09/21/2017 03:35 AM, David Gibson wrote:\n> On Wed, Sep 20, 2017 at 02:26:32PM +0200, Cédric Le Goater wrote:\n>> On 09/19/2017 10:44 AM, David Gibson wrote:\n>>> On Mon, Sep 11, 2017 at 07:12:32PM +0200, Cédric Le Goater wrote:\n>>>> Like for XICS, the XIVE interface for the guest is described in the\n>>>> device tree under the \"interrupt-controller\" node. A couple of new\n>>>> properties are specific to XIVE :\n>>>>\n>>>> - \"reg\"\n>>>>\n>>>> contains the base address and size of the thread interrupt\n>>>> managnement areas (TIMA), also called rings, for the User level and\n>>>> for the Guest OS level. Only the Guest OS level is taken into\n>>>> account today.\n>>>>\n>>>> - \"ibm,xive-eq-sizes\"\n>>>>\n>>>> the size of the event queues. One cell per size supported, contains\n>>>> log2 of size, in ascending order.\n>>>>\n>>>> - \"ibm,xive-lisn-ranges\"\n>>>>\n>>>> the interrupt numbers ranges assigned to the guest. These are\n>>>> allocated using a simple bitmap.\n>>>>\n>>>> and also under the root node :\n>>>>\n>>>> - \"ibm,plat-res-int-priorities\"\n>>>>\n>>>> contains a list of priorities that the hypervisor has reserved for\n>>>> its own use. Simulate ranges as defined by the PowerVM Hypervisor.\n>>>>\n>>>> Signed-off-by: Cédric Le Goater \n>>>> ---\n>>>> hw/intc/spapr_xive_hcall.c | 54 +++++++++++++++++++++++++++++++++++++++++++++\n>>>> include/hw/ppc/spapr_xive.h | 1 +\n>>>> 2 files changed, 55 insertions(+)\n>>>>\n>>>> diff --git a/hw/intc/spapr_xive_hcall.c b/hw/intc/spapr_xive_hcall.c\n>>>> index 4c77b65683de..7b19ea6373dd 100644\n>>>> --- a/hw/intc/spapr_xive_hcall.c\n>>>> +++ b/hw/intc/spapr_xive_hcall.c\n>>>> @@ -874,3 +874,57 @@ void spapr_xive_hcall_init(sPAPRMachineState *spapr)\n>>>> spapr_register_hypercall(H_INT_SYNC, h_int_sync);\n>>>> spapr_register_hypercall(H_INT_RESET, h_int_reset);\n>>>> }\n>>>> +\n>>>> +void spapr_xive_populate(sPAPRXive *xive, void *fdt, uint32_t phandle)\n>>>> +{\n>>>> + int node;\n>>>> + uint64_t timas[2 * 2];\n>>>> + uint32_t lisn_ranges[] = {\n>>>> + cpu_to_be32(xive->nr_irqs - xive->nr_targets + xive->ics->offset),\n>>>> + cpu_to_be32(xive->nr_targets),\n>>>> + };\n>>>> + uint32_t eq_sizes[] = {\n>>>> + cpu_to_be32(12), /* 4K */\n>>>> + cpu_to_be32(16), /* 64K */\n>>>> + cpu_to_be32(21), /* 2M */\n>>>> + cpu_to_be32(24), /* 16M */\n>>>> + };\n>>>> +\n>>>> + /* Use some ranges to exercise the Linux driver, which should\n>>>> + * result in Linux choosing priority 6. This is not strictly\n>>>> + * necessary\n>>>> + */\n>>>> + uint32_t reserved_priorities[] = {\n>>>> + cpu_to_be32(1), /* start */\n>>>> + cpu_to_be32(2), /* count */\n>>>> + cpu_to_be32(7), /* start */\n>>>> + cpu_to_be32(0xf8), /* count */\n>>>> + };\n>>>> + int i;\n>>>> +\n>>>> + /* Thread Interrupt Management Areas : User and OS */\n>>>> + for (i = 0; i < 2; i++) {\n>>>> + timas[i * 2] = cpu_to_be64(xive->tm_base + i * (1 << xive->tm_shift));\n>>>> + timas[i * 2 + 1] = cpu_to_be64(1 << xive->tm_shift);\n>>>> + }\n>>>> +\n>>>> + _FDT(node = fdt_add_subnode(fdt, 0, \"interrupt-controller\"));\n>>>> +\n>>>> + _FDT(fdt_setprop_string(fdt, node, \"name\", \"interrupt-controller\"));\n>>>\n>>> Shouldn't need this - SLOF will figure it out from the node name above.\n>>\n>> It is in the specs. phyp has it. we might as well keep it.\n> \n> You misunderstand. SLOF will *create* the name property based on the\n> node name. Adding it here has *no effect*.\n\nok. I was not ware of that. I will remove it then.\n \n>>>> + _FDT(fdt_setprop_string(fdt, node, \"device_type\", \"power-ivpe\"));\n>>>> + _FDT(fdt_setprop(fdt, node, \"reg\", timas, sizeof(timas)));\n>>>> +\n>>>> + _FDT(fdt_setprop_string(fdt, node, \"compatible\", \"ibm,power-ivpe\"));\n>>>> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-eq-sizes\", eq_sizes,\n>>>> + sizeof(eq_sizes)));\n>>>> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-lisn-ranges\", lisn_ranges,\n>>>> + sizeof(lisn_ranges)));\n>>>\n>>> I note this doesn't have the interrupt-controller or #interrupt-cells\n>>> properties. So what acts as the interrupt parent for all the devices\n>>> in the tree with XIVE?\n>>\n>> these properties are not in the specs anymore for the interrupt-controller\n>> node and I don't think Linux makes use of them (even for XICS). So \n>> it just works fine.\n> \n> Um.. what!? Are you saying that the PAPR XIVE spec completely broke\n> how interrupt specifiers have worked in the device tree since forever?\n\nLet me be more precise. I am saying that the interrupt-controller \nand #interrupt-cells properties are not needed under the main interrupt \ncontroller node. They can be removed from the tree and the Linux guest \nkernel will boot perfectly well.\n \nThese properties still are needed under the sub nodes like :\n\n/proc/device-tree/vdevice/interrupt-controller\n/proc/device-tree/event-sources/interrupt-controller\n\nC.\n\n\n> And I'm pretty sure Linux does make use of them. Without\n> #interrupt-cells, there's no way it can properly interpret the\n> interrupts properties in the device nodes.\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyZ2K6Nh5z9t3m\n\tfor ;\n\tThu, 21 Sep 2017 21:22:01 +1000 (AEST)","from localhost ([::1]:52984 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duzYN-0005Rk-Ot\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 07:21:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56398)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duzXo-0005RV-8e\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 07:21:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duzXk-00050L-9V\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 07:21:24 -0400","from 1.mo2.mail-out.ovh.net ([46.105.63.121]:57288)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duzXk-0004w5-1Q\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 07:21:20 -0400","from player157.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo2.mail-out.ovh.net (Postfix) with ESMTP id B9593AABFB\n\tfor ; Thu, 21 Sep 2017 13:21:17 +0200 (CEST)","from zorba.kaod.org (LFbn-1-2231-173.w90-76.abo.wanadoo.fr\n\t[90.76.52.173]) (Authenticated sender: postmaster@kaod.org)\n\tby player157.ha.ovh.net (Postfix) with ESMTPSA id C7BE3500083;\n\tThu, 21 Sep 2017 13:21:10 +0200 (CEST)"],"To":"David Gibson ","References":"<20170911171235.29331-1-clg@kaod.org>\n\t<20170911171235.29331-19-clg@kaod.org> <20170919084406.GX27153@umbus>\n\t<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>\n\t<20170921013548.GB4998@umbus.fritz.box>","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"<50588b22-8081-c353-9d83-70cf29a4daa4@kaod.org>","Date":"Thu, 21 Sep 2017 13:21:10 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170921013548.GB4998@umbus.fritz.box>","Content-Type":"text/plain; charset=windows-1252","Content-Language":"en-US","X-Ovh-Tracer-Id":"11577910218376121208","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledriedvgdegudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.63.121","Subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773495,"web_url":"http://patchwork.ozlabs.org/comment/1773495/","msgid":"<20170922105433.GM4998@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-22T10:54:34","subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Thu, Sep 21, 2017 at 01:21:10PM +0200, Cédric Le Goater wrote:\n> On 09/21/2017 03:35 AM, David Gibson wrote:\n> > On Wed, Sep 20, 2017 at 02:26:32PM +0200, Cédric Le Goater wrote:\n> >> On 09/19/2017 10:44 AM, David Gibson wrote:\n> >>> On Mon, Sep 11, 2017 at 07:12:32PM +0200, Cédric Le Goater wrote:\n> >>>> Like for XICS, the XIVE interface for the guest is described in the\n> >>>> device tree under the \"interrupt-controller\" node. A couple of new\n> >>>> properties are specific to XIVE :\n> >>>>\n> >>>> - \"reg\"\n> >>>>\n> >>>> contains the base address and size of the thread interrupt\n> >>>> managnement areas (TIMA), also called rings, for the User level and\n> >>>> for the Guest OS level. Only the Guest OS level is taken into\n> >>>> account today.\n> >>>>\n> >>>> - \"ibm,xive-eq-sizes\"\n> >>>>\n> >>>> the size of the event queues. One cell per size supported, contains\n> >>>> log2 of size, in ascending order.\n> >>>>\n> >>>> - \"ibm,xive-lisn-ranges\"\n> >>>>\n> >>>> the interrupt numbers ranges assigned to the guest. These are\n> >>>> allocated using a simple bitmap.\n> >>>>\n> >>>> and also under the root node :\n> >>>>\n> >>>> - \"ibm,plat-res-int-priorities\"\n> >>>>\n> >>>> contains a list of priorities that the hypervisor has reserved for\n> >>>> its own use. Simulate ranges as defined by the PowerVM Hypervisor.\n> >>>>\n> >>>> Signed-off-by: Cédric Le Goater \n> >>>> ---\n> >>>> hw/intc/spapr_xive_hcall.c | 54 +++++++++++++++++++++++++++++++++++++++++++++\n> >>>> include/hw/ppc/spapr_xive.h | 1 +\n> >>>> 2 files changed, 55 insertions(+)\n> >>>>\n> >>>> diff --git a/hw/intc/spapr_xive_hcall.c b/hw/intc/spapr_xive_hcall.c\n> >>>> index 4c77b65683de..7b19ea6373dd 100644\n> >>>> --- a/hw/intc/spapr_xive_hcall.c\n> >>>> +++ b/hw/intc/spapr_xive_hcall.c\n> >>>> @@ -874,3 +874,57 @@ void spapr_xive_hcall_init(sPAPRMachineState *spapr)\n> >>>> spapr_register_hypercall(H_INT_SYNC, h_int_sync);\n> >>>> spapr_register_hypercall(H_INT_RESET, h_int_reset);\n> >>>> }\n> >>>> +\n> >>>> +void spapr_xive_populate(sPAPRXive *xive, void *fdt, uint32_t phandle)\n> >>>> +{\n> >>>> + int node;\n> >>>> + uint64_t timas[2 * 2];\n> >>>> + uint32_t lisn_ranges[] = {\n> >>>> + cpu_to_be32(xive->nr_irqs - xive->nr_targets + xive->ics->offset),\n> >>>> + cpu_to_be32(xive->nr_targets),\n> >>>> + };\n> >>>> + uint32_t eq_sizes[] = {\n> >>>> + cpu_to_be32(12), /* 4K */\n> >>>> + cpu_to_be32(16), /* 64K */\n> >>>> + cpu_to_be32(21), /* 2M */\n> >>>> + cpu_to_be32(24), /* 16M */\n> >>>> + };\n> >>>> +\n> >>>> + /* Use some ranges to exercise the Linux driver, which should\n> >>>> + * result in Linux choosing priority 6. This is not strictly\n> >>>> + * necessary\n> >>>> + */\n> >>>> + uint32_t reserved_priorities[] = {\n> >>>> + cpu_to_be32(1), /* start */\n> >>>> + cpu_to_be32(2), /* count */\n> >>>> + cpu_to_be32(7), /* start */\n> >>>> + cpu_to_be32(0xf8), /* count */\n> >>>> + };\n> >>>> + int i;\n> >>>> +\n> >>>> + /* Thread Interrupt Management Areas : User and OS */\n> >>>> + for (i = 0; i < 2; i++) {\n> >>>> + timas[i * 2] = cpu_to_be64(xive->tm_base + i * (1 << xive->tm_shift));\n> >>>> + timas[i * 2 + 1] = cpu_to_be64(1 << xive->tm_shift);\n> >>>> + }\n> >>>> +\n> >>>> + _FDT(node = fdt_add_subnode(fdt, 0, \"interrupt-controller\"));\n> >>>> +\n> >>>> + _FDT(fdt_setprop_string(fdt, node, \"name\", \"interrupt-controller\"));\n> >>>\n> >>> Shouldn't need this - SLOF will figure it out from the node name above.\n> >>\n> >> It is in the specs. phyp has it. we might as well keep it.\n> > \n> > You misunderstand. SLOF will *create* the name property based on the\n> > node name. Adding it here has *no effect*.\n> \n> ok. I was not ware of that. I will remove it then.\n\nHistorical aside: in traditional OF there aren't \"node names\" as such.\nEach node has a 'name' and 'reg' property and the \"node name\"\ndisplayed in listings is formed from those as name@unit-address - with\nthe tricky catch being that unit-address is encoded from 'reg' in a\nbus specific manner (using what's essentially a method attached to the\nparent node).\n\nObviously that's awkward in the flat tree world, since we can't have\nmethods. So instead nodes have a real string name built into the\nstructure including both the name and unit address components. 'name'\nproperties are generally omitted and derived from that name. 'reg'\nshould match according to the bus's encoding conventions, but the\nnumber of things that can actually verify that is relatively small.\n\n> >>>> + _FDT(fdt_setprop_string(fdt, node, \"device_type\", \"power-ivpe\"));\n> >>>> + _FDT(fdt_setprop(fdt, node, \"reg\", timas, sizeof(timas)));\n> >>>> +\n> >>>> + _FDT(fdt_setprop_string(fdt, node, \"compatible\", \"ibm,power-ivpe\"));\n> >>>> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-eq-sizes\", eq_sizes,\n> >>>> + sizeof(eq_sizes)));\n> >>>> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-lisn-ranges\", lisn_ranges,\n> >>>> + sizeof(lisn_ranges)));\n> >>>\n> >>> I note this doesn't have the interrupt-controller or #interrupt-cells\n> >>> properties. So what acts as the interrupt parent for all the devices\n> >>> in the tree with XIVE?\n> >>\n> >> these properties are not in the specs anymore for the interrupt-controller\n> >> node and I don't think Linux makes use of them (even for XICS). So \n> >> it just works fine.\n> > \n> > Um.. what!? Are you saying that the PAPR XIVE spec completely broke\n> > how interrupt specifiers have worked in the device tree since forever?\n> \n> Let me be more precise. I am saying that the interrupt-controller \n> and #interrupt-cells properties are not needed under the main interrupt \n> controller node. They can be removed from the tree and the Linux guest \n> kernel will boot perfectly well.\n> \n> These properties still are needed under the sub nodes like :\n> \n> /proc/device-tree/vdevice/interrupt-controller\n> /proc/device-tree/event-sources/interrupt-controller\n\nUm. This still makes no sense. In order to have a common interrupt\nspace, those nodes must have an interrupt-parent pointing somewhere -\nthe top level interrupt controller, which needs interrupt-controller\nand #interrupt-cells properties. Note that that will be the \"source\"\nside of the intc. There could also be a presentation side of the\nintc, which wouldn't need those properties.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"pRN9u7M3\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzB081bWQz9sNw\n\tfor ;\n\tFri, 22 Sep 2017 21:22:16 +1000 (AEST)","from localhost ([::1]:58072 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvM2A-0006KT-Cg\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 07:22:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37845)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvLzr-0004i9-DT\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 07:19:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvLzo-0007Dh-6O\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 07:19:51 -0400","from ozlabs.org ([103.22.144.67]:55217)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dvLzn-0007Ac-25; Fri, 22 Sep 2017 07:19:48 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xz9xC0GLqz9sPm; Fri, 22 Sep 2017 21:19:42 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1506079183;\n\tbh=/QuAPYJJytoDu17+TOE3XR9WTDH7sX2wf11QRWDK/y0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pRN9u7M3FTcVUyX/qPv3tlnA+6zOWZnKd7847kvzx5eUngkEVrM07tGJng/U7QfjF\n\tm/i3OJF88HfDiklJSum35TGX93jmyPFYA4GJkYREcax9nrzoRWMHYsdmJYS78R4uG1\n\t9swtuBZTDF/ObaA35ia5ppvL3CyjM1vXRWaoo5Iw=","Date":"Fri, 22 Sep 2017 20:54:34 +1000","From":"David Gibson ","To":"=?iso-8859-1?q?C=E9dric?= Le Goater ","Message-ID":"<20170922105433.GM4998@umbus.fritz.box>","References":"<20170911171235.29331-1-clg@kaod.org>\n\t<20170911171235.29331-19-clg@kaod.org>\n\t<20170919084406.GX27153@umbus>\n\t<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>\n\t<20170921013548.GB4998@umbus.fritz.box>\n\t<50588b22-8081-c353-9d83-70cf29a4daa4@kaod.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"iUV/lbBrmPtUT9dM\"","Content-Disposition":"inline","In-Reply-To":"<50588b22-8081-c353-9d83-70cf29a4daa4@kaod.org>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776872,"web_url":"http://patchwork.ozlabs.org/comment/1776872/","msgid":"<1506588226.25626.29.camel@kernel.crashing.org>","list_archive_url":null,"date":"2017-09-28T08:43:46","subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","submitter":{"id":38,"url":"http://patchwork.ozlabs.org/api/people/38/","name":"Benjamin Herrenschmidt","email":"benh@kernel.crashing.org"},"content":"On Thu, 2017-09-21 at 13:21 +0200, Cédric Le Goater wrote:\n> Let me be more precise. I am saying that the interrupt-controller \n> and #interrupt-cells properties are not needed under the main interrupt \n> controller node. They can be removed from the tree and the Linux guest \n> kernel will boot perfectly well.\n\nNo they are needed. They are the parents of PCI interrupts for example.\nThere's something fishy here.\n\nDo you have a DT snapshot from pHyp for me to look at ?\n\n> These properties still are needed under the sub nodes like :\n> \n> /proc/device-tree/vdevice/interrupt-controller\n> /proc/device-tree/event-sources/interrupt-controller","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2pCs4gRHz9t1G\n\tfor ;\n\tThu, 28 Sep 2017 18:44:57 +1000 (AEST)","from localhost ([::1]:57988 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxURC-0005I5-V9\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 04:44:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52266)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxUQk-0005Hv-Vj\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 04:44:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxUQg-0005bs-3O\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 04:44:27 -0400","from gate.crashing.org ([63.228.1.57]:53483)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxUQf-0005aM-6N; Thu, 28 Sep 2017 04:44:22 -0400","from localhost (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id v8S8hlL4030196;\n\tThu, 28 Sep 2017 03:43:49 -0500"],"Message-ID":"<1506588226.25626.29.camel@kernel.crashing.org>","From":"Benjamin Herrenschmidt ","To":"=?iso-8859-1?q?C=E9dric?= Le Goater , David Gibson\n\t","Date":"Thu, 28 Sep 2017 10:43:46 +0200","In-Reply-To":"<50588b22-8081-c353-9d83-70cf29a4daa4@kaod.org>","References":"<20170911171235.29331-1-clg@kaod.org>\n\t<20170911171235.29331-19-clg@kaod.org> <20170919084406.GX27153@umbus>\n\t<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>\n\t<20170921013548.GB4998@umbus.fritz.box>\n\t<50588b22-8081-c353-9d83-70cf29a4daa4@kaod.org>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by gate.crashing.org id\n\tv8S8hlL4030196","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"63.228.1.57","Subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776880,"web_url":"http://patchwork.ozlabs.org/comment/1776880/","msgid":"","list_archive_url":null,"date":"2017-09-28T08:51:32","subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 09/28/2017 10:43 AM, Benjamin Herrenschmidt wrote:\n> On Thu, 2017-09-21 at 13:21 +0200, Cédric Le Goater wrote:\n>> Let me be more precise. I am saying that the interrupt-controller \n>> and #interrupt-cells properties are not needed under the main interrupt \n>> controller node. They can be removed from the tree and the Linux guest \n>> kernel will boot perfectly well.\n> \n> No they are needed. They are the parents of PCI interrupts for example.\n> There's something fishy here.\n\nprobably, I just removed the properties under QEMU and could \nboot the guest, with disks and network.\n\n \n> Do you have a DT snapshot from pHyp for me to look at ?\n\n\n# lsprop /proc/device-tree/interrupt-controller\\@200010000/\ncompatible \"ibm,power-ivpe\"\ndevice_type \"power-ivpe\"\nibm,xive-eq-sizes\n\t\t 00000007 00000009 0000000c 0000000e\n\t\t 00000010 00000012 00000015 00000016\n\t\t 00000018\nreg 00000002 00010000 00000000 00010000\n\t\t 00000002 00000000 00000000 00010000\nlinux,phandle 00dce438 (14476344)\nibm,xive-lisn-ranges\n\t\t 00094000 00000030\nname \"interrupt-controller\"\n\n\nCheers,\n\nC. \n\n> \n>> These properties still are needed under the sub nodes like :\n>>\n>> /proc/device-tree/vdevice/interrupt-controller\n>> /proc/device-tree/event-sources/interrupt-controller","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2pNT2lPlz9t2l\n\tfor ;\n\tThu, 28 Sep 2017 18:52:25 +1000 (AEST)","from localhost ([::1]:58022 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxUYR-0001iw-F4\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 04:52:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54149)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxUXy-0001ir-Gs\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 04:51:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxUXu-0001mf-F8\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 04:51:54 -0400","from 6.mo177.mail-out.ovh.net ([46.105.51.249]:55043)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxUXu-0001kq-7t\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 04:51:50 -0400","from player779.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo177.mail-out.ovh.net (Postfix) with ESMTP id 2D24B81703\n\tfor ; Thu, 28 Sep 2017 10:51:44 +0200 (CEST)","from zorba.kaod.org (unknown [195.81.232.10])\n\t(Authenticated sender: postmaster@kaod.org)\n\tby player779.ha.ovh.net (Postfix) with ESMTPSA id 31B0F7C00A5;\n\tThu, 28 Sep 2017 10:51:32 +0200 (CEST)"],"To":"Benjamin Herrenschmidt ,\n\tDavid Gibson ","References":"<20170911171235.29331-1-clg@kaod.org>\n\t<20170911171235.29331-19-clg@kaod.org> <20170919084406.GX27153@umbus>\n\t<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>\n\t<20170921013548.GB4998@umbus.fritz.box>\n\t<50588b22-8081-c353-9d83-70cf29a4daa4@kaod.org>\n\t<1506588226.25626.29.camel@kernel.crashing.org>","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"","Date":"Thu, 28 Sep 2017 10:51:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506588226.25626.29.camel@kernel.crashing.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"13267323030241577848","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrjeeigddutdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.51.249","Subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776881,"web_url":"http://patchwork.ozlabs.org/comment/1776881/","msgid":"<1506587465.25626.27.camel@kernel.crashing.org>","list_archive_url":null,"date":"2017-09-28T08:31:05","subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","submitter":{"id":38,"url":"http://patchwork.ozlabs.org/api/people/38/","name":"Benjamin Herrenschmidt","email":"benh@kernel.crashing.org"},"content":"On Thu, 2017-09-21 at 11:35 +1000, David Gibson wrote:\n> > >> + _FDT(fdt_setprop_string(fdt, node, \"device_type\", \"power-ivpe\"));\n> > >> + _FDT(fdt_setprop(fdt, node, \"reg\", timas, sizeof(timas)));\n> > >> +\n> > >> + _FDT(fdt_setprop_string(fdt, node, \"compatible\", \"ibm,power-ivpe\"));\n> > >> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-eq-sizes\", eq_sizes,\n> > >> + sizeof(eq_sizes)));\n> > >> + _FDT(fdt_setprop(fdt, node, \"ibm,xive-lisn-ranges\", lisn_ranges,\n> > >> + sizeof(lisn_ranges)));\n> > > \n> > > I note this doesn't have the interrupt-controller or #interrupt-cells\n> > > properties. So what acts as the interrupt parent for all the devices\n> > > in the tree with XIVE?\n> > \n> > these properties are not in the specs anymore for the interrupt-controller\n> > node and I don't think Linux makes use of them (even for XICS). So \n> > it just works fine.\n> \n> Um.. what!? Are you saying that the PAPR XIVE spec completely broke\n> how interrupt specifiers have worked in the device tree since forever?\n> \n> And I'm pretty sure Linux does make use of them. Without\n> #interrupt-cells, there's no way it can properly interpret the\n> interrupts properties in the device nodes.\n\nLinux does make use of them and they are in the spec, but don't confuse\nthe nodes for the presentation controllers vs the node for the virtual\nsource controller which is the one that is the root of the interrupt\ntree.\n\nCheers,\nBen.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2pPc3Hb1z9t38\n\tfor ;\n\tThu, 28 Sep 2017 18:53:24 +1000 (AEST)","from localhost ([::1]:58027 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxUZO-0002PP-JV\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 04:53:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54345)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxUYu-0002OB-Nv\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 04:52:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxUYq-0002Bc-RU\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 04:52:52 -0400","from gate.crashing.org ([63.228.1.57]:34253)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxUYq-0002An-2S; Thu, 28 Sep 2017 04:52:48 -0400","from localhost (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id v8S8V5R3029448;\n\tThu, 28 Sep 2017 03:31:08 -0500"],"Message-ID":"<1506587465.25626.27.camel@kernel.crashing.org>","From":"Benjamin Herrenschmidt ","To":"David Gibson , =?iso-8859-1?q?C=E9dric?=\n\tLe Goater ","Date":"Thu, 28 Sep 2017 10:31:05 +0200","In-Reply-To":"<20170921013548.GB4998@umbus.fritz.box>","References":"<20170911171235.29331-1-clg@kaod.org>\n\t<20170911171235.29331-19-clg@kaod.org> <20170919084406.GX27153@umbus>\n\t<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>\n\t<20170921013548.GB4998@umbus.fritz.box>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"63.228.1.57","Subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776931,"web_url":"http://patchwork.ozlabs.org/comment/1776931/","msgid":"<1506593024.25626.33.camel@kernel.crashing.org>","list_archive_url":null,"date":"2017-09-28T10:03:44","subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","submitter":{"id":38,"url":"http://patchwork.ozlabs.org/api/people/38/","name":"Benjamin Herrenschmidt","email":"benh@kernel.crashing.org"},"content":"On Thu, 2017-09-28 at 10:51 +0200, Cédric Le Goater wrote:\n> probably, I just removed the properties under QEMU and could \n> boot the guest, with disks and network.\n\nAs long as you don't use LSIs...\n> \n> > Do you have a DT snapshot from pHyp for me to look at ?\n> \n> \n> # lsprop /proc/device-tree/interrupt-controller\\@200010000/\n> compatible \"ibm,power-ivpe\"\n> device_type \"power-ivpe\"\n> ibm,xive-eq-sizes\n> 00000007 00000009 0000000c 0000000e\n> 00000010 00000012 00000015 00000016\n> 00000018\n> reg 00000002 00010000 00000000 00010000\n> 00000002 00000000 00000000 00010000\n> linux,phandle 00dce438 (14476344)\n> ibm,xive-lisn-ranges\n> 00094000 00000030\n> name \"interrupt-controller\"\n> \n> \n> Cheers,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2r0f5sj3z9sBW\n\tfor ;\n\tThu, 28 Sep 2017 20:05:21 +1000 (AEST)","from localhost ([::1]:58254 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxVh0-0004E1-B5\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 06:05:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41181)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxVfv-0003rJ-Ge\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:04:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxVfs-0007Qy-9w\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:04:11 -0400","from gate.crashing.org ([63.228.1.57]:42703)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxVfs-0007QT-0t; Thu, 28 Sep 2017 06:04:08 -0400","from localhost (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id v8SA3ilN004193;\n\tThu, 28 Sep 2017 05:03:45 -0500"],"Message-ID":"<1506593024.25626.33.camel@kernel.crashing.org>","From":"Benjamin Herrenschmidt ","To":"=?iso-8859-1?q?C=E9dric?= Le Goater , David Gibson\n\t","Date":"Thu, 28 Sep 2017 12:03:44 +0200","In-Reply-To":"","References":"<20170911171235.29331-1-clg@kaod.org>\n\t<20170911171235.29331-19-clg@kaod.org> <20170919084406.GX27153@umbus>\n\t<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>\n\t<20170921013548.GB4998@umbus.fritz.box>\n\t<50588b22-8081-c353-9d83-70cf29a4daa4@kaod.org>\n\t<1506588226.25626.29.camel@kernel.crashing.org>\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by gate.crashing.org id\n\tv8SA3ilN004193","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"63.228.1.57","Subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1777008,"web_url":"http://patchwork.ozlabs.org/comment/1777008/","msgid":"<343aea30-4a14-5f66-d7b6-1b53d92f0288@kaod.org>","list_archive_url":null,"date":"2017-09-28T12:50:58","subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 09/28/2017 12:03 PM, Benjamin Herrenschmidt wrote:\n> On Thu, 2017-09-28 at 10:51 +0200, Cédric Le Goater wrote:\n>> probably, I just removed the properties under QEMU and could \n>> boot the guest, with disks and network.\n> \n> As long as you don't use LSIs...\n\nThat I didn't test much. Which the devices could I use for \nthe guest ? \n\nThanks, \n\nC.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2vjy2rWqz9t3B\n\tfor ;\n\tThu, 28 Sep 2017 22:52:54 +1000 (AEST)","from localhost ([::1]:59138 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxYJA-0000GL-HO\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 08:52:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54694)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxYHY-00084j-9h\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:51:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxYHV-0008RG-8E\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:51:12 -0400","from 1.mo177.mail-out.ovh.net ([178.33.107.143]:47369)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxYHV-0008Qv-2G\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:51:09 -0400","from player779.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo177.mail-out.ovh.net (Postfix) with ESMTP id CD0AE80BAA\n\tfor ; Thu, 28 Sep 2017 14:51:05 +0200 (CEST)","from zorba.kaod.org (unknown [195.81.232.10])\n\t(Authenticated sender: postmaster@kaod.org)\n\tby player779.ha.ovh.net (Postfix) with ESMTPSA id 20AD87C00C6;\n\tThu, 28 Sep 2017 14:50:58 +0200 (CEST)"],"To":"Benjamin Herrenschmidt ,\n\tDavid Gibson ","References":"<20170911171235.29331-1-clg@kaod.org>\n\t<20170911171235.29331-19-clg@kaod.org> <20170919084406.GX27153@umbus>\n\t<5d9394e6-0e3f-7824-dd23-04107eb22582@kaod.org>\n\t<20170921013548.GB4998@umbus.fritz.box>\n\t<50588b22-8081-c353-9d83-70cf29a4daa4@kaod.org>\n\t<1506588226.25626.29.camel@kernel.crashing.org>\n\t\n\t<1506593024.25626.33.camel@kernel.crashing.org>","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= ","Message-ID":"<343aea30-4a14-5f66-d7b6-1b53d92f0288@kaod.org>","Date":"Thu, 28 Sep 2017 14:50:58 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506593024.25626.33.camel@kernel.crashing.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Ovh-Tracer-Id":"17309866643647925112","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrjeeigdehkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"178.33.107.143","Subject":"Re: [Qemu-devel] [RFC PATCH v2 18/21] ppc/xive: add device tree\n\tsupport","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tqemu-devel@nongnu.org, Alexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]