[{"id":1766993,"web_url":"http://patchwork.ozlabs.org/comment/1766993/","msgid":"<20170912144623.13363403@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-09-12T12:46:23","subject":"Re: [Qemu-devel] [PATCH v4 12/21] target/s390x: set cpu->id for\n\tlinux user when realizing","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Mon, 11 Sep 2017 17:21:41 +0200\nDavid Hildenbrand wrote:\n\n> scc->next_cpu_id is updated when realizing. Setting it just before that\n> point looks cleaner.\n> \n> Reviewed-by: Matthew Rosato \n> Signed-off-by: David Hildenbrand \nReviewed-by: Igor Mammedov \n\n> ---\n> target/s390x/cpu.c | 11 ++++-------\n> 1 file changed, 4 insertions(+), 7 deletions(-)\n> \n> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c\n> index 74b3e4fd0d..5f9315fb16 100644\n> --- a/target/s390x/cpu.c\n> +++ b/target/s390x/cpu.c\n> @@ -194,7 +194,11 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n> \", max allowed: %d\", cpu->id, max_cpus - 1);\n> goto out;\n> }\n> +#else\n> + /* implicitly set for linux-user only */\n> + cpu->id = scc->next_cpu_id;\n> #endif\n> +\n> if (cpu_exists(cpu->id)) {\n> error_setg(&err, \"Unable to add CPU: %\" PRIi64\n> \", it already exists\", cpu->id);\n> @@ -306,13 +310,6 @@ static void s390_cpu_initfn(Object *obj)\n> inited = true;\n> s390x_translate_init();\n> }\n> -\n> -#if defined(CONFIG_USER_ONLY)\n> - {\n> - S390CPUClass *scc = S390_CPU_GET_CLASS(obj);\n> - cpu->id = scc->next_cpu_id;\n> - }\n> -#endif\n> }\n> \n> static void s390_cpu_finalize(Object *obj)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs4ZF3rrfz9rxl\n\tfor ;\n\tTue, 12 Sep 2017 22:57:09 +1000 (AEST)","from localhost ([::1]:35671 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drkkV-0008Un-Gd\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 08:57:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52076)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drkaM-0000F6-Lu\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:46:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drkaH-0007Os-O3\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:46:38 -0400","from mx1.redhat.com ([209.132.183.28]:44362)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drkaH-0007OU-HJ\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:46:33 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 795F3C058EA8;\n\tTue, 12 Sep 2017 12:46:32 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.209])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5DFA36B263;\n\tTue, 12 Sep 2017 12:46:23 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 795F3C058EA8","Date":"Tue, 12 Sep 2017 14:46:23 +0200","From":"Igor Mammedov ","To":"David Hildenbrand ","Message-ID":"<20170912144623.13363403@nial.brq.redhat.com>","In-Reply-To":"<20170911152150.12535-13-david@redhat.com>","References":"<20170911152150.12535-1-david@redhat.com>\n\t<20170911152150.12535-13-david@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 12 Sep 2017 12:46:32 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 12/21] target/s390x: set cpu->id for\n\tlinux user when realizing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tMarkus Armbruster , cohuck@redhat.com,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]