[{"id":1766961,"web_url":"http://patchwork.ozlabs.org/comment/1766961/","msgid":"<20170912144330.3f07b30b@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-09-12T12:43:30","subject":"Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Mon, 11 Sep 2017 17:21:40 +0200\nDavid Hildenbrand wrote:\n\n> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\n> guest tries to bring these CPUs up but fails), because we don't support\n> multiple CPUs on s390x under TCG.\n> \n> Let's bail out if more than 1 is specified, so we don't raise people's\n> hope. Make it a define, so we can easily bump it up later.\n> \n> Tested-by: Matthew Rosato \n> Signed-off-by: David Hildenbrand \n> ---\n> hw/s390x/s390-virtio-ccw.c | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index f67b4b5d58..f1198b2745 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -23,6 +23,7 @@\n> #include \"hw/s390x/css.h\"\n> #include \"virtio-ccw.h\"\n> #include \"qemu/config-file.h\"\n> +#include \"qemu/error-report.h\"\n> #include \"s390-pci-bus.h\"\n> #include \"hw/s390x/storage-keys.h\"\n> #include \"hw/s390x/storage-attributes.h\"\n> @@ -47,6 +48,8 @@ S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)\n> return cpu_states[cpu_addr];\n> }\n> \n> +/* #define S390_TCG_SMP_SUPPORT */\nI'd drop define and ifdef for something that doesn't exists\n\n> static void s390_init_cpus(MachineState *machine)\n> {\n> int i;\n> @@ -55,6 +58,13 @@ static void s390_init_cpus(MachineState *machine)\n> if (machine->cpu_model == NULL) {\n> machine->cpu_model = s390_default_cpu_model_name();\n> }\n> +#ifndef S390_TCG_SMP_SUPPORT\n> + if (tcg_enabled() && max_cpus > 1) {\n> + error_report(\"Number of SMP CPUs requested (%d) exceeds max CPUs \"\n> + \"supported by TCG (1) on s390x\", max_cpus);\n> + exit(1);\n> + }\n> +#endif\n> \n> cpu_states = g_new0(S390CPU *, max_cpus);\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs4Vx0QYNz9t9m\n\tfor ;\n\tTue, 12 Sep 2017 22:54:13 +1000 (AEST)","from localhost ([::1]:35645 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drkgT-0004rn-95\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 08:52:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50757)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drkXS-00068S-BE\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:43:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drkXR-00065d-DB\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:43:38 -0400","from mx1.redhat.com ([209.132.183.28]:42164)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drkXR-00065V-6i\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:43:37 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 161FE7EA88;\n\tTue, 12 Sep 2017 12:43:36 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.209])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id F3E0F6684F;\n\tTue, 12 Sep 2017 12:43:32 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 161FE7EA88","Date":"Tue, 12 Sep 2017 14:43:30 +0200","From":"Igor Mammedov ","To":"David Hildenbrand ","Message-ID":"<20170912144330.3f07b30b@nial.brq.redhat.com>","In-Reply-To":"<20170911152150.12535-12-david@redhat.com>","References":"<20170911152150.12535-1-david@redhat.com>\n\t<20170911152150.12535-12-david@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 12 Sep 2017 12:43:36 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tMarkus Armbruster , cohuck@redhat.com,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767171,"web_url":"http://patchwork.ozlabs.org/comment/1767171/","msgid":"","list_archive_url":null,"date":"2017-09-12T15:42:35","subject":"Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 12.09.2017 14:43, Igor Mammedov wrote:\n> On Mon, 11 Sep 2017 17:21:40 +0200\n> David Hildenbrand wrote:\n> \n>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\n>> guest tries to bring these CPUs up but fails), because we don't support\n>> multiple CPUs on s390x under TCG.\n>>\n>> Let's bail out if more than 1 is specified, so we don't raise people's\n>> hope. Make it a define, so we can easily bump it up later.\n>>\n>> Tested-by: Matthew Rosato \n>> Signed-off-by: David Hildenbrand \n>> ---\n>> hw/s390x/s390-virtio-ccw.c | 10 ++++++++++\n>> 1 file changed, 10 insertions(+)\n>>\n>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n>> index f67b4b5d58..f1198b2745 100644\n>> --- a/hw/s390x/s390-virtio-ccw.c\n>> +++ b/hw/s390x/s390-virtio-ccw.c\n>> @@ -23,6 +23,7 @@\n>> #include \"hw/s390x/css.h\"\n>> #include \"virtio-ccw.h\"\n>> #include \"qemu/config-file.h\"\n>> +#include \"qemu/error-report.h\"\n>> #include \"s390-pci-bus.h\"\n>> #include \"hw/s390x/storage-keys.h\"\n>> #include \"hw/s390x/storage-attributes.h\"\n>> @@ -47,6 +48,8 @@ S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)\n>> return cpu_states[cpu_addr];\n>> }\n>> \n>> +/* #define S390_TCG_SMP_SUPPORT */\n> I'd drop define and ifdef for something that doesn't exists\n\nConny requested it as we might see some work on that area (supporting\nsmp) soon. So as long as there are no other opinions, I'll stick to the\ncurrent version.\n\nThanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs8Fv6LvFz9s7f\n\tfor ;\n\tWed, 13 Sep 2017 01:43:14 +1000 (AEST)","from localhost ([::1]:36585 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drnLE-00018o-I6\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 11:43:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49610)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drnKm-00018O-3D\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 11:42:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drnKi-00024Z-1o\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 11:42:44 -0400","from mx1.redhat.com ([209.132.183.28]:54100)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drnKh-00023x-Ro\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 11:42:39 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 906FDC04B930;\n\tTue, 12 Sep 2017 15:42:38 +0000 (UTC)","from [10.36.117.114] (ovpn-117-114.ams2.redhat.com [10.36.117.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0008017AEA;\n\tTue, 12 Sep 2017 15:42:35 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 906FDC04B930","To":"Igor Mammedov ","References":"<20170911152150.12535-1-david@redhat.com>\n\t<20170911152150.12535-12-david@redhat.com>\n\t<20170912144330.3f07b30b@nial.brq.redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Tue, 12 Sep 2017 17:42:35 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912144330.3f07b30b@nial.brq.redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tTue, 12 Sep 2017 15:42:38 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tMarkus Armbruster , cohuck@redhat.com,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767621,"web_url":"http://patchwork.ozlabs.org/comment/1767621/","msgid":"<20170913091959.336e86f3@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-09-13T07:19:59","subject":"Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Tue, 12 Sep 2017 17:42:35 +0200\nDavid Hildenbrand wrote:\n\n> On 12.09.2017 14:43, Igor Mammedov wrote:\n> > On Mon, 11 Sep 2017 17:21:40 +0200\n> > David Hildenbrand wrote:\n> > \n> >> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\n> >> guest tries to bring these CPUs up but fails), because we don't support\n> >> multiple CPUs on s390x under TCG.\n> >>\n> >> Let's bail out if more than 1 is specified, so we don't raise people's\n> >> hope. Make it a define, so we can easily bump it up later.\n> >>\n> >> Tested-by: Matthew Rosato \n> >> Signed-off-by: David Hildenbrand \n> >> ---\n> >> hw/s390x/s390-virtio-ccw.c | 10 ++++++++++\n> >> 1 file changed, 10 insertions(+)\n> >>\n> >> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> >> index f67b4b5d58..f1198b2745 100644\n> >> --- a/hw/s390x/s390-virtio-ccw.c\n> >> +++ b/hw/s390x/s390-virtio-ccw.c\n> >> @@ -23,6 +23,7 @@\n> >> #include \"hw/s390x/css.h\"\n> >> #include \"virtio-ccw.h\"\n> >> #include \"qemu/config-file.h\"\n> >> +#include \"qemu/error-report.h\"\n> >> #include \"s390-pci-bus.h\"\n> >> #include \"hw/s390x/storage-keys.h\"\n> >> #include \"hw/s390x/storage-attributes.h\"\n> >> @@ -47,6 +48,8 @@ S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)\n> >> return cpu_states[cpu_addr];\n> >> }\n> >> \n> >> +/* #define S390_TCG_SMP_SUPPORT */ \n> > I'd drop define and ifdef for something that doesn't exists \n> \n> Conny requested it as we might see some work on that area (supporting\n> smp) soon. So as long as there are no other opinions, I'll stick to the\n> current version.\n> \n> Thanks!\n> \nI've just removed a bunch of TODO cpu models in PPC with\ncorresponding macro, my guess they were also introduced\nwith similar intent but ended up as dead code.\n\nSo it's better to add new code when it actually is needed,\ninstead of just in case.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsY6W11f6z9sNV\n\tfor ;\n\tWed, 13 Sep 2017 17:23:15 +1000 (AEST)","from localhost ([::1]:40559 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds20v-0003wA-8c\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 03:23:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53620)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds1y0-0007xu-B7\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 03:20:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds1xw-0005TV-A9\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 03:20:12 -0400","from mx1.redhat.com ([209.132.183.28]:51976)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ds1xw-0005Re-4k\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 03:20:08 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0D2D685550;\n\tWed, 13 Sep 2017 07:20:07 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.209])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6262B19E72;\n\tWed, 13 Sep 2017 07:20:00 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0D2D685550","Date":"Wed, 13 Sep 2017 09:19:59 +0200","From":"Igor Mammedov ","To":"David Hildenbrand ","Message-ID":"<20170913091959.336e86f3@nial.brq.redhat.com>","In-Reply-To":"","References":"<20170911152150.12535-1-david@redhat.com>\n\t<20170911152150.12535-12-david@redhat.com>\n\t<20170912144330.3f07b30b@nial.brq.redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 13 Sep 2017 07:20:07 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato ,\n\tAlexander Graf , thuth@redhat.com,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tMarkus Armbruster , qemu-devel@nongnu.org,\n\tborntraeger@de.ibm.com, Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767830,"web_url":"http://patchwork.ozlabs.org/comment/1767830/","msgid":"","list_archive_url":null,"date":"2017-09-13T12:10:53","subject":"Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 13.09.2017 09:19, Igor Mammedov wrote:\n> On Tue, 12 Sep 2017 17:42:35 +0200\n> David Hildenbrand wrote:\n> \n>> On 12.09.2017 14:43, Igor Mammedov wrote:\n>>> On Mon, 11 Sep 2017 17:21:40 +0200\n>>> David Hildenbrand wrote:\n>>> \n>>>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\n>>>> guest tries to bring these CPUs up but fails), because we don't support\n>>>> multiple CPUs on s390x under TCG.\n>>>>\n>>>> Let's bail out if more than 1 is specified, so we don't raise people's\n>>>> hope. Make it a define, so we can easily bump it up later.\n>>>>\n>>>> Tested-by: Matthew Rosato \n>>>> Signed-off-by: David Hildenbrand \n>>>> ---\n>>>> hw/s390x/s390-virtio-ccw.c | 10 ++++++++++\n>>>> 1 file changed, 10 insertions(+)\n>>>>\n>>>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n>>>> index f67b4b5d58..f1198b2745 100644\n>>>> --- a/hw/s390x/s390-virtio-ccw.c\n>>>> +++ b/hw/s390x/s390-virtio-ccw.c\n>>>> @@ -23,6 +23,7 @@\n>>>> #include \"hw/s390x/css.h\"\n>>>> #include \"virtio-ccw.h\"\n>>>> #include \"qemu/config-file.h\"\n>>>> +#include \"qemu/error-report.h\"\n>>>> #include \"s390-pci-bus.h\"\n>>>> #include \"hw/s390x/storage-keys.h\"\n>>>> #include \"hw/s390x/storage-attributes.h\"\n>>>> @@ -47,6 +48,8 @@ S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)\n>>>> return cpu_states[cpu_addr];\n>>>> }\n>>>> \n>>>> +/* #define S390_TCG_SMP_SUPPORT */ \n>>> I'd drop define and ifdef for something that doesn't exists \n>>\n>> Conny requested it as we might see some work on that area (supporting\n>> smp) soon. So as long as there are no other opinions, I'll stick to the\n>> current version.\n>>\n>> Thanks!\n>>\n> I've just removed a bunch of TODO cpu models in PPC with\n> corresponding macro, my guess they were also introduced\n> with similar intent but ended up as dead code.\n> \n> So it's better to add new code when it actually is needed,\n> instead of just in case.\n> \nv1 of this patch had no ifdef at all. So I'll let Conny decide whether\nto keep it like this or whether to drop the ifdef again.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsgXc44Xqz9sNV\n\tfor ;\n\tWed, 13 Sep 2017 22:12:48 +1000 (AEST)","from localhost ([::1]:42099 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds6X8-0005nO-M5\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 08:12:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54774)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds6VO-0004PY-Dv\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:11:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds6VN-0001Te-Cw\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:10:58 -0400","from mx1.redhat.com ([209.132.183.28]:37446)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ds6VN-0001Ss-4N\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:10:57 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 37681C04B958;\n\tWed, 13 Sep 2017 12:10:56 +0000 (UTC)","from [10.36.116.21] (ovpn-116-21.ams2.redhat.com [10.36.116.21])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D24AF17558;\n\tWed, 13 Sep 2017 12:10:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 37681C04B958","To":"Igor Mammedov , cohuck@redhat.com","References":"<20170911152150.12535-1-david@redhat.com>\n\t<20170911152150.12535-12-david@redhat.com>\n\t<20170912144330.3f07b30b@nial.brq.redhat.com>\n\t\n\t<20170913091959.336e86f3@nial.brq.redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Wed, 13 Sep 2017 14:10:53 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913091959.336e86f3@nial.brq.redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 13 Sep 2017 12:10:56 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost , qemu-devel@nongnu.org,\n\tRichard Henderson ,\n\tMarkus Armbruster ,\n\tAlexander Graf , borntraeger@de.ibm.com,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767852,"web_url":"http://patchwork.ozlabs.org/comment/1767852/","msgid":"<20170913143514.7dc8a649.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-13T12:35:14","subject":"Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 13 Sep 2017 14:10:53 +0200\nDavid Hildenbrand wrote:\n\n> On 13.09.2017 09:19, Igor Mammedov wrote:\n> > On Tue, 12 Sep 2017 17:42:35 +0200\n> > David Hildenbrand wrote:\n> > \n> >> On 12.09.2017 14:43, Igor Mammedov wrote: \n> >>> On Mon, 11 Sep 2017 17:21:40 +0200\n> >>> David Hildenbrand wrote:\n> >>> \n> >>>> Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\n> >>>> guest tries to bring these CPUs up but fails), because we don't support\n> >>>> multiple CPUs on s390x under TCG.\n> >>>>\n> >>>> Let's bail out if more than 1 is specified, so we don't raise people's\n> >>>> hope. Make it a define, so we can easily bump it up later.\n> >>>>\n> >>>> Tested-by: Matthew Rosato \n> >>>> Signed-off-by: David Hildenbrand \n> >>>> ---\n> >>>> hw/s390x/s390-virtio-ccw.c | 10 ++++++++++\n> >>>> 1 file changed, 10 insertions(+)\n> >>>>\n> >>>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> >>>> index f67b4b5d58..f1198b2745 100644\n> >>>> --- a/hw/s390x/s390-virtio-ccw.c\n> >>>> +++ b/hw/s390x/s390-virtio-ccw.c\n> >>>> @@ -23,6 +23,7 @@\n> >>>> #include \"hw/s390x/css.h\"\n> >>>> #include \"virtio-ccw.h\"\n> >>>> #include \"qemu/config-file.h\"\n> >>>> +#include \"qemu/error-report.h\"\n> >>>> #include \"s390-pci-bus.h\"\n> >>>> #include \"hw/s390x/storage-keys.h\"\n> >>>> #include \"hw/s390x/storage-attributes.h\"\n> >>>> @@ -47,6 +48,8 @@ S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)\n> >>>> return cpu_states[cpu_addr];\n> >>>> }\n> >>>> \n> >>>> +/* #define S390_TCG_SMP_SUPPORT */ \n> >>> I'd drop define and ifdef for something that doesn't exists \n> >>\n> >> Conny requested it as we might see some work on that area (supporting\n> >> smp) soon. So as long as there are no other opinions, I'll stick to the\n> >> current version.\n> >>\n> >> Thanks!\n> >> \n> > I've just removed a bunch of TODO cpu models in PPC with\n> > corresponding macro, my guess they were also introduced\n> > with similar intent but ended up as dead code.\n> > \n> > So it's better to add new code when it actually is needed,\n> > instead of just in case.\n> > \n> v1 of this patch had no ifdef at all. So I'll let Conny decide whether\n> to keep it like this or whether to drop the ifdef again.\n\nYou could add a comment? OTOH, this one hits immediately, so whoever\nimplements smp for tcg will remember to change this :)\n\nSo no real objection to leaving out the ifdef.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsh3W4zDkz9sNr\n\tfor ;\n\tWed, 13 Sep 2017 22:36:06 +1000 (AEST)","from localhost ([::1]:42195 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds6tc-0002BH-FI\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 08:36:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40548)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds6tE-0002BB-6p\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:35:37 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds6t9-00073q-8A\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:35:36 -0400","from mx1.redhat.com ([209.132.183.28]:45306)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ds6t8-0006zO-U2\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 08:35:31 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2E3E6C04B31B;\n\tWed, 13 Sep 2017 12:35:27 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3B39077C1B;\n\tWed, 13 Sep 2017 12:35:16 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2E3E6C04B31B","Date":"Wed, 13 Sep 2017 14:35:14 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170913143514.7dc8a649.cohuck@redhat.com>","In-Reply-To":"","References":"<20170911152150.12535-1-david@redhat.com>\n\t<20170911152150.12535-12-david@redhat.com>\n\t<20170912144330.3f07b30b@nial.brq.redhat.com>\n\t\n\t<20170913091959.336e86f3@nial.brq.redhat.com>\n\t","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 13 Sep 2017 12:35:27 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 11/21] s390x: allow only 1 CPU with TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost , qemu-devel@nongnu.org,\n\tRichard Henderson ,\n\tAlexander Graf ,\n\tMarkus Armbruster , borntraeger@de.ibm.com,\n\tPaolo Bonzini , Igor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]