[{"id":1766351,"web_url":"http://patchwork.ozlabs.org/comment/1766351/","msgid":"<1299bf0c-f887-bcfe-2e97-3c7103d407a1@redhat.com>","list_archive_url":null,"date":"2017-09-11T14:51:48","subject":"Re: [Qemu-devel] [PATCH v2 3/3] tests/hmp: test \"none\" machine with\n\tmemory","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 11.09.2017 16:20, Laurent Vivier wrote:\n> and add a test case of dump-guest-memory without\n> \"[begin length]\" parameters.\n> \n> Signed-off-by: Laurent Vivier \n> ---\n> tests/test-hmp.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/tests/test-hmp.c b/tests/test-hmp.c\n> index 729c0339f7..90693c0ce2 100644\n> --- a/tests/test-hmp.c\n> +++ b/tests/test-hmp.c\n> @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = {\n> \"mouse_button 0\",\n> \"device_del mouse1\",\n> \"dump-guest-memory /dev/null 0 4096\",\n> + \"dump-guest-memory /dev/null\",\n> \"gdbserver\",\n> \"host_net_add user id=net0\",\n> \"hostfwd_add tcp::43210-:43210\",\n> @@ -159,5 +160,9 @@ int main(int argc, char **argv)\n> \n> qtest_cb_for_every_machine(add_machine_test_case);\n> \n> + /* as none machine has no memory, add a test case with memory */\n> +\n\nMaybe remove the empty line after the comment?\n\n> + qtest_add_data_func(\"hmp/none+2MB\", g_strdup(\"none -m 2\"), test_machine);\n> +\n> return g_test_run();\n> }\n> \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrWBB4Qy9z9s4q\n\tfor ;\n\tTue, 12 Sep 2017 00:52:50 +1000 (AEST)","from localhost ([::1]:58224 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drQ4u-0007aJ-PO\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 10:52:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34035)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drQ4E-0007Rb-DL\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 10:52:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drQ4D-0007Oq-MD\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 10:52:06 -0400","from mx1.redhat.com ([209.132.183.28]:57842)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drQ46-0007H8-RJ; Mon, 11 Sep 2017 10:51:58 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9613CC5488;\n\tMon, 11 Sep 2017 14:51:57 +0000 (UTC)","from [10.36.116.113] (ovpn-116-113.ams2.redhat.com [10.36.116.113])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 63614612AA;\n\tMon, 11 Sep 2017 14:51:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9613CC5488","To":"Laurent Vivier , qemu-devel@nongnu.org","References":"<20170911142056.15643-1-lvivier@redhat.com>\n\t<20170911142056.15643-4-lvivier@redhat.com>","From":"Thomas Huth ","Message-ID":"<1299bf0c-f887-bcfe-2e97-3c7103d407a1@redhat.com>","Date":"Mon, 11 Sep 2017 16:51:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911142056.15643-4-lvivier@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 11 Sep 2017 14:51:57 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 3/3] tests/hmp: test \"none\" machine with\n\tmemory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tCornelia Huck , \n\t\"Dr . David Alan Gilbert\" ,\n\tGreg Kurz , qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766364,"web_url":"http://patchwork.ozlabs.org/comment/1766364/","msgid":"","list_archive_url":null,"date":"2017-09-11T15:39:08","subject":"Re: [Qemu-devel] [PATCH v2 3/3] tests/hmp: test \"none\" machine with\n\tmemory","submitter":{"id":66421,"url":"http://patchwork.ozlabs.org/api/people/66421/","name":"Laurent Vivier","email":"lvivier@redhat.com"},"content":"On 11/09/2017 16:51, Thomas Huth wrote:\n> On 11.09.2017 16:20, Laurent Vivier wrote:\n>> and add a test case of dump-guest-memory without\n>> \"[begin length]\" parameters.\n>>\n>> Signed-off-by: Laurent Vivier \n>> ---\n>> tests/test-hmp.c | 5 +++++\n>> 1 file changed, 5 insertions(+)\n>>\n>> diff --git a/tests/test-hmp.c b/tests/test-hmp.c\n>> index 729c0339f7..90693c0ce2 100644\n>> --- a/tests/test-hmp.c\n>> +++ b/tests/test-hmp.c\n>> @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = {\n>> \"mouse_button 0\",\n>> \"device_del mouse1\",\n>> \"dump-guest-memory /dev/null 0 4096\",\n>> + \"dump-guest-memory /dev/null\",\n>> \"gdbserver\",\n>> \"host_net_add user id=net0\",\n>> \"hostfwd_add tcp::43210-:43210\",\n>> @@ -159,5 +160,9 @@ int main(int argc, char **argv)\n>> \n>> qtest_cb_for_every_machine(add_machine_test_case);\n>> \n>> + /* as none machine has no memory, add a test case with memory */\n>> +\n> \n> Maybe remove the empty line after the comment?\n\nBad habit. If I respin the series, I'll update this, otherwise I would\nappreciate the committer does.\n\n>> + qtest_add_data_func(\"hmp/none+2MB\", g_strdup(\"none -m 2\"), test_machine);\n>> +\n>> return g_test_run();\n>> }\n>>\n> \n> Reviewed-by: Thomas Huth \n> \n\nThanks,\nLaurent","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=lvivier@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrXDX3jnCz9s7B\n\tfor ;\n\tTue, 12 Sep 2017 01:39:56 +1000 (AEST)","from localhost ([::1]:58481 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drQoU-0002Jj-KW\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 11:39:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55980)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drQns-0002Hp-Id\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:39:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drQnr-0005Uq-Qg\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 11:39:16 -0400","from mx1.redhat.com ([209.132.183.28]:58486)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drQnp-0005Sh-H8; Mon, 11 Sep 2017 11:39:13 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 62DB5C0587D9;\n\tMon, 11 Sep 2017 15:39:12 +0000 (UTC)","from [10.36.116.239] (ovpn-116-239.ams2.redhat.com [10.36.116.239])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D2D4F60A98;\n\tMon, 11 Sep 2017 15:39:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 62DB5C0587D9","To":"Thomas Huth , qemu-devel@nongnu.org","References":"<20170911142056.15643-1-lvivier@redhat.com>\n\t<20170911142056.15643-4-lvivier@redhat.com>\n\t<1299bf0c-f887-bcfe-2e97-3c7103d407a1@redhat.com>","From":"Laurent Vivier ","Message-ID":"","Date":"Mon, 11 Sep 2017 17:39:08 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1299bf0c-f887-bcfe-2e97-3c7103d407a1@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tMon, 11 Sep 2017 15:39:12 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 3/3] tests/hmp: test \"none\" machine with\n\tmemory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tCornelia Huck , \n\t\"Dr . David Alan Gilbert\" ,\n\tGreg Kurz , qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766937,"web_url":"http://patchwork.ozlabs.org/comment/1766937/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:15:11","subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH v2 3/3] tests/hmp: test \"none\"\n\tmachine with memory","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/11/2017 11:20 AM, Laurent Vivier wrote:\n> and add a test case of dump-guest-memory without\n> \"[begin length]\" parameters.\n> \n> Signed-off-by: Laurent Vivier \n> ---\n> tests/test-hmp.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/tests/test-hmp.c b/tests/test-hmp.c\n> index 729c0339f7..90693c0ce2 100644\n> --- a/tests/test-hmp.c\n> +++ b/tests/test-hmp.c\n> @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = {\n> \"mouse_button 0\",\n> \"device_del mouse1\",\n> \"dump-guest-memory /dev/null 0 4096\",\n> + \"dump-guest-memory /dev/null\",\n> \"gdbserver\",\n> \"host_net_add user id=net0\",\n> \"hostfwd_add tcp::43210-:43210\",\n> @@ -159,5 +160,9 @@ int main(int argc, char **argv)\n> \n> qtest_cb_for_every_machine(add_machine_test_case);\n> \n> + /* as none machine has no memory, add a test case with memory */\n> +\n> + qtest_add_data_func(\"hmp/none+2MB\", g_strdup(\"none -m 2\"), test_machine);\n\nTIL:\n\n\"-m 0\",\n\"none\" machine is implemented in \"null-machine.c\",\n\"none\" machine default maps memory at 0x0.\n\n> +\n> return g_test_run();\n> }\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SOeqDKKV\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs3gL1DYPz9t4k\n\tfor ;\n\tTue, 12 Sep 2017 22:16:20 +1000 (AEST)","from localhost ([::1]:35485 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drk6i-00017w-2y\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 08:16:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41299)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1drk6I-000135-E0\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:15:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1drk6H-0002YS-Hk\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 08:15:34 -0400","from mail-qt0-x232.google.com ([2607:f8b0:400d:c0d::232]:36867)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1drk60-0002IQ-Qg; Tue, 12 Sep 2017 08:15:16 -0400","by mail-qt0-x232.google.com with SMTP id b1so15311080qtc.4;\n\tTue, 12 Sep 2017 05:15:16 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\t48sm7910487qty.29.2017.09.12.05.15.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Sep 2017 05:15:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=WgxxTNFulw9Fw2oOFT9wjXPXnXqcOMH4k8pxR3Q9VTA=;\n\tb=SOeqDKKVRKSrnAz+gPOWZ0Z5NhySz4Hh0HrAnFx8UQ7a0SUFqWAlOUnpAAHVxczuqv\n\t45715KIqJWO8qcAPWO01iYNfjwfqijZ5FtToQnCyBYY1tcgsruWFdhH6bkpvv1mzZlAp\n\tPvky5VDGV67OjtmV7wjVU3jofq3slbh2Gr94t2h3Hzu0FKBDyYCoc4JEaBx9fUTOJ4Qq\n\tb66+SCcmh+nSP8FxXOjVMmzLtlH6KYMjSnf5So4sJrXD6JjeO9WJULXgrqk17DQYpYRz\n\teVRe9fDSYHQnSGhAQ/9YmWDPtU4Br5cysDZ6Lgozw8INL5B41tZsGyl3BIBLRl7e6T/d\n\tCT/A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=WgxxTNFulw9Fw2oOFT9wjXPXnXqcOMH4k8pxR3Q9VTA=;\n\tb=mdjLRpxF8xSdXOnDdnhICKbjahxbrD8sPlreDDhUrC6LLTAgQe4ky31YoeyvzVA6jE\n\tbXuPDg49UqM/B9mEa/U4OZwsOI7/paPmpe0sCe49pHGf1Rxjp4kbt6EBKu+iclAyTN7e\n\tygc10RTXaDV8N1Xltzqisok7jZC/LuRbsWIMvnrW/0CLDwUvQdaWIylBqpIS1SG6zhpQ\n\t/Mei9DI0C26wVoVyHRf1mCUOlkko6LKAv4Zfhp4M3lCUxVJPpOQoHiBymevKoYy5ZYZF\n\tsQPm4EbJZ/9n7UnMOxwqWlBqbh0+TA3L3oXjq64or+E4KobjRRYnmNpAdZVBm9mO58FG\n\tOQ8A==","X-Gm-Message-State":"AHPjjUjSyCn/I92v6KG0ZBzO3ipGdUjKpoigzLmIA6zGZzYPsYiSfRaS\n\t82QsaVH0LeJ/8A==","X-Google-Smtp-Source":"AOwi7QBMlNt1EhryqCALVfmioeOF66fugj4qjjCWuX7xyVVNmvVlHSHOGsMUqRi3tXpdWb93fPNNxQ==","X-Received":"by 10.237.42.85 with SMTP id k21mr20559973qtf.289.1505218516299; \n\tTue, 12 Sep 2017 05:15:16 -0700 (PDT)","To":"Laurent Vivier , qemu-devel@nongnu.org","References":"<20170911142056.15643-1-lvivier@redhat.com>\n\t<20170911142056.15643-4-lvivier@redhat.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Tue, 12 Sep 2017 09:15:11 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911142056.15643-4-lvivier@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::232","Subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH v2 3/3] tests/hmp: test \"none\"\n\tmachine with memory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Thomas Huth ,\n\tCornelia Huck ,\n\t\"Dr . David Alan Gilbert\" ,\n\tGreg Kurz , qemu-arm@nongnu.org,\n\tqemu-ppc@nongnu.org, David Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]