[{"id":1820991,"web_url":"http://patchwork.ozlabs.org/comment/1820991/","msgid":"<87shcflpel.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-12-12T19:25:22","subject":"Re: [Qemu-devel] [PATCH v3 30/50] qapi: add #if conditions to\n\tgenerated alternate variants","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Marc-André Lureau writes:\n\n> Mostly covered by previous patches already.\n>\n> Signed-off-by: Marc-André Lureau \n> ---\n> scripts/qapi-introspect.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/scripts/qapi-introspect.py b/scripts/qapi-introspect.py\n> index ef2d5577db..d6194ff702 100644\n> --- a/scripts/qapi-introspect.py\n> +++ b/scripts/qapi-introspect.py\n> @@ -172,7 +172,7 @@ const QLitObject %(c_name)s = %(c_string)s;\n> \n> def visit_alternate_type(self, name, info, ifcond, variants):\n> self._gen_qlit(name, 'alternate',\n> - {'members': [{'type': self._use_type(m.type)}\n> + {'members': [({'type': self._use_type(m.type)}, m.ifcond)\n> for m in variants.variants]}, ifcond)\n> \n> def visit_command(self, name, info, ifcond, arg_type, ret_type,\n\nAdds blank lines to qmp-introspect.c, just like PATCH 12, which see.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yx8tn52p9z9s81\n\tfor ;\n\tWed, 13 Dec 2017 06:25:53 +1100 (AEDT)","from localhost ([::1]:60136 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eOqBb-00072M-8N\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Dec 2017 14:25:51 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:55790)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eOqBH-00072H-4A\n\tfor qemu-devel@nongnu.org; Tue, 12 Dec 2017 14:25:32 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eOqBE-0003rq-FX\n\tfor qemu-devel@nongnu.org; Tue, 12 Dec 2017 14:25:31 -0500","from mx1.redhat.com ([209.132.183.28]:41924)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eOqBE-0003r4-68\n\tfor qemu-devel@nongnu.org; Tue, 12 Dec 2017 14:25:28 -0500","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 441A17F7B9;\n\tTue, 12 Dec 2017 19:25:27 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-74.ams2.redhat.com\n\t[10.36.116.74])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 1E0584DA72;\n\tTue, 12 Dec 2017 19:25:24 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 9994E1138658; Tue, 12 Dec 2017 20:25:22 +0100 (CET)"],"From":"Markus Armbruster ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-31-marcandre.lureau@redhat.com>","Date":"Tue, 12 Dec 2017 20:25:22 +0100","In-Reply-To":"<20170911110623.24981-31-marcandre.lureau@redhat.com> (\n\t=?utf-8?b?Ik1hcmMtQW5kcsOp?= Lureau\"'s message of \"Mon,\n\t11 Sep 2017 \t13:06:03 +0200\")","Message-ID":"<87shcflpel.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 12 Dec 2017 19:25:27 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 30/50] qapi: add #if conditions to\n\tgenerated alternate variants","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]