[{"id":1822340,"web_url":"http://patchwork.ozlabs.org/comment/1822340/","msgid":"<874lot1krh.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-12-14T13:50:26","subject":"Re: [Qemu-devel] [PATCH v3 40/50] qapi: add -i/--include filename.h","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Marc-André Lureau <marcandre.lureau@redhat.com> writes:\n\n> Add a new option to add user-specified #include lines in the generated\n> headers. This will help to split a schema, where one generated header\n> will depend on another.\n>\n> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nIf we need to manage includes manually, then this patch is one way to do\nit.  But I'm not sure we need to.  Let me review the remainder of the\nseries before we analyze this further.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yyFMf1mBkz9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Dec 2017 00:51:10 +1100 (AEDT)","from localhost ([::1]:41034 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ePTum-00005O-BD\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Dec 2017 08:51:08 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:44670)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1ePTuG-0008W8-Be\n\tfor qemu-devel@nongnu.org; Thu, 14 Dec 2017 08:50:37 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <armbru@redhat.com>) id 1ePTuC-0002fu-9v\n\tfor qemu-devel@nongnu.org; Thu, 14 Dec 2017 08:50:36 -0500","from mx1.redhat.com ([209.132.183.28]:35132)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1ePTuC-0002fQ-4S\n\tfor qemu-devel@nongnu.org; Thu, 14 Dec 2017 08:50:32 -0500","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1518A60161;\n\tThu, 14 Dec 2017 13:50:31 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-74.ams2.redhat.com\n\t[10.36.116.74])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 4D1CB60A9D;\n\tThu, 14 Dec 2017 13:50:28 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid B6D8F1138658; Thu, 14 Dec 2017 14:50:26 +0100 (CET)"],"From":"Markus Armbruster <armbru@redhat.com>","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-41-marcandre.lureau@redhat.com>","Date":"Thu, 14 Dec 2017 14:50:26 +0100","In-Reply-To":"<20170911110623.24981-41-marcandre.lureau@redhat.com> (\n\t=?utf-8?b?Ik1hcmMtQW5kcsOp?= Lureau\"'s message of \"Mon,\n\t11 Sep 2017 \t13:06:13 +0200\")","Message-ID":"<874lot1krh.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tThu, 14 Dec 2017 13:50:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 40/50] qapi: add -i/--include filename.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]