[{"id":1822491,"web_url":"http://patchwork.ozlabs.org/comment/1822491/","msgid":"<87r2rxuvao.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-12-14T16:30:07","subject":"Re: [Qemu-devel] [PATCH v3 43/50] build-sys: move qmp-introspect\n\tper target","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Marc-André Lureau writes:\n\n> The following patches are going to introduce per-target #ifdef, and\n> but the introspection data is generated only once, and must thus be\n> built with the target.\n\n\"and but\"?\n\n> Drop \"do_test_visitor_in_qmp_introspect(&&qmp_schema_qlit)\" since it\n\ns/&&/&/\n\n> is no longer in a common object, and covered by \"query-qmp-schema\n> test\" instead.\n\nDo you mean test /x86_64/qmp/query-qmp-schema of tests/qmp-test.c?\n\nThat test tests significantly less. It runs the command, tests it\nsucceeds and returns something. The test you remove additionally tests\nthe returned value conforms to the schema, by passing it to\nvisit_type_SchemaInfoList().\n\nPerhaps we can enhance the test you keep to avoid this loss.\n\n> Signed-off-by: Marc-André Lureau ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yyJvm6w68z9t8S\n\tfor ;\n\tFri, 15 Dec 2017 03:30:44 +1100 (AEDT)","from localhost ([::1]:41834 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ePWPD-0005Vx-1y\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Dec 2017 11:30:43 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:60296)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ePWOs-0005Vn-1b\n\tfor qemu-devel@nongnu.org; Thu, 14 Dec 2017 11:30:22 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ePWOm-0001X6-Ft\n\tfor qemu-devel@nongnu.org; Thu, 14 Dec 2017 11:30:22 -0500","from mx1.redhat.com ([209.132.183.28]:37860)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1ePWOm-0001UN-AG\n\tfor qemu-devel@nongnu.org; Thu, 14 Dec 2017 11:30:16 -0500","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DFC338B137;\n\tThu, 14 Dec 2017 16:30:14 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-74.ams2.redhat.com\n\t[10.36.116.74])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 3DD257C358;\n\tThu, 14 Dec 2017 16:30:09 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid ADF691138658; Thu, 14 Dec 2017 17:30:07 +0100 (CET)"],"From":"Markus Armbruster ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-44-marcandre.lureau@redhat.com>","Date":"Thu, 14 Dec 2017 17:30:07 +0100","In-Reply-To":"<20170911110623.24981-44-marcandre.lureau@redhat.com> (\n\t=?utf-8?b?Ik1hcmMtQW5kcsOp?= Lureau\"'s message of \"Mon,\n\t11 Sep 2017 \t13:06:16 +0200\")","Message-ID":"<87r2rxuvao.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 14 Dec 2017 16:30:14 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 43/50] build-sys: move qmp-introspect\n\tper target","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1837336,"web_url":"http://patchwork.ozlabs.org/comment/1837336/","msgid":"","list_archive_url":null,"date":"2018-01-11T21:32:17","subject":"Re: [Qemu-devel] [PATCH v3 43/50] build-sys: move qmp-introspect\n\tper target","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"Hi\n\nOn Thu, Dec 14, 2017 at 5:30 PM, Markus Armbruster wrote:\n> Marc-André Lureau writes:\n>\n>> The following patches are going to introduce per-target #ifdef, and\n>> but the introspection data is generated only once, and must thus be\n>> built with the target.\n>\n> \"and but\"?\n>\n>> Drop \"do_test_visitor_in_qmp_introspect(&&qmp_schema_qlit)\" since it\n>\n> s/&&/&/\n>\n>> is no longer in a common object, and covered by \"query-qmp-schema\n>> test\" instead.\n>\n> Do you mean test /x86_64/qmp/query-qmp-schema of tests/qmp-test.c?\n>\n\nI updated the commit message.\n\n> That test tests significantly less. It runs the command, tests it\n> succeeds and returns something. The test you remove additionally tests\n> the returned value conforms to the schema, by passing it to\n> visit_type_SchemaInfoList().\n>\n> Perhaps we can enhance the test you keep to avoid this loss.\n>\n\nIt does call visit_type_SchemaInfoList() already on the return value.\n\nthanks","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"uUbP1ikV\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zHfK607gdz9sRW\n\tfor ;\n\tFri, 12 Jan 2018 08:34:16 +1100 (AEDT)","from localhost ([::1]:44586 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eZkUI-0004hl-48\n\tfor incoming@patchwork.ozlabs.org; Thu, 11 Jan 2018 16:34:14 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:48774)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eZkSS-0003aa-Ej\n\tfor qemu-devel@nongnu.org; Thu, 11 Jan 2018 16:32:21 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eZkSR-0007so-Kd\n\tfor qemu-devel@nongnu.org; Thu, 11 Jan 2018 16:32:20 -0500","from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]:42726)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1eZkSR-0007sB-FJ\n\tfor qemu-devel@nongnu.org; Thu, 11 Jan 2018 16:32:19 -0500","by mail-wr0-x232.google.com with SMTP id e41so3213207wre.9\n\tfor ; Thu, 11 Jan 2018 13:32:19 -0800 (PST)","by 10.223.199.143 with HTTP; Thu, 11 Jan 2018 13:32:17 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=aYK/dIyhHDhTVkvR5WVQDCnxybtwR81weTMLbXIF7Sw=;\n\tb=uUbP1ikViB3qZMqI0YzbnitlIbnttCrIUMYmuItpI4vi969knG/lmiA8CT4I2dCo06\n\tFNpkQ7gUr2UkXBBGqaOIKwJl/X1qrabgayFaOVVfnU+dEtKB8GT7Tv6tscDmOFWWUnTu\n\tV0P0jbkvXuJK7s9KoNGw/wtNj8KLcq6Z6TEMn3DZJx/Vbm1FKw04cVZIFtevky7V/gL1\n\tCJoMlbVp6ZRxmQvyVvZ1Jk1TxGs4Zep7GqLKir4n4FsBTBY6kjx72bXy8QFn//nmGAED\n\tu4gr6hRkrjyKzAwesVMXtzOOy1xV8RDj8JDoSQyF9sa66R/kFY68/Uy7scI6RoSwkNcP\n\tX/yA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=aYK/dIyhHDhTVkvR5WVQDCnxybtwR81weTMLbXIF7Sw=;\n\tb=PFk8Vh8EfeLANTNcgRFk0fyfHgkApVOUbJTei7HxCk2YB+SP0eNobu6Q2mBOniHIEV\n\tmMlLe1Yj/Rc5B5efQw/e4munv/v8W210vFfz0J6cMY2j17biAgfY0I95ltQPSjNQV7qL\n\tl2huZ2u+qFOszPuPT2FwuR9JdHniuSdnJt3Y3sFWVLCskKpwpVcfhdgSN2lwoZBTDcQH\n\t6Q7dCtHx4Y1mj/GLgEcUuUNnKoCKf3889jrMr2r9UmtWtZXBHvlu9tH7bGW9c23uIDyh\n\t9+77q4FY5tZiOwpXx/TSJYyBDd5mCtiuoqxJvrfZqGxrW7pZerIJFmUdZu5eRYeO4odi\n\tcB2A==","X-Gm-Message-State":"AKGB3mKEnFhuj4/M72T/pfWS/X199yHs2rWcwOm/pYIfNHCtgqcNaGgd\n\tqFwFiVRSbQlqvwgSN+pHt01vG4u2LRjIPZd3TXU=","X-Google-Smtp-Source":"ACJfBovkiiU784rGOhRy3GuhMEbs3YwQ1tL7cdyr4GYMKSIe7FjC9cQJknHSRU935r775AM8VOEcbx6sVRfVO/Zkb6w=","X-Received":"by 10.223.174.236 with SMTP id\n\ty99mr13610233wrc.117.1515706338480; \n\tThu, 11 Jan 2018 13:32:18 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"<87r2rxuvao.fsf@dusky.pond.sub.org>","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-44-marcandre.lureau@redhat.com>\n\t<87r2rxuvao.fsf@dusky.pond.sub.org>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 11 Jan 2018 22:32:17 +0100","Message-ID":"","To":"Markus Armbruster ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::232","Subject":"Re: [Qemu-devel] [PATCH v3 43/50] build-sys: move qmp-introspect\n\tper target","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU , Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]