[{"id":1821641,"web_url":"http://patchwork.ozlabs.org/comment/1821641/","msgid":"<87o9n27g2d.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-12-13T16:23:06","subject":"Re: [Qemu-devel] [PATCH v3 39/50] qapi-commands: don't initialize\n\tcommand list in qmp_init_marshall()","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Marc-André Lureau writes:\n\n> This will let the caller add several list of commands.\n\nWhat for? I guess that'll become clear later in this series.\n\n> Signed-off-by: Marc-André Lureau \n> ---\n> scripts/qapi-commands.py | 2 --\n> monitor.c | 1 +\n> qga/main.c | 1 +\n> tests/test-qmp-commands.c | 1 +\n> 4 files changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py\n> index 8af8d913b9..7455d2b8bb 100644\n> --- a/scripts/qapi-commands.py\n> +++ b/scripts/qapi-commands.py\n> @@ -211,8 +211,6 @@ def gen_registry(registry):\n> \n> void %(c_prefix)sqmp_init_marshal(QmpCommandList *cmds)\n> {\n> - QTAILQ_INIT(cmds);\n> -\n> ''',\n> c_prefix=c_name(prefix, protect=False))\n> ret += registry\n\nPlease update qapi-code-gen.txt, too.\n\n> diff --git a/monitor.c b/monitor.c\n> index b5ddcf8c67..bf8a7685bf 100644\n> --- a/monitor.c\n> +++ b/monitor.c\n> @@ -1001,6 +1001,7 @@ void monitor_init_qmp_commands(void)\n> * \"qmp_capabilities\", to enforce capability negotiation\n> */\n> \n> + QTAILQ_INIT(&qmp_commands);\n> qmp_init_marshal(&qmp_commands);\n> \n> qmp_register_command(&qmp_commands, \"query-qmp-schema\",\n> diff --git a/qga/main.c b/qga/main.c\n> index 62a62755bd..b949b1ccb0 100644\n> --- a/qga/main.c\n> +++ b/qga/main.c\n> @@ -1360,6 +1360,7 @@ int main(int argc, char **argv)\n> \n> config->log_level = G_LOG_LEVEL_ERROR | G_LOG_LEVEL_CRITICAL;\n> \n> + QTAILQ_INIT(&ga_commands);\n> qga_qmp_init_marshal(&ga_commands);\n> \n> init_dfl_pathnames();\n> diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c\n> index ad7b6e4e1d..28ce88e012 100644\n> --- a/tests/test-qmp-commands.c\n> +++ b/tests/test-qmp-commands.c\n> @@ -283,6 +283,7 @@ int main(int argc, char **argv)\n> g_test_add_func(\"/0.15/dealloc_types\", test_dealloc_types);\n> g_test_add_func(\"/0.15/dealloc_partial\", test_dealloc_partial);\n> \n> + QTAILQ_INIT(&qmp_commands);\n> test_qmp_init_marshal(&qmp_commands);\n> g_test_run();","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yxhp7729kz9sPm\n\tfor ;\n\tThu, 14 Dec 2017 03:23:43 +1100 (AEDT)","from localhost ([::1]:36187 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eP9os-0001w7-3J\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Dec 2017 11:23:42 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:51350)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eP9oX-0001w2-JG\n\tfor qemu-devel@nongnu.org; Wed, 13 Dec 2017 11:23:22 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eP9oS-0000XF-GC\n\tfor qemu-devel@nongnu.org; Wed, 13 Dec 2017 11:23:21 -0500","from mx1.redhat.com ([209.132.183.28]:53882)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eP9oS-0000WQ-AH\n\tfor qemu-devel@nongnu.org; Wed, 13 Dec 2017 11:23:16 -0500","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A012849007;\n\tWed, 13 Dec 2017 16:23:14 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-74.ams2.redhat.com\n\t[10.36.116.74])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 2A53C6C512;\n\tWed, 13 Dec 2017 16:23:08 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid AB0471138658; Wed, 13 Dec 2017 17:23:06 +0100 (CET)"],"From":"Markus Armbruster ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-40-marcandre.lureau@redhat.com>","Date":"Wed, 13 Dec 2017 17:23:06 +0100","In-Reply-To":"<20170911110623.24981-40-marcandre.lureau@redhat.com> (\n\t=?utf-8?b?Ik1hcmMtQW5kcsOp?= Lureau\"'s message of \"Mon,\n\t11 Sep 2017 \t13:06:12 +0200\")","Message-ID":"<87o9n27g2d.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 13 Dec 2017 16:23:14 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 39/50] qapi-commands: don't initialize\n\tcommand list in qmp_init_marshall()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, \"Dr. David Alan Gilbert\" ,\n\tMichael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]