[{"id":1818702,"web_url":"http://patchwork.ozlabs.org/comment/1818702/","msgid":"<87tvx1e2xz.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-12-08T13:58:48","subject":"Re: [Qemu-devel] [PATCH v3 20/50] qapi-event: add 'if' condition to\n\tgenerated enum","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Marc-André Lureau writes:\n\n> Add condition to QAPIEvent enum members based on the event 'if'.\n>\n> Signed-off-by: Marc-André Lureau \n> ---\n> scripts/qapi-event.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py\n> index 38f4264817..60c6f7030d 100644\n> --- a/scripts/qapi-event.py\n> +++ b/scripts/qapi-event.py\n> @@ -168,7 +168,7 @@ class QAPISchemaGenEventVisitor(QAPISchemaVisitor):\n> def visit_event(self, name, info, ifcond, arg_type, boxed):\n> self.decl += gen_event_send_decl(name, arg_type, boxed)\n> self.defn += gen_event_send(name, arg_type, boxed)\n> - self._event_names.append(QAPISchemaMember(name))\n> + self._event_names.append(QAPISchemaMember(name, ifcond))\n> \n> \n> (input_file, output_dir, do_c, do_h, prefix, dummy) = parse_command_line()\n\nNo test coverage?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ytYqw3yf7z9sNd\n\tfor ;\n\tSat, 9 Dec 2017 00:59:23 +1100 (AEDT)","from localhost ([::1]:37389 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eNJBQ-0006hg-RM\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Dec 2017 08:59:20 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:37312)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eNJB7-0006hZ-Oj\n\tfor qemu-devel@nongnu.org; Fri, 08 Dec 2017 08:59:02 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eNJB4-0008Go-JT\n\tfor qemu-devel@nongnu.org; Fri, 08 Dec 2017 08:59:01 -0500","from mx1.redhat.com ([209.132.183.28]:55892)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eNJB4-0008G4-Cg\n\tfor qemu-devel@nongnu.org; Fri, 08 Dec 2017 08:58:58 -0500","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 31B79A58BD;\n\tFri, 8 Dec 2017 13:58:57 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-74.ams2.redhat.com\n\t[10.36.116.74])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 72B4718A64;\n\tFri, 8 Dec 2017 13:58:50 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid F32F21138658; Fri, 8 Dec 2017 14:58:48 +0100 (CET)"],"From":"Markus Armbruster ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-21-marcandre.lureau@redhat.com>","Date":"Fri, 08 Dec 2017 14:58:48 +0100","In-Reply-To":"<20170911110623.24981-21-marcandre.lureau@redhat.com> (\n\t=?utf-8?b?Ik1hcmMtQW5kcsOp?= Lureau\"'s message of \"Mon,\n\t11 Sep 2017 \t13:05:53 +0200\")","Message-ID":"<87tvx1e2xz.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 08 Dec 2017 13:58:57 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 20/50] qapi-event: add 'if' condition to\n\tgenerated enum","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1818711,"web_url":"http://patchwork.ozlabs.org/comment/1818711/","msgid":"<87o9n9cnz3.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-12-08T14:07:28","subject":"Re: [Qemu-devel] [PATCH v3 20/50] qapi-event: add 'if' condition to\n\tgenerated enum","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Markus Armbruster writes:\n\n> Marc-André Lureau writes:\n>\n>> Add condition to QAPIEvent enum members based on the event 'if'.\n>>\n>> Signed-off-by: Marc-André Lureau \n>> ---\n>> scripts/qapi-event.py | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py\n>> index 38f4264817..60c6f7030d 100644\n>> --- a/scripts/qapi-event.py\n>> +++ b/scripts/qapi-event.py\n>> @@ -168,7 +168,7 @@ class QAPISchemaGenEventVisitor(QAPISchemaVisitor):\n>> def visit_event(self, name, info, ifcond, arg_type, boxed):\n>> self.decl += gen_event_send_decl(name, arg_type, boxed)\n>> self.defn += gen_event_send(name, arg_type, boxed)\n>> - self._event_names.append(QAPISchemaMember(name))\n>> + self._event_names.append(QAPISchemaMember(name, ifcond))\n>> \n>> \n>> (input_file, output_dir, do_c, do_h, prefix, dummy) = parse_command_line()\n>\n> No test coverage?\n\nWait! This patch has no effect, because the it merely puts the ifcond\nargument into QAPISchemaMember.ifcond. Only later patches put\nQAPISchemaMember.ifcond to use. Correct?\n\nAside: the ifcond_decorator could already be doing something with the\nargument, but I'll be hanged if I remember how that magic works.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ytZ1x0Xxkz9t7x\n\tfor ;\n\tSat, 9 Dec 2017 01:08:03 +1100 (AEDT)","from localhost ([::1]:37446 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eNJJp-0001Px-7T\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Dec 2017 09:08:01 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:39330)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eNJJU-0001MM-0c\n\tfor qemu-devel@nongnu.org; Fri, 08 Dec 2017 09:07:41 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eNJJP-0006AI-1J\n\tfor qemu-devel@nongnu.org; Fri, 08 Dec 2017 09:07:39 -0500","from mx1.redhat.com ([209.132.183.28]:38264)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eNJJO-00069t-Qm\n\tfor qemu-devel@nongnu.org; Fri, 08 Dec 2017 09:07:34 -0500","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 03D66132CD8;\n\tFri, 8 Dec 2017 14:07:34 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-74.ams2.redhat.com\n\t[10.36.116.74])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8CC2C18EED;\n\tFri, 8 Dec 2017 14:07:29 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 1DECE1138658; Fri, 8 Dec 2017 15:07:28 +0100 (CET)"],"From":"Markus Armbruster ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-21-marcandre.lureau@redhat.com>\n\t<87tvx1e2xz.fsf@dusky.pond.sub.org>","Date":"Fri, 08 Dec 2017 15:07:28 +0100","In-Reply-To":"<87tvx1e2xz.fsf@dusky.pond.sub.org> (Markus Armbruster's message\n\tof \"Fri, 08 Dec 2017 14:58:48 +0100\")","Message-ID":"<87o9n9cnz3.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tFri, 08 Dec 2017 14:07:34 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 20/50] qapi-event: add 'if' condition to\n\tgenerated enum","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1837337,"web_url":"http://patchwork.ozlabs.org/comment/1837337/","msgid":"","list_archive_url":null,"date":"2018-01-11T21:31:08","subject":"Re: [Qemu-devel] [PATCH v3 20/50] qapi-event: add 'if' condition to\n\tgenerated enum","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"Hi\n\nOn Fri, Dec 8, 2017 at 3:07 PM, Markus Armbruster wrote:\n> Markus Armbruster writes:\n>\n>> Marc-André Lureau writes:\n>>\n>>> Add condition to QAPIEvent enum members based on the event 'if'.\n>>>\n>>> Signed-off-by: Marc-André Lureau \n>>> ---\n>>> scripts/qapi-event.py | 2 +-\n>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py\n>>> index 38f4264817..60c6f7030d 100644\n>>> --- a/scripts/qapi-event.py\n>>> +++ b/scripts/qapi-event.py\n>>> @@ -168,7 +168,7 @@ class QAPISchemaGenEventVisitor(QAPISchemaVisitor):\n>>> def visit_event(self, name, info, ifcond, arg_type, boxed):\n>>> self.decl += gen_event_send_decl(name, arg_type, boxed)\n>>> self.defn += gen_event_send(name, arg_type, boxed)\n>>> - self._event_names.append(QAPISchemaMember(name))\n>>> + self._event_names.append(QAPISchemaMember(name, ifcond))\n>>>\n>>>\n>>> (input_file, output_dir, do_c, do_h, prefix, dummy) = parse_command_line()\n>>\n>> No test coverage?\n\nThere is no coverage of this change in qapi-schema-test.out since the\nevent_names enum is an implicit type created by qapi-event.py.\n\nWe verify the generated event.h still compiles ;)\n\nSeriously, if necessary we could add a specific test somehow, checking\nthe generated code further.\n\n>\n> Wait! This patch has no effect, because the it merely puts the ifcond\n> argument into QAPISchemaMember.ifcond. Only later patches put\n> QAPISchemaMember.ifcond to use. Correct?\n\nIn general, the patches were splitted this way:\n1. accept 'if' in json & verify with visitors\n2. add the #if wrapping in the generated code\n3. add negative / error tests\n\nIn v4, I merged most tests with 1.\n\n> Aside: the ifcond_decorator could already be doing something with the\n> argument, but I'll be hanged if I remember how that magic works.\n>\n\nIt's wrapping visitor methods with a ifcond argument in the previous\npatches, not used later.\n\nthanks","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RUOnGrUA\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3zHfKz1bqNz9sNr\n\tfor ;\n\tFri, 12 Jan 2018 08:35:03 +1100 (AEDT)","from localhost ([::1]:44704 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eZkV0-0005YU-Hd\n\tfor incoming@patchwork.ozlabs.org; Thu, 11 Jan 2018 16:35:01 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:48180)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eZkRL-0002eh-6G\n\tfor qemu-devel@nongnu.org; Thu, 11 Jan 2018 16:31:13 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eZkRK-0006wa-BW\n\tfor qemu-devel@nongnu.org; Thu, 11 Jan 2018 16:31:11 -0500","from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:37874)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1eZkRK-0006vp-63\n\tfor qemu-devel@nongnu.org; Thu, 11 Jan 2018 16:31:10 -0500","by mail-wm0-x230.google.com with SMTP id f140so8044488wmd.2\n\tfor ; Thu, 11 Jan 2018 13:31:10 -0800 (PST)","by 10.223.199.143 with HTTP; Thu, 11 Jan 2018 13:31:08 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=too40BYKFUpvcJ+zZbmT89cIKGfZTyC60itPc6KLIOI=;\n\tb=RUOnGrUAOLc0zDF+VeAlQZ5HYecxxpTKgomBkD9C8KCMCEyV4FLqd7JDUTKoSTkfjY\n\t+qgkAKxgcINir2/4k/4mRouSN65lbFg60c3GiGdtA0cRqxN4iOyU2W9W/j+xFIeyc99U\n\tVpWDrOB/5fpHKtY6ymhUfuMnhexSCAoWz0tSHXR7rlEJonoVRXHWrbqdP/jSIt/ElH7a\n\t4vBz+yxlkg7nrsP0u7ZMBmHkRSiGc38437DRmWl5ar/UIMFb+sb6xslkzJkICxSoi3P9\n\tjS8Vgy8Zeg6g0K2Gezo7X/SaE5/p8U022RPaZz1JJskYPSz5o6FvTPhTMNWbCrevx8HS\n\tAzfw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=too40BYKFUpvcJ+zZbmT89cIKGfZTyC60itPc6KLIOI=;\n\tb=PUfLAclUbhfx3UKXDV95IOMbampE4dVclrK7qGbq89BB//q6o3ij+d/6JKUvt0oZf5\n\tMtQQZwprZHLmPmuSLmN9enS6NsSxxZPZURk13M5uF6YRTnSTzLg7FpPnDUyokffenhu1\n\t4OqlorowLNBuTiooUFLBU+6coU39izXjFlQZQoeiFwq8a4Xfn6xrna0fi7muF+X/73BB\n\t6vLmEp38i+RDzW14dEybFTYnfTa8Qt0P/b8kQwoc/bCzbsrlgpm3NHOTd3cnEoZlQ7ys\n\tMhnnpAg28v49xY5BbOuCbvC7EJ0my/FLh1coDd5CHJ9MfhIE/Dyzq4Ymb0/gqu1tEqFY\n\tNT7A==","X-Gm-Message-State":"AKwxytedwbrZM0IqmwFxE8uSUem1fJWIpVBM8bEZPOYHAP8Gi20yR0BV\n\tK6DE5Jl7+gvXwk3JAt2b6DZHgUOGyisQrkTBkX4=","X-Google-Smtp-Source":"ACJfBot7eiHqgvEHRzK818iWbSWH7so8dJsNgd/F/6ODgZEdoW0kZ+jW7WnhyHEpzwCdy0QnBXMF+k1R3VCwACUKmSY=","X-Received":"by 10.28.24.11 with SMTP id 11mr2275430wmy.108.1515706269159;\n\tThu, 11 Jan 2018 13:31:09 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"<87o9n9cnz3.fsf@dusky.pond.sub.org>","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-21-marcandre.lureau@redhat.com>\n\t<87tvx1e2xz.fsf@dusky.pond.sub.org>\n\t<87o9n9cnz3.fsf@dusky.pond.sub.org>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Thu, 11 Jan 2018 22:31:08 +0100","Message-ID":"","To":"Markus Armbruster ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::230","Subject":"Re: [Qemu-devel] [PATCH v3 20/50] qapi-event: add 'if' condition to\n\tgenerated enum","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU , Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]