[{"id":1817934,"web_url":"http://patchwork.ozlabs.org/comment/1817934/","msgid":"<87tvx2mogj.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-12-07T17:34:36","subject":"Re: [Qemu-devel] [PATCH v3 18/50] qapi: change enum visitor to take\n\tQAPISchemaMember","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Marc-André Lureau writes:\n\n> This will allow to add and access more properties associated with enum\n> values/members, like the associated 'if' condition. We may want to\n> have a specialized type QAPISchemaEnumMember, for now this will do.\n>\n> Suggested-by: Markus Armbruster \n> Signed-off-by: Marc-André Lureau \n> ---\n> scripts/qapi.py | 40 +++++++++++++-------------\n> scripts/qapi-event.py | 2 +-\n> scripts/qapi-introspect.py | 5 ++--\n> scripts/qapi-types.py | 10 +++----\n> scripts/qapi-visit.py | 2 +-\n> scripts/qapi2texi.py | 2 +-\n> tests/qapi-schema/comments.out | 14 +++++++--\n> tests/qapi-schema/doc-good.out | 17 +++++++++--\n> tests/qapi-schema/empty.out | 9 +++++-\n> tests/qapi-schema/event-case.out | 9 +++++-\n> tests/qapi-schema/ident-with-escape.out | 9 +++++-\n> tests/qapi-schema/include-relpath.out | 14 +++++++--\n> tests/qapi-schema/include-repetition.out | 14 +++++++--\n> tests/qapi-schema/include-simple.out | 14 +++++++--\n> tests/qapi-schema/indented-expr.out | 9 +++++-\n> tests/qapi-schema/qapi-schema-test.out | 49 ++++++++++++++++++++++++++------\n> tests/qapi-schema/test-qapi.py | 17 +++++++----\n> 17 files changed, 177 insertions(+), 59 deletions(-)\n>\n> diff --git a/scripts/qapi.py b/scripts/qapi.py\n> index 074ee221a1..386a577a59 100644\n> --- a/scripts/qapi.py\n> +++ b/scripts/qapi.py\n> @@ -1039,7 +1039,7 @@ class QAPISchemaVisitor(object):\n> def visit_builtin_type(self, name, info, json_type):\n> pass\n> \n> - def visit_enum_type(self, name, info, ifcond, values, prefix):\n> + def visit_enum_type(self, name, info, ifcond, members, prefix):\n> pass\n> \n> def visit_array_type(self, name, info, ifcond, element_type):\n> @@ -1127,21 +1127,21 @@ class QAPISchemaBuiltinType(QAPISchemaType):\n> \n> \n> class QAPISchemaEnumType(QAPISchemaType):\n> - def __init__(self, name, info, doc, ifcond, values, prefix):\n> + def __init__(self, name, info, doc, ifcond, members, prefix):\n> QAPISchemaType.__init__(self, name, info, doc, ifcond)\n> - for v in values:\n> - assert isinstance(v, QAPISchemaMember)\n> - v.set_owner(name)\n> + for m in members:\n> + assert isinstance(m, QAPISchemaMember)\n> + m.set_owner(name)\n> assert prefix is None or isinstance(prefix, str)\n> - self.values = values\n> + self.members = members\n> self.prefix = prefix\n> \n> def check(self, schema):\n> seen = {}\n> - for v in self.values:\n> - v.check_clash(self.info, seen)\n> + for m in self.members:\n> + m.check_clash(self.info, seen)\n> if self.doc:\n> - self.doc.connect_member(v)\n> + self.doc.connect_member(m)\n> \n> def is_implicit(self):\n> # See QAPISchema._make_implicit_enum_type() and ._def_predefineds()\n> @@ -1151,14 +1151,14 @@ class QAPISchemaEnumType(QAPISchemaType):\n> return c_name(self.name)\n> \n> def member_names(self):\n> - return [v.name for v in self.values]\n> + return [m.name for m in self.members]\n> \n> def json_type(self):\n> return 'string'\n> \n> def visit(self, visitor):\n> visitor.visit_enum_type(self.name, self.info, self.ifcond,\n> - self.member_names(), self.prefix)\n> + self.members, self.prefix)\n> \n> \n> class QAPISchemaArrayType(QAPISchemaType):\n> @@ -1952,19 +1952,19 @@ def ifcond_decorator(func):\n> return func_wrapper\n> \n> \n> -def gen_enum_lookup(name, values, prefix=None):\n> +def gen_enum_lookup(name, members, prefix=None):\n> ret = mcgen('''\n> \n> const QEnumLookup %(c_name)s_lookup = {\n> .array = (const char *const[]) {\n> ''',\n> c_name=c_name(name))\n> - for value in values:\n> - index = c_enum_const(name, value, prefix)\n> + for m in members:\n> + index = c_enum_const(name, m.name, prefix)\n> ret += mcgen('''\n> - [%(index)s] = \"%(value)s\",\n> + [%(index)s] = \"%(name)s\",\n> ''',\n> - index=index, value=value)\n> + index=index, name=m.name)\n> \n> ret += mcgen('''\n> },\n> @@ -1975,9 +1975,9 @@ const QEnumLookup %(c_name)s_lookup = {\n> return ret\n> \n> \n> -def gen_enum(name, values, prefix=None):\n> +def gen_enum(name, members, prefix=None):\n> # append automatically generated _MAX value\n> - enum_values = values + ['_MAX']\n> + enum_members = members + [QAPISchemaMember('_MAX')]\n> \n> ret = mcgen('''\n> \n> @@ -1985,11 +1985,11 @@ typedef enum %(c_name)s {\n> ''',\n> c_name=c_name(name))\n> \n> - for value in enum_values:\n> + for m in enum_members:\n> ret += mcgen('''\n> %(c_enum)s,\n> ''',\n> - c_enum=c_enum_const(name, value, prefix))\n> + c_enum=c_enum_const(name, m.name, prefix))\n> \n> ret += mcgen('''\n> } %(c_name)s;\n> diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py\n> index bef301dfe9..38f4264817 100644\n> --- a/scripts/qapi-event.py\n> +++ b/scripts/qapi-event.py\n> @@ -168,7 +168,7 @@ class QAPISchemaGenEventVisitor(QAPISchemaVisitor):\n> def visit_event(self, name, info, ifcond, arg_type, boxed):\n> self.decl += gen_event_send_decl(name, arg_type, boxed)\n> self.defn += gen_event_send(name, arg_type, boxed)\n> - self._event_names.append(name)\n> + self._event_names.append(QAPISchemaMember(name))\n> \n> \n> (input_file, output_dir, do_c, do_h, prefix, dummy) = parse_command_line()\n> diff --git a/scripts/qapi-introspect.py b/scripts/qapi-introspect.py\n> index 69d9afc792..32a58cf879 100644\n> --- a/scripts/qapi-introspect.py\n> +++ b/scripts/qapi-introspect.py\n> @@ -151,8 +151,9 @@ const QLitObject %(c_name)s = %(c_string)s;\n> def visit_builtin_type(self, name, info, json_type):\n> self._gen_qlit(name, 'builtin', {'json-type': json_type}, None)\n> \n> - def visit_enum_type(self, name, info, ifcond, values, prefix):\n> - self._gen_qlit(name, 'enum', {'values': values}, ifcond)\n> + def visit_enum_type(self, name, info, ifcond, members, prefix):\n> + self._gen_qlit(name, 'enum',\n> + {'values': [m.name for m in members]}, ifcond)\n> \n> def visit_array_type(self, name, info, ifcond, element_type):\n> element = self._use_type(element_type)\n> diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py\n> index 789e89ff59..75c1823e44 100644\n> --- a/scripts/qapi-types.py\n> +++ b/scripts/qapi-types.py\n> @@ -203,16 +203,16 @@ class QAPISchemaGenTypeVisitor(QAPISchemaVisitor):\n> self.defn += gen_type_cleanup(name)\n> \n> @ifcond_decorator\n> - def visit_enum_type(self, name, info, ifcond, values, prefix):\n> + def visit_enum_type(self, name, info, ifcond, members, prefix):\n> # Special case for our lone builtin enum type\n> # TODO use something cleaner than existence of info\n> if not info:\n> - self._btin += gen_enum(name, values, prefix)\n> + self._btin += gen_enum(name, members, prefix)\n> if do_builtins:\n> - self.defn += gen_enum_lookup(name, values, prefix)\n> + self.defn += gen_enum_lookup(name, members, prefix)\n> else:\n> - self._fwdecl += gen_enum(name, values, prefix)\n> - self.defn += gen_enum_lookup(name, values, prefix)\n> + self._fwdecl += gen_enum(name, members, prefix)\n> + self.defn += gen_enum_lookup(name, members, prefix)\n> \n> @ifcond_decorator\n> def visit_array_type(self, name, info, ifcond, element_type):\n> diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py\n> index 4b0e005437..7e816ae98e 100644\n> --- a/scripts/qapi-visit.py\n> +++ b/scripts/qapi-visit.py\n> @@ -284,7 +284,7 @@ class QAPISchemaGenVisitVisitor(QAPISchemaVisitor):\n> self._btin = None\n> \n> @ifcond_decorator\n> - def visit_enum_type(self, name, info, ifcond, values, prefix):\n> + def visit_enum_type(self, name, info, ifcond, members, prefix):\n> # Special case for our lone builtin enum type\n> # TODO use something cleaner than existence of info\n> if not info:\n> diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py\n> index cf63cb0006..e72e7cfe0b 100755\n> --- a/scripts/qapi2texi.py\n> +++ b/scripts/qapi2texi.py\n> @@ -207,7 +207,7 @@ class QAPISchemaGenDocVisitor(qapi.QAPISchemaVisitor):\n> def visit_begin(self, schema):\n> self.out = ''\n> \n> - def visit_enum_type(self, name, info, ifcond, values, prefix):\n> + def visit_enum_type(self, name, info, ifcond, members, prefix):\n> doc = self.cur_doc\n> if self.out:\n> self.out += '\\n'\n> diff --git a/tests/qapi-schema/comments.out b/tests/qapi-schema/comments.out\n> index 17e652535c..17b493ec24 100644\n> --- a/tests/qapi-schema/comments.out\n> +++ b/tests/qapi-schema/comments.out\n> @@ -1,4 +1,14 @@\n> -enum QType ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 'qbool']\n> +enum QType\n> prefix QTYPE\n> -enum Status ['good', 'bad', 'ugly']\n> + member none:\n> + member qnull:\n> + member qnum:\n> + member qstring:\n> + member qdict:\n> + member qlist:\n> + member qbool:\n> +enum Status\n> + member good:\n> + member bad:\n> + member ugly:\n> object q_empty\n> diff --git a/tests/qapi-schema/doc-good.out b/tests/qapi-schema/doc-good.out\n> index 63ca25a8b9..0de06ce345 100644\n> --- a/tests/qapi-schema/doc-good.out\n> +++ b/tests/qapi-schema/doc-good.out\n> @@ -1,19 +1,30 @@\n> object Base\n> member base1: Enum optional=False\n> -enum Enum ['one', 'two']\n> +enum Enum\n> + member one:\n> + member two:\n> object Object\n> base Base\n> tag base1\n> case one: Variant1\n> case two: Variant2\n> -enum QType ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 'qbool']\n> +enum QType\n> prefix QTYPE\n> + member none:\n> + member qnull:\n> + member qnum:\n> + member qstring:\n> + member qdict:\n> + member qlist:\n> + member qbool:\n> object SugaredUnion\n> member type: SugaredUnionKind optional=False\n> tag type\n> case one: q_obj_Variant1-wrapper\n> case two: q_obj_Variant2-wrapper\n> -enum SugaredUnionKind ['one', 'two']\n> +enum SugaredUnionKind\n> + member one:\n> + member two:\n> object Variant1\n> member var1: str optional=False\n> object Variant2\n> diff --git a/tests/qapi-schema/empty.out b/tests/qapi-schema/empty.out\n> index 40b886ddae..9859251087 100644\n> --- a/tests/qapi-schema/empty.out\n> +++ b/tests/qapi-schema/empty.out\n> @@ -1,3 +1,10 @@\n> -enum QType ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 'qbool']\n> +enum QType\n> prefix QTYPE\n> + member none:\n> + member qnull:\n> + member qnum:\n> + member qstring:\n> + member qdict:\n> + member qlist:\n> + member qbool:\n> object q_empty\n> diff --git a/tests/qapi-schema/event-case.out b/tests/qapi-schema/event-case.out\n> index 313c0fe7be..4dccc8f61e 100644\n> --- a/tests/qapi-schema/event-case.out\n> +++ b/tests/qapi-schema/event-case.out\n> @@ -1,5 +1,12 @@\n> -enum QType ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 'qbool']\n> +enum QType\n> prefix QTYPE\n> + member none:\n> + member qnull:\n> + member qnum:\n> + member qstring:\n> + member qdict:\n> + member qlist:\n> + member qbool:\n> event oops None\n> boxed=False\n> object q_empty\n> diff --git a/tests/qapi-schema/ident-with-escape.out b/tests/qapi-schema/ident-with-escape.out\n> index b5637cb2e0..4d17bc6783 100644\n> --- a/tests/qapi-schema/ident-with-escape.out\n> +++ b/tests/qapi-schema/ident-with-escape.out\n> @@ -1,5 +1,12 @@\n> -enum QType ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 'qbool']\n> +enum QType\n> prefix QTYPE\n> + member none:\n> + member qnull:\n> + member qnum:\n> + member qstring:\n> + member qdict:\n> + member qlist:\n> + member qbool:\n> command fooA q_obj_fooA-arg -> None\n> gen=True success_response=True boxed=False\n> object q_empty\n> diff --git a/tests/qapi-schema/include-relpath.out b/tests/qapi-schema/include-relpath.out\n> index 17e652535c..17b493ec24 100644\n> --- a/tests/qapi-schema/include-relpath.out\n> +++ b/tests/qapi-schema/include-relpath.out\n> @@ -1,4 +1,14 @@\n> -enum QType ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 'qbool']\n> +enum QType\n> prefix QTYPE\n> -enum Status ['good', 'bad', 'ugly']\n> + member none:\n> + member qnull:\n> + member qnum:\n> + member qstring:\n> + member qdict:\n> + member qlist:\n> + member qbool:\n> +enum Status\n> + member good:\n> + member bad:\n> + member ugly:\n> object q_empty\n> diff --git a/tests/qapi-schema/include-repetition.out b/tests/qapi-schema/include-repetition.out\n> index 17e652535c..17b493ec24 100644\n> --- a/tests/qapi-schema/include-repetition.out\n> +++ b/tests/qapi-schema/include-repetition.out\n> @@ -1,4 +1,14 @@\n> -enum QType ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 'qbool']\n> +enum QType\n> prefix QTYPE\n> -enum Status ['good', 'bad', 'ugly']\n> + member none:\n> + member qnull:\n> + member qnum:\n> + member qstring:\n> + member qdict:\n> + member qlist:\n> + member qbool:\n> +enum Status\n> + member good:\n> + member bad:\n> + member ugly:\n> object q_empty\n> diff --git a/tests/qapi-schema/include-simple.out b/tests/qapi-schema/include-simple.out\n> index 17e652535c..17b493ec24 100644\n> --- a/tests/qapi-schema/include-simple.out\n> +++ b/tests/qapi-schema/include-simple.out\n> @@ -1,4 +1,14 @@\n> -enum QType ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 'qbool']\n> +enum QType\n> prefix QTYPE\n> -enum Status ['good', 'bad', 'ugly']\n> + member none:\n> + member qnull:\n> + member qnum:\n> + member qstring:\n> + member qdict:\n> + member qlist:\n> + member qbool:\n> +enum Status\n> + member good:\n> + member bad:\n> + member ugly:\n> object q_empty\n> diff --git a/tests/qapi-schema/indented-expr.out b/tests/qapi-schema/indented-expr.out\n> index 586795f44d..8bdc016e55 100644\n> --- a/tests/qapi-schema/indented-expr.out\n> +++ b/tests/qapi-schema/indented-expr.out\n> @@ -1,5 +1,12 @@\n> -enum QType ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 'qbool']\n> +enum QType\n> prefix QTYPE\n> + member none:\n> + member qnull:\n> + member qnum:\n> + member qstring:\n> + member qdict:\n> + member qlist:\n> + member qbool:\n> command eins None -> None\n> gen=True success_response=True boxed=False\n> object q_empty\n> diff --git a/tests/qapi-schema/qapi-schema-test.out b/tests/qapi-schema/qapi-schema-test.out\n> index fc5fd25f1b..9a7cafc269 100644\n> --- a/tests/qapi-schema/qapi-schema-test.out\n> +++ b/tests/qapi-schema/qapi-schema-test.out\n> @@ -33,7 +33,10 @@ event EVENT_F UserDefAlternate\n> object Empty1\n> object Empty2\n> base Empty1\n> -enum EnumOne ['value1', 'value2', 'value3']\n> +enum EnumOne\n> + member value1:\n> + member value2:\n> + member value3:\n> object EventStructOne\n> member struct1: UserDefOne optional=False\n> member string: str optional=False\n> @@ -42,16 +45,25 @@ object ForceArrays\n> member unused1: UserDefOneList optional=False\n> member unused2: UserDefTwoList optional=False\n> member unused3: TestStructList optional=False\n> -enum MyEnum []\n> +enum MyEnum\n> object NestedEnumsOne\n> member enum1: EnumOne optional=False\n> member enum2: EnumOne optional=True\n> member enum3: EnumOne optional=False\n> member enum4: EnumOne optional=True\n> -enum QEnumTwo ['value1', 'value2']\n> +enum QEnumTwo\n> prefix QENUM_TWO\n> -enum QType ['none', 'qnull', 'qnum', 'qstring', 'qdict', 'qlist', 'qbool']\n> + member value1:\n> + member value2:\n> +enum QType\n> prefix QTYPE\n> + member none:\n> + member qnull:\n> + member qnum:\n> + member qstring:\n> + member qdict:\n> + member qlist:\n> + member qbool:\n> alternate TestIfAlternate\n> tag type\n> case foo: int\n> @@ -60,7 +72,9 @@ alternate TestIfAlternate\n> command TestIfCmd q_obj_TestIfCmd-arg -> None\n> gen=True success_response=True boxed=False\n> if defined(TEST_IF_CMD) && defined(TEST_IF_STRUCT)\n> -enum TestIfEnum ['foo', 'bar']\n> +enum TestIfEnum\n> + member foo:\n> + member bar:\n> if defined(TEST_IF_ENUM)\n> event TestIfEvent q_obj_TestIfEvent-arg\n> boxed=False\n> @@ -73,7 +87,8 @@ object TestIfUnion\n> tag type\n> case foo: q_obj_TestStruct-wrapper\n> if defined(TEST_IF_UNION) && defined(TEST_IF_STRUCT)\n> -enum TestIfUnionKind ['foo']\n> +enum TestIfUnionKind\n> + member foo:\n> if defined(TEST_IF_UNION) && defined(TEST_IF_STRUCT)\n> object TestStruct\n> member integer: int optional=False\n> @@ -122,7 +137,21 @@ object UserDefNativeListUnion\n> case string: q_obj_strList-wrapper\n> case sizes: q_obj_sizeList-wrapper\n> case any: q_obj_anyList-wrapper\n> -enum UserDefNativeListUnionKind ['integer', 's8', 's16', 's32', 's64', 'u8', 'u16', 'u32', 'u64', 'number', 'boolean', 'string', 'sizes', 'any']\n> +enum UserDefNativeListUnionKind\n> + member integer:\n> + member s8:\n> + member s16:\n> + member s32:\n> + member s64:\n> + member u8:\n> + member u16:\n> + member u32:\n> + member u64:\n> + member number:\n> + member boolean:\n> + member string:\n> + member sizes:\n> + member any:\n> object UserDefOne\n> base UserDefZero\n> member string: str optional=False\n> @@ -159,7 +188,8 @@ alternate __org.qemu_x-Alt\n> case b: __org.qemu_x-Base\n> object __org.qemu_x-Base\n> member __org.qemu_x-member1: __org.qemu_x-Enum optional=False\n> -enum __org.qemu_x-Enum ['__org.qemu_x-value']\n> +enum __org.qemu_x-Enum\n> + member __org.qemu_x-value:\n> object __org.qemu_x-Struct\n> base __org.qemu_x-Base\n> member __org.qemu_x-member2: str optional=False\n> @@ -170,7 +200,8 @@ object __org.qemu_x-Union1\n> member type: __org.qemu_x-Union1Kind optional=False\n> tag type\n> case __org.qemu_x-branch: q_obj_str-wrapper\n> -enum __org.qemu_x-Union1Kind ['__org.qemu_x-branch']\n> +enum __org.qemu_x-Union1Kind\n> + member __org.qemu_x-branch:\n> object __org.qemu_x-Union2\n> base __org.qemu_x-Base\n> tag __org.qemu_x-member1\n> diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py\n> index 8627f978af..67c6c1ecef 100644\n> --- a/tests/qapi-schema/test-qapi.py\n> +++ b/tests/qapi-schema/test-qapi.py\n> @@ -17,19 +17,18 @@ import sys\n> \n> \n> class QAPISchemaTestVisitor(QAPISchemaVisitor):\n> - def visit_enum_type(self, name, info, ifcond, values, prefix):\n> - print 'enum %s %s' % (name, values)\n> + def visit_enum_type(self, name, info, ifcond, members, prefix):\n> + print 'enum %s' % name\n> if prefix:\n> print ' prefix %s' % prefix\n> + self._print_members(members)\n> self._print_if(ifcond)\n> \n> def visit_object_type(self, name, info, ifcond, base, members, variants):\n> print 'object %s' % name\n> if base:\n> print ' base %s' % base.name\n> - for m in members:\n> - print ' member %s: %s optional=%s' % \\\n> - (m.name, m.type.name, m.optional)\n> + self._print_members(members)\n> self._print_variants(variants)\n> self._print_if(ifcond)\n> \n> @@ -51,6 +50,14 @@ class QAPISchemaTestVisitor(QAPISchemaVisitor):\n> print ' boxed=%s' % boxed\n> self._print_if(ifcond)\n> \n> + @staticmethod\n> + def _print_members(members):\n> + for m in members:\n> + print ' member %s:' % m.name,\n> + if isinstance(m, QAPISchemaObjectTypeMember):\n> + print '%s optional=%s' % (m.type.name, m.optional),\n> + print\n> +\n> @staticmethod\n> def _print_variants(variants):\n> if variants:\n\nThe change advertized in the commit message is hard to see among all the\nother stuff going on. I think this patch should be split into three\nparts:\n\n1. Rename QAPISchemaEnumType.values and related variables to members.\n Makes sense ever since commit 93bda4dd4 changed .values from list of\n string to list of QAPISchemaMember. Obvious no-op.\n\n2. Change the visit_enum_type().\n\n3. Change test-qapi.py.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yt2gX2ZhYz9ryQ\n\tfor ;\n\tFri, 8 Dec 2017 04:35:20 +1100 (AEDT)","from localhost ([::1]:33601 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eN04s-0007U1-FN\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Dec 2017 12:35:18 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:55713)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eN04M-0007Tg-2e\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 12:34:48 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eN04I-0003iU-43\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 12:34:46 -0500","from mx1.redhat.com ([209.132.183.28]:36102)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eN04H-0003hN-R8\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 12:34:42 -0500","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F09914A6E5;\n\tThu, 7 Dec 2017 17:34:40 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-74.ams2.redhat.com\n\t[10.36.116.74])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5EF7D7D89B;\n\tThu, 7 Dec 2017 17:34:38 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid DAA571138658; Thu, 7 Dec 2017 18:34:36 +0100 (CET)"],"From":"Markus Armbruster ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-19-marcandre.lureau@redhat.com>","Date":"Thu, 07 Dec 2017 18:34:36 +0100","In-Reply-To":"<20170911110623.24981-19-marcandre.lureau@redhat.com> (\n\t=?utf-8?b?Ik1hcmMtQW5kcsOp?= Lureau\"'s message of \"Mon,\n\t11 Sep 2017 \t13:05:51 +0200\")","Message-ID":"<87tvx2mogj.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tThu, 07 Dec 2017 17:34:41 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 18/50] qapi: change enum visitor to take\n\tQAPISchemaMember","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]