[{"id":1817817,"web_url":"http://patchwork.ozlabs.org/comment/1817817/","msgid":"<87mv2uo8a9.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-12-07T15:41:02","subject":"Re: [Qemu-devel] [PATCH v3 12/50] qapi-introspect: add preprocessor\n\tconditions to generated QLit","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Marc-André Lureau writes:\n\n> Add 'ifcond' condition to top-level QLit objects.\n>\n> to_qlit() handles the (obj, ifcond) tuples in previous patch.\n>\n> Signed-off-by: Marc-André Lureau \n\nAccording to my testing, this patch adds blank lines between the\nelements of qmp_schema_qlit. I suspect this is because to_qlit((obj,\nNone) is not actually equivalent to to_qlit(obj). It should be.\n\nNote that the issue is in PATCH 11, but becomes visible only in PATCH\n12, because the new code only gets used in PATCH 12. Consider squashing\nthe two together.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yt08J64mPz9t1t\n\tfor ;\n\tFri, 8 Dec 2017 02:41:36 +1100 (AEDT)","from localhost ([::1]:32918 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eMyIo-0006HP-Qv\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Dec 2017 10:41:34 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:44301)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eMyIQ-0006H8-Ga\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 10:41:11 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eMyIN-0001EA-ER\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 10:41:10 -0500","from mx1.redhat.com ([209.132.183.28]:44060)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eMyIN-0001Cy-8n\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 10:41:07 -0500","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5BDF96A7D4;\n\tThu, 7 Dec 2017 15:41:06 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-74.ams2.redhat.com\n\t[10.36.116.74])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id B5BFB6062E;\n\tThu, 7 Dec 2017 15:41:03 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 487EC1138658; Thu, 7 Dec 2017 16:41:02 +0100 (CET)"],"From":"Markus Armbruster ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-13-marcandre.lureau@redhat.com>","Date":"Thu, 07 Dec 2017 16:41:02 +0100","In-Reply-To":"<20170911110623.24981-13-marcandre.lureau@redhat.com> (\n\t=?utf-8?b?Ik1hcmMtQW5kcsOp?= Lureau\"'s message of \"Mon,\n\t11 Sep 2017 \t13:05:45 +0200\")","Message-ID":"<87mv2uo8a9.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tThu, 07 Dec 2017 15:41:06 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 12/50] qapi-introspect: add preprocessor\n\tconditions to generated QLit","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]