[{"id":1817769,"web_url":"http://patchwork.ozlabs.org/comment/1817769/","msgid":"<87r2s6oamw.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-12-07T14:50:15","subject":"Re: [Qemu-devel] [PATCH v3 11/50] qapi-introspect: modify to_qlit()\n\tto generate #if code","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Marc-André Lureau writes:\n\n> The generator now accepts (obj, condition) tuples to wrap generated\n> QLit objects for 'obj' with #if/#endif conditions.\n>\n> Signed-off-by: Marc-André Lureau \n> ---\n> scripts/qapi-introspect.py | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/scripts/qapi-introspect.py b/scripts/qapi-introspect.py\n> index b1d08ec97b..dc70954e8a 100644\n> --- a/scripts/qapi-introspect.py\n> +++ b/scripts/qapi-introspect.py\n> @@ -17,6 +17,13 @@ def to_qlit(obj, level=0, suppress_first_indent=False):\n> def indent(level):\n> return level * 4 * ' '\n> \n> + if isinstance(obj, tuple):\n> + ifobj, ifcond = obj\n> + ret = gen_if(ifcond)\n> + ret += to_qlit(ifobj, level)\n> + ret += '\\n' + gen_endif(ifcond)\n> + return ret\n> +\n> ret = ''\n> if not suppress_first_indent:\n> ret += indent(level)\n\nReviewed-by: Markus Armbruster ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ysz1w0PPcz9t34\n\tfor ;\n\tFri, 8 Dec 2017 01:51:00 +1100 (AEDT)","from localhost ([::1]:60974 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eMxVq-0000B1-6G\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Dec 2017 09:50:58 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:59529)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eMxVH-00009W-HK\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 09:50:24 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eMxVE-0005xt-D3\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 09:50:23 -0500","from mx1.redhat.com ([209.132.183.28]:51892)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eMxVD-0005vH-Vj\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 09:50:20 -0500","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DA1D82D1ED8;\n\tThu, 7 Dec 2017 14:50:18 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-74.ams2.redhat.com\n\t[10.36.116.74])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id A6D5170100;\n\tThu, 7 Dec 2017 14:50:16 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 72C321138658; Thu, 7 Dec 2017 15:50:15 +0100 (CET)"],"From":"Markus Armbruster ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-12-marcandre.lureau@redhat.com>","Date":"Thu, 07 Dec 2017 15:50:15 +0100","In-Reply-To":"<20170911110623.24981-12-marcandre.lureau@redhat.com> (\n\t=?utf-8?b?Ik1hcmMtQW5kcsOp?= Lureau\"'s message of \"Mon,\n\t11 Sep 2017 \t13:05:44 +0200\")","Message-ID":"<87r2s6oamw.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tThu, 07 Dec 2017 14:50:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 11/50] qapi-introspect: modify to_qlit()\n\tto generate #if code","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]