[{"id":1817766,"web_url":"http://patchwork.ozlabs.org/comment/1817766/","msgid":"<87vahioarr.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-12-07T14:47:20","subject":"Re: [Qemu-devel] [PATCH v3 10/50] qapi-introspect: modify to_qlit()\n\tto append ', ' on level > 0","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Marc-André Lureau writes:\n\n> The following patch is going to break list entries with #if/#endif, so\n> they should have the trailing ',' as suffix.\n>\n> Signed-off-by: Marc-André Lureau \n> ---\n> scripts/qapi-introspect.py | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/scripts/qapi-introspect.py b/scripts/qapi-introspect.py\n> index 56c1f9d548..b1d08ec97b 100644\n> --- a/scripts/qapi-introspect.py\n> +++ b/scripts/qapi-introspect.py\n> @@ -29,7 +29,7 @@ def to_qlit(obj, level=0, suppress_first_indent=False):\n> for elt in obj]\n> elts.append(indent(level + 1) + \"{}\")\n> ret += 'QLIT_QLIST(((QLitObject[]) {\\n'\n> - ret += ',\\n'.join(elts) + '\\n'\n> + ret += '\\n'.join(elts) + '\\n'\n> ret += indent(level) + '}))'\n> elif isinstance(obj, dict):\n> elts = []\n> @@ -42,6 +42,8 @@ def to_qlit(obj, level=0, suppress_first_indent=False):\n> ret += indent(level) + '}))'\n> else:\n> assert False # not implemented\n> + if level > 0:\n> + ret += ','\n> return ret\n\nReviewed-by: Markus Armbruster ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ysz0S1cXvz9t34\n\tfor ;\n\tFri, 8 Dec 2017 01:49:39 +1100 (AEDT)","from localhost ([::1]:60964 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1eMxUV-0007hG-NE\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Dec 2017 09:49:35 -0500","from eggs.gnu.org ([2001:4830:134:3::10]:58505)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1eMxSW-0005o1-KH\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 09:47:38 -0500","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1eMxST-0002wf-Hk\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 09:47:32 -0500","from mx1.redhat.com ([209.132.183.28]:48156)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1eMxST-0002vu-BB\n\tfor qemu-devel@nongnu.org; Thu, 07 Dec 2017 09:47:29 -0500","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0A84B7EA91;\n\tThu, 7 Dec 2017 14:47:28 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-74.ams2.redhat.com\n\t[10.36.116.74])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8D94C60C4B;\n\tThu, 7 Dec 2017 14:47:21 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 1B33C1138658; Thu, 7 Dec 2017 15:47:20 +0100 (CET)"],"From":"Markus Armbruster ","To":"=?utf-8?q?Marc-Andr=C3=A9?= Lureau ","References":"<20170911110623.24981-1-marcandre.lureau@redhat.com>\n\t<20170911110623.24981-11-marcandre.lureau@redhat.com>","Date":"Thu, 07 Dec 2017 15:47:20 +0100","In-Reply-To":"<20170911110623.24981-11-marcandre.lureau@redhat.com> (\n\t=?utf-8?b?Ik1hcmMtQW5kcsOp?= Lureau\"'s message of \"Mon,\n\t11 Sep 2017 \t13:05:43 +0200\")","Message-ID":"<87vahioarr.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 07 Dec 2017 14:47:28 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 10/50] qapi-introspect: modify to_qlit()\n\tto append ', ' on level > 0","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Michael Roth ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]