[{"id":1766673,"web_url":"http://patchwork.ozlabs.org/comment/1766673/","msgid":"<CAKgLnsF7R5=be2EsBu+P+zYhx9GD-B-hA7A5ptBMw7JgCPSeAg@mail.gmail.com>","list_archive_url":null,"date":"2017-09-12T04:37:59","subject":"Re: [ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when\n\tremove rev_conn.","submitter":{"id":68060,"url":"http://patchwork.ozlabs.org/api/people/68060/","name":"Darrell Ball","email":"dlu998@gmail.com"},"content":"We cannot merge this patch.\n\nCan you provide answers to the questions I asked here\n\nhttps://mail.openvswitch.org/pipermail/ovs-discuss/2017-September/045308.html\n\nThanks Darrell\n\n\nOn Mon, Sep 11, 2017 at 2:49 AM, w00273186 <wangyunjian@huawei.com> wrote:\n\n> From: Yunjian Wang <wangyunjian@huawei.com>\n>\n> The rev_conn need will be removed, only when conn_type is\n> CT_CONN_TYPE_UN_NAT.\n> This crash will be triggered when remove conn in ct-clean thread.\n>\n> Reported-by: Lili Huang <huanglili.huang@huawei.com>\n> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>\n> ---\n>  lib/conntrack.c | 7 ++++---\n>  1 file changed, 4 insertions(+), 3 deletions(-)\n>\n> diff --git a/lib/conntrack.c b/lib/conntrack.c\n> index 419cb1d..c1adb56 100644\n> --- a/lib/conntrack.c\n> +++ b/lib/conntrack.c\n> @@ -684,9 +684,10 @@ nat_clean(struct conntrack *ct, struct conn *conn,\n>\n>      /* In the unlikely event, rev conn was recreated, then skip\n>       * rev_conn cleanup. */\n> -    if (rev_conn && (!nat_conn_key_node ||\n> -                     conn_key_cmp(&nat_conn_key_node->value,\n> -                                  &rev_conn->rev_key))) {\n> +    if (rev_conn &&\n> +        (rev_conn->conn_type == CT_CONN_TYPE_UN_NAT) &&\n> +        (!nat_conn_key_node || conn_key_cmp(&nat_conn_key_node->value,\n> +                                            &rev_conn->rev_key))) {\n>          hmap_remove(&ct->buckets[bucket_rev_conn].connections,\n>                      &rev_conn->node);\n>          free(rev_conn);\n> --\n> 1.8.3.1\n>\n>\n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev\n>","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"gCh/7/aT\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrsVQ0SgTz9s5L\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 12 Sep 2017 14:38:05 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id C44F99F0;\n\tTue, 12 Sep 2017 04:38:02 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 218BA92B\n\tfor <dev@openvswitch.org>; Tue, 12 Sep 2017 04:38:01 +0000 (UTC)","from mail-it0-f68.google.com (mail-it0-f68.google.com\n\t[209.85.214.68])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7809CA1\n\tfor <dev@openvswitch.org>; Tue, 12 Sep 2017 04:38:00 +0000 (UTC)","by mail-it0-f68.google.com with SMTP id f64so5272415itf.0\n\tfor <dev@openvswitch.org>; Mon, 11 Sep 2017 21:38:00 -0700 (PDT)","by 10.2.12.82 with HTTP; Mon, 11 Sep 2017 21:37:59 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=hlqMix9vhPqi2kwEn88wrdY0PdaX5kG6fIQ7aTZue/s=;\n\tb=gCh/7/aTlUap6XF3PMKzCSEbxYaDHRD1Lz3NnKhI2ihCE9IF7+UeEOn3CoN/0yA5Gw\n\tiC3rd2NketPG5aPk68d4n44a0V/PgMKdAumaLAuzTG1RnCZzig6Kv96HMXDL1cM+Gc8a\n\tuhma81TFKz81d3EnYFLRP4jy8uwXDdzLAJjzikAkh6ZeKkB47O+zyXLxT0t4QIls9uXZ\n\tf0+lRz1QBbJe1DNUV4OPq8lXmm8qv98blcmBf8wsKPR8C2bkJu1CZ0ooXWfpmChVzwUE\n\tFNWPM7o+s8Sn95n76fj+0Mt//MTMKaEKbPGBqR1YgjPsnxMy/1608D4xTAtMh32KslMH\n\tPoEQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=hlqMix9vhPqi2kwEn88wrdY0PdaX5kG6fIQ7aTZue/s=;\n\tb=KC/8Yk35caCqfOIjUMIQRy2beGBr8EH/tertZLUoMjJkYCa/wbGFYLCxWnBJE+uxar\n\tKCqMkGcq6CecytcHKpk3S+R4iePA8yIxE8ak7+5f0I0Fca03tuIjB/f8NgTy2dsmLLql\n\tihYqJuJEzDJm6kSq2CWVVAMtqTYku2o5FqeWDEt7hHm/3Zn2xb85b8CEBwKpxq/o3ekz\n\tx0y94xAhPdj1GeifLYdhJ9sB+7YxFBojvSLapwQkxwFbXSmkr1ACwuczCTcUr16ZwjaX\n\tqnfpwTFXtAFOm/y4Jdk3fWfo7sNl7UTM/MfU0mEeBmjYcf9XCX0h57y9UvpZCLNUZo/M\n\tlwRw==","X-Gm-Message-State":"AHPjjUjMQNN7A0tFBxAGTuqfh5RpKh4W2giWH5w+HcaEw07DwTON4zTO\n\tYryYYB5audj5qph4G5rwzvbH9p76pMKB","X-Google-Smtp-Source":"AOwi7QAIm/6hNi9SX9dDdeVpK+kazxARZRXr6cFga33ElBqAKv+ZjB3LrbHsMUdviJYCL+pprQ4YHFP86EncugRniWQ=","X-Received":"by 10.36.36.67 with SMTP id f64mr3862968ita.10.1505191079860;\n\tMon, 11 Sep 2017 21:37:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505123379-12144-1-git-send-email-wangyunjian@huawei.com>","References":"<1505123379-12144-1-git-send-email-wangyunjian@huawei.com>","From":"Darrell Ball <dlu998@gmail.com>","Date":"Mon, 11 Sep 2017 21:37:59 -0700","Message-ID":"<CAKgLnsF7R5=be2EsBu+P+zYhx9GD-B-hA7A5ptBMw7JgCPSeAg@mail.gmail.com>","To":"w00273186 <wangyunjian@huawei.com>","X-Spam-Status":"No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HTML_MESSAGE,\n\tRCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","X-Content-Filtered-By":"Mailman/MimeDel 2.1.12","Cc":"ovs dev <dev@openvswitch.org>, huanglili.huang@huawei.com, blp@ovs.org","Subject":"Re: [ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when\n\tremove rev_conn.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1774009,"web_url":"http://patchwork.ozlabs.org/comment/1774009/","msgid":"<34EFBCA9F01B0748BEB6B629CE643AE60C6454C1@dggemm513-mbx.china.huawei.com>","list_archive_url":null,"date":"2017-09-23T09:35:49","subject":"Re: [ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when\n\tremove rev_conn.","submitter":{"id":69073,"url":"http://patchwork.ozlabs.org/api/people/69073/","name":"Yunjian Wang","email":"wangyunjian@huawei.com"},"content":"We use hping3 to send random tcp, udp from VM1 to VM2. We met a issue that conn_lookup( ) will find\nrev_conn->conn_type = CT_CONN_TYPE_DEFAULT in nat_clean().\n\nIs this rev_conn->conn_type = CT_CONN_TYPE_DEFAULT ok?\n\nI think the rev_conn->conn_type need to be CT_CONN_TYPE_UN_NAT.\n\nFrom: Darrell Ball [mailto:dlu998@gmail.com]\nSent: Tuesday, September 12, 2017 12:38 PM\nTo: wangyunjian <wangyunjian@huawei.com>\nCc: ovs dev <dev@openvswitch.org>; Huanglili (lee) <huanglili.huang@huawei.com>; blp@ovs.org\nSubject: Re: [ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when remove rev_conn.\n\nWe cannot merge this patch.\n\nCan you provide answers to the questions I asked here\n\nhttps://mail.openvswitch.org/pipermail/ovs-discuss/2017-September/045308.html\n\nThanks Darrell\n\n\nOn Mon, Sep 11, 2017 at 2:49 AM, w00273186 <wangyunjian@huawei.com<mailto:wangyunjian@huawei.com>> wrote:\nFrom: Yunjian Wang <wangyunjian@huawei.com<mailto:wangyunjian@huawei.com>>\n\nThe rev_conn need will be removed, only when conn_type is CT_CONN_TYPE_UN_NAT.\nThis crash will be triggered when remove conn in ct-clean thread.\n\nReported-by: Lili Huang <huanglili.huang@huawei.com<mailto:huanglili.huang@huawei.com>>\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com<mailto:wangyunjian@huawei.com>>\n---\n lib/conntrack.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)\n\ndiff --git a/lib/conntrack.c b/lib/conntrack.c\nindex 419cb1d..c1adb56 100644\n--- a/lib/conntrack.c\n+++ b/lib/conntrack.c\n@@ -684,9 +684,10 @@ nat_clean(struct conntrack *ct, struct conn *conn,\n\n     /* In the unlikely event, rev conn was recreated, then skip\n      * rev_conn cleanup. */\n-    if (rev_conn && (!nat_conn_key_node ||\n-                     conn_key_cmp(&nat_conn_key_node->value,\n-                                  &rev_conn->rev_key))) {\n+    if (rev_conn &&\n+        (rev_conn->conn_type == CT_CONN_TYPE_UN_NAT) &&\n+        (!nat_conn_key_node || conn_key_cmp(&nat_conn_key_node->value,\n+                                            &rev_conn->rev_key))) {\n         hmap_remove(&ct->buckets[bucket_rev_conn].connections,\n                     &rev_conn->node);\n         free(rev_conn);\n--\n1.8.3.1","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzlbM2CTzz9t5Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Sep 2017 19:36:11 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 451AF87A;\n\tSat, 23 Sep 2017 09:36:07 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 9F21282\n\tfor <dev@openvswitch.org>; Sat, 23 Sep 2017 09:36:05 +0000 (UTC)","from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id B94AC3F9\n\tfor <dev@openvswitch.org>; Sat, 23 Sep 2017 09:36:03 +0000 (UTC)","from 172.30.72.55 (EHLO DGGEMM405-HUB.china.huawei.com)\n\t([172.30.72.55])\n\tby dggrg02-dlp.huawei.com (MOS 4.4.6-GA FastPath queued)\n\twith ESMTP id AVU61240; Sat, 23 Sep 2017 17:36:00 +0800 (CST)","from DGGEMM513-MBX.china.huawei.com ([169.254.1.64]) by\n\tDGGEMM405-HUB.china.huawei.com ([10.3.20.213]) with mapi id\n\t14.03.0301.000; Sat, 23 Sep 2017 17:35:50 +0800"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","From":"wangyunjian <wangyunjian@huawei.com>","To":"\"dlu998@gmail.com\" <dlu998@gmail.com>","Thread-Topic":"[ovs-dev] [PATCH] conntrack: Fix conn_type need be checked\n\twhen remove rev_conn.","Thread-Index":"AQHTKuNX13/cP5g0WkyAehpmvNsTIqKwJe+AgBHr1VA=","Date":"Sat, 23 Sep 2017 09:35:49 +0000","Message-ID":"<34EFBCA9F01B0748BEB6B629CE643AE60C6454C1@dggemm513-mbx.china.huawei.com>","References":"<1505123379-12144-1-git-send-email-wangyunjian@huawei.com>\n\t<CAKgLnsF7R5=be2EsBu+P+zYhx9GD-B-hA7A5ptBMw7JgCPSeAg@mail.gmail.com>","In-Reply-To":"<CAKgLnsF7R5=be2EsBu+P+zYhx9GD-B-hA7A5ptBMw7JgCPSeAg@mail.gmail.com>","Accept-Language":"en-US","Content-Language":"zh-CN","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.177.24.66]","MIME-Version":"1.0","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A090205.59C62B00.0069, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=169.254.1.64,\n\tso=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"8dfd0308da190ad7a0d9e8676e1556e3","X-Spam-Status":"No, score=0.0 required=5.0 tests=HTML_MESSAGE, RP_MATCHES_RCVD\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","X-Content-Filtered-By":"Mailman/MimeDel 2.1.12","Cc":"ovs dev <dev@openvswitch.org>,\n\t\"Huanglili \\(lee\\)\" <huanglili.huang@huawei.com>","Subject":"Re: [ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when\n\tremove rev_conn.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1775971,"web_url":"http://patchwork.ozlabs.org/comment/1775971/","msgid":"<163C7B17-C8F6-442E-9AD6-2031C624B988@vmware.com>","list_archive_url":null,"date":"2017-09-27T01:02:43","subject":"Re: [ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when\n\tremove rev_conn.","submitter":{"id":68212,"url":"http://patchwork.ozlabs.org/api/people/68212/","name":"Darrell Ball","email":"dball@vmware.com"},"content":"On 9/23/17, 2:36 AM, \"ovs-dev-bounces@openvswitch.org on behalf of wangyunjian\" <ovs-dev-bounces@openvswitch.org on behalf of wangyunjian@huawei.com> wrote:\r\n\r\n    We use hping3 to send random tcp, udp from VM1 to VM2. We met a issue that conn_lookup( ) will find\r\n    rev_conn->conn_type = CT_CONN_TYPE_DEFAULT in nat_clean().\r\n\r\n[Darrell] So you are sending traffic in one direction between 2 OVS ports ?\r\n               What is the associated packet src/dst IP and src/dst ports, conn key src/dst addresses, src/dst ports\r\n               and reverse conn key src/dst addresses, src/dst ports causing the problem?\r\n               Is it the TCP or UDP traffic related ?\r\n               \r\n    Is this rev_conn->conn_type = CT_CONN_TYPE_DEFAULT ok?\r\n\r\n[Darrell] I asked for information related to such a possible case, but no details were provided yet – see link below.\r\n               Furthermore, the other information provided was not consistent, as mentioned earlier.\r\n               The data would need to be from a non-instrumented version of the code.\r\n               \r\n    I think the rev_conn->conn_type need to be CT_CONN_TYPE_UN_NAT.\r\n\r\n\r\n    From: Darrell Ball [mailto:dlu998@gmail.com]\r\n    Sent: Tuesday, September 12, 2017 12:38 PM\r\n    To: wangyunjian <wangyunjian@huawei.com>\r\n    Cc: ovs dev <dev@openvswitch.org>; Huanglili (lee) <huanglili.huang@huawei.com>; blp@ovs.org\r\n    Subject: Re: [ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when remove rev_conn.\r\n    \r\n    We cannot merge this patch.\r\n    \r\n    Can you provide answers to the questions I asked here\r\n    \r\n    https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_pipermail_ovs-2Ddiscuss_2017-2DSeptember_045308.html&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=lN8LgYzgffaggReqxu_7a9QKH74RKoTbK0Faru94z7o&s=l8K4j912IB0MotzNP8RaUgLFTrO4BI9QTggLebSzhoY&e= \r\n    \r\n    Thanks Darrell\r\n    \r\n    \r\n    On Mon, Sep 11, 2017 at 2:49 AM, w00273186 <wangyunjian@huawei.com<mailto:wangyunjian@huawei.com>> wrote:\r\n    From: Yunjian Wang <wangyunjian@huawei.com<mailto:wangyunjian@huawei.com>>\r\n    \r\n    The rev_conn need will be removed, only when conn_type is CT_CONN_TYPE_UN_NAT.\r\n    This crash will be triggered when remove conn in ct-clean thread.\r\n    \r\n    Reported-by: Lili Huang <huanglili.huang@huawei.com<mailto:huanglili.huang@huawei.com>>\r\n    Signed-off-by: Yunjian Wang <wangyunjian@huawei.com<mailto:wangyunjian@huawei.com>>\r\n    ---\r\n     lib/conntrack.c | 7 ++++---\r\n     1 file changed, 4 insertions(+), 3 deletions(-)\r\n    \r\n    diff --git a/lib/conntrack.c b/lib/conntrack.c\r\n    index 419cb1d..c1adb56 100644\r\n    --- a/lib/conntrack.c\r\n    +++ b/lib/conntrack.c\r\n    @@ -684,9 +684,10 @@ nat_clean(struct conntrack *ct, struct conn *conn,\r\n    \r\n         /* In the unlikely event, rev conn was recreated, then skip\r\n          * rev_conn cleanup. */\r\n    -    if (rev_conn && (!nat_conn_key_node ||\r\n    -                     conn_key_cmp(&nat_conn_key_node->value,\r\n    -                                  &rev_conn->rev_key))) {\r\n    +    if (rev_conn &&\r\n    +        (rev_conn->conn_type == CT_CONN_TYPE_UN_NAT) &&\r\n    +        (!nat_conn_key_node || conn_key_cmp(&nat_conn_key_node->value,\r\n    +                                            &rev_conn->rev_key))) {\r\n             hmap_remove(&ct->buckets[bucket_rev_conn].connections,\r\n                         &rev_conn->node);\r\n             free(rev_conn);\r\n    --\r\n    1.8.3.1\r\n    \r\n    \r\n    _______________________________________________\r\n    dev mailing list\r\n    dev@openvswitch.org<mailto:dev@openvswitch.org>\r\n    https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=lN8LgYzgffaggReqxu_7a9QKH74RKoTbK0Faru94z7o&s=z8oNo064OLtfO_bcwjyMAq0xXydcu0oWif5YkLENYtw&e= \r\n    \r\n    _______________________________________________\r\n    dev mailing list\r\n    dev@openvswitch.org\r\n    https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=lN8LgYzgffaggReqxu_7a9QKH74RKoTbK0Faru94z7o&s=z8oNo064OLtfO_bcwjyMAq0xXydcu0oWif5YkLENYtw&e=","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"mNnS2doq\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y20175tvYz9t16\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 11:02:51 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id C25D1B2B;\n\tWed, 27 Sep 2017 01:02:47 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id A3D1EB1D\n\tfor <dev@openvswitch.org>; Wed, 27 Sep 2017 01:02:46 +0000 (UTC)","from NAM02-BL2-obe.outbound.protection.outlook.com\n\t(mail-bl2nam02on0087.outbound.protection.outlook.com [104.47.38.87])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id B0C2217E\n\tfor <dev@openvswitch.org>; Wed, 27 Sep 2017 01:02:45 +0000 (UTC)","from MWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com (10.174.175.155) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Wed, 27 Sep 2017 01:02:43 +0000","from MWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) by\n\tMWHPR05MB3406.namprd05.prod.outlook.com ([10.174.175.155]) with\n\tmapi id 15.20.0077.007; Wed, 27 Sep 2017 01:02:43 +0000"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=onevmw.onmicrosoft.com; s=selector1-vmware-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=Dv8K3LZrqiGGJ2kDlVgmkjZO8E5ZVP585cVdhmIgFtg=;\n\tb=mNnS2doq5KM5p4Tri6YQtrNPmc+MJ6nGqgtn7/vUUeXvgAPWKPriKoyGsDYbxG6ZAM8AZsverWjHo7tHpazReY2flfq2vN18VDdoE4BYzNtmjuh73IpnD4Ne45wsGKM607IKzWl6EzRDnrTwiWwRJP90oQ3v7pT6wDJpmydz0oM=","From":"Darrell Ball <dball@vmware.com>","To":"wangyunjian <wangyunjian@huawei.com>,\n\t\"dlu998@gmail.com\" <dlu998@gmail.com>","Thread-Topic":"[ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when\n\tremove rev_conn.","Thread-Index":"AQHTKuNiICjXqEh60E2X46ho7ZH/G6KwrAuAgBGc3ICABbn2AA==","Date":"Wed, 27 Sep 2017 01:02:43 +0000","Message-ID":"<163C7B17-C8F6-442E-9AD6-2031C624B988@vmware.com>","References":"<1505123379-12144-1-git-send-email-wangyunjian@huawei.com>\n\t<CAKgLnsF7R5=be2EsBu+P+zYhx9GD-B-hA7A5ptBMw7JgCPSeAg@mail.gmail.com>\n\t<34EFBCA9F01B0748BEB6B629CE643AE60C6454C1@dggemm513-mbx.china.huawei.com>","In-Reply-To":"<34EFBCA9F01B0748BEB6B629CE643AE60C6454C1@dggemm513-mbx.china.huawei.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","user-agent":"Microsoft-MacOutlook/f.26.0.170902","x-originating-ip":"[73.162.236.45]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; MWHPR05MB3406;\n\t20:TQhFyEnZBWU/4lExbkm9jj5sL6ETQUX3g0lyOA5fvs0RVP9w2DYTDFfG3le/s3+vYFSGoTcTYDrNWd+v+OUILwx0CT3M6bpWDLT2GtWxo41FT9nrQMNXy/CqFGjqFldwjH9TuuFcQSt42G4mi+dF8GOmDmDmDIxGajP8ffyBLsI=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"bedea233-cb5d-4a49-0c58-08d50543756f","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:MWHPR05MB3406; ","x-ms-traffictypediagnostic":"MWHPR05MB3406:","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=onevmw.onmicrosoft.com\n\theader.i=@onevmw.onmicrosoft.com header.b=\"mNnS2doq\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=dball@vmware.com; "],"x-exchange-antispam-report-test":"UriScan:(10436049006162)(216315784871565)(50582790962513); ","x-microsoft-antispam-prvs":"<MWHPR05MB34061E3B9AD8F6A3E085E085C8780@MWHPR05MB3406.namprd05.prod.outlook.com>","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR05MB3406; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR05MB3406; ","x-forefront-prvs":"04433051BF","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(24454002)(189002)(199003)(377454003)(99286003)(110136005)(53936002)(4326008)(58126008)(5660300001)(575784001)(83506001)(316002)(6246003)(2950100002)(66066001)(86362001)(82746002)(54906003)(102836003)(36756003)(2900100001)(53546010)(25786009)(189998001)(2501003)(39060400002)(83716003)(6116002)(3846002)(50986999)(229853002)(6306002)(478600001)(101416001)(8676002)(97736004)(6486002)(54356999)(81156014)(76176999)(77096006)(6512007)(81166006)(33656002)(8936002)(7736002)(966005)(6506006)(3280700002)(68736007)(106356001)(3660700001)(14454004)(6436002)(105586002)(2906002)(305945005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB3406;\n\tH:MWHPR05MB3406.namprd05.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: vmware.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-ID":"<1CBD99C4ADBE8E4CB899FA173C5A323A@namprd05.prod.outlook.com>","MIME-Version":"1.0","X-OriginatorOrg":"vmware.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"27 Sep 2017 01:02:43.2546\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR05MB3406","X-Spam-Status":"No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"ovs dev <dev@openvswitch.org>,\n\t\"Huanglili \\(lee\\)\" <huanglili.huang@huawei.com>","Subject":"Re: [ovs-dev] [PATCH] conntrack: Fix conn_type need be checked when\n\tremove rev_conn.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]