[{"id":1766176,"web_url":"http://patchwork.ozlabs.org/comment/1766176/","msgid":"<6cf99eb6-7b59-661a-963a-d46747d51f1f@xs4all.nl>","list_archive_url":null,"date":"2017-09-11T09:40:53","subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","submitter":{"id":723,"url":"http://patchwork.ozlabs.org/api/people/723/","name":"Hans Verkuil","email":"hverkuil@xs4all.nl"},"content":"On 09/11/2017 10:00 AM, Sakari Ailus wrote:\n> Document optional lens-focus and flash properties for the smiapp driver.\n> \n> Signed-off-by: Sakari Ailus \n\nAcked-by: Hans Verkuil \n\nRegards,\n\n\tHans\n\n> ---\n> Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/media/i2c/nokia,smia.txt b/Documentation/devicetree/bindings/media/i2c/nokia,smia.txt\n> index 855e1faf73e2..33f10a94c381 100644\n> --- a/Documentation/devicetree/bindings/media/i2c/nokia,smia.txt\n> +++ b/Documentation/devicetree/bindings/media/i2c/nokia,smia.txt\n> @@ -27,6 +27,8 @@ Optional properties\n> - nokia,nvm-size: The size of the NVM, in bytes. If the size is not given,\n> the NVM contents will not be read.\n> - reset-gpios: XSHUTDOWN GPIO\n> +- flash-leds: See ../video-interfaces.txt\n> +- lens-focus: See ../video-interfaces.txt\n> \n> \n> Endpoint node mandatory properties\n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrNGQ1wR6z9s7G\n\tfor ;\n\tMon, 11 Sep 2017 19:41:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751469AbdIKJk7 (ORCPT\n\t);\n\tMon, 11 Sep 2017 05:40:59 -0400","from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]:44167 \"EHLO\n\tlb3-smtp-cloud7.xs4all.net\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751087AbdIKJk6 (ORCPT\n\t); Mon, 11 Sep 2017 05:40:58 -0400","from [192.168.2.10] ([212.251.195.8])\n\tby smtp-cloud7.xs4all.net with ESMTPA\n\tid rLD3dI5Beb2snrLD6d6t4e; Mon, 11 Sep 2017 11:40:56 +0200"],"Subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","To":"Sakari Ailus , linux-media@vger.kernel.org","Cc":"niklas.soderlund@ragnatech.se, robh@kernel.org,\n\tlaurent.pinchart@ideasonboard.com, linux-acpi@vger.kernel.org,\n\tmika.westerberg@intel.com, devicetree@vger.kernel.org,\n\tpavel@ucw.cz, sre@kernel.org","References":"<20170911080008.21208-1-sakari.ailus@linux.intel.com>\n\t<20170911080008.21208-21-sakari.ailus@linux.intel.com>","From":"Hans Verkuil ","Message-ID":"<6cf99eb6-7b59-661a-963a-d46747d51f1f@xs4all.nl>","Date":"Mon, 11 Sep 2017 11:40:53 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170911080008.21208-21-sakari.ailus@linux.intel.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-CMAE-Envelope":"MS4wfEajx+KGSPMbh374iHkv9K1N0IZJB0DkrcWqshCKZY+DS2jMtM7P/uyR+v4fDWlTGYxVNBW/tql9SUI4sMehD/6rTQcl/fc3Yrr1Zvo42RcrO0oVOwuQ\n\tu4HnPJbEFIZT+kFVzVVsF4Xuy5AHmmu4Kt3cvENUH418FBiZawG7t1g58yENUg8hZ0zzwJswReL1k7rIupstGTwL/7jLOerTR42g50pCbwYjUXPj04UwdvdO\n\t0JwnGPlTMqPmFFqJq3tVAslfCDKqacswDvMO8FxnkvdlGrjPwU1iJ8vBn4TBW5ydnRvEs3Jdi2GLnD0f+n86yS+wyBLslc7js2h0iQ5A9FpZHjvxKkiqHZDP\n\tpmUZcJk6xhxoxMGMHUQ70e1cvkLy10oohPizFQUiZoX8ZA1DNlB1ZqL94HDuED2TL5NWGgecLi1q+1SXvKzVFUaZtsMz0j1tDRn5y7gym+RJMjmb/CtEJ0fj\n\tLDj6RAxbTYMIbg/mWLjcMt5+V7tOak46Nz0nUqkXL4nWD1TtWoy8BkH4IFeClkWUtRybL4wHYlEU9Za53rHvHgK/IFgd58KZgNMYng==","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1766227,"web_url":"http://patchwork.ozlabs.org/comment/1766227/","msgid":"<20170911111155.GA28095@amd>","list_archive_url":null,"date":"2017-09-11T11:11:56","subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","submitter":{"id":2109,"url":"http://patchwork.ozlabs.org/api/people/2109/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"On Mon 2017-09-11 11:00:04, Sakari Ailus wrote:\n> Document optional lens-focus and flash properties for the smiapp\ndriver.\n\nAcked-by: Pavel Machek ","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrQHP6QtDz9s7G\n\tfor ;\n\tMon, 11 Sep 2017 21:12:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751435AbdIKLL6 (ORCPT\n\t);\n\tMon, 11 Sep 2017 07:11:58 -0400","from atrey.karlin.mff.cuni.cz ([195.113.26.193]:54239 \"EHLO\n\tatrey.karlin.mff.cuni.cz\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751013AbdIKLL6 (ORCPT\n\t); Mon, 11 Sep 2017 07:11:58 -0400","by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid 78B38824CB; Mon, 11 Sep 2017 13:11:56 +0200 (CEST)"],"Date":"Mon, 11 Sep 2017 13:11:56 +0200","From":"Pavel Machek ","To":"Sakari Ailus ","Cc":"linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se,\n\trobh@kernel.org, hverkuil@xs4all.nl,\n\tlaurent.pinchart@ideasonboard.com, linux-acpi@vger.kernel.org,\n\tmika.westerberg@intel.com, devicetree@vger.kernel.org, sre@kernel.org","Subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","Message-ID":"<20170911111155.GA28095@amd>","References":"<20170911080008.21208-1-sakari.ailus@linux.intel.com>\n\t<20170911080008.21208-21-sakari.ailus@linux.intel.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"YiEDa0DAkWCtVeE4\"","Content-Disposition":"inline","In-Reply-To":"<20170911080008.21208-21-sakari.ailus@linux.intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1770493,"web_url":"http://patchwork.ozlabs.org/comment/1770493/","msgid":"<20170918210028.67sbpuetdh5j7wpf@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-18T21:00:28","subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Mon, Sep 11, 2017 at 11:00:04AM +0300, Sakari Ailus wrote:\n> Document optional lens-focus and flash properties for the smiapp driver.\n> \n> Signed-off-by: Sakari Ailus \n> ---\n> Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++\n> 1 file changed, 2 insertions(+)\n\nAcked-by: Rob Herring \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwz1H09Ylz9s7m\n\tfor ;\n\tTue, 19 Sep 2017 07:00:35 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751001AbdIRVAd (ORCPT\n\t);\n\tMon, 18 Sep 2017 17:00:33 -0400","from mail-io0-f194.google.com ([209.85.223.194]:35712 \"EHLO\n\tmail-io0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750974AbdIRVAc (ORCPT\n\t); Mon, 18 Sep 2017 17:00:32 -0400","by mail-io0-f194.google.com with SMTP id d16so2459495ioj.2;\n\tMon, 18 Sep 2017 14:00:32 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tn139sm1085443oig.10.2017.09.18.14.00.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 18 Sep 2017 14:00:29 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Vg9Jy4T0/NiWONIrnbCcs+vldDJdiDC6uRYNf5iT08Y=;\n\tb=tZYXGoAEVLe9i1xDxOiburPOhsS7U/62S41efCl9DVZbwW0IPzc9GSEYTGhAhqK6LZ\n\tuLg1ajyd5oB4DJaD+SRA85ocmZUAh0U1qc31mCetAqsmRjooF362pgzf1WQadAppvwv4\n\tjGJPZKFJsWr2DowTrhDTSqDa6Bp6WPB/0eFrGz5E+o8YedLLGy7cSDH4xNdmkKQrOTLE\n\tsQpKuN0FNSzuF7O+GrhB1i0jBijvmEwqLi+vXqhEL6/gkpNlueEEaR2KiDkwuLNVTyDI\n\tHML+rwFDJRHqMeY5UnZz6y6y3KmRLWSY1/uZQ/7v2W4Zne0JxP5i0AtSiKq0uySMV+Q5\n\tiwSQ==","X-Gm-Message-State":"AHPjjUid7b9SWb3M/nS7272rbPaZ7J7sLuWrRR6hRP784dLyKNkRwT03\n\tt0e57ogOAWBXww==","X-Google-Smtp-Source":"AOwi7QApjGkdstXrzAekxoM6FVCcpCP6NL/tVclJELGh7zq9UgJnwat3vhPlHld+tl5XTCf8n4Jxgw==","X-Received":"by 10.202.106.198 with SMTP id\n\tf189mr17512985oic.54.1505768430090; \n\tMon, 18 Sep 2017 14:00:30 -0700 (PDT)","Date":"Mon, 18 Sep 2017 16:00:28 -0500","From":"Rob Herring ","To":"Sakari Ailus ","Cc":"linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se,\n\thverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,\n\tlinux-acpi@vger.kernel.org, mika.westerberg@intel.com,\n\tdevicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org","Subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","Message-ID":"<20170918210028.67sbpuetdh5j7wpf@rob-hp-laptop>","References":"<20170911080008.21208-1-sakari.ailus@linux.intel.com>\n\t<20170911080008.21208-21-sakari.ailus@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170911080008.21208-21-sakari.ailus@linux.intel.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1770535,"web_url":"http://patchwork.ozlabs.org/comment/1770535/","msgid":"","list_archive_url":null,"date":"2017-09-18T21:56:22","subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","submitter":{"id":65485,"url":"http://patchwork.ozlabs.org/api/people/65485/","name":"Sakari Ailus","email":"sakari.ailus@linux.intel.com"},"content":"Hi Rob,\n\nRob Herring wrote:\n> On Mon, Sep 11, 2017 at 11:00:04AM +0300, Sakari Ailus wrote:\n>> Document optional lens-focus and flash properties for the smiapp driver.\n>>\n>> Signed-off-by: Sakari Ailus \n>> ---\n>> Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++\n>> 1 file changed, 2 insertions(+)\n>\n> Acked-by: Rob Herring \n\nThanks for the ack. There have been since a few iterations of the set, \nand the corresponding patch in v13 has minor changes to this:\n\n\n\nEssentially \"flash\" was renamed to \"flash-leds\" as the current flash \ndevices we have are all LEDs and the referencing assumes LED framework's \nways to describe LEDs. The same change is present in the patch adding \nthe property to video-interfaces.txt:\n\n","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx0Fs4q9Jz9s7m\n\tfor ;\n\tTue, 19 Sep 2017 07:56:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751524AbdIRV4a (ORCPT\n\t);\n\tMon, 18 Sep 2017 17:56:30 -0400","from mga02.intel.com ([134.134.136.20]:27210 \"EHLO mga02.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751548AbdIRV43 (ORCPT );\n\tMon, 18 Sep 2017 17:56:29 -0400","from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Sep 2017 14:56:29 -0700","from demallia-mobl2.ger.corp.intel.com (HELO [10.249.38.229])\n\t([10.249.38.229])\n\tby orsmga005.jf.intel.com with ESMTP; 18 Sep 2017 14:56:25 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,414,1500966000\"; d=\"scan'208\";a=\"150605761\"","Subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","To":"Rob Herring ","Cc":"linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se,\n\thverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,\n\tlinux-acpi@vger.kernel.org, mika.westerberg@intel.com,\n\tdevicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org","References":"<20170911080008.21208-1-sakari.ailus@linux.intel.com>\n\t<20170911080008.21208-21-sakari.ailus@linux.intel.com>\n\t<20170918210028.67sbpuetdh5j7wpf@rob-hp-laptop>","From":"Sakari Ailus ","Message-ID":"","Date":"Tue, 19 Sep 2017 00:56:22 +0300","User-Agent":"Mozilla/5.0 (X11; Linux i686 on x86_64; rv:51.0) Gecko/20100101\n\tSeaMonkey/2.48","MIME-Version":"1.0","In-Reply-To":"<20170918210028.67sbpuetdh5j7wpf@rob-hp-laptop>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1771343,"web_url":"http://patchwork.ozlabs.org/comment/1771343/","msgid":"","list_archive_url":null,"date":"2017-09-19T20:00:11","subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Mon, Sep 18, 2017 at 4:56 PM, Sakari Ailus\n wrote:\n> Hi Rob,\n>\n>\n> Rob Herring wrote:\n>>\n>> On Mon, Sep 11, 2017 at 11:00:04AM +0300, Sakari Ailus wrote:\n>>>\n>>> Document optional lens-focus and flash properties for the smiapp driver.\n>>>\n>>> Signed-off-by: Sakari Ailus \n>>> ---\n>>> Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++\n>>> 1 file changed, 2 insertions(+)\n>>\n>>\n>> Acked-by: Rob Herring \n>\n>\n> Thanks for the ack. There have been since a few iterations of the set, and\n> the corresponding patch in v13 has minor changes to this:\n\nMy review script can't deal with subject changes...\n\n> \n>\n> Essentially \"flash\" was renamed to \"flash-leds\" as the current flash devices\n> we have are all LEDs and the referencing assumes LED framework's ways to\n> describe LEDs. The same change is present in the patch adding the property\n\nSo we're kind of creating a binding that mirrors the gpio bindings\n(*-gpios) which is a bit of an oddball as all other bindings have gone\nwith a fixed property name and then a *-names property to name them.\nThe main downside to this form is a prefixed property name is harder\nto parse and validate. So perhaps we should follow the more common\npattern, but we're not really describing a h/w connection just an\nassociation. And now we also have the trigger source binding to\nassociate LEDs with device nodes, so perhaps that should be used here.\nWe shouldn't really have 2 ways to associate things in DT even if how\nthat gets handled in the kernel is different.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxYdh4bY3z9sNr\n\tfor ;\n\tWed, 20 Sep 2017 06:00:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751370AbdISUAi (ORCPT\n\t);\n\tTue, 19 Sep 2017 16:00:38 -0400","from mail.kernel.org ([198.145.29.99]:48384 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751097AbdISUAh (ORCPT );\n\tTue, 19 Sep 2017 16:00:37 -0400","from mail-qk0-f173.google.com (mail-qk0-f173.google.com\n\t[209.85.220.173])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 7150C218F8;\n\tTue, 19 Sep 2017 20:00:36 +0000 (UTC)","by mail-qk0-f173.google.com with SMTP id c69so754327qke.8;\n\tTue, 19 Sep 2017 13:00:36 -0700 (PDT)","by 10.12.209.75 with HTTP; Tue, 19 Sep 2017 13:00:11 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 7150C218F8","X-Gm-Message-State":"AHPjjUgMGW3bzy56P2cW07VxMScCyEOuFfkysIknKLDty18lyqpSLOiC\n\tEv/suLDK3Tyq/X07zbxu+apBZ/wYVEdCph5j3g==","X-Google-Smtp-Source":"AOwi7QD64wfbxFbGgNDQFqOfxVcn5Xtio6qxcJtXYNteNP65eq/4DPw76PqlldFQqlFHAX3/VvSWkpmtg/8w4RrvrmI=","X-Received":"by 10.55.78.144 with SMTP id c138mr3723381qkb.67.1505851232067; \n\tTue, 19 Sep 2017 13:00:32 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170911080008.21208-1-sakari.ailus@linux.intel.com>\n\t<20170911080008.21208-21-sakari.ailus@linux.intel.com>\n\t<20170918210028.67sbpuetdh5j7wpf@rob-hp-laptop>\n\t","From":"Rob Herring ","Date":"Tue, 19 Sep 2017 15:00:11 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","To":"Sakari Ailus ","Cc":"\"linux-media@vger.kernel.org\" ,\n\t=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tHans Verkuil , Laurent Pinchart\n\t, \"linux-acpi@vger.kernel.org\"\n\t, mika.westerberg@intel.com,\n\t\"devicetree@vger.kernel.org\" , \n\tPavel Machek , Sebastian Reichel ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1777287,"web_url":"http://patchwork.ozlabs.org/comment/1777287/","msgid":"<20170928210215.bgtsjdj6fgcrce36@kekkonen.localdomain>","list_archive_url":null,"date":"2017-09-28T21:02:15","subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","submitter":{"id":65485,"url":"http://patchwork.ozlabs.org/api/people/65485/","name":"Sakari Ailus","email":"sakari.ailus@linux.intel.com"},"content":"Hi Rob,\n\nOn Tue, Sep 19, 2017 at 03:00:11PM -0500, Rob Herring wrote:\n> On Mon, Sep 18, 2017 at 4:56 PM, Sakari Ailus\n> wrote:\n> > Hi Rob,\n> >\n> >\n> > Rob Herring wrote:\n> >>\n> >> On Mon, Sep 11, 2017 at 11:00:04AM +0300, Sakari Ailus wrote:\n> >>>\n> >>> Document optional lens-focus and flash properties for the smiapp driver.\n> >>>\n> >>> Signed-off-by: Sakari Ailus \n> >>> ---\n> >>> Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++\n> >>> 1 file changed, 2 insertions(+)\n> >>\n> >>\n> >> Acked-by: Rob Herring \n> >\n> >\n> > Thanks for the ack. There have been since a few iterations of the set, and\n> > the corresponding patch in v13 has minor changes to this:\n> \n> My review script can't deal with subject changes...\n> \n> > \n> >\n> > Essentially \"flash\" was renamed to \"flash-leds\" as the current flash devices\n> > we have are all LEDs and the referencing assumes LED framework's ways to\n> > describe LEDs. The same change is present in the patch adding the property\n> \n> So we're kind of creating a binding that mirrors the gpio bindings\n> (*-gpios) which is a bit of an oddball as all other bindings have gone\n> with a fixed property name and then a *-names property to name them.\n\nIt could be that \"flash-leds\" will remain the only one. Depending on\nwhether anyone would ever want to support a Xenon flash in which case we\ncould add a property for \"flash-xenon\" or such. Quite possibly not; LEDs\nhave improved in luminosity a lot over the recent years and aren't that far\nfrom tiny Xenon flash devices. I don't remember seeing a mobile phone less\nthan five years or so with a Xenon flash.\n\n> The main downside to this form is a prefixed property name is harder\n> to parse and validate. So perhaps we should follow the more common\n> pattern, but we're not really describing a h/w connection just an\n> association. And now we also have the trigger source binding to\n> associate LEDs with device nodes, so perhaps that should be used here.\n> We shouldn't really have 2 ways to associate things in DT even if how\n> that gets handled in the kernel is different.\n\ntrigger-sources is not really the same thing: it's present in the LED node,\nnot in the sensor to start with. The LED driver has no knowledge of the\nMedia device --- the sensor driver gains this information through the\nendpoints. The sensor driver would need to find the node which contains a\nphandle back to the sensor node.\n\nHaving this property in the sensor gives the association information\nbetween the sensor and the LED. It could be present elsewhere, e.g. the\nmaster device with DMA engines if there's no association with a sensor.\n\nSome sensors do support strobing the flash, too. The flash type (Xenon or\nLED) needs to be known to the strobe source (sensor).\n\nThe strobe wiring may not be there: the module vendors often omit that. Or\nit could be omitted on the board. That's the case with LED flashes; they\ncan mostly be triggered using I²C as well albeit less precisely.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y36Zq33thz9t32\n\tfor ;\n\tFri, 29 Sep 2017 07:02:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751345AbdI1VCY (ORCPT\n\t);\n\tThu, 28 Sep 2017 17:02:24 -0400","from mga14.intel.com ([192.55.52.115]:31655 \"EHLO mga14.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751008AbdI1VCY (ORCPT );\n\tThu, 28 Sep 2017 17:02:24 -0400","from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Sep 2017 14:02:22 -0700","from twillhal-mobl3.ger.corp.intel.com (HELO kekkonen.fi.intel.com)\n\t([10.249.40.40])\n\tby orsmga002.jf.intel.com with ESMTP; 28 Sep 2017 14:02:19 -0700","by kekkonen.fi.intel.com (Postfix, from userid 1000)\n\tid 1232E21EDE; Fri, 29 Sep 2017 00:02:16 +0300 (EEST)"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,450,1500966000\"; d=\"scan'208\";a=\"140660615\"","Date":"Fri, 29 Sep 2017 00:02:15 +0300","From":"Sakari Ailus ","To":"Rob Herring ","Cc":"\"linux-media@vger.kernel.org\" , Niklas\n\t=?iso-8859-1?q?S=F6derlund?= ,\n\tHans Verkuil , Laurent Pinchart\n\t, \"linux-acpi@vger.kernel.org\"\n\t, mika.westerberg@intel.com,\n\t\"devicetree@vger.kernel.org\" , \n\tPavel Machek , Sebastian Reichel ","Subject":"Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and\n\tflash properties","Message-ID":"<20170928210215.bgtsjdj6fgcrce36@kekkonen.localdomain>","References":"<20170911080008.21208-1-sakari.ailus@linux.intel.com>\n\t<20170911080008.21208-21-sakari.ailus@linux.intel.com>\n\t<20170918210028.67sbpuetdh5j7wpf@rob-hp-laptop>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]