[{"id":1775050,"web_url":"http://patchwork.ozlabs.org/comment/1775050/","msgid":"<20170925235000.GI15970@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-25T23:50:00","subject":"Re: [PATCH 3/3] driver core: platform: Don't read past the end of\n\t\"driver_override\" buffer","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"Greg, I assume you'll deal with this one? Just let me know if I\nshould do something with it.\n\nOn Mon, Sep 11, 2017 at 09:45:42AM +0200, Nicolai Stange wrote:\n> When printing the driver_override parameter when it is 4095 and 4094 bytes\n> long, the printing code would access invalid memory because we need count+1\n> bytes for printing.\n> \n> Reject driver_override values of these lengths in driver_override_store().\n> \n> This is in close analogy to commit 4efe874aace5 (\"PCI: Don't read past the\n> end of sysfs \"driver_override\" buffer\") from Sasha Levin.\n> \n> Fixes: 3d713e0e382e (\"driver core: platform: add device binding path 'driver_override'\")\n> Cc: stable@vger.kernel.org\t# v3.17+\n> Signed-off-by: Nicolai Stange \n> ---\n> drivers/base/platform.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/base/platform.c b/drivers/base/platform.c\n> index d1bd99271066..9045c5f3734e 100644\n> --- a/drivers/base/platform.c\n> +++ b/drivers/base/platform.c\n> @@ -868,7 +868,8 @@ static ssize_t driver_override_store(struct device *dev,\n> \tstruct platform_device *pdev = to_platform_device(dev);\n> \tchar *driver_override, *old, *cp;\n> \n> -\tif (count > PATH_MAX)\n> +\t/* We need to keep extra room for a newline */\n> +\tif (count >= (PAGE_SIZE - 1))\n> \t\treturn -EINVAL;\n> \n> \tdriver_override = kstrndup(buf, count, GFP_KERNEL);\n> -- \n> 2.13.5\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1LRd4fXcz9t2S\n\tfor ;\n\tTue, 26 Sep 2017 09:50:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S965020AbdIYXuE (ORCPT );\n\tMon, 25 Sep 2017 19:50:04 -0400","from mail.kernel.org ([198.145.29.99]:55274 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S966488AbdIYXuD (ORCPT );\n\tMon, 25 Sep 2017 19:50:03 -0400","from localhost (unknown [69.71.4.159])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 218652148C;\n\tMon, 25 Sep 2017 23:50:03 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 218652148C","Date":"Mon, 25 Sep 2017 18:50:00 -0500","From":"Bjorn Helgaas ","To":"Nicolai Stange ","Cc":"Bjorn Helgaas ,\n\tGreg Kroah-Hartman ,\n\tAdrian Salido , Sasha Levin ,\n\tlinux-kernel@vger.kernel.org, linux-pci@vger.kernel.org","Subject":"Re: [PATCH 3/3] driver core: platform: Don't read past the end of\n\t\"driver_override\" buffer","Message-ID":"<20170925235000.GI15970@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170911074542.16777-1-nstange@suse.de>\n\t<20170911074542.16777-4-nstange@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170911074542.16777-4-nstange@suse.de>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1775194,"web_url":"http://patchwork.ozlabs.org/comment/1775194/","msgid":"<20170926065119.GA6250@kroah.com>","list_archive_url":null,"date":"2017-09-26T06:51:19","subject":"Re: [PATCH 3/3] driver core: platform: Don't read past the end of\n\t\"driver_override\" buffer","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Mon, Sep 25, 2017 at 06:50:00PM -0500, Bjorn Helgaas wrote:\n> Greg, I assume you'll deal with this one? Just let me know if I\n> should do something with it.\n\nI've already applied it to my driver-core-next tree, thanks.\n\ngreg k-h","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1Wnd3XPHz9tX4\n\tfor ;\n\tTue, 26 Sep 2017 16:51:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S965540AbdIZGvM (ORCPT );\n\tTue, 26 Sep 2017 02:51:12 -0400","from mail.linuxfoundation.org ([140.211.169.12]:33708 \"EHLO\n\tmail.linuxfoundation.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S965319AbdIZGvK (ORCPT\n\t); Tue, 26 Sep 2017 02:51:10 -0400","from localhost (LFbn-1-12253-150.w90-92.abo.wanadoo.fr\n\t[90.92.67.150])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id B5FC79C;\n\tTue, 26 Sep 2017 06:51:09 +0000 (UTC)"],"Date":"Tue, 26 Sep 2017 08:51:19 +0200","From":"Greg Kroah-Hartman ","To":"Bjorn Helgaas ","Cc":"Nicolai Stange , Bjorn Helgaas ,\n\tAdrian Salido , Sasha Levin ,\n\tlinux-kernel@vger.kernel.org, linux-pci@vger.kernel.org","Subject":"Re: [PATCH 3/3] driver core: platform: Don't read past the end of\n\t\"driver_override\" buffer","Message-ID":"<20170926065119.GA6250@kroah.com>","References":"<20170911074542.16777-1-nstange@suse.de>\n\t<20170911074542.16777-4-nstange@suse.de>\n\t<20170925235000.GI15970@bhelgaas-glaptop.roam.corp.google.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170925235000.GI15970@bhelgaas-glaptop.roam.corp.google.com>","User-Agent":"Mutt/1.9.1 (2017-09-22)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]