[{"id":1767108,"web_url":"http://patchwork.ozlabs.org/comment/1767108/","msgid":"<20170912141727.im7axya5ouxxtrl4@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-12T14:17:27","subject":"Re: [PATCH] Input: add support for HiDeep touchscreen","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Mon, Sep 11, 2017 at 04:27:42PM +0900, Anthony Kim wrote:\n> The HiDeep touchscreen device is a capacitive multi-touch controller\n> mainly for multi-touch supported devices use. It use I2C interface for\n> communication to IC and provide axis X, Y, Z locations for ten finger\n> touch through input event interface to userspace.\n> \n> It support the Crimson and the Lime two type IC. They are different\n> the number of channel supported and FW size. But the working protocol\n> is same.\n> \n> Signed-off-by: Anthony Kim \n> ---\n> .../bindings/input/touchscreen/hideep.txt | 42 +\n> .../devicetree/bindings/vendor-prefixes.txt | 1 +\n\nAcked-by: Rob Herring \n\n> drivers/input/touchscreen/Kconfig | 11 +\n> drivers/input/touchscreen/Makefile | 1 +\n> drivers/input/touchscreen/hideep.c | 1274 ++++++++++++++++++++\n> 5 files changed, 1329 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/hideep.txt\n> create mode 100644 drivers/input/touchscreen/hideep.c\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs6MG54Mkz9sRm\n\tfor ;\n\tWed, 13 Sep 2017 00:17:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751476AbdILORb (ORCPT\n\t);\n\tTue, 12 Sep 2017 10:17:31 -0400","from mail-it0-f67.google.com ([209.85.214.67]:37351 \"EHLO\n\tmail-it0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751423AbdILORa (ORCPT\n\t); Tue, 12 Sep 2017 10:17:30 -0400","by mail-it0-f67.google.com with SMTP id d6so5902032itc.4;\n\tTue, 12 Sep 2017 07:17:30 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\te18sm17414041oih.38.2017.09.12.07.17.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 12 Sep 2017 07:17:28 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=qFe6YI/r1Ubfw8H+b8nHC7R7QDfBE9kSCviw7cGqGrY=;\n\tb=eBShVVPr7HGaFE02GHVKp2VtucdEBvVUSOlS4hC9q0sm9sK640Pfw3TSoQsuCPgTUh\n\t+jdMAuMqidCDWiBiDRxC7tnEf+dVswOchdum1oasHZgSe9aW55isp7750JGUN8LoDyFp\n\tHZ296MHq/nO8vdkhBTMpdQYOSJlruMH6neIOzXtoQIW+AHs6kWdzCtltmLhIe9XDAipc\n\tyE7ZmoUZoNw6TRkNvJaSBWFWDzC7lozU3E+PX+F4GFaeuBwlzLekBEw1uzvHGkWmwn1p\n\tzdULtvPCXtcYFGzbF7uqy8oxMUeqGrzC9RTMY1KOqiqsY6mzRd4Ctm8U+nryVaULkFPJ\n\tYrpg==","X-Gm-Message-State":"AHPjjUgKXZDhX+oX/wPQ/BejIWqeve+smXhuSFXtLqkdqSOaNgjMzKJD\n\t67cz0E8PCBCIfA==","X-Google-Smtp-Source":"AOwi7QC6F7HywIVMD6i36dpa9EGBoHJXmPE8byM6oAkpUbnV+zXkTJTFIYm/WpdZH83+Ku3ppthbFw==","X-Received":"by 10.202.79.68 with SMTP id d65mr13492365oib.81.1505225849528; \n\tTue, 12 Sep 2017 07:17:29 -0700 (PDT)","Date":"Tue, 12 Sep 2017 09:17:27 -0500","From":"Rob Herring ","To":"Anthony Kim ","Cc":"dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] Input: add support for HiDeep touchscreen","Message-ID":"<20170912141727.im7axya5ouxxtrl4@rob-hp-laptop>","References":"<1503392618-26853-1-git-send-email-anthony.kim@hideep.com>\n\t<1505114862-32489-1-git-send-email-anthony.kim@hideep.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1505114862-32489-1-git-send-email-anthony.kim@hideep.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767641,"web_url":"http://patchwork.ozlabs.org/comment/1767641/","msgid":"<201709131553.MqkK1W0W%fengguang.wu@intel.com>","list_archive_url":null,"date":"2017-09-13T07:50:06","subject":"Re: [PATCH] Input: add support for HiDeep touchscreen","submitter":{"id":67315,"url":"http://patchwork.ozlabs.org/api/people/67315/","name":"kernel test robot","email":"lkp@intel.com"},"content":"Hi Anthony,\n\n[auto build test WARNING on input/next]\n[also build test WARNING on v4.13 next-20170912]\n[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]\n\nurl: https://github.com/0day-ci/linux/commits/Anthony-Kim/Input-add-support-for-HiDeep-touchscreen/20170913-140147\nbase: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next\nconfig: i386-allmodconfig (attached as .config)\ncompiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901\nreproduce:\n # save the attached .config to linux build tree\n make ARCH=i386 \n\nAll warnings (new ones prefixed by >>):\n\n drivers/input/touchscreen/hideep.c: In function 'hideep_update_firmware':\n>> drivers/input/touchscreen/hideep.c:575:17: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka const unsigned int}' [-Wformat=]\n \"file size(%ld) is big more than fw memory size(%d)\",\n ^\n\nvim +575 drivers/input/touchscreen/hideep.c\n\n 558\t\n 559\tstatic int hideep_update_firmware(struct hideep_ts *ts, const char *fn)\n 560\t{\n 561\t\tint ret;\n 562\t\tint retry, retry_cnt = 3;\n 563\t\tconst struct firmware *fw_entry;\n 564\t\n 565\t\tdev_dbg(&ts->client->dev, \"enter\");\n 566\t\tret = request_firmware(&fw_entry, fn, &ts->client->dev);\n 567\t\n 568\t\tif (ret != 0) {\n 569\t\t\tdev_err(&ts->client->dev, \"request_firmware : fail(%d)\", ret);\n 570\t\t\treturn ret;\n 571\t\t}\n 572\t\n 573\t\tif (fw_entry->size > ts->fw_size) {\n 574\t\t\tdev_err(&ts->client->dev,\n > 575\t\t\t\t\"file size(%ld) is big more than fw memory size(%d)\",\n 576\t\t\t\tfw_entry->size, ts->fw_size);\n 577\t\t\trelease_firmware(fw_entry);\n 578\t\t\treturn -EFBIG;\n 579\t\t}\n 580\t\n 581\t\t/* chip specific code for flash fuse */\n 582\t\tmutex_lock(&ts->dev_mutex);\n 583\t\n 584\t\tts->dev_state = state_updating;\n 585\t\n 586\t\t/* enter program mode */\n 587\t\tret = hideep_enter_pgm(ts);\n 588\t\n 589\t\tif (ret)\n 590\t\t\treturn ret;\n 591\t\n 592\t\t/* comparing & programming each page, if the memory of specified\n 593\t\t * page is exactly same, no need to update.\n 594\t\t */\n 595\t\tfor (retry = 0; retry < retry_cnt; retry++) {\n 596\t\t\thideep_program_nvm(ts, fw_entry->data, fw_entry->size);\n 597\t\n 598\t\t\tret = hideep_verify_nvm(ts, fw_entry->data, fw_entry->size);\n 599\t\t\tif (!ret)\n 600\t\t\t\tbreak;\n 601\t\t}\n 602\t\n 603\t\tif (retry < retry_cnt)\n 604\t\t\tdev_dbg(&ts->client->dev, \"update success!!!\");\n 605\t\telse\n 606\t\t\tdev_err(&ts->client->dev, \"update failed!!!\");\n 607\t\n 608\t\tSW_RESET_IN_PGM(1000);\n 609\t\n 610\t\tts->dev_state = state_normal;\n 611\t\n 612\t\tmutex_unlock(&ts->dev_mutex);\n 613\t\n 614\t\trelease_firmware(fw_entry);\n 615\t\n 616\t\treturn ret;\n 617\t}\n 618\t\n\n---\n0-DAY kernel test infrastructure Open Source Technology Center\nhttps://lists.01.org/pipermail/kbuild-all Intel Corporation","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsYl13PdQz9sRV\n\tfor ;\n\tWed, 13 Sep 2017 17:51:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751015AbdIMHvI (ORCPT\n\t);\n\tWed, 13 Sep 2017 03:51:08 -0400","from mga11.intel.com ([192.55.52.93]:46514 \"EHLO mga11.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750737AbdIMHvH (ORCPT );\n\tWed, 13 Sep 2017 03:51:07 -0400","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Sep 2017 00:51:06 -0700","from bee.sh.intel.com (HELO bee) ([10.239.97.14])\n\tby fmsmga001.fm.intel.com with ESMTP; 13 Sep 2017 00:51:01 -0700","from kbuild by bee with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1ds2Wf-0009JA-V2; Wed, 13 Sep 2017 15:56:01 +0800"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,386,1500966000\"; \n\td=\"gz'50?scan'50,208,50\";a=\"1194561711\"","Date":"Wed, 13 Sep 2017 15:50:06 +0800","From":"kbuild test robot ","To":"Anthony Kim ","Cc":"kbuild-all@01.org, dmitry.torokhov@gmail.com, robh+dt@kernel.org,\n\tlinux-input@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Anthony Kim ","Subject":"Re: [PATCH] Input: add support for HiDeep touchscreen","Message-ID":"<201709131553.MqkK1W0W%fengguang.wu@intel.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"5vNYLRcllDrimb99\"","Content-Disposition":"inline","In-Reply-To":"<1505114862-32489-1-git-send-email-anthony.kim@hideep.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"fengguang.wu@intel.com","X-SA-Exim-Scanned":"No (on bee); SAEximRunCond expanded to false","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1767685,"web_url":"http://patchwork.ozlabs.org/comment/1767685/","msgid":"<201709131645.1eY8eUTb%fengguang.wu@intel.com>","list_archive_url":null,"date":"2017-09-13T08:51:06","subject":"Re: [PATCH] Input: add support for HiDeep touchscreen","submitter":{"id":67315,"url":"http://patchwork.ozlabs.org/api/people/67315/","name":"kernel test robot","email":"lkp@intel.com"},"content":"Hi Anthony,\n\n[auto build test WARNING on input/next]\n[also build test WARNING on v4.13 next-20170912]\n[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]\n\nurl: https://github.com/0day-ci/linux/commits/Anthony-Kim/Input-add-support-for-HiDeep-touchscreen/20170913-140147\nbase: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next\nconfig: m68k-allmodconfig (attached as .config)\ncompiler: m68k-linux-gcc (GCC) 4.9.0\nreproduce:\n wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross\n chmod +x ~/bin/make.cross\n # save the attached .config to linux build tree\n make.cross ARCH=m68k \n\nAll warnings (new ones prefixed by >>):\n\n drivers/input/touchscreen/hideep.c: In function 'hideep_update_firmware':\n>> drivers/input/touchscreen/hideep.c:576:4: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' [-Wformat=]\n fw_entry->size, ts->fw_size);\n ^\n\nvim +576 drivers/input/touchscreen/hideep.c\n\n 558\t\n 559\tstatic int hideep_update_firmware(struct hideep_ts *ts, const char *fn)\n 560\t{\n 561\t\tint ret;\n 562\t\tint retry, retry_cnt = 3;\n 563\t\tconst struct firmware *fw_entry;\n 564\t\n 565\t\tdev_dbg(&ts->client->dev, \"enter\");\n 566\t\tret = request_firmware(&fw_entry, fn, &ts->client->dev);\n 567\t\n 568\t\tif (ret != 0) {\n 569\t\t\tdev_err(&ts->client->dev, \"request_firmware : fail(%d)\", ret);\n 570\t\t\treturn ret;\n 571\t\t}\n 572\t\n 573\t\tif (fw_entry->size > ts->fw_size) {\n 574\t\t\tdev_err(&ts->client->dev,\n 575\t\t\t\t\"file size(%ld) is big more than fw memory size(%d)\",\n > 576\t\t\t\tfw_entry->size, ts->fw_size);\n 577\t\t\trelease_firmware(fw_entry);\n 578\t\t\treturn -EFBIG;\n 579\t\t}\n 580\t\n 581\t\t/* chip specific code for flash fuse */\n 582\t\tmutex_lock(&ts->dev_mutex);\n 583\t\n 584\t\tts->dev_state = state_updating;\n 585\t\n 586\t\t/* enter program mode */\n 587\t\tret = hideep_enter_pgm(ts);\n 588\t\n 589\t\tif (ret)\n 590\t\t\treturn ret;\n 591\t\n 592\t\t/* comparing & programming each page, if the memory of specified\n 593\t\t * page is exactly same, no need to update.\n 594\t\t */\n 595\t\tfor (retry = 0; retry < retry_cnt; retry++) {\n 596\t\t\thideep_program_nvm(ts, fw_entry->data, fw_entry->size);\n 597\t\n 598\t\t\tret = hideep_verify_nvm(ts, fw_entry->data, fw_entry->size);\n 599\t\t\tif (!ret)\n 600\t\t\t\tbreak;\n 601\t\t}\n 602\t\n 603\t\tif (retry < retry_cnt)\n 604\t\t\tdev_dbg(&ts->client->dev, \"update success!!!\");\n 605\t\telse\n 606\t\t\tdev_err(&ts->client->dev, \"update failed!!!\");\n 607\t\n 608\t\tSW_RESET_IN_PGM(1000);\n 609\t\n 610\t\tts->dev_state = state_normal;\n 611\t\n 612\t\tmutex_unlock(&ts->dev_mutex);\n 613\t\n 614\t\trelease_firmware(fw_entry);\n 615\t\n 616\t\treturn ret;\n 617\t}\n 618\t\n\n---\n0-DAY kernel test infrastructure Open Source Technology Center\nhttps://lists.01.org/pipermail/kbuild-all Intel Corporation","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsb5R3tvlz9sNr\n\tfor ;\n\tWed, 13 Sep 2017 18:52:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751692AbdIMIwL (ORCPT\n\t);\n\tWed, 13 Sep 2017 04:52:11 -0400","from mga09.intel.com ([134.134.136.24]:29589 \"EHLO mga09.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750776AbdIMIwK (ORCPT );\n\tWed, 13 Sep 2017 04:52:10 -0400","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Sep 2017 01:52:08 -0700","from bee.sh.intel.com (HELO bee) ([10.239.97.14])\n\tby FMSMGA003.fm.intel.com with ESMTP; 13 Sep 2017 01:52:06 -0700","from kbuild by bee with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1ds3Tm-0001WE-J7; Wed, 13 Sep 2017 16:57:06 +0800"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,386,1500966000\"; \n\td=\"gz'50?scan'50,208,50\";a=\"899786592\"","Date":"Wed, 13 Sep 2017 16:51:06 +0800","From":"kbuild test robot ","To":"Anthony Kim ","Cc":"kbuild-all@01.org, dmitry.torokhov@gmail.com, robh+dt@kernel.org,\n\tlinux-input@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Anthony Kim ","Subject":"Re: [PATCH] Input: add support for HiDeep touchscreen","Message-ID":"<201709131645.1eY8eUTb%fengguang.wu@intel.com>","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"nFreZHaLTZJo0R7j\"","Content-Disposition":"inline","In-Reply-To":"<1505114862-32489-1-git-send-email-anthony.kim@hideep.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"fengguang.wu@intel.com","X-SA-Exim-Scanned":"No (on bee); SAEximRunCond expanded to false","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]