[{"id":1767087,"web_url":"http://patchwork.ozlabs.org/comment/1767087/","msgid":"","list_archive_url":null,"date":"2017-09-12T13:59:57","subject":"Re: [PATCH] pinctrl/amd: save pin registers over suspend/resume","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Mon, Sep 11, 2017 at 8:11 AM, Daniel Drake wrote:\n\n> The touchpad in the Asus laptop models X505BA/BP and X542BA/BP is\n> unresponsive after suspend/resume. The following error appears during\n> resume:\n>\n> i2c_hid i2c-ELAN1300:00: failed to reset device.\n>\n> The problem here is that i2c_hid does not notice the interrupt being\n> generated at this point, because the GPIO is no longer configured\n> for interrupts.\n>\n> Fix this by saving pinctrl-amd pin registers during suspend and\n> restoring them at resume time.\n>\n> Based on code from pinctrl-intel.\n>\n> Signed-off-by: Daniel Drake \n\nExcellent analysis and patch.\n\nApplied for fixes and tagged for stable.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"asmeVLta\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs5yn0P9mz9s7B\n\tfor ;\n\tWed, 13 Sep 2017 00:00:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751370AbdILN77 (ORCPT );\n\tTue, 12 Sep 2017 09:59:59 -0400","from mail-it0-f54.google.com ([209.85.214.54]:43707 \"EHLO\n\tmail-it0-f54.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751337AbdILN77 (ORCPT\n\t); Tue, 12 Sep 2017 09:59:59 -0400","by mail-it0-f54.google.com with SMTP id g142so16223634ita.0\n\tfor ;\n\tTue, 12 Sep 2017 06:59:58 -0700 (PDT)","by 10.79.164.78 with HTTP; Tue, 12 Sep 2017 06:59:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=gNuhnJxgsHBbhlT+Llvu289Hk1kuooEGEsuJp9wBL3I=;\n\tb=asmeVLtaPi79lMXwsi3PDqtABnKjGwL+VukWOYd09lraI7Wy7IgQz9fKX4eXFnapxn\n\tpNg712u0FkCYgtK20uJ5BWzjybW2V59uflRq449gbDOnk7hkF1Bo/cHdrgcfPNXA/6PZ\n\tdkhZ3GJajC0SuuITXfln5/qlwZ1w3eNPt8+Wc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=gNuhnJxgsHBbhlT+Llvu289Hk1kuooEGEsuJp9wBL3I=;\n\tb=boUwTY9ZUmGsZMzDREiCKIZxKtVs5yPcfrrkhnoew+5G+L6ZQR569vD1aridw7ZxgN\n\t1I/Y+8iU6K5BUOX6nYkPxSI22Whxw0A6ZRWNnoXrXjaMgEZkaSKJDAFIaDoYmbG1ZR/V\n\tpzHsqjHvRJhV6P7vaNYLHmrQHNpBUz47Iqii1zTiWQNRFaMxSwGfio24mT7aDbwbPeai\n\tAS1gd51csldZC3JJ9yui1XveviaN5iSWd0Gy7x8MukeVCDaGl8DvrWJSudDca45dMCgL\n\toyuiqLG4Pqh+wbYvhhTrfv2AvuK/QKeh8dhIGI031o8bGWE45k7UTSFkkJt8WYcO/lEc\n\t6EFA==","X-Gm-Message-State":"AHPjjUi89aziP0j9goMmp5krnzeebyctFGaHFyT80MFOv+NOd2vvJZoS\n\t+fGobLOI1BSvKrUepZouJR+NJxfj+fk+ivmzEPRqCw==","X-Google-Smtp-Source":"AOwi7QCDJ8G6wnVYmqp+QlRlWi36advvyTvmTaODY2sV6trgxJ5glQydrRLiS/qL8+08VDiDKGSIz8E+t/vhNo1AJwg=","X-Received":"by 10.36.123.200 with SMTP id q191mr1124711itc.83.1505224798631; \n\tTue, 12 Sep 2017 06:59:58 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170911061156.31872-1-drake@endlessm.com>","References":"<20170911061156.31872-1-drake@endlessm.com>","From":"Linus Walleij ","Date":"Tue, 12 Sep 2017 15:59:57 +0200","Message-ID":"","Subject":"Re: [PATCH] pinctrl/amd: save pin registers over suspend/resume","To":"Daniel Drake ","Cc":"\"linux-gpio@vger.kernel.org\" ,\n\t\"Shah, Nehal-bakulchandra\" ,\n\t\"S-k, Shyam-sundar\" , linux@endlessm.com","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]