[{"id":1766046,"web_url":"http://patchwork.ozlabs.org/comment/1766046/","msgid":"","list_archive_url":null,"date":"2017-09-11T05:18:01","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":9527,"url":"http://patchwork.ozlabs.org/api/people/9527/","name":"Stefan Weil","email":"sw@weilnetz.de"},"content":"Am 11.09.2017 um 04:28 schrieb Philippe Mathieu-Daudé:\n> changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter:\n> \n> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror]\n> static bool tcg_out_ldst_finalize(TCGContext *s);\n> ^\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n> ---\n> see https://travis-ci.org/qemu/qemu/jobs/273351287\n> \n> tcg/tci/tcg-target.h | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h\n> index 5d692e1f4b..26140d78cb 100644\n> --- a/tcg/tci/tcg-target.h\n> +++ b/tcg/tci/tcg-target.h\n> @@ -206,8 +206,4 @@ static inline void tb_target_set_jmp_target(uintptr_t tc_ptr,\n> /* no need to flush icache explicitly */\n> }\n> \n> -#ifdef CONFIG_SOFTMMU\n> -#define TCG_TARGET_NEED_LDST_LABELS\n> -#endif\n> -\n> #endif /* TCG_TARGET_H */\n> \n\nReviewed-by: Stefan Weil \n\nThank you.\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrGRW5jt7z9s81\n\tfor ;\n\tMon, 11 Sep 2017 15:18:30 +1000 (AEST)","from localhost ([::1]:55489 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drH76-00066G-5N\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 01:18:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37755)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drH6l-00064t-Lr\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 01:18:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drH6i-0008JN-GC\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 01:18:07 -0400","from mail.weilnetz.de ([37.120.169.71]:43556\n\thelo=v2201612906741603.powersrv.de)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drH6i-0008Io-9h\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 01:18:04 -0400","from localhost (localhost [127.0.0.1])\n\tby v2201612906741603.powersrv.de (Postfix) with ESMTP id B5A68DA789B; \n\tMon, 11 Sep 2017 07:18:02 +0200 (CEST)","from v2201612906741603.powersrv.de ([127.0.0.1])\n\tby localhost (v2201612906741603.powersrv.de [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id QDwW_lLLD-TN; Mon, 11 Sep 2017 07:18:01 +0200 (CEST)","from edv32.bib.uni-mannheim.de (pD9E01FFC.dip0.t-ipconnect.de\n\t[217.224.31.252])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby v2201612906741603.powersrv.de (Postfix) with ESMTPSA id\n\tB2E16DA788D; Mon, 11 Sep 2017 07:18:01 +0200 (CEST)"],"X-Virus-Scanned":"Debian amavisd-new at v2201612906741603.powersrv.de","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tRichard Henderson , Paolo Bonzini ","References":"<20170911022839.23231-1-f4bug@amsat.org>","From":"Stefan Weil ","Message-ID":"","Date":"Mon, 11 Sep 2017 07:18:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911022839.23231-1-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"de-DE","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"37.120.169.71","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766441,"web_url":"http://patchwork.ozlabs.org/comment/1766441/","msgid":"<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>","list_archive_url":null,"date":"2017-09-11T18:01:10","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/10/2017 07:28 PM, Philippe Mathieu-Daudé wrote:\n> changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter:\n> \n> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror]\n> static bool tcg_out_ldst_finalize(TCGContext *s);\n> ^\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n\nOops.\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"C9ik48hW\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrbkF1BDqz9s76\n\tfor ;\n\tTue, 12 Sep 2017 04:17:25 +1000 (AEST)","from localhost ([::1]:59690 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drTGr-00019J-Rw\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 14:17:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53882)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drT1M-0003Iv-8L\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:01:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drT1I-0000Y6-DO\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:01:20 -0400","from mail-pg0-x232.google.com ([2607:f8b0:400e:c05::232]:33416)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1drT1I-0000WH-7e\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:01:16 -0400","by mail-pg0-x232.google.com with SMTP id u18so7119pgo.0\n\tfor ; Mon, 11 Sep 2017 11:01:14 -0700 (PDT)","from bigtime.twiddle.net (97-126-103-167.tukw.qwest.net.\n\t[97.126.103.167]) by smtp.gmail.com with ESMTPSA id\n\th186sm17003581pge.72.2017.09.11.11.01.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 11:01:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=uvPTUp9BeLt1wRQhxkPp+ujsdb43hQEV+V0RP5JVy/4=;\n\tb=C9ik48hWTprtFL0uGV6Uwx87PLIwRPZFG7Q61ntgyUT7LV01b9pZs2Z6iVcJA+DT/C\n\tozExul/9b2wGOTZ8wCD5+lc2n1pqmwLyOgDySjH+/jbBm9PUpLN1+025RfqldT65U44c\n\tzWzD9fvDu3wwQwCAehZMnu7GXJn9FKRV7Cjw8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=uvPTUp9BeLt1wRQhxkPp+ujsdb43hQEV+V0RP5JVy/4=;\n\tb=ANh74cbK37DqJGm2yLle1oz95btKxZrL3t4lZnKlqM7PNJTLHXds91jB5lLDh7bDV6\n\tdU3oA1GssMposJsiGLgP7gQ0shMUYhTzpPuW0dm4r6ZzqM++J/naafJqSeVczQhoHrQ5\n\ta1p5fjFkzWuCEiUXN2XY65Ugr+lM3im5oTDZ7KbaozyCmTIKRvOLbqfrbDQHCDjzdrUw\n\tG6SW4Wqx7A0iF4JWDXO2VDinghKCED25zaiNlZuV6GBC8M2plMeEVX9px/KNww01R1yW\n\tdJvexaui0eoAcYotyoHoXBRd/vq9KdO6hAtDDCdiyq5S/nDrjGAqhCs0deZMt13Bn4Fg\n\t60IA==","X-Gm-Message-State":"AHPjjUhrwQW2P9xnsXm8QXdG+OZcmYpsIzHndwttm/jC9qWVy3JtiBzA\n\tgYG5Jc1v8Xw3GxZ1CzNq4A==","X-Google-Smtp-Source":"ADKCNb4E+k6ElbqHlPKIwu+i+Stzmdwods+qE1ko2HTA2sraCOZwCyA9ld/fpVpQHiLMX8Vo4YatBg==","X-Received":"by 10.84.238.194 with SMTP id l2mr14630134pln.319.1505152873509; \n\tMon, 11 Sep 2017 11:01:13 -0700 (PDT)","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tRichard Henderson ,\n\tPaolo Bonzini , \tStefan Weil ","References":"<20170911022839.23231-1-f4bug@amsat.org>","From":"Richard Henderson ","Message-ID":"<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>","Date":"Mon, 11 Sep 2017 11:01:10 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911022839.23231-1-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::232","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766446,"web_url":"http://patchwork.ozlabs.org/comment/1766446/","msgid":"","list_archive_url":null,"date":"2017-09-11T18:13:14","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/10/2017 11:28 PM, Philippe Mathieu-Daudé wrote:\n> changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter:\n> \n> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror]\n> static bool tcg_out_ldst_finalize(TCGContext *s);\n> ^\n> \n> Signed-off-by: Philippe Mathieu-Daudé \n\nI'm not sure I can sign for Jincheng, but since his patch has the same \ncontent you could add:\n\nSigned-off-by: Jincheng Miao \n\n(https://patchwork.kernel.org/patch/9947709/)\n\n> ---\n> see https://travis-ci.org/qemu/qemu/jobs/273351287\n> \n> tcg/tci/tcg-target.h | 4 ----\n> 1 file changed, 4 deletions(-)\n> \n> diff --git a/tcg/tci/tcg-target.h b/tcg/tci/tcg-target.h\n> index 5d692e1f4b..26140d78cb 100644\n> --- a/tcg/tci/tcg-target.h\n> +++ b/tcg/tci/tcg-target.h\n> @@ -206,8 +206,4 @@ static inline void tb_target_set_jmp_target(uintptr_t tc_ptr,\n> /* no need to flush icache explicitly */\n> }\n> \n> -#ifdef CONFIG_SOFTMMU\n> -#define TCG_TARGET_NEED_LDST_LABELS\n> -#endif\n> -\n> #endif /* TCG_TARGET_H */\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"T4Pi70Vt\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrbqK3hgFz9s7F\n\tfor ;\n\tTue, 12 Sep 2017 04:21:49 +1000 (AEST)","from localhost ([::1]:59748 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drTL9-0005cY-I0\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 14:21:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59542)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1drTD2-00061p-1i\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:13:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1drTCy-0001G6-RI\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:13:24 -0400","from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:38144)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1drTCy-0001Ev-Ml\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:13:20 -0400","by mail-qk0-x243.google.com with SMTP id c69so5878625qke.5\n\tfor ; Mon, 11 Sep 2017 11:13:19 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tc38sm6644343qtc.18.2017.09.11.11.13.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 11:13:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=lp+/z0GkLnI6Z/vTBYJRsWRReSdwygmQB5B1sGh68X0=;\n\tb=T4Pi70VtI/UboFZSYvYOcKt9Crp4L0Ug98WcaDoOQRGEeqh1M0n4dIzVWB+yHDP0DD\n\tDez7PyA9v0jqMH1CQmSlx+oOts+yIvYctXZjOGm5fusHCc8Rl++LXjpdtXgTt/uLdfMK\n\tHXKvxGvtZHVlpo9miE3Eodsbg3NRy48PTBfv2bo310KIFcAeyt33B9FM61sK1jRiypJO\n\tsPsuddnnwSRr6W8IlnOO4O8Fdg9D9s8BOLkcNWcuOV9lwaOYlMabtcyDwDmm8gpachmk\n\tnwIkIDTfyUEtzh/NBpQaheklqX44gyZF+bqDUvPg/YD6WCnTpcIm8B731OTlmJcs7cmc\n\th/pw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=lp+/z0GkLnI6Z/vTBYJRsWRReSdwygmQB5B1sGh68X0=;\n\tb=Tt8qtHsRMxwjhK08aGHE8u/0jjjkA4a0t8HNU4bWG2FNNrYyZxcpTTxdxv5RIywPlg\n\tGY0bd1gB4K2PKPDXapwEwl8iIDnqAF2dgjD8ZmXi6mA8Ea1Alm0Y/CTax9g5v1+8IQNi\n\tsarUxMHb9/Tw+U6gcXInfiOX020sWjMxuWEqHTy1vj+BZ6rRYhvQx7oWPqOKXk/vPRXX\n\tQujyfNfir7xlXFzupD7bOXmmpqjqra4k5nWUhkK2eQ+tgY0KySvIXkZGfwiY0z7ZusRM\n\tbebKcA+ilv5i55BU8XtBOOOLN/0xMWmE/k6A3UQIiORLHk1wlkMQbxSHt/NEzluMfM6d\n\tPqAQ==","X-Gm-Message-State":"AHPjjUiR+4OvPxvf+WRjtZTimyb7rcUi/k9P2myYgvrBBhelZg4kkdPS\n\twRBG7xNbh+tnv7VTrW8=","X-Google-Smtp-Source":"AOwi7QB/azjUI5tCQZtiGF7Yb3lCykZ68lzZoF0+5oxMW7ewMvy2nh5PR/lil4QCRW2Ubk4fWBp0MQ==","X-Received":"by 10.55.74.72 with SMTP id x69mr15850209qka.84.1505153598787;\n\tMon, 11 Sep 2017 11:13:18 -0700 (PDT)","To":"Peter Maydell ","References":"<20170911022839.23231-1-f4bug@amsat.org>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Mon, 11 Sep 2017 15:13:14 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911022839.23231-1-f4bug@amsat.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::243","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , Stefan Weil ,\n\tqemu-devel@nongnu.org, Richard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766447,"web_url":"http://patchwork.ozlabs.org/comment/1766447/","msgid":"","list_archive_url":null,"date":"2017-09-11T18:14:33","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 11 September 2017 at 19:13, Philippe Mathieu-Daudé wrote:\n> On 09/10/2017 11:28 PM, Philippe Mathieu-Daudé wrote:\n>>\n>> changed in 659ef5cbb893, this fixes building with\n>> --enable-tcg-interpreter:\n>>\n>> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error:\n>> ‘tcg_out_ldst_finalize’ used but never defined [-Werror]\n>> static bool tcg_out_ldst_finalize(TCGContext *s);\n>> ^\n>>\n>> Signed-off-by: Philippe Mathieu-Daudé \n>\n>\n> I'm not sure I can sign for Jincheng, but since his patch has the same\n> content you could add:\n>\n> Signed-off-by: Jincheng Miao \n\nIn that sort of case we generally just say \"first person's\npatch won\". Extra signed-off-by tags are for where there's\nreally multiple peoples' work in the patch.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ELrfaUAq\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrbtP5ckzz9s76\n\tfor ;\n\tTue, 12 Sep 2017 04:24:29 +1000 (AEST)","from localhost ([::1]:59768 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drTNj-00087u-E7\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 14:24:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60603)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drTEW-0007dr-5Z\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:15:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drTEV-0002jQ-8z\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:14:56 -0400","from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:46779)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1drTEV-0002ih-2V\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:14:55 -0400","by mail-wm0-x22c.google.com with SMTP id i189so46083788wmf.1\n\tfor ; Mon, 11 Sep 2017 11:14:55 -0700 (PDT)","by 10.223.139.215 with HTTP; Mon, 11 Sep 2017 11:14:33 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=7KYsx+mweVpA68Vb7JaxDL++xdXPQq8xulNwTsX2zis=;\n\tb=ELrfaUAqyiak3HnQ6ZW9EgLN2VUFgaV0oY1wfg857v0h6iNId1X+whhbC9uNhAPZDG\n\t+EdcIfBT+IbFg/6Voo5EK2dD/sm/53H0wWGVk18oZpU5jFr6NuaxovsecabCZb4YbEqn\n\tJUG4jjJSY3CTFMCwBg4Xh3+q7UTfQhISSPBXg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=7KYsx+mweVpA68Vb7JaxDL++xdXPQq8xulNwTsX2zis=;\n\tb=qmlytkbwe81KltDr76LOvPK0QwIpYuiZ7npzkXH7yOK7vlIkayRf12mVxP9Yu4pLzF\n\tWXLAoKWtiq5TirIzpVip7if/gcv361sXolBpyxIKK5c+OPH0AS5LfsBhHNjVD05asIGw\n\tbcYodplnu45dt1MpCJvbkj+heUDGPB50jf8wUKMBLihr77Tm7BQseBp5AkwkJn3Chb4Z\n\t5UA45Ds2xG/qCu16i+YuASlmno5MDvS8Wd3kBwn0+ifytA+1mvDOVSNBYuHerGWaYh5u\n\tDRgqfGnmJIxGTM4HG1ByMC7v4n0iSXGadbPe4HtwiFeLLQ9yvfYCTJKYnFgnw6KoOP0Z\n\tMf8w==","X-Gm-Message-State":"AHPjjUhyrjoLP7Cn1tzcpJ+lKRdlYN9YMes5V4dQTkpOZsc7xK5Co4jR\n\tkepP7NrlOTBkMEkSzTBJQjRFSC7xsEmG","X-Google-Smtp-Source":"AOwi7QBOpoMaWUgNkDUVvRFPZ/I+pa5ikQV8KDcGEek6TK4MBeCdumBlr4MIalnAgk1zL6neqHsoYHt14e+5S2x6RJ0=","X-Received":"by 10.28.52.81 with SMTP id b78mr7529618wma.11.1505153694054;\n\tMon, 11 Sep 2017 11:14:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t","From":"Peter Maydell ","Date":"Mon, 11 Sep 2017 19:14:33 +0100","Message-ID":"","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::22c","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini , Stefan Weil ,\n\tQEMU Developers ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766451,"web_url":"http://patchwork.ozlabs.org/comment/1766451/","msgid":"","list_archive_url":null,"date":"2017-09-11T18:24:51","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 11 September 2017 at 19:01, Richard Henderson\n wrote:\n> On 09/10/2017 07:28 PM, Philippe Mathieu-Daudé wrote:\n>> changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter:\n>>\n>> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror]\n>> static bool tcg_out_ldst_finalize(TCGContext *s);\n>> ^\n>>\n>> Signed-off-by: Philippe Mathieu-Daudé \n>\n> Oops.\n>\n> Reviewed-by: Richard Henderson \n\nApplied to master as a buildfix, thanks.\n\nI've also turned on a tci compile check on my pre-merge tests.\n(It doesn't pass \"make check\" for me, though...)\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"U2yJIMea\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrc0Y6T9sz9sPr\n\tfor ;\n\tTue, 12 Sep 2017 04:29:49 +1000 (AEST)","from localhost ([::1]:59843 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drTSt-0004en-QI\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 14:29:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36895)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drTOT-00012B-VP\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:25:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drTOT-00069y-5t\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:25:13 -0400","from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:45947)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1drTOS-00069L-Vo\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 14:25:13 -0400","by mail-wm0-x235.google.com with SMTP id f199so46286349wme.0\n\tfor ; Mon, 11 Sep 2017 11:25:12 -0700 (PDT)","by 10.223.139.215 with HTTP; Mon, 11 Sep 2017 11:24:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=Hc1k9TvkTMLo/xeB0yKY9KHm/46Sfk99dn5YFwwLS2k=;\n\tb=U2yJIMeazhCNhxvyM7uRTPUQunAOvr9MTcUfcaK+MZoys1YrYTNMgZhgAKephlGmhz\n\tEsxhuhY1vTzC7vfEn5/h++5JtNdvFOo5GG4zZ6ADBXhfQlHQZiOOanCNEPLR5zUiUevt\n\tj7QgtEoTKHWPgD+0fGZt+VNHz3i/CguPE/C0s=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=Hc1k9TvkTMLo/xeB0yKY9KHm/46Sfk99dn5YFwwLS2k=;\n\tb=WeFjjEzs64Cqy9JjOk2tg35KGGO3/hk9w65+cvChKwxDHHe2KROctkALyO3WMs2F43\n\t3ivJpN63zYR1P8x11n4CowqMQ9nhvjlUKGD9KwFL+lzCqlcT9dC0o9HxsOjTUs2fEfrf\n\tjNoLL/55+UESKVbvBEPuZ0rOPTzHeetc081lox7QVvGCl9tYaWR6l9l126FBsnQPtrD4\n\t0qMQXZbGEGh5iT5MnvKMzYSbFAuv1p9xqd/WtoqgzpwxsnbWfDmCJPPVP3UgcTVve+0x\n\tkmKhQVD0hN3gy8QbXN78fqsC+6DZq4YIZZ58tlGPpTv+zmG7qskisMqTfmxFVOvGBY3k\n\t4OpQ==","X-Gm-Message-State":"AHPjjUgV5dF01DxfQjP7z8wtkP2PLCc4N/ey4F0x35TOwN71G3ksLubP\n\ti5H/3znbJABuA5Ek6Zddk5UDrwotYD7i","X-Google-Smtp-Source":"AOwi7QB60wTbjoXq9yjnaaSQtqLGum4OHl4blKAtTU0vPY7pb99BriBwZCnja+VKsFUvUhhQ+sV7UyUP4N1Vmm0wWXc=","X-Received":"by 10.28.52.81 with SMTP id b78mr7549517wma.11.1505154311970;\n\tMon, 11 Sep 2017 11:25:11 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>","From":"Peter Maydell ","Date":"Mon, 11 Sep 2017 19:24:51 +0100","Message-ID":"","To":"Richard Henderson ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::235","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers , Paolo Bonzini\n\t, Stefan Weil , =?utf-8?q?Philip?=\n\t=?utf-8?q?pe_Mathieu-Daud=C3=A9?= ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766478,"web_url":"http://patchwork.ozlabs.org/comment/1766478/","msgid":"<6a9c81f3-bbe3-e177-1ede-ad0cf40fe553@weilnetz.de>","list_archive_url":null,"date":"2017-09-11T19:39:01","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":9527,"url":"http://patchwork.ozlabs.org/api/people/9527/","name":"Stefan Weil","email":"sw@weilnetz.de"},"content":"Am 11.09.2017 um 20:24 schrieb Peter Maydell:\n> On 11 September 2017 at 19:01, Richard Henderson\n> wrote:\n>> On 09/10/2017 07:28 PM, Philippe Mathieu-Daudé wrote:\n>>> changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter:\n>>>\n>>> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror]\n>>> static bool tcg_out_ldst_finalize(TCGContext *s);\n>>> ^\n>>>\n>>> Signed-off-by: Philippe Mathieu-Daudé \n>>\n>> Oops.\n>>\n>> Reviewed-by: Richard Henderson \n> \n> Applied to master as a buildfix, thanks.\n\nThank you, Peter.\n\n> I've also turned on a tci compile check on my pre-merge tests.\n> (It doesn't pass \"make check\" for me, though...)\n\nI just tested it myself. \"make check\" passed, but printed some\nKVM related messages which could be suppressed by fixing the\ntest code:\n\n[...]\n GTESTER tests/test-qht-par\nCould not access KVM kernel module: No such file or directory\nqemu-system-x86_64: failed to initialize KVM: No such file or directory\nqemu-system-x86_64: Back to tcg accelerator\nCould not access KVM kernel module: No such file or directory\nqemu-system-x86_64: failed to initialize KVM: No such file or directory\n[...]\nCould not access KVM kernel module: No such file or directory\nqemu-system-x86_64: failed to initialize KVM: No such file or directory\nqemu-system-x86_64: Back to tcg accelerator\nmake: Verzeichnis „/qemu/bin/“ wird verlassen\n\nWhat failures do you get?\n\nRegards,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrdY55yrpz9s7C\n\tfor ;\n\tTue, 12 Sep 2017 05:39:36 +1000 (AEST)","from localhost ([::1]:60124 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drUYO-0007x3-0z\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 15:39:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59686)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drUY1-0007wh-My\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:39:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drUXw-0006nM-Qn\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:39:09 -0400","from mail.weilnetz.de ([37.120.169.71]:53928\n\thelo=v2201612906741603.powersrv.de)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drUXw-0006m7-Jz\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:39:04 -0400","from localhost (localhost [127.0.0.1])\n\tby v2201612906741603.powersrv.de (Postfix) with ESMTP id E0577DA7950; \n\tMon, 11 Sep 2017 21:39:02 +0200 (CEST)","from v2201612906741603.powersrv.de ([127.0.0.1])\n\tby localhost (v2201612906741603.powersrv.de [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id EVXjplC2LuCK; Mon, 11 Sep 2017 21:39:02 +0200 (CEST)","from edv32.bib.uni-mannheim.de (pD9E01FFC.dip0.t-ipconnect.de\n\t[217.224.31.252])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby v2201612906741603.powersrv.de (Postfix) with ESMTPSA id\n\t1D82FDA794D; Mon, 11 Sep 2017 21:39:02 +0200 (CEST)"],"X-Virus-Scanned":"Debian amavisd-new at v2201612906741603.powersrv.de","To":"Peter Maydell ,\n\tRichard Henderson ","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t","From":"Stefan Weil ","Message-ID":"<6a9c81f3-bbe3-e177-1ede-ad0cf40fe553@weilnetz.de>","Date":"Mon, 11 Sep 2017 21:39:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"37.120.169.71","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers , Paolo Bonzini\n\t, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766482,"web_url":"http://patchwork.ozlabs.org/comment/1766482/","msgid":"<005f4db4-ff06-30ee-f693-f233fd37c247@amsat.org>","list_archive_url":null,"date":"2017-09-11T19:47:07","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"Hi Peter, Stefan,\n\n> Am 11.09.2017 um 20:24 schrieb Peter Maydell:\n>> I've also turned on a tci compile check on my pre-merge tests.\n>> (It doesn't pass \"make check\" for me, though...)\n\nPeter you might want to restrict it to X86...\n\n--target-list=subdir-i386-softmmu,x86_64-softmmu,x86_64-linux-user\n\n> \n> I just tested it myself. \"make check\" passed, but printed some\n> KVM related messages which could be suppressed by fixing the\n> test code:\n> \n> [...]\n> GTESTER tests/test-qht-par\n> Could not access KVM kernel module: No such file or directory\n> qemu-system-x86_64: failed to initialize KVM: No such file or directory\n> qemu-system-x86_64: Back to tcg accelerator\n> Could not access KVM kernel module: No such file or directory\n> qemu-system-x86_64: failed to initialize KVM: No such file or directory\n> [...]\n> Could not access KVM kernel module: No such file or directory\n> qemu-system-x86_64: failed to initialize KVM: No such file or directory\n> qemu-system-x86_64: Back to tcg accelerator\n> make: Verzeichnis „/qemu/bin/“ wird verlassen\n\nStefan are you testing no-X86 targets?\n\nRegards,\n\nPhil.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"JVmBaJTQ\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrdkS6pM9z9s81\n\tfor ;\n\tTue, 12 Sep 2017 05:47:43 +1000 (AEST)","from localhost ([::1]:60177 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drUgH-0002Jw-3X\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 15:47:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34288)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1drUfw-0002JW-Qy\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:47:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1drUfr-0003cd-U0\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:47:20 -0400","from mail-qk0-x22e.google.com ([2607:f8b0:400d:c09::22e]:33624)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1drUfr-0003cW-Py\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:47:15 -0400","by mail-qk0-x22e.google.com with SMTP id o129so20928042qkd.0\n\tfor ; Mon, 11 Sep 2017 12:47:15 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tn12sm6450235qkn.83.2017.09.11.12.47.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 12:47:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=XRdNh/8ZKVwXpfiuFIRMILgBTQrfgFfQD/XOmciX+KQ=;\n\tb=JVmBaJTQ4UhefmbwjyI+f6hCCIaZFHmndlP1jfpvsoPJzQez1yCYyRurqXr9HeYrO0\n\t1q24i+aZcRBO1T4Nh8kXfK9QEqkgxaMfcZPgsR2C/vndLG7zgEWTJ/ELg6iVHNHOlBZj\n\t1P5ygEZ+kvVBA3DHz7uIwEWTGrAc1wVyMS4j4H5XpWKBmkRyM2nODMulq7JL7K1F21HI\n\twAt9wm6OmwyhYIf7v4vK20EZx3M5BSN7CDpFJuG7ajacwA2yPd396nHGHXMO17S4AHaY\n\toUeSqvn/5goQRo8aGoxozjM9fhGaJRSYVoQscnljWL7P2aU1iu3pruMwIIwftijhbLAM\n\tXAAQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=XRdNh/8ZKVwXpfiuFIRMILgBTQrfgFfQD/XOmciX+KQ=;\n\tb=Wo2ERaAovo6yqFvnyZnpzta4vBXSfTATbQsiWjhXgRl2XKhb+KDmBgzkogWt2pxBEG\n\tsVajHIhbysyyvhdQSy9RTzaCSXXRNPaV2S3xsc0frzjPt1Hs0PFuv6YsN0i6Se6R0uOI\n\t+S7qlKMQ/c8MnzAAP4sobzo8v3w+X4MRzpoSXOSXNl6Bl4sP0eCVQ2jL+CjcNJpLWrlk\n\ts+HCdYHoVc5eh5NBIk6XcIJHV02LX/1jp5ecfu0h9AaBcO7TtVGO3yChR/xaTeUbdB77\n\teTRG4qc5yCR35cERh+C/9+K3NMRc6pbStf+G+7x5vFZk6DbEXBygjfEDIH2Dgavd+B1B\n\thQlA==","X-Gm-Message-State":"AHPjjUhY7rnWLtA+lS0qErZMOGhTCuFm5iJ6XhDHntD37NsOPQcEN9qA\n\tpltOvpXs0kvwSuShcMI=","X-Google-Smtp-Source":"AOwi7QBAqKzAQbj1gzFvzsqsKzv404fjyBugGxnVkdo+yVAZzngvZQk32X6JbfV4OdkGtigHAdCNlw==","X-Received":"by 10.55.166.131 with SMTP id\n\tp125mr13684271qke.264.1505159234972; \n\tMon, 11 Sep 2017 12:47:14 -0700 (PDT)","To":"Stefan Weil , Peter Maydell , \n\tRichard Henderson ","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t\n\t<6a9c81f3-bbe3-e177-1ede-ad0cf40fe553@weilnetz.de>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<005f4db4-ff06-30ee-f693-f233fd37c247@amsat.org>","Date":"Mon, 11 Sep 2017 16:47:07 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<6a9c81f3-bbe3-e177-1ede-ad0cf40fe553@weilnetz.de>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::22e","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766486,"web_url":"http://patchwork.ozlabs.org/comment/1766486/","msgid":"<4296c8b2-e3ed-7a73-05bb-985603d08423@weilnetz.de>","list_archive_url":null,"date":"2017-09-11T19:54:33","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":9527,"url":"http://patchwork.ozlabs.org/api/people/9527/","name":"Stefan Weil","email":"sw@weilnetz.de"},"content":"Am 11.09.2017 um 21:47 schrieb Philippe Mathieu-Daudé:\n[...]> Stefan are you testing no-X86 targets?\n\nI only tested x86_64:\n\n./configure --enable-debug --enable-tcg-interpreter \\\n --target-list=x86_64-linux-user,x86_64-softmmu\n\nIf other targets fail, I'll have a look to find the cause.\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrdtx1FD1z9s0Z\n\tfor ;\n\tTue, 12 Sep 2017 05:55:03 +1000 (AEST)","from localhost ([::1]:60205 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drUnL-0005C2-Hx\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 15:54:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39280)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drUn2-0005Bs-34\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:54:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drUmy-00010U-7H\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:54:40 -0400","from mail.weilnetz.de ([37.120.169.71]:54092\n\thelo=v2201612906741603.powersrv.de)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drUmy-0000zT-0j\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 15:54:36 -0400","from localhost (localhost [127.0.0.1])\n\tby v2201612906741603.powersrv.de (Postfix) with ESMTP id 69B9EDA793C; \n\tMon, 11 Sep 2017 21:54:34 +0200 (CEST)","from v2201612906741603.powersrv.de ([127.0.0.1])\n\tby localhost (v2201612906741603.powersrv.de [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id XFI4OTK8o2Pw; Mon, 11 Sep 2017 21:54:33 +0200 (CEST)","from edv32.bib.uni-mannheim.de (pD9E01FFC.dip0.t-ipconnect.de\n\t[217.224.31.252])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby v2201612906741603.powersrv.de (Postfix) with ESMTPSA id\n\tC7AA5DA7005; Mon, 11 Sep 2017 21:54:33 +0200 (CEST)"],"X-Virus-Scanned":"Debian amavisd-new at v2201612906741603.powersrv.de","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n\tPeter Maydell , Richard Henderson\n\t","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t\n\t<6a9c81f3-bbe3-e177-1ede-ad0cf40fe553@weilnetz.de>\n\t<005f4db4-ff06-30ee-f693-f233fd37c247@amsat.org>","From":"Stefan Weil ","Message-ID":"<4296c8b2-e3ed-7a73-05bb-985603d08423@weilnetz.de>","Date":"Mon, 11 Sep 2017 21:54:33 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<005f4db4-ff06-30ee-f693-f233fd37c247@amsat.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"de-DE","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"37.120.169.71","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766525,"web_url":"http://patchwork.ozlabs.org/comment/1766525/","msgid":"","list_archive_url":null,"date":"2017-09-11T20:26:14","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":9527,"url":"http://patchwork.ozlabs.org/api/people/9527/","name":"Stefan Weil","email":"sw@weilnetz.de"},"content":"Am 11.09.2017 um 20:24 schrieb Peter Maydell:\n> I've also turned on a tci compile check on my pre-merge tests.\n> (It doesn't pass \"make check\" for me, though...)\n\nDid you run \"make\" before running \"make check\"?\n\nI had an assertion because of a missing qemu-ga\nwhen I‌ only had run \"make check\", so there is a\ndependency (perhaps check: tools) missing.\n\nNow \"make check\" is running fine with all targets\n(at least until check-qtest-ppc64). Sorry, I have\nto finish for today.\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrfbN4rxvz9s7B\n\tfor ;\n\tTue, 12 Sep 2017 06:26:40 +1000 (AEST)","from localhost ([::1]:60404 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drVHy-0006AF-OI\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 16:26:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52042)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drVHf-00069U-U5\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 16:26:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drVHc-0001Q6-Pf\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 16:26:19 -0400","from mail.weilnetz.de ([37.120.169.71]:54648\n\thelo=v2201612906741603.powersrv.de)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drVHc-0001Ph-Iy\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 16:26:16 -0400","from localhost (localhost [127.0.0.1])\n\tby v2201612906741603.powersrv.de (Postfix) with ESMTP id 72CB2DA7942; \n\tMon, 11 Sep 2017 22:26:15 +0200 (CEST)","from v2201612906741603.powersrv.de ([127.0.0.1])\n\tby localhost (v2201612906741603.powersrv.de [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 2YYfCHH9R4uC; Mon, 11 Sep 2017 22:26:15 +0200 (CEST)","from edv32.bib.uni-mannheim.de (pD9E01FFC.dip0.t-ipconnect.de\n\t[217.224.31.252])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby v2201612906741603.powersrv.de (Postfix) with ESMTPSA id\n\tD5928DA7940; Mon, 11 Sep 2017 22:26:14 +0200 (CEST)"],"X-Virus-Scanned":"Debian amavisd-new at v2201612906741603.powersrv.de","To":"Peter Maydell ,\n\tRichard Henderson ","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t","From":"Stefan Weil ","Message-ID":"","Date":"Mon, 11 Sep 2017 22:26:14 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"37.120.169.71","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers , Paolo Bonzini\n\t, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766553,"web_url":"http://patchwork.ozlabs.org/comment/1766553/","msgid":"","list_archive_url":null,"date":"2017-09-11T21:06:25","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"Hi Stefan,\n\nOn 09/11/2017 05:26 PM, Stefan Weil wrote:> I had an assertion because \nof a missing qemu-ga\n> when I‌ only had run \"make check\", so there is a\n> dependency (perhaps check: tools) missing.\n> \n> Now \"make check\" is running fine with all targets\n> (at least until check-qtest-ppc64). Sorry, I have\n> to finish for today.\n\nI had this patch in my travis-ci queue, here extracted alone:\nhttps://patchwork.kernel.org/patch/9948117/\n\nRegards,\n\nPhil.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fLw9J0g/\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrgTz1mKMz9s8J\n\tfor ;\n\tTue, 12 Sep 2017 07:07:03 +1000 (AEST)","from localhost ([::1]:60569 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drVv3-0005Na-Az\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 17:07:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35433)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1drVuc-0005N2-MW\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:06:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1drVuX-0006IP-Ng\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:06:34 -0400","from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:34038)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1drVuX-0006Hm-Ig\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 17:06:29 -0400","by mail-qt0-x241.google.com with SMTP id q8so6302360qtb.1\n\tfor ; Mon, 11 Sep 2017 14:06:29 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tb27sm6920037qtc.78.2017.09.11.14.06.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 14:06:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=UfI3OHoVJ3ghQeVdDr6r5hCLbhUqN6gys9hqJ4mDPXU=;\n\tb=fLw9J0g/YY7DM/STQTc2yYuk8PANAfEJ+4YU1XyLWn/QrAwYhP36YQM7HR0kjqG7pD\n\tCkVPjJCJ64uuPyS97sGyH7pkXVtatLAOA0K7QR2bGNpkhVGPYlNxTWDCyz1Q9P1hzzcw\n\tH0KndDJIbTaWX2UIxEEckvASxTopCy0gKahIkyjX1LXLBxJpbiXaLi5HosB3CbPc3q2G\n\tNxYwiXtHsNhD3FpB++WNwPpdRjDoThxGc8Ela7e/MLRhmpVm8ln7HedPMCcT9+17SWE8\n\tu9AnH5MHQSnp8ZU1o3QRpAB4HIC3ZTMuGUt85mix3t3csOAl6VUMgsetNTi05w464NkG\n\tL21A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=UfI3OHoVJ3ghQeVdDr6r5hCLbhUqN6gys9hqJ4mDPXU=;\n\tb=oacSpG5qSrH4y9R2Nc8uwdbZI7+9rC+ws3AgJ38PQ9H6S57y+J7IRgmgiC59ZuVB8Z\n\tHW4Tv9dJ6cu5HW0k4ev++siqj9Nk9+TpSsSs0dTLve/wB/pfmMM9+GuuKt+g6FeKV9pX\n\twybPDcz3cvAIct3HXPeNA8pQcEAiCwcKq/COxGTzrICw/Mpcv7DK0cn95ZY+278ykEYm\n\tmcfGqEKT/u4FOxfi8go7DQY6EQQ0dDIW5sSo9ra/vwCHF19ZBc4hHOBjtwU1Ov7hflfq\n\tQqZQ9rSlv9dhQ6bnBF0w8q5lTi7xeDczgzyyCf+q75mLmGteH1CGjw/StlaJFOG+ck7U\n\twLNg==","X-Gm-Message-State":"AHPjjUhcJMbI+bG63XtvZOU+u47txfoXsKReBVktGkUbj9CxPg1NT5AV\n\tjSplzdTxRA1v+rcvIFY=","X-Google-Smtp-Source":"AOwi7QCLO4MBTgbnvIV5rN2guoys6Gl7zuaIXIzDKTjAQ7WiF22tVyZc6QDDkTbjEjbXJ5ITbgiwEA==","X-Received":"by 10.200.27.6 with SMTP id y6mr18914442qtj.247.1505163988691;\n\tMon, 11 Sep 2017 14:06:28 -0700 (PDT)","To":"Stefan Weil ","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t\n\t","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"","Date":"Mon, 11 Sep 2017 18:06:25 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::241","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell ,\n\tPaolo Bonzini ,\n\tRichard Henderson ,\n\tQEMU Developers ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766776,"web_url":"http://patchwork.ozlabs.org/comment/1766776/","msgid":"","list_archive_url":null,"date":"2017-09-12T08:52:49","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":9527,"url":"http://patchwork.ozlabs.org/api/people/9527/","name":"Stefan Weil","email":"sw@weilnetz.de"},"content":"Am 11.09.2017 um 20:24 schrieb Peter Maydell:\n> I've also turned on a tci compile check on my pre-merge tests.\n> (It doesn't pass \"make check\" for me, though...) thanks -- PMM\n\n\"make check-qtest-ppc64\" fails for me, too.\n\nThomas, this seems to be again the well known timing problem\nin tests/prom-env-test.c. The time for the test had been\nchangedfrom 30 s to 10 s to 120 s in the past.\n\nFor TCI, even that latest value isnot sufficient when\ntesting with pseries. Of course that also depends on other\nparameters (speed of test machine, compilerflags).\n\nIn my test pseries took nearly 5 minutes, so the test passes\nwhen the loop upper limit is increased to 30000.\n\nIs there a better way to handle this test? Why does pseries\nstill need much more time than the other machines\n(not only with TCI)?\n\nRegards,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrz951krrz9s81\n\tfor ;\n\tTue, 12 Sep 2017 18:53:27 +1000 (AEST)","from localhost ([::1]:34316 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drgwY-0001EA-9I\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 04:53:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35218)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drgwA-0001Do-PJ\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 04:52:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drgw7-0002a9-Nk\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 04:52:54 -0400","from smtp.mail.uni-mannheim.de ([134.155.96.80]:44155)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drgw7-0002XM-GF\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 04:52:51 -0400","from localhost (localhost [127.0.0.1])\n\tby smtp.mail.uni-mannheim.de (Postfix) with ESMTP id C76C1104188;\n\tTue, 12 Sep 2017 10:52:48 +0200 (CEST)","from smtp.mail.uni-mannheim.de ([134.155.96.80])\n\tby localhost (mail-r83.rz.uni-mannheim.de [127.0.0.1]) (amavisd-new, \n\tport 10024)\n\twith ESMTP id msYWyexAdBNI; Tue, 12 Sep 2017 10:52:48 +0200 (CEST)","from [134.155.36.73] (edv13.bib.uni-mannheim.de [134.155.36.73])\n\tby smtp.mail.uni-mannheim.de (Postfix) with ESMTPSA id A2B1F104177;\n\tTue, 12 Sep 2017 10:52:48 +0200 (CEST)"],"X-Virus-Scanned":"amavisd-new at uni-mannheim.de","To":"Thomas Huth ","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t","From":"Stefan Weil ","Message-ID":"","Date":"Tue, 12 Sep 2017 10:52:49 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Content-Language":"en-GB","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"134.155.96.80","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Richard Henderson\n\t, \n\tQEMU Developers , =?utf-8?q?Philippe_Mathieu-D?=\n\t=?utf-8?b?YXVkw6k=?= ,\n\tPaolo Bonzini , Richard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766796,"web_url":"http://patchwork.ozlabs.org/comment/1766796/","msgid":"<15608989-cb43-a522-9a7d-b57b3a393155@weilnetz.de>","list_archive_url":null,"date":"2017-09-12T09:20:12","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":9527,"url":"http://patchwork.ozlabs.org/api/people/9527/","name":"Stefan Weil","email":"sw@weilnetz.de"},"content":"Am 12.09.2017 um 10:52 schrieb Stefan Weil:\n> Am 11.09.2017 um 20:24 schrieb Peter Maydell:\n>> I've also turned on a tci compile check on my pre-merge tests.\n>> (It doesn't pass \"make check\" for me, though...) thanks -- PMM\n> \n> \"make check-qtest-ppc64\" fails for me, too.\n> \n> Thomas, this seems to be again the well known timing problem\n> in tests/prom-env-test.c. The time for the test had been\n> changedfrom 30 s to 10 s to 120 s in the past.\n\n... changed from 10 s to 30 s to 120 s ...\n\n> For TCI, even that latest value is not sufficient when\n> testing with pseries. Of course that also depends on other\n> parameters (speed of test machine, compiler flags).\n> \n> In my test pseries took nearly 5 minutes, so the test passes\n> when the loop upper limit is increased to 30000.\n\nTiming data for prom-env-test with TCI on another test machine:\n\nmac99: 78 s\ng3beige: 74 s\npseries: 477 s\n\n> \n> Is there a better way to handle this test? Why does pseries\n> still need much more time than the other machines\n> (not only with TCI)?\n> \n> Regards,\n> Stefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrzmZ4rw4z9s81\n\tfor ;\n\tTue, 12 Sep 2017 19:20:42 +1000 (AEST)","from localhost ([::1]:34479 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drhN0-0004oJ-Ts\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 05:20:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44752)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drhMf-0004o6-Mp\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 05:20:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drhMb-0001nb-N9\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 05:20:17 -0400","from smtp.mail.uni-mannheim.de ([134.155.96.80]:35179)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drhMb-0001m4-GD\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 05:20:13 -0400","from localhost (localhost [127.0.0.1])\n\tby smtp.mail.uni-mannheim.de (Postfix) with ESMTP id E57BF10429C;\n\tTue, 12 Sep 2017 11:20:11 +0200 (CEST)","from smtp.mail.uni-mannheim.de ([134.155.96.80])\n\tby localhost (mail-r83.rz.uni-mannheim.de [127.0.0.1]) (amavisd-new, \n\tport 10024)\n\twith ESMTP id evWXnA9uqHgI; Tue, 12 Sep 2017 11:20:11 +0200 (CEST)","from [134.155.36.73] (edv13.bib.uni-mannheim.de [134.155.36.73])\n\tby smtp.mail.uni-mannheim.de (Postfix) with ESMTPSA id C27BA104190;\n\tTue, 12 Sep 2017 11:20:11 +0200 (CEST)"],"X-Virus-Scanned":"amavisd-new at uni-mannheim.de","From":"Stefan Weil ","To":"Thomas Huth ","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t\n\t","Message-ID":"<15608989-cb43-a522-9a7d-b57b3a393155@weilnetz.de>","Date":"Tue, 12 Sep 2017 11:20:12 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"134.155.96.80","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Richard Henderson\n\t, \n\tQEMU Developers , =?utf-8?q?Philippe_Mathieu-D?=\n\t=?utf-8?b?YXVkw6k=?= ,\n\tPaolo Bonzini , Richard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767147,"web_url":"http://patchwork.ozlabs.org/comment/1767147/","msgid":"","list_archive_url":null,"date":"2017-09-12T14:56:39","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 12.09.2017 11:20, Stefan Weil wrote:\n> Am 12.09.2017 um 10:52 schrieb Stefan Weil:\n>> Am 11.09.2017 um 20:24 schrieb Peter Maydell:\n>>> I've also turned on a tci compile check on my pre-merge tests.\n>>> (It doesn't pass \"make check\" for me, though...) thanks -- PMM\n>>\n>> \"make check-qtest-ppc64\" fails for me, too.\n>>\n>> Thomas, this seems to be again the well known timing problem\n>> in tests/prom-env-test.c. The time for the test had been\n>> changedfrom 30 s to 10 s to 120 s in the past.\n> \n> ... changed from 10 s to 30 s to 120 s ...\n> \n>> For TCI, even that latest value is not sufficient when\n>> testing with pseries. Of course that also depends on other\n>> parameters (speed of test machine, compiler flags).\n>>\n>> In my test pseries took nearly 5 minutes, so the test passes\n>> when the loop upper limit is increased to 30000.\n> \n> Timing data for prom-env-test with TCI on another test machine:\n> \n> mac99: 78 s\n> g3beige: 74 s\n> pseries: 477 s\n\nHow fast is your host machine? For me the whole prom-env-test finishes\nwithin 52 seconds (my host machine has 3.2 GHz) in TCI mode, and there\nare no errors reported during \"make check-qtest-ppc64\".\n\nDid you compile your QEMU with --enable-debug by accident? I think that\ncould explain the bad performance here - TCI with --enable-debug is not\njust slow, but rather unusable slow already...\n\n>> Is there a better way to handle this test? Why does pseries\n>> still need much more time than the other machines\n>> (not only with TCI)?\n\nThe problem is that the SLOF firmware just performs very badly with TCG\n(it's fine on real hardware). It executes a lot of Forth code, and the\nForth interpreter uses things like computed gotos or other tricks that\nbasically prevent proper JIT operation here. I've done quite a bit of\noptimizations in SLOF in the past already, but I've got hardly any ideas\nleft how to fix that further.\n\nSo I hope the problem is just the \"--enable-debug\" here and we could run\nthe test with TCI in normal builds? I'm also fine if we increase the\ntimeout to 5 minutes instead - it should not affect the normal users\n(i.e. those who don't use TCI) and ease this situation with TCI a little\nbit.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs7F306hSz9sNV\n\tfor ;\n\tWed, 13 Sep 2017 00:57:26 +1000 (AEST)","from localhost ([::1]:36377 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drmcu-0005IF-EI\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 10:57:24 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57081)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drmcI-0005G3-Aa\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:56:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drmcH-0008Dm-CO\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:56:46 -0400","from mx1.redhat.com ([209.132.183.28]:45590)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drmcH-0008C0-3m\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 10:56:45 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id EDC6F83F3E;\n\tTue, 12 Sep 2017 14:56:43 +0000 (UTC)","from [10.40.204.137] (ovpn-204-137.brq.redhat.com [10.40.204.137])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id C0CB117DF6;\n\tTue, 12 Sep 2017 14:56:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com EDC6F83F3E","To":"Stefan Weil ","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t\n\t\n\t<15608989-cb43-a522-9a7d-b57b3a393155@weilnetz.de>","From":"Thomas Huth ","Message-ID":"","Date":"Tue, 12 Sep 2017 16:56:39 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<15608989-cb43-a522-9a7d-b57b3a393155@weilnetz.de>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 12 Sep 2017 14:56:44 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Richard Henderson\n\t, \n\tQEMU Developers , =?utf-8?q?Philippe_Mathieu-D?=\n\t=?utf-8?b?YXVkw6k=?= ,\n\tPaolo Bonzini , Richard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767157,"web_url":"http://patchwork.ozlabs.org/comment/1767157/","msgid":"<2a90999d-6f79-cbd4-aaba-a6cd425980c6@redhat.com>","list_archive_url":null,"date":"2017-09-12T15:13:56","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"On 12/09/2017 16:56, Thomas Huth wrote:\n> The problem is that the SLOF firmware just performs very badly with TCG\n> (it's fine on real hardware). It executes a lot of Forth code, and the\n> Forth interpreter uses things like computed gotos or other tricks that\n> basically prevent proper JIT operation here. I've done quite a bit of\n> optimizations in SLOF in the past already, but I've got hardly any ideas\n> left how to fix that further.\n\nTwo ideas for QEMU based on a quick \"perf record\" test:\n\n- 25% of the time is spent in cpu_exec. PPC doesn't use\ntcg_gen_lookup_and_goto_ptr. The main thing to be careful about is\nthat, whenever an interrupt is pending (e.g. after enabling them) you\nneed to force an exit to the loop. See for example commits b29fd33db5\n(\"target/arm: use DISAS_EXIT for eret handling\", 2017-07-17) and\nb74cddcbf6 (\"target/mips: Use BS_EXCP where interrupts are expected\",\n2017-08-02). On PPC this mostly means SPRs and env->msr writes. Apart\nfrom this, however, it shouldn't be hard to do.\n\n- 8% of the time is spend in cpu_exec's call to\nobject_class_dynamic_cast_assert aka this line\n\n CPUClass *cc = CPU_GET_CLASS(cpu);\n\nThis maybe could avoid the dynamic cast. But it's also possible that\nfixing the first gets rid of this one too.\n\nThanks,\n\nPaolo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=pbonzini@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs7dN3XNWz9sRg\n\tfor ;\n\tWed, 13 Sep 2017 01:15:02 +1000 (AEST)","from localhost ([::1]:36455 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drmtv-0000oA-Jh\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 11:14:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37533)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drmtT-0000my-El\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 11:14:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drmtQ-0005e8-7R\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 11:14:31 -0400","from mx1.redhat.com ([209.132.183.28]:39580)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drmtQ-0005aP-2D\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 11:14:28 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 24F4A4E4C3;\n\tTue, 12 Sep 2017 15:14:27 +0000 (UTC)","from [10.36.117.43] (ovpn-117-43.ams2.redhat.com [10.36.117.43])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5EDE36C53B;\n\tTue, 12 Sep 2017 15:14:11 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 24F4A4E4C3","To":"Thomas Huth , Stefan Weil ","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t\n\t\n\t<15608989-cb43-a522-9a7d-b57b3a393155@weilnetz.de>\n\t","From":"Paolo Bonzini ","Message-ID":"<2a90999d-6f79-cbd4-aaba-a6cd425980c6@redhat.com>","Date":"Tue, 12 Sep 2017 17:13:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 12 Sep 2017 15:14:27 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , Richard Henderson\n\t, \tRichard Henderson ,\n\tQEMU Developers , \n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772638,"web_url":"http://patchwork.ozlabs.org/comment/1772638/","msgid":"<125b2e2a-290e-568a-0e33-d40150220912@redhat.com>","list_archive_url":null,"date":"2017-09-21T09:59:04","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 12.09.2017 17:13, Paolo Bonzini wrote:\n> On 12/09/2017 16:56, Thomas Huth wrote:\n>> The problem is that the SLOF firmware just performs very badly with TCG\n>> (it's fine on real hardware). It executes a lot of Forth code, and the\n>> Forth interpreter uses things like computed gotos or other tricks that\n>> basically prevent proper JIT operation here. I've done quite a bit of\n>> optimizations in SLOF in the past already, but I've got hardly any ideas\n>> left how to fix that further.\n> \n> Two ideas for QEMU based on a quick \"perf record\" test:\n> \n> - 25% of the time is spent in cpu_exec. PPC doesn't use\n> tcg_gen_lookup_and_goto_ptr.\n\nI just realized that Richard recently already posted a patch for this:\n\nhttps://lists.gnu.org/archive/html/qemu-devel/2017-06/msg07124.html\n\nI've applied it locally, and indeed, it speeds up a simple test with\n-prom-env by factor two. Before the change:\n\n$ time ppc64-softmmu/qemu-system-ppc64 -nographic -vga none -prom-env\n'use-nvramrc?=true' -prom-env 'nvramrc=power-off'\n[...]\nreal\t0m28.784s\nuser\t0m28.700s\nsys\t0m0.031s\n\nAfter the change:\n\n$ time ppc64-softmmu/qemu-system-ppc64 -nographic -vga none -prom-env\n'use-nvramrc?=true' -prom-env 'nvramrc=power-off'\n[...]\nreal\t0m13.953s\nuser\t0m13.904s\nsys\t0m0.046s\n\nThat's impressive! Richard, may I ask what's the current state of this?\nDo you plan to merge this soon, or are there still issues (like the ones\nthat Paolo mentioned)?\n\nHowever, I only see that speed-up with the normal x86 backend. I've also\ntried it with TCI, but I hardly saw any improvements there ... is there\nstill something missing in the TCI backend that is required for the\ntcg_gen_lookup_and_goto_ptr feature?\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyXCP1CFgz9t49\n\tfor ;\n\tThu, 21 Sep 2017 19:59:45 +1000 (AEST)","from localhost ([::1]:52678 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duyGl-0008Bx-9o\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 05:59:43 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37670)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duyGH-00089v-F9\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 05:59:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duyGD-0004Di-JD\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 05:59:13 -0400","from mx1.redhat.com ([209.132.183.28]:50576)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duyGD-0004CT-Da\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 05:59:09 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 46F89C074F1E;\n\tThu, 21 Sep 2017 09:59:08 +0000 (UTC)","from [10.36.116.54] (ovpn-116-54.ams2.redhat.com [10.36.116.54])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id A5FF65D6A3;\n\tThu, 21 Sep 2017 09:59:06 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 46F89C074F1E","To":"Paolo Bonzini , Richard Henderson ","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t\n\t\n\t<15608989-cb43-a522-9a7d-b57b3a393155@weilnetz.de>\n\t\n\t<2a90999d-6f79-cbd4-aaba-a6cd425980c6@redhat.com>","From":"Thomas Huth ","Message-ID":"<125b2e2a-290e-568a-0e33-d40150220912@redhat.com>","Date":"Thu, 21 Sep 2017 11:59:04 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<2a90999d-6f79-cbd4-aaba-a6cd425980c6@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tThu, 21 Sep 2017 09:59:08 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Weil , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tRichard Henderson ,\n\tQEMU Developers , \n\tPeter Maydell ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773594,"web_url":"http://patchwork.ozlabs.org/comment/1773594/","msgid":"","list_archive_url":null,"date":"2017-09-22T13:31:29","subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","submitter":{"id":2222,"url":"http://patchwork.ozlabs.org/api/people/2222/","name":"Richard Henderson","email":"rth@twiddle.net"},"content":"On 09/21/2017 04:59 AM, Thomas Huth wrote:\n> $ time ppc64-softmmu/qemu-system-ppc64 -nographic -vga none -prom-env\n> 'use-nvramrc?=true' -prom-env 'nvramrc=power-off'\n> [...]\n> real\t0m13.953s\n> user\t0m13.904s\n> sys\t0m0.046s\n> \n> That's impressive! Richard, may I ask what's the current state of this?\n> Do you plan to merge this soon, or are there still issues (like the ones\n> that Paolo mentioned)?\n\nI had been assuming that it would go in via the normal ppc tree.\nIf I should just merge it with tcg-next, I can do so...\n\n> However, I only see that speed-up with the normal x86 backend. I've also\n> tried it with TCI, but I hardly saw any improvements there ... is there\n> still something missing in the TCI backend that is required for the\n> tcg_gen_lookup_and_goto_ptr feature?\n\nYes.\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EnPC9JVE\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzDsq3pYSz9s06\n\tfor ;\n\tFri, 22 Sep 2017 23:31:59 +1000 (AEST)","from localhost ([::1]:58955 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvO3h-0005Ji-Mr\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 09:31:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46869)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvO3N-0005JR-2m\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 09:31:37 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvO3K-0002Cj-Fa\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 09:31:37 -0400","from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]:48718)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dvO3K-0002CX-A1\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 09:31:34 -0400","by mail-io0-x232.google.com with SMTP id n69so3050977ioi.5\n\tfor ; Fri, 22 Sep 2017 06:31:34 -0700 (PDT)","from bigtime.twiddle.net (162.189-204-159.bestel.com.mx.\n\t[189.204.159.162]) by smtp.googlemail.com with ESMTPSA id\n\tq10sm45229oth.64.2017.09.22.06.31.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 06:31:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=oVVRtUHdhJxLq8VQnUjggkWiy9p/dRgg7lcKkA9sNKU=;\n\tb=EnPC9JVEtAsTY3AL4e7lU4P/adLDQgSrV8ysnD4jsc66M9opklL/u6SZj0pTqTuGDJ\n\ti5vt27GHg/T+jyU2eFjMOz4wHvqeiIpXMR9H6WUkOocKK+EbAZjLEhFzI7RMKDnz1jrg\n\tDaf8TdIarmWfc+uyOPVW9bMUW5PogvDhnTpH8cU6c+75xnPWdlHjxDzwicxDNzJTTvC6\n\tLXaw4cq9YAl3WfskQVUtcxuX52rBzPF0H4mmksRDQAvQr4+TB8aBsXsRIbiGJlC6zGd0\n\ttOKSwrWGcDNfJJ6UROhq1Iqsh/Y5FEIAqIF/slNR0OiB2l9HpJ6ThD0pSLhpnu9b+0rs\n\tuy8A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=oVVRtUHdhJxLq8VQnUjggkWiy9p/dRgg7lcKkA9sNKU=;\n\tb=g5TufYSDI4vcvNTqlj8bm8gFBszhFzILZAw+fMUcirkm8Z4LZOjkt+tuqMpvRlzONw\n\tlEW3jAWj6vYue2U4qt7RITwFwNdCU3lHfx7CrlwLWmw+spwovySV5xP/tc7dW/Z/cZnQ\n\t11/qG5q0/ynKtZqG23gWrLINXhY/szRveUM8Y1/koLHSQhD1fp12nx0SVtwXS8W0hg18\n\twk1fhwXfILVai/AUCOjOy9BFT/h9zjy4FvbdZ4T05k17CNMDOVKofU0ZxxLiJoPiEQWb\n\tuKdjhbvDAQJskHf7h2DuATRIF3hCNpNLKqXO3lUYNCMksEvMikhuvCPmcgxhpLQzFfNH\n\t4scw==","X-Gm-Message-State":"AHPjjUip5NxVUHJjCgZHTVMVnHWFKT+8Kc7hfrRO2MH4jXRBSIlwDgf1\n\tJIJh6KFII3j0SI0FXxTW8fI=","X-Google-Smtp-Source":"AOwi7QAxG/eTeIhBQHhNLov7wmnvzUPf1JJQdgTwR9axELlJiWdYDEBM0DaPJGZHXnzFqubowNjNvg==","X-Received":"by 10.202.92.130 with SMTP id q124mr6367978oib.213.1506087093328;\n\tFri, 22 Sep 2017 06:31:33 -0700 (PDT)","To":"Thomas Huth , Paolo Bonzini ","References":"<20170911022839.23231-1-f4bug@amsat.org>\n\t<1c72c0c6-bd29-5228-d4ad-b26b11afa712@linaro.org>\n\t\n\t\n\t<15608989-cb43-a522-9a7d-b57b3a393155@weilnetz.de>\n\t\n\t<2a90999d-6f79-cbd4-aaba-a6cd425980c6@redhat.com>\n\t<125b2e2a-290e-568a-0e33-d40150220912@redhat.com>","From":"Richard Henderson ","Message-ID":"","Date":"Fri, 22 Sep 2017 08:31:29 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<125b2e2a-290e-568a-0e33-d40150220912@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c06::232","Subject":"Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never\n\timplemented)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Weil , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?=\n\t, \tRichard Henderson ,\n\tQEMU Developers , \n\tPeter Maydell ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]