[{"id":1766346,"web_url":"http://patchwork.ozlabs.org/comment/1766346/","msgid":"","list_archive_url":null,"date":"2017-09-11T14:41:29","subject":"Re: [PATCH v2 3/5] ldbl-128ibm: Copy implementations from ldbl-128\n\tinstead of including them","submitter":{"id":4349,"url":"http://patchwork.ozlabs.org/api/people/4349/","name":"Joseph Myers","email":"joseph@codesourcery.com"},"content":"On Sun, 10 Sep 2017, Gabriel F. T. Gomes wrote:\n\n> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_expl.c b/sysdeps/ieee754/ldbl-128ibm/e_expl.c\n> index 10df6bb7d5..3d32f8f0b0 100644\n> --- a/sysdeps/ieee754/ldbl-128ibm/e_expl.c\n> +++ b/sysdeps/ieee754/ldbl-128ibm/e_expl.c\n> @@ -69,7 +69,7 @@\n> #define _Float128 long double\n> #define L(x) x ## L\n> \n> -#include \n> +#include \n\nShould just be #include \"t_expl.h\".\n\n> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_j0l.c b/sysdeps/ieee754/ldbl-128ibm/e_j0l.c\n> index 00bce29284..ec71904720 100644\n> --- a/sysdeps/ieee754/ldbl-128ibm/e_j0l.c\n> +++ b/sysdeps/ieee754/ldbl-128ibm/e_j0l.c\n> @@ -1,5 +1,867 @@\n> -/* Looks like we can use ieee854 e_j0l.c as is for IBM extended format. */\n> +/* Bessel function of order zero. IBM Extended Precision version.\n> + Copyright (C) 2017 Free Software Foundation, Inc.\n> + This file is part of the GNU C Library.\n> +\n> + The GNU C Library is free software; you can redistribute it and/or\n> + modify it under the terms of the GNU Lesser General Public\n> + License as published by the Free Software Foundation; either\n> + version 2.1 of the License, or (at your option) any later version.\n> +\n> + The GNU C Library is distributed in the hope that it will be useful,\n> + but WITHOUT ANY WARRANTY; without even the implied warranty of\n> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n> + Lesser General Public License for more details.\n> +\n> + You should have received a copy of the GNU Lesser General Public\n> + License along with the GNU C Library; if not, see\n> + . */\n> +\n> +/* This file was copied from sysdeps/ieee754/ldbl-128/e_j0l.c. */\n\nWhen copying you need to preserve the original copyright / license notice. \nNote that this is copyright Stephen L. Moshier, not FSF.\n\n> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_j1l.c b/sysdeps/ieee754/ldbl-128ibm/e_j1l.c\n\nLikewise.\n\n> diff --git a/sysdeps/ieee754/ldbl-128ibm/e_lgammal_r.c b/sysdeps/ieee754/ldbl-128ibm/e_lgammal_r.c\n\nLikewise.\n\n> diff --git a/sysdeps/ieee754/ldbl-128ibm/s_cbrtl.c b/sysdeps/ieee754/ldbl-128ibm/s_cbrtl.c\n\nLikewise.\n\n> diff --git a/sysdeps/ieee754/ldbl-128ibm/t_expl.h b/sysdeps/ieee754/ldbl-128ibm/t_expl.h\n\nLikewise (this one is FSF-copyright, but should still have the dates \n1999-2017 - but not the \"Contributed by\").","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84449-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"pE3WAU/B\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrVxS2TTPz9s81\n\tfor ;\n\tTue, 12 Sep 2017 00:41:48 +1000 (AEST)","(qmail 15221 invoked by alias); 11 Sep 2017 14:41:42 -0000","(qmail 15211 invoked by uid 89); 11 Sep 2017 14:41:41 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; q=dns; s=default; b=BkFiv\n\tQhja9Uht0/nvXZbSeT5Vfwsh/juUyanXRT59wsDh9JfWkIZIruGvAg1rcPENkmIk\n\tmp3+wKgJFdfOeijpljxB3JwzU5Nzmk9b1zZjhQg4qa+hfSb1RDetgIFP05t4/DLj\n\tk9F9x5RNH0kJZhiIkph15qkX9MG02PA7HxDQ/o=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; s=default; bh=BuemCDef3PP\n\t1PZ/4O7ys0AHm8Dg=; b=pE3WAU/Bkk9T1sckxmF9c4Pn4DmgaEhowdPlVlJQPiy\n\trI+n3uNA/UYiqNGzeoZg+R5iTXUORzW1gqXWX0x2ix/WLdFURSoIC/pJmJ4H0ltW\n\tAu465xoIJNWunau+mmwZHIFIo0fE7RWV1JNLJP9YmbSgezcS3/wltupxkh/F3Tt4\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-24.5 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tRCVD_IN_DNSWL_NONE, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=1999-2017,\n\t19992017","X-HELO":"relay1.mentorg.com","Date":"Mon, 11 Sep 2017 14:41:29 +0000","From":"Joseph Myers ","To":"\"Gabriel F. T. Gomes\" ","CC":"","Subject":"Re: [PATCH v2 3/5] ldbl-128ibm: Copy implementations from ldbl-128\n\tinstead of including them","In-Reply-To":"<20170911011654.28743-4-gabriel@inconstante.eti.br>","Message-ID":"","References":"<20170911011654.28743-1-gabriel@inconstante.eti.br>\n\t<20170911011654.28743-4-gabriel@inconstante.eti.br>","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"US-ASCII\"","X-ClientProxiedBy":"svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To\n\tsvr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)"}}]