[{"id":1766415,"web_url":"http://patchwork.ozlabs.org/comment/1766415/","msgid":"<20170911173105.GJ17058@bill-the-cat>","list_archive_url":null,"date":"2017-09-11T17:31:05","subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote:\n\n> This patch gives an opportunity to override the defined CONFIG_BOOTCOMMAND\n> (at files) with set of commands defined in\n> board _defconfig file.\n> \n> Rationale: This change allows having two different u-boot builds - one for\n> production and one (far more larger) for factory setup.\n> \n> Signed-off-by: Lukasz Majewski \n\nI don't get it, sorry. We need to move CONFIG_BOOTCOMMAND into Kconfig\nwith some other logic so that distro_bootcmd stuff works.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"kn1RwUBj\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrZhJ3d7zz9s81\n\tfor ;\n\tTue, 12 Sep 2017 03:30:39 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E9260C21F3C; Mon, 11 Sep 2017 17:30:33 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 7C8B9C21E31;\n\tMon, 11 Sep 2017 17:30:31 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid B8AD4C21E31; Mon, 11 Sep 2017 17:30:30 +0000 (UTC)","from mail-yw0-f181.google.com (mail-yw0-f181.google.com\n\t[209.85.161.181])\n\tby lists.denx.de (Postfix) with ESMTPS id 37ECBC21DA4\n\tfor ; Mon, 11 Sep 2017 17:30:30 +0000 (UTC)","by mail-yw0-f181.google.com with SMTP id s62so23076488ywg.0\n\tfor ; Mon, 11 Sep 2017 10:30:30 -0700 (PDT)","from bill-the-cat ([2606:a000:140b:dc:8d31:fe52:9bd6:9896])\n\tby smtp.gmail.com with ESMTPSA id\n\tg84sm3281316ywg.100.2017.09.11.10.30.27\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tMon, 11 Sep 2017 10:30:27 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=jTbN5sh5w7pqqnc0chew7Pr8LlZpE8nbpC++WeVAlZc=;\n\tb=kn1RwUBj+VdzsS9HaLNj1eFGzXbpTD1tWyyM9clvGWZLgYHCbRJIzhb5LGY8Iyv6+C\n\tknLglivSrMOYny1MIyT44dnAyLQKARyBmPv+0FxYM36uHaN2ZyD83YA/qMO9L5xAYNeU\n\tFYlnYwvipX4C/RrDq/VUt6jBhcS4tqzlbWI/A=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=jTbN5sh5w7pqqnc0chew7Pr8LlZpE8nbpC++WeVAlZc=;\n\tb=R3KaahZI6/lBaMg46zrE5Ql8Z7LdJdiOmwxreAT8dkOkY17kNgBhudrlKX4BBlkXPp\n\tsge/aMxgN7xSZy+6uMnFdIkUHCBXORlCqDv9772ktilO0+nTuljQdQdszyoMrHGsPSzm\n\t0KIfFS/PsKVO0j8spT1bf9T1kYR+1LyY7jVarY8K8f3HBJAH9ZsJD+QQiZl2Qh87NKpi\n\tQLR/+iL9jja2JsxVkQuUXsNUM6TM89m3udG6dkD5ebBTv9/ohWkMsUJdf+2oXspRYrgS\n\tyT247em/N1AaSnxaH4HAWPudBW7pkL0szIql2gCQ/vW6FemjEwuqgKfSJswqj5B8uz7A\n\tIKpQ==","X-Gm-Message-State":"AHPjjUjP+omoJQymHQYPRJ/DYzEgOxqWWyDVCryMZqmIs45zVggVP+NP\n\tXS1kEvZWcWu7dZUO","X-Google-Smtp-Source":"AOwi7QB6pjfglYP8iaQ0Qi9ggmPXqZ95cqkPWgPHs5/jkKROqjzvaawmG440O+6252WHZofUINqwxw==","X-Received":"by 10.37.161.161 with SMTP id a30mr10206462ybi.263.1505151028642;\n\tMon, 11 Sep 2017 10:30:28 -0700 (PDT)","Date":"Mon, 11 Sep 2017 13:31:05 -0400","From":"Tom Rini ","To":"Lukasz Majewski ","Message-ID":"<20170911173105.GJ17058@bill-the-cat>","References":"<1505067902-2530-1-git-send-email-lukma@denx.de>","MIME-Version":"1.0","In-Reply-To":"<1505067902-2530-1-git-send-email-lukma@denx.de>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============8927973162626406071==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1766548,"web_url":"http://patchwork.ozlabs.org/comment/1766548/","msgid":"<4b8cb582-0cb0-c94e-860d-b2a45eea4322@denx.de>","list_archive_url":null,"date":"2017-09-11T20:53:51","subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"On 09/11/2017 07:31 PM, Tom Rini wrote:\n> On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote:\n> \n>> This patch gives an opportunity to override the defined CONFIG_BOOTCOMMAND\n>> (at files) with set of commands defined in\n>> board _defconfig file.\n>>\n>> Rationale: This change allows having two different u-boot builds - one for\n>> production and one (far more larger) for factory setup.\n>>\n>> Signed-off-by: Lukasz Majewski \n> \n> I don't get it, sorry. We need to move CONFIG_BOOTCOMMAND into Kconfig\n> with some other logic so that distro_bootcmd stuff works.\n> \n\nThe state of the art:\n---------------------\n\nMany boards use CONFIG_BOOTCOMMAND as a set of commands to be executed \nat boot time:\n\nbootcmd=CONFIG_BOOTCOMMAND\n\nOne notable user of it is config_distro_bootcmd.h\n\nRationale:\n----------\n\nWith this patch I can:\n\n1. Setup one set of commands to be executed by default - e.g.:\n\nbootcmd=\"run boot_mmc\"\n\nand\n\n2. Have other defconfig - e.g. _factory_defconfig, which \nenables some extra stuff (like USB, gadget, gpt write, etc) and is used \nsolely for factory flashing.\n\nBy having the opportunity to override CONFIG_BOOTCOMMAND in Kconfig, I \ncan use the same code base and just adjust Kconfig for board.\n\n\nWhat do you mean by \"some other logic\"?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrgBz5wKLz9s8J\n\tfor ;\n\tTue, 12 Sep 2017 06:54:03 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 68F68C21FAF; Mon, 11 Sep 2017 20:53:57 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E0EE6C21E72;\n\tMon, 11 Sep 2017 20:53:54 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9365FC21E4B; Mon, 11 Sep 2017 20:53:53 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 3D955C21E72\n\tfor ; Mon, 11 Sep 2017 20:53:53 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xrgBn08vwz1qtFK;\n\tMon, 11 Sep 2017 22:53:52 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xrgBm5fvvz3jgY4;\n\tMon, 11 Sep 2017 22:53:52 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id OuVR24VhIiri; Mon, 11 Sep 2017 22:53:52 +0200 (CEST)","from [192.168.2.222] (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tMon, 11 Sep 2017 22:53:51 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"ksUnonnDPs/Hs5OVLmxzKu4hZ2eyxrogIfhaxa8mUiw=","To":"Tom Rini ","References":"<1505067902-2530-1-git-send-email-lukma@denx.de>\n\t<20170911173105.GJ17058@bill-the-cat>","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"<4b8cb582-0cb0-c94e-860d-b2a45eea4322@denx.de>","Date":"Mon, 11 Sep 2017 22:53:51 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170911173105.GJ17058@bill-the-cat>","Content-Language":"en-US","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1768646,"web_url":"http://patchwork.ozlabs.org/comment/1768646/","msgid":"<20170914145530.GE23092@bill-the-cat>","list_archive_url":null,"date":"2017-09-14T14:55:30","subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Mon, Sep 11, 2017 at 10:53:51PM +0200, Łukasz Majewski wrote:\n> On 09/11/2017 07:31 PM, Tom Rini wrote:\n> >On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote:\n> >\n> >>This patch gives an opportunity to override the defined CONFIG_BOOTCOMMAND\n> >>(at files) with set of commands defined in\n> >>board _defconfig file.\n> >>\n> >>Rationale: This change allows having two different u-boot builds - one for\n> >>production and one (far more larger) for factory setup.\n> >>\n> >>Signed-off-by: Lukasz Majewski \n> >\n> >I don't get it, sorry. We need to move CONFIG_BOOTCOMMAND into Kconfig\n> >with some other logic so that distro_bootcmd stuff works.\n> >\n> \n> The state of the art:\n> ---------------------\n> \n> Many boards use CONFIG_BOOTCOMMAND as a set of commands to be\n> executed at boot time:\n> \n> bootcmd=CONFIG_BOOTCOMMAND\n> \n> One notable user of it is config_distro_bootcmd.h\n\nRight.\n\n> Rationale:\n> ----------\n> \n> With this patch I can:\n> \n> 1. Setup one set of commands to be executed by default - e.g.:\n> \n> bootcmd=\"run boot_mmc\"\n> \n> and\n> \n> 2. Have other defconfig - e.g. _factory_defconfig, which\n> enables some extra stuff (like USB, gadget, gpt write, etc) and is\n> used solely for factory flashing.\n> \n> By having the opportunity to override CONFIG_BOOTCOMMAND in Kconfig,\n> I can use the same code base and just adjust Kconfig for board.\n> \n> \n> What do you mean by \"some other logic\"?\n\nWell, CONFIG_BOOTCOMMAND needs to be moved to Kconfig itself. Figuring\nout some of the \"how\" will take a little work. And a little\nre-organization. But that needs doing.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"EGCfS7wU\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtM634vmPz9sPt\n\tfor ;\n\tFri, 15 Sep 2017 00:55:39 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 6B2FDC21DCE; Thu, 14 Sep 2017 14:55:36 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C9078C21C59;\n\tThu, 14 Sep 2017 14:55:33 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 890A8C21C59; Thu, 14 Sep 2017 14:55:32 +0000 (UTC)","from mail-yw0-f179.google.com (mail-yw0-f179.google.com\n\t[209.85.161.179])\n\tby lists.denx.de (Postfix) with ESMTPS id E572EC21C57\n\tfor ; Thu, 14 Sep 2017 14:55:31 +0000 (UTC)","by mail-yw0-f179.google.com with SMTP id o143so394334ywd.12\n\tfor ; Thu, 14 Sep 2017 07:55:31 -0700 (PDT)","from bill-the-cat ([2606:a000:140b:dc:d5bb:7ea9:8de7:8926])\n\tby smtp.gmail.com with ESMTPSA id\n\tn186sm5813797ywn.12.2017.09.14.07.55.29\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 14 Sep 2017 07:55:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=7x+5GlBZtBP7oDOvgmDodHA+QXSyaq8haRPU4pFcCq4=;\n\tb=EGCfS7wUQHiLD1Ycq7y806U6sCB73wRQNtkP2xjEQJzAoR+vi/uPtWrVC59av88s4N\n\t66lSKAgU+TXKvh2x/316/9+77zsaMKmIleZzSsMnYl4p4SSVK+YqW4JPayf1quXqTu1U\n\tjK1rDZtGyZUZFv4syj9ljRzxzWa5jWfEMyWCA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=7x+5GlBZtBP7oDOvgmDodHA+QXSyaq8haRPU4pFcCq4=;\n\tb=IVJX1BPtkIgjTBqkytXTbOdmfPBvosxXnd5Yij8aAGdrTRWXUamPzFHwwh8ze7l6IP\n\tzkVWB5xr93yYOyHetQJBlz5Ef+jYRLZWFpc5g8L5Qqhhs8o3LLkxr71KGk+nAJz6AKjJ\n\tnmLEHux6ki4K0jzhckI8nT/o98DvFxoiSDFrSEbHw6nzw/bZJ3NqmqQpxxejDzi20NMY\n\tBqbFzuiVpJ8MP8yow3TpwW4FOLdwT2BIEZveuXkRmussO/LsazMtwvII/mMUL2ibMIv6\n\td/6c+Drm+7eYyWRWOjZRZqEXNcXDuVs9CNAk1wdddOYmf8JhF0EhLYlzGEZdhIeuG6VG\n\tA8+Q==","X-Gm-Message-State":"AHPjjUgO8RHm6FFW9iK0A4xq1nab/40h3BSwoiLegyQoNAeJlO1oTgyi\n\tLqnNE9taGgs0Xn2+s+djfg==","X-Google-Smtp-Source":"ADKCNb6D6+gQWEJiEbcx/RbfECRyFc0LVnC8lykhhGOKt+k9c6MGH4E59BstBe7aWNqvEAqvuwe8ew==","X-Received":"by 10.129.146.66 with SMTP id j63mr18612047ywg.137.1505400930792;\n\tThu, 14 Sep 2017 07:55:30 -0700 (PDT)","Date":"Thu, 14 Sep 2017 10:55:30 -0400","From":"Tom Rini ","To":"=?utf-8?q?=C5=81ukasz?= Majewski ","Message-ID":"<20170914145530.GE23092@bill-the-cat>","References":"<1505067902-2530-1-git-send-email-lukma@denx.de>\n\t<20170911173105.GJ17058@bill-the-cat>\n\t<4b8cb582-0cb0-c94e-860d-b2a45eea4322@denx.de>","MIME-Version":"1.0","In-Reply-To":"<4b8cb582-0cb0-c94e-860d-b2a45eea4322@denx.de>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1284824758091838327==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1777938,"web_url":"http://patchwork.ozlabs.org/comment/1777938/","msgid":"<1d7d00b0-62c3-a67d-9efc-dbc9af4943dc@denx.de>","list_archive_url":null,"date":"2017-09-30T20:20:47","subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"On 09/14/2017 04:55 PM, Tom Rini wrote:\n> On Mon, Sep 11, 2017 at 10:53:51PM +0200, Łukasz Majewski wrote:\n>> On 09/11/2017 07:31 PM, Tom Rini wrote:\n>>> On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote:\n>>>\n>>>> This patch gives an opportunity to override the defined CONFIG_BOOTCOMMAND\n>>>> (at files) with set of commands defined in\n>>>> board _defconfig file.\n>>>>\n>>>> Rationale: This change allows having two different u-boot builds - one for\n>>>> production and one (far more larger) for factory setup.\n>>>>\n>>>> Signed-off-by: Lukasz Majewski \n>>>\n>>> I don't get it, sorry. We need to move CONFIG_BOOTCOMMAND into Kconfig\n>>> with some other logic so that distro_bootcmd stuff works.\n>>>\n>>\n>> The state of the art:\n>> ---------------------\n>>\n>> Many boards use CONFIG_BOOTCOMMAND as a set of commands to be\n>> executed at boot time:\n>>\n>> bootcmd=CONFIG_BOOTCOMMAND\n>>\n>> One notable user of it is config_distro_bootcmd.h\n> \n> Right.\n> \n>> Rationale:\n>> ----------\n>>\n>> With this patch I can:\n>>\n>> 1. Setup one set of commands to be executed by default - e.g.:\n>>\n>> bootcmd=\"run boot_mmc\"\n>>\n>> and\n>>\n>> 2. Have other defconfig - e.g. _factory_defconfig, which\n>> enables some extra stuff (like USB, gadget, gpt write, etc) and is\n>> used solely for factory flashing.\n>>\n>> By having the opportunity to override CONFIG_BOOTCOMMAND in Kconfig,\n>> I can use the same code base and just adjust Kconfig for board.\n>>\n>>\n>> What do you mean by \"some other logic\"?\n> \n> Well, CONFIG_BOOTCOMMAND needs to be moved to Kconfig itself. Figuring\n> out some of the \"how\" will take a little work. And a little\n> re-organization. But that needs doing.\n> \n\nCannot we start with the approach proposed by this commit?\n\nHow would you see the rework done?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y4KZB06ZDz9t32\n\tfor ;\n\tSun, 1 Oct 2017 07:21:04 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 51E01C21E51; Sat, 30 Sep 2017 20:20:55 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1BF48C21C34;\n\tSat, 30 Sep 2017 20:20:52 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 964BFC21C34; Sat, 30 Sep 2017 20:20:50 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 8BDC7C21C2B\n\tfor ; Sat, 30 Sep 2017 20:20:49 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3y4KYs2BSRz1qqkg;\n\tSat, 30 Sep 2017 22:20:49 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3y4KYs1kNBz1qqkZ;\n\tSat, 30 Sep 2017 22:20:49 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id RArL28863WuM; Sat, 30 Sep 2017 22:20:48 +0200 (CEST)","from [192.168.2.222] (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tSat, 30 Sep 2017 22:20:48 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"wLG2oaZe7agAMuwbES6BIeORP2xBWT1qtPbZL7K9mx0=","To":"Tom Rini ","References":"<1505067902-2530-1-git-send-email-lukma@denx.de>\n\t<20170911173105.GJ17058@bill-the-cat>\n\t<4b8cb582-0cb0-c94e-860d-b2a45eea4322@denx.de>\n\t<20170914145530.GE23092@bill-the-cat>","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"<1d7d00b0-62c3-a67d-9efc-dbc9af4943dc@denx.de>","Date":"Sat, 30 Sep 2017 22:20:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170914145530.GE23092@bill-the-cat>","Content-Language":"en-US","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1777967,"web_url":"http://patchwork.ozlabs.org/comment/1777967/","msgid":"<20171001004128.GF3503@bill-the-cat>","list_archive_url":null,"date":"2017-10-01T00:41:28","subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Sat, Sep 30, 2017 at 10:20:47PM +0200, Łukasz Majewski wrote:\n> On 09/14/2017 04:55 PM, Tom Rini wrote:\n> >On Mon, Sep 11, 2017 at 10:53:51PM +0200, Łukasz Majewski wrote:\n> >>On 09/11/2017 07:31 PM, Tom Rini wrote:\n> >>>On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote:\n> >>>\n> >>>>This patch gives an opportunity to override the defined CONFIG_BOOTCOMMAND\n> >>>>(at files) with set of commands defined in\n> >>>>board _defconfig file.\n> >>>>\n> >>>>Rationale: This change allows having two different u-boot builds - one for\n> >>>>production and one (far more larger) for factory setup.\n> >>>>\n> >>>>Signed-off-by: Lukasz Majewski \n> >>>\n> >>>I don't get it, sorry. We need to move CONFIG_BOOTCOMMAND into Kconfig\n> >>>with some other logic so that distro_bootcmd stuff works.\n> >>>\n> >>\n> >>The state of the art:\n> >>---------------------\n> >>\n> >>Many boards use CONFIG_BOOTCOMMAND as a set of commands to be\n> >>executed at boot time:\n> >>\n> >>bootcmd=CONFIG_BOOTCOMMAND\n> >>\n> >>One notable user of it is config_distro_bootcmd.h\n> >\n> >Right.\n> >\n> >>Rationale:\n> >>----------\n> >>\n> >>With this patch I can:\n> >>\n> >>1. Setup one set of commands to be executed by default - e.g.:\n> >>\n> >>bootcmd=\"run boot_mmc\"\n> >>\n> >>and\n> >>\n> >>2. Have other defconfig - e.g. _factory_defconfig, which\n> >>enables some extra stuff (like USB, gadget, gpt write, etc) and is\n> >>used solely for factory flashing.\n> >>\n> >>By having the opportunity to override CONFIG_BOOTCOMMAND in Kconfig,\n> >>I can use the same code base and just adjust Kconfig for board.\n> >>\n> >>\n> >>What do you mean by \"some other logic\"?\n> >\n> >Well, CONFIG_BOOTCOMMAND needs to be moved to Kconfig itself. Figuring\n> >out some of the \"how\" will take a little work. And a little\n> >re-organization. But that needs doing.\n>\n> \n> Cannot we start with the approach proposed by this commit?\n> \n> How would you see the rework done?\n\nI'd like to see something that tries to move CONFIG_BOOTCOMMAND around.\nMove the distro boot things into include/environment/ and use the\npost-processed command as value in configs/*_defconfig as fits, or put\nthings into something else in include/environment/ for other repeated\nbut not distro boot commands.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"rPXIXUbn\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y4RLy0cBHz9t2h\n\tfor ;\n\tSun, 1 Oct 2017 11:41:44 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 4015AC21DEB; Sun, 1 Oct 2017 00:41:38 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 53401C21D57;\n\tSun, 1 Oct 2017 00:41:35 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 449D6C21D57; Sun, 1 Oct 2017 00:41:33 +0000 (UTC)","from mail-yw0-f182.google.com (mail-yw0-f182.google.com\n\t[209.85.161.182])\n\tby lists.denx.de (Postfix) with ESMTPS id 6B60DC21C4C\n\tfor ; Sun, 1 Oct 2017 00:41:32 +0000 (UTC)","by mail-yw0-f182.google.com with SMTP id v72so1815855ywa.3\n\tfor ; Sat, 30 Sep 2017 17:41:32 -0700 (PDT)","from bill-the-cat ([2606:a000:1401:811b:8d6c:b934:258:b45f])\n\tby smtp.gmail.com with ESMTPSA id\n\tu65sm3092307ywa.40.2017.09.30.17.41.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 30 Sep 2017 17:41:30 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=vqb2POaW9SD6sExt85xHOZocayqlFrANZ1zW6Kn72fw=;\n\tb=rPXIXUbnPoh3vbJJFvkAyXpWKqctyjq0R4f4rPIaECF4jcV05g3UnW6A8Xq/3u28lK\n\tBMgsaET5x6f2R8xP/9POaNqM1/FGT2AbQ5UZYspTZ2V0lI77mG+DjEt5zn29tw4p7ZFu\n\tQd0it6tIfw/b0GhfDelWhY6wywwuLsTuB2NoY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=vqb2POaW9SD6sExt85xHOZocayqlFrANZ1zW6Kn72fw=;\n\tb=IUAher+9hDYjdJ8EUnZSSG4i1KZRBZwb2DjVVbx9Hbgc9LNOB92q+zv2jpN0Jy3FY8\n\tpMtWJtcZCWrJryDp5fiaMKEeEOwIXkNr8P3urHLE+Q4WRYxa4orOn5f8Z84m0ATV+b1O\n\tJBdRLXRBlX9flSvn/dzr/iNP6XcmOWz1t3sTQWgRcZdSvVfUI5GNxykcbYSyW5ya1yEm\n\tBjt5nS442bPoYRzWbesluIUh8XMam1VOt/gzwI5CWQis9wFoy0aTu27yIEYpZckpolgZ\n\tAE0yg49dlDdW8GL/Fo4p+r6+KJaiaybsj+PNXUN8g2KplKTYLiaDaayuXYbFrO92HXQg\n\tHNRg==","X-Gm-Message-State":"AHPjjUh1+AGxAlUS/7ZGvxJ++ZqqB8Y58GSaj/2gsi1/2X7+zGjCzcau\n\tj+lrA1Wx8H0ywpPa+aDMzstnJA==","X-Google-Smtp-Source":"AOwi7QBzWK/QrUoathyOnyGdKsQlu55fSBQuxiKOpXTDMqWdLHRfMPVTUqy2cC7kqr6K/oVCTDhmGw==","X-Received":"by 10.129.96.87 with SMTP id u84mr9341297ywb.190.1506818491151; \n\tSat, 30 Sep 2017 17:41:31 -0700 (PDT)","Date":"Sat, 30 Sep 2017 20:41:28 -0400","From":"Tom Rini ","To":"=?utf-8?q?=C5=81ukasz?= Majewski ","Message-ID":"<20171001004128.GF3503@bill-the-cat>","References":"<1505067902-2530-1-git-send-email-lukma@denx.de>\n\t<20170911173105.GJ17058@bill-the-cat>\n\t<4b8cb582-0cb0-c94e-860d-b2a45eea4322@denx.de>\n\t<20170914145530.GE23092@bill-the-cat>\n\t<1d7d00b0-62c3-a67d-9efc-dbc9af4943dc@denx.de>","MIME-Version":"1.0","In-Reply-To":"<1d7d00b0-62c3-a67d-9efc-dbc9af4943dc@denx.de>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============5711394770837585822==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1778199,"web_url":"http://patchwork.ozlabs.org/comment/1778199/","msgid":"","list_archive_url":null,"date":"2017-10-02T08:19:56","subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"On 10/01/2017 02:41 AM, Tom Rini wrote:\n> On Sat, Sep 30, 2017 at 10:20:47PM +0200, Łukasz Majewski wrote:\n>> On 09/14/2017 04:55 PM, Tom Rini wrote:\n>>> On Mon, Sep 11, 2017 at 10:53:51PM +0200, Łukasz Majewski wrote:\n>>>> On 09/11/2017 07:31 PM, Tom Rini wrote:\n>>>>> On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote:\n>>>>>\n>>>>>> This patch gives an opportunity to override the defined CONFIG_BOOTCOMMAND\n>>>>>> (at files) with set of commands defined in\n>>>>>> board _defconfig file.\n>>>>>>\n>>>>>> Rationale: This change allows having two different u-boot builds - one for\n>>>>>> production and one (far more larger) for factory setup.\n>>>>>>\n>>>>>> Signed-off-by: Lukasz Majewski \n>>>>>\n>>>>> I don't get it, sorry. We need to move CONFIG_BOOTCOMMAND into Kconfig\n>>>>> with some other logic so that distro_bootcmd stuff works.\n>>>>>\n>>>>\n>>>> The state of the art:\n>>>> ---------------------\n>>>>\n>>>> Many boards use CONFIG_BOOTCOMMAND as a set of commands to be\n>>>> executed at boot time:\n>>>>\n>>>> bootcmd=CONFIG_BOOTCOMMAND\n>>>>\n>>>> One notable user of it is config_distro_bootcmd.h\n>>>\n>>> Right.\n>>>\n>>>> Rationale:\n>>>> ----------\n>>>>\n>>>> With this patch I can:\n>>>>\n>>>> 1. Setup one set of commands to be executed by default - e.g.:\n>>>>\n>>>> bootcmd=\"run boot_mmc\"\n>>>>\n>>>> and\n>>>>\n>>>> 2. Have other defconfig - e.g. _factory_defconfig, which\n>>>> enables some extra stuff (like USB, gadget, gpt write, etc) and is\n>>>> used solely for factory flashing.\n>>>>\n>>>> By having the opportunity to override CONFIG_BOOTCOMMAND in Kconfig,\n>>>> I can use the same code base and just adjust Kconfig for board.\n>>>>\n>>>>\n>>>> What do you mean by \"some other logic\"?\n>>>\n>>> Well, CONFIG_BOOTCOMMAND needs to be moved to Kconfig itself. Figuring\n>>> out some of the \"how\" will take a little work. And a little\n>>> re-organization. But that needs doing.\n>>\n>>\n>> Cannot we start with the approach proposed by this commit?\n>>\n>> How would you see the rework done?\n> \n> I'd like to see something that tries to move CONFIG_BOOTCOMMAND around.\n> Move the distro boot things into include/environment/ and use the\n> post-processed command as value in configs/*_defconfig as fits, or put\n> things into something else in include/environment/ for other repeated\n> but not distro boot commands.\n> \n\nThe proposed above changes are orthogonal to this patch.\n\nThis patch _only_ gives the opportunity to override current BOOTCOMMAND \nsettings.\nThis functionality allows the same code base for two distinct u-boot \nbuilds - namely factory (for flashing) and production one.\n\nSuch approach is very convenient with OE builds.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5FTP5K8Cz9t4X\n\tfor ;\n\tMon, 2 Oct 2017 19:20:08 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid AE482C21DF4; Mon, 2 Oct 2017 08:20:03 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C9E8AC21CA5;\n\tMon, 2 Oct 2017 08:20:00 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D51ADC21CA5; Mon, 2 Oct 2017 08:19:58 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 85C72C21C41\n\tfor ; Mon, 2 Oct 2017 08:19:58 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3y5FTB28WXz1qrNS;\n\tMon, 2 Oct 2017 10:19:58 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3y5FTB1VrDz1qr4Z;\n\tMon, 2 Oct 2017 10:19:58 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id iZcA9NAL7chx; Mon, 2 Oct 2017 10:19:57 +0200 (CEST)","from [192.168.2.222] (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tMon, 2 Oct 2017 10:19:57 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"ym+vcwraaCd6sK0EFl0VFjbL8Mq39oJJFT3aLTrOB5Q=","To":"Tom Rini ","References":"<1505067902-2530-1-git-send-email-lukma@denx.de>\n\t<20170911173105.GJ17058@bill-the-cat>\n\t<4b8cb582-0cb0-c94e-860d-b2a45eea4322@denx.de>\n\t<20170914145530.GE23092@bill-the-cat>\n\t<1d7d00b0-62c3-a67d-9efc-dbc9af4943dc@denx.de>\n\t<20171001004128.GF3503@bill-the-cat>","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"","Date":"Mon, 2 Oct 2017 10:19:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20171001004128.GF3503@bill-the-cat>","Content-Language":"en-US","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1794800,"web_url":"http://patchwork.ozlabs.org/comment/1794800/","msgid":"<20171027140453.426edc2d@jawa>","list_archive_url":null,"date":"2017-10-27T12:04:53","subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"Hi Tom,\n\n> On Sat, Sep 30, 2017 at 10:20:47PM +0200, Łukasz Majewski wrote:\n> > On 09/14/2017 04:55 PM, Tom Rini wrote:\n> > >On Mon, Sep 11, 2017 at 10:53:51PM +0200, Łukasz Majewski wrote:\n> > >>On 09/11/2017 07:31 PM, Tom Rini wrote:\n> > >>>On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote:\n> > >>>\n> > >>>>This patch gives an opportunity to override the defined\n> > >>>>CONFIG_BOOTCOMMAND (at files) with set of\n> > >>>>commands defined in board _defconfig file.\n> > >>>>\n> > >>>>Rationale: This change allows having two different u-boot\n> > >>>>builds - one for production and one (far more larger) for\n> > >>>>factory setup.\n> > >>>>\n> > >>>>Signed-off-by: Lukasz Majewski \n> > >>>\n> > >>>I don't get it, sorry. We need to move CONFIG_BOOTCOMMAND into\n> > >>>Kconfig with some other logic so that distro_bootcmd stuff works.\n> > >>>\n> > >>\n> > >>The state of the art:\n> > >>---------------------\n> > >>\n> > >>Many boards use CONFIG_BOOTCOMMAND as a set of commands to be\n> > >>executed at boot time:\n> > >>\n> > >>bootcmd=CONFIG_BOOTCOMMAND\n> > >>\n> > >>One notable user of it is config_distro_bootcmd.h\n> > >\n> > >Right.\n> > >\n> > >>Rationale:\n> > >>----------\n> > >>\n> > >>With this patch I can:\n> > >>\n> > >>1. Setup one set of commands to be executed by default - e.g.:\n> > >>\n> > >>bootcmd=\"run boot_mmc\"\n> > >>\n> > >>and\n> > >>\n> > >>2. Have other defconfig - e.g. _factory_defconfig, which\n> > >>enables some extra stuff (like USB, gadget, gpt write, etc) and is\n> > >>used solely for factory flashing.\n> > >>\n> > >>By having the opportunity to override CONFIG_BOOTCOMMAND in\n> > >>Kconfig, I can use the same code base and just adjust Kconfig for\n> > >>board.\n> > >>\n> > >>\n> > >>What do you mean by \"some other logic\"?\n> > >\n> > >Well, CONFIG_BOOTCOMMAND needs to be moved to Kconfig itself.\n> > >Figuring out some of the \"how\" will take a little work. And a\n> > >little re-organization. But that needs doing.\n> >\n> > \n> > Cannot we start with the approach proposed by this commit?\n> > \n> > How would you see the rework done?\n> \n> I'd like to see something that tries to move CONFIG_BOOTCOMMAND\n> around. Move the distro boot things into include/environment/ and use\n> the post-processed command as value in configs/*_defconfig as fits,\n> or put things into something else in include/environment/ for other\n> repeated but not distro boot commands.\n> \n\nI've not received any reply from you regarding following argument for\nthis patch:\n\nThe proposed above changes are orthogonal to this patch.\n\nThis patch _only_ gives the opportunity to override current BOOTCOMMAND \nsettings.\nThis functionality allows the same code base for two distinct u-boot \nbuilds - namely factory (for flashing) and production one.\n\nSuch approach is very convenient with OE builds.\n\n\n\nThe whole discussion can be find at:\nhttps://patchwork.ozlabs.org/patch/812174/\n\n\nBest regards,\n\nLukasz Majewski\n\n--\n\nDENX Software Engineering GmbH, Managing Director: Wolfgang Denk\nHRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany\nPhone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNjHb6LSWz9t2h\n\tfor ;\n\tFri, 27 Oct 2017 23:05:15 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 864D0C21D8C; Fri, 27 Oct 2017 12:05:12 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A7C59C21C4E;\n\tFri, 27 Oct 2017 12:05:09 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 494FDC21C4E; Fri, 27 Oct 2017 12:05:08 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 54FA2C21C46\n\tfor ; Fri, 27 Oct 2017 12:05:06 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3yNjHQ1GCLz1s06y;\n\tFri, 27 Oct 2017 14:05:06 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3yNjHQ0pdxz1tSmG;\n\tFri, 27 Oct 2017 14:05:06 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id fbfyL_G9E6Ql; Fri, 27 Oct 2017 14:05:03 +0200 (CEST)","from jawa (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tFri, 27 Oct 2017 14:05:03 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"yOKLMbIUfrKDIIuzg4l4Hq9lLVFqtnAjKvDabrTZd8k=","Date":"Fri, 27 Oct 2017 14:04:53 +0200","From":"Lukasz Majewski ","To":"Tom Rini ","Message-ID":"<20171027140453.426edc2d@jawa>","In-Reply-To":"<20171001004128.GF3503@bill-the-cat>","References":"<1505067902-2530-1-git-send-email-lukma@denx.de>\n\t<20170911173105.GJ17058@bill-the-cat>\n\t<4b8cb582-0cb0-c94e-860d-b2a45eea4322@denx.de>\n\t<20170914145530.GE23092@bill-the-cat>\n\t<1d7d00b0-62c3-a67d-9efc-dbc9af4943dc@denx.de>\n\t<20171001004128.GF3503@bill-the-cat>","Organization":"denx.de","X-Mailer":"Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1885880935934935977==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1799740,"web_url":"http://patchwork.ozlabs.org/comment/1799740/","msgid":"<20171106143226.GJ32663@bill-the-cat>","list_archive_url":null,"date":"2017-11-06T14:32:26","subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Fri, Oct 27, 2017 at 02:04:53PM +0200, Lukasz Majewski wrote:\n> Hi Tom,\n> \n> > On Sat, Sep 30, 2017 at 10:20:47PM +0200, Łukasz Majewski wrote:\n> > > On 09/14/2017 04:55 PM, Tom Rini wrote:\n> > > >On Mon, Sep 11, 2017 at 10:53:51PM +0200, Łukasz Majewski wrote:\n> > > >>On 09/11/2017 07:31 PM, Tom Rini wrote:\n> > > >>>On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski wrote:\n> > > >>>\n> > > >>>>This patch gives an opportunity to override the defined\n> > > >>>>CONFIG_BOOTCOMMAND (at files) with set of\n> > > >>>>commands defined in board _defconfig file.\n> > > >>>>\n> > > >>>>Rationale: This change allows having two different u-boot\n> > > >>>>builds - one for production and one (far more larger) for\n> > > >>>>factory setup.\n> > > >>>>\n> > > >>>>Signed-off-by: Lukasz Majewski \n> > > >>>\n> > > >>>I don't get it, sorry. We need to move CONFIG_BOOTCOMMAND into\n> > > >>>Kconfig with some other logic so that distro_bootcmd stuff works.\n> > > >>>\n> > > >>\n> > > >>The state of the art:\n> > > >>---------------------\n> > > >>\n> > > >>Many boards use CONFIG_BOOTCOMMAND as a set of commands to be\n> > > >>executed at boot time:\n> > > >>\n> > > >>bootcmd=CONFIG_BOOTCOMMAND\n> > > >>\n> > > >>One notable user of it is config_distro_bootcmd.h\n> > > >\n> > > >Right.\n> > > >\n> > > >>Rationale:\n> > > >>----------\n> > > >>\n> > > >>With this patch I can:\n> > > >>\n> > > >>1. Setup one set of commands to be executed by default - e.g.:\n> > > >>\n> > > >>bootcmd=\"run boot_mmc\"\n> > > >>\n> > > >>and\n> > > >>\n> > > >>2. Have other defconfig - e.g. _factory_defconfig, which\n> > > >>enables some extra stuff (like USB, gadget, gpt write, etc) and is\n> > > >>used solely for factory flashing.\n> > > >>\n> > > >>By having the opportunity to override CONFIG_BOOTCOMMAND in\n> > > >>Kconfig, I can use the same code base and just adjust Kconfig for\n> > > >>board.\n> > > >>\n> > > >>\n> > > >>What do you mean by \"some other logic\"?\n> > > >\n> > > >Well, CONFIG_BOOTCOMMAND needs to be moved to Kconfig itself.\n> > > >Figuring out some of the \"how\" will take a little work. And a\n> > > >little re-organization. But that needs doing.\n> > >\n> > > \n> > > Cannot we start with the approach proposed by this commit?\n> > > \n> > > How would you see the rework done?\n> > \n> > I'd like to see something that tries to move CONFIG_BOOTCOMMAND\n> > around. Move the distro boot things into include/environment/ and use\n> > the post-processed command as value in configs/*_defconfig as fits,\n> > or put things into something else in include/environment/ for other\n> > repeated but not distro boot commands.\n> > \n> \n> I've not received any reply from you regarding following argument for\n> this patch:\n> \n> The proposed above changes are orthogonal to this patch.\n> \n> This patch _only_ gives the opportunity to override current BOOTCOMMAND \n> settings.\n> This functionality allows the same code base for two distinct u-boot \n> builds - namely factory (for flashing) and production one.\n> \n> Such approach is very convenient with OE builds.\n\nThe problem I see is that we should instead move CONFIG_BOOTCOMMAND to\nKconfig and OE/similar can override bootcmd via .cfg or similar. To\nthat end, I've started the migration at least for distro_bootcmd and\nsome of the cases where it's not just 'run distro_bootcmd' being used.\nI hope to post it shortly, once I've migrated a few more options.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"TRsa/ISe\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3yVw546rhgz9ryT\n\tfor ;\n\tTue, 7 Nov 2017 01:32:40 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid A51D8C21EC8; Mon, 6 Nov 2017 14:32:34 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 0667FC21C73;\n\tMon, 6 Nov 2017 14:32:32 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 17CE3C21C73; Mon, 6 Nov 2017 14:32:31 +0000 (UTC)","from mail-yw0-f196.google.com (mail-yw0-f196.google.com\n\t[209.85.161.196])\n\tby lists.denx.de (Postfix) with ESMTPS id 7CEFEC21C60\n\tfor ; Mon, 6 Nov 2017 14:32:30 +0000 (UTC)","by mail-yw0-f196.google.com with SMTP id j4so7949207ywb.2\n\tfor ; Mon, 06 Nov 2017 06:32:30 -0800 (PST)","from bill-the-cat (cpe-65-184-142-68.ec.res.rr.com.\n\t[65.184.142.68]) by smtp.gmail.com with ESMTPSA id\n\tr29sm6164762ywa.79.2017.11.06.06.32.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 06 Nov 2017 06:32:28 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=ef7bPmhAeAEQjqnxx8v7B45D49ouJBTOsgfmLC1LfRE=;\n\tb=TRsa/ISeibWUic98US1KgMkNACaGZ+Gwr/XyhDML92X2a6tKqd8hBjbLMlb6KkRZsH\n\tQG+pZL76+kW5xOMXC7rSQ3srRGq0uVYPbMS6lPPXeV91t/OfaL1+EK03IanLlqBTIUdu\n\t1cGcyRTmP7APt2JW/7bYOshLP3Itq1Rn4xvXo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=ef7bPmhAeAEQjqnxx8v7B45D49ouJBTOsgfmLC1LfRE=;\n\tb=IKZ47MmlDn8N/HSYhxlcd88OEVl/ThvvFxGg/ZdifiHMfo6In4C2Oe49Sl28IB0REb\n\tq24Pdgfc0Go1apJWlelF+QyRHNjoeCN4bTfAk5IOvR8x/l+qP+tYRYo3pWjBOOPHv23k\n\tOSOBvozLl4LiHmLdNhDDqmdmL9dsg4GEPJvuOthfu++oKoLY1U1jsmfeNfTA3qk7+d2D\n\tvVq3pUmXvdkTZKGZPWZzTk1M8RCdCvll49nJLqVvCUojPmqYwn2WcXlOpzKlaZPAT+TK\n\tCzUMRfj4VvV+H6VrQOgHHWkjjp2rpdAR8idAiWTTvB22548dXQ8DhlS7gyzXIAY2BlDt\n\tk6qQ==","X-Gm-Message-State":"AMCzsaWjuxxQZntnaOm66WWZnH31luev1Mo61HRZInGd6oVCwMcdxRwU\n\tZpN8rti2Q+2tg2cAm6BCOVWIK10F08U=","X-Google-Smtp-Source":"ABhQp+SV1GzFMme013Gpoj81VhRKIv+p4gaoenItsfbgEVyG4y7XuMjG9ylHnnKw5zTOX4tTlTjoqA==","X-Received":"by 10.37.190.139 with SMTP id i11mr9586012ybk.296.1509978749313; \n\tMon, 06 Nov 2017 06:32:29 -0800 (PST)","Date":"Mon, 6 Nov 2017 09:32:26 -0500","From":"Tom Rini ","To":"Lukasz Majewski ","Message-ID":"<20171106143226.GJ32663@bill-the-cat>","References":"<1505067902-2530-1-git-send-email-lukma@denx.de>\n\t<20170911173105.GJ17058@bill-the-cat>\n\t<4b8cb582-0cb0-c94e-860d-b2a45eea4322@denx.de>\n\t<20170914145530.GE23092@bill-the-cat>\n\t<1d7d00b0-62c3-a67d-9efc-dbc9af4943dc@denx.de>\n\t<20171001004128.GF3503@bill-the-cat> <20171027140453.426edc2d@jawa>","MIME-Version":"1.0","In-Reply-To":"<20171027140453.426edc2d@jawa>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============5157659544450651092==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1799874,"web_url":"http://patchwork.ozlabs.org/comment/1799874/","msgid":"<20171106183807.63150ab4@jawa>","list_archive_url":null,"date":"2017-11-06T17:38:07","subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"Hi Tom,\n\n> On Fri, Oct 27, 2017 at 02:04:53PM +0200, Lukasz Majewski wrote:\n> > Hi Tom,\n> > \n> > > On Sat, Sep 30, 2017 at 10:20:47PM +0200, Łukasz Majewski wrote: \n> > > > On 09/14/2017 04:55 PM, Tom Rini wrote: \n> > > > >On Mon, Sep 11, 2017 at 10:53:51PM +0200, Łukasz Majewski\n> > > > >wrote: \n> > > > >>On 09/11/2017 07:31 PM, Tom Rini wrote: \n> > > > >>>On Sun, Sep 10, 2017 at 08:25:02PM +0200, Lukasz Majewski\n> > > > >>>wrote:\n> > > > >>> \n> > > > >>>>This patch gives an opportunity to override the defined\n> > > > >>>>CONFIG_BOOTCOMMAND (at files) with set of\n> > > > >>>>commands defined in board _defconfig file.\n> > > > >>>>\n> > > > >>>>Rationale: This change allows having two different u-boot\n> > > > >>>>builds - one for production and one (far more larger) for\n> > > > >>>>factory setup.\n> > > > >>>>\n> > > > >>>>Signed-off-by: Lukasz Majewski \n> > > > >>>\n> > > > >>>I don't get it, sorry. We need to move CONFIG_BOOTCOMMAND\n> > > > >>>into Kconfig with some other logic so that distro_bootcmd\n> > > > >>>stuff works.\n> > > > >>> \n> > > > >>\n> > > > >>The state of the art:\n> > > > >>---------------------\n> > > > >>\n> > > > >>Many boards use CONFIG_BOOTCOMMAND as a set of commands to be\n> > > > >>executed at boot time:\n> > > > >>\n> > > > >>bootcmd=CONFIG_BOOTCOMMAND\n> > > > >>\n> > > > >>One notable user of it is config_distro_bootcmd.h \n> > > > >\n> > > > >Right.\n> > > > > \n> > > > >>Rationale:\n> > > > >>----------\n> > > > >>\n> > > > >>With this patch I can:\n> > > > >>\n> > > > >>1. Setup one set of commands to be executed by default - e.g.:\n> > > > >>\n> > > > >>bootcmd=\"run boot_mmc\"\n> > > > >>\n> > > > >>and\n> > > > >>\n> > > > >>2. Have other defconfig - e.g. _factory_defconfig,\n> > > > >>which enables some extra stuff (like USB, gadget, gpt write,\n> > > > >>etc) and is used solely for factory flashing.\n> > > > >>\n> > > > >>By having the opportunity to override CONFIG_BOOTCOMMAND in\n> > > > >>Kconfig, I can use the same code base and just adjust Kconfig\n> > > > >>for board.\n> > > > >>\n> > > > >>\n> > > > >>What do you mean by \"some other logic\"? \n> > > > >\n> > > > >Well, CONFIG_BOOTCOMMAND needs to be moved to Kconfig itself.\n> > > > >Figuring out some of the \"how\" will take a little work. And a\n> > > > >little re-organization. But that needs doing. \n> > > >\n> > > > \n> > > > Cannot we start with the approach proposed by this commit?\n> > > > \n> > > > How would you see the rework done? \n> > > \n> > > I'd like to see something that tries to move CONFIG_BOOTCOMMAND\n> > > around. Move the distro boot things into include/environment/ and\n> > > use the post-processed command as value in configs/*_defconfig as\n> > > fits, or put things into something else in include/environment/\n> > > for other repeated but not distro boot commands.\n> > > \n> > \n> > I've not received any reply from you regarding following argument\n> > for this patch:\n> > \n> > The proposed above changes are orthogonal to this patch.\n> > \n> > This patch _only_ gives the opportunity to override current\n> > BOOTCOMMAND settings.\n> > This functionality allows the same code base for two distinct\n> > u-boot builds - namely factory (for flashing) and production one.\n> > \n> > Such approach is very convenient with OE builds. \n> \n> The problem I see is that we should instead move CONFIG_BOOTCOMMAND to\n> Kconfig and OE/similar can override bootcmd via .cfg or similar. To\n> that end, I've started the migration at least for distro_bootcmd and\n> some of the cases where it's not just 'run distro_bootcmd' being used.\n> I hope to post it shortly, once I've migrated a few more options.\n\nI see. Thanks for update on this topic.\n\n> \n\n\n\nBest regards,\n\nLukasz Majewski\n\n--\n\nDENX Software Engineering GmbH, Managing Director: Wolfgang Denk\nHRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany\nPhone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3yW0DP4SfMz9s7f\n\tfor ;\n\tTue, 7 Nov 2017 04:39:17 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 1B958C21DA3; Mon, 6 Nov 2017 17:38:52 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 10270C21DDD;\n\tMon, 6 Nov 2017 17:38:50 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 879E5C21DDD; Mon, 6 Nov 2017 17:38:09 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 521D6C21EFD\n\tfor ; Mon, 6 Nov 2017 17:38:09 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3yW0C513GYz1qsWF;\n\tMon, 6 Nov 2017 18:38:09 +0100 (CET)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3yW0C50bXZz1s37Q;\n\tMon, 6 Nov 2017 18:38:09 +0100 (CET)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id oCdInNrKbCQg; Mon, 6 Nov 2017 18:38:08 +0100 (CET)","from jawa (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tMon, 6 Nov 2017 18:38:08 +0100 (CET)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"qvPN0Fy/5PmGPdV63ylYmGEwXiDTlt6bNLuI/DY6OMQ=","Date":"Mon, 6 Nov 2017 18:38:07 +0100","From":"Lukasz Majewski ","To":"Tom Rini ","Message-ID":"<20171106183807.63150ab4@jawa>","In-Reply-To":"<20171106143226.GJ32663@bill-the-cat>","References":"<1505067902-2530-1-git-send-email-lukma@denx.de>\n\t<20170911173105.GJ17058@bill-the-cat>\n\t<4b8cb582-0cb0-c94e-860d-b2a45eea4322@denx.de>\n\t<20170914145530.GE23092@bill-the-cat>\n\t<1d7d00b0-62c3-a67d-9efc-dbc9af4943dc@denx.de>\n\t<20171001004128.GF3503@bill-the-cat> <20171027140453.426edc2d@jawa>\n\t<20171106143226.GJ32663@bill-the-cat>","Organization":"denx.de","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Cc":"u-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH] Kconfig: BOOTCOMMAND: Define default set of\n\tboot commands in Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============4743194756011237742==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]