[{"id":1768070,"web_url":"http://patchwork.ozlabs.org/comment/1768070/","msgid":"<07d31da3-65cf-f7ad-708b-b635afe5936c@linaro.org>","list_archive_url":null,"date":"2017-09-13T18:03:32","subject":"Re: [Qemu-devel] [PATCH 7/7] trace: Add event\n\t\"guest_inst_info_after\"","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/10/2017 09:39 AM, Lluís Vilanova wrote:\n> if (TRACE_GUEST_INST_AFTER_ENABLED && translated_insn) {\n> trace_guest_inst_after_tcg(cpu, tcg_ctx.tcg_env, pc_insn);\n> }\n> + if (TRACE_GUEST_INST_INFO_AFTER_ENABLED && translated_insn) {\n> + trace_guest_inst_info_after_tcg(\n> + cpu, tcg_ctx.tcg_env, pc_insn, insn_size);\n> + }\n\nSame comments re guest_inst + guest_inst_info, really.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"eM403CMR\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsqLK0341z9s7v\n\tfor ;\n\tThu, 14 Sep 2017 04:04:25 +1000 (AEST)","from localhost ([::1]:43931 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsC1P-0007Dc-4A\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 14:04:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59466)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsC0j-0007CK-2l\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:03:41 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsC0g-00072j-0c\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:03:41 -0400","from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]:47178)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsC0f-00072R-Tb\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:03:37 -0400","by mail-qk0-x233.google.com with SMTP id b82so2396326qkc.4\n\tfor ; Wed, 13 Sep 2017 11:03:37 -0700 (PDT)","from bigtime.twiddle.net (184-217-192-88.pools.spcsdns.net.\n\t[184.217.192.88]) by smtp.gmail.com with ESMTPSA id\n\to17sm8365479qkl.14.2017.09.13.11.03.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 11:03:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=DmSA8Og5+NCM4w78KTjc/ma5jn84qf03MjsgQ1OrYH0=;\n\tb=eM403CMRr0Qsfd3J/XoV8zYgVHxXwVavYQQXh58ZUpP7Qdqwpb9/7mk7ArJ8i8gACR\n\tBVudN8a6Oh9l9agg9GuNvW4HuIzRZuwWkCLK5fmDVCKjBpp8Udi97cQ957pKych42urA\n\tpNDSHHtDeLM7viTVyMVNdkpOrfYG/4ozyZhBk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=DmSA8Og5+NCM4w78KTjc/ma5jn84qf03MjsgQ1OrYH0=;\n\tb=amnr0WoIpG8DYksC5bK1yq7tsnWAzwDO/MHDOTbq7df0iG0R8PGTDmuJs8wWEkm3z6\n\tsu84gyEVSbhvcoEIOmKSfN6l/LAd31Ua8o8sHkOUux7JAkAq5d7F9dgMwJze89E+sMie\n\tqPxO6BJqn6DsndK8go0DVHe/+FajB/OP2XK/6757yKLWbq+s+1gL7xF9/UkkJ7PsHdSg\n\tSH8rs152Tq9/CO0bvQisiXnkH+BpHwY5WCP8fK1UzA8G0ODyp5ZTWws3kbz0HMRQgPFt\n\tBhtplYKlLGFVfFqvp6zabUtJu1zAf0Xjja0AYF7lsgbC8GTnLy80VKIsGYaC4DXocb1J\n\tV6zg==","X-Gm-Message-State":"AHPjjUihE3ApbCQx2IAuoKPij4hRtg47Q3CMcOpT8VKG3a1Wj6DlhDvS\n\tzh44v9rLymJuP3zV","X-Google-Smtp-Source":"AOwi7QDETqF5ee76G2qoasBSZQM0/tkeIXqUpuWzhKp7gMuGvtIJfZUkBhEN/8dQgIc+sdndEnrJbQ==","X-Received":"by 10.55.209.155 with SMTP id o27mr27465377qkl.145.1505325817365;\n\tWed, 13 Sep 2017 11:03:37 -0700 (PDT)","To":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ,\n\tqemu-devel@nongnu.org","References":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>\n\t<150506156146.19604.7064966029596517363.stgit@frigg.lan>","From":"Richard Henderson ","Message-ID":"<07d31da3-65cf-f7ad-708b-b635afe5936c@linaro.org>","Date":"Wed, 13 Sep 2017 11:03:32 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<150506156146.19604.7064966029596517363.stgit@frigg.lan>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::233","Subject":"Re: [Qemu-devel] [PATCH 7/7] trace: Add event\n\t\"guest_inst_info_after\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tPeter Crosthwaite ,\n\tStefan Hajnoczi ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]