[{"id":1768068,"web_url":"http://patchwork.ozlabs.org/comment/1768068/","msgid":"<3fb9d3ac-db86-2ff7-d6e1-988982d1eb18@linaro.org>","list_archive_url":null,"date":"2017-09-13T17:34:05","subject":"Re: [Qemu-devel] [PATCH 5/7] trace: Add event \"guest_bbl_after\"","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/10/2017 09:31 AM, Lluís Vilanova wrote:\n> +void translator__gen_goto_tb(TCGContext *ctx)\n> +{\n> + if (ctx->disas.in_guest_code &&\n> + (TRACE_GUEST_BBL_AFTER_ENABLED)) {\n> + if (ctx->disas.inline_label == NULL) {\n> + ctx->disas.inline_label = gen_new_inline_label();\n> + }\n> + gen_set_inline_point(ctx->disas.inline_label);\n> + /* disable next exit_tb */\n> + ctx->disas.seen_goto_tb = true;\n> + }\n> +}\n> +\n> +void translator__gen_exit_tb(TCGContext *ctx)\n> +{\n> + if (ctx->disas.in_guest_code && !ctx->disas.seen_goto_tb &&\n> + (TRACE_GUEST_BBL_AFTER_ENABLED)) {\n> + if (ctx->disas.inline_label == NULL) {\n> + ctx->disas.inline_label = gen_new_inline_label();\n> + }\n> + gen_set_inline_point(ctx->disas.inline_label);\n> + /* enable next exit_tb */\n> + ctx->disas.seen_goto_tb = false;\n> + }\n> +}\n\nI don't understand why you wouldn't just modify tcg_gen_goto_tb and\ntcg_gen_exit_tb instead.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"cXJOAk3I\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsqJz1mP2z9s7v\n\tfor ;\n\tThu, 14 Sep 2017 04:03:15 +1000 (AEST)","from localhost ([::1]:43929 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsC0H-00069h-Cm\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 14:03:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59082)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsBzo-00069R-By\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:02:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsBzl-0006JO-BP\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:02:44 -0400","from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:45267)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsBzl-0006J5-6x\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 14:02:41 -0400","by mail-qk0-x236.google.com with SMTP id r141so2419588qke.2\n\tfor ; Wed, 13 Sep 2017 11:02:41 -0700 (PDT)","from bigtime.twiddle.net (184-217-192-88.pools.spcsdns.net.\n\t[184.217.192.88]) by smtp.gmail.com with ESMTPSA id\n\tm4sm10579407qkm.66.2017.09.13.11.02.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 11:02:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=36t2hjZFO9cKDh2ATU4/MYsm1B5c4vvWpWdZLH3Pd38=;\n\tb=cXJOAk3IIM6xNOe5lR/KpP7Wsv7GUAvkVp7icNJaTJ1Hbm0yELA/I/A9og/l2KZrlf\n\tA7vLhMzsNj1CqSYROOFhns9logGC90HlqhywgFFgISPKbpyoRvlRmj/jPRnbFfoLRPwN\n\t+F11mce0fMWcgTH7ICtTzRa7jJIhiGNdQdjs0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=36t2hjZFO9cKDh2ATU4/MYsm1B5c4vvWpWdZLH3Pd38=;\n\tb=uANu27Coz1jcqXi4jUPvk9xTIStUpYbyfK51VlS62ghw1lEP+jcGENCMIZJdIM1hpF\n\tgoKml5ifIPs9DxZPUGlxczbXzy+r0AttGutrFXhuDqYMALt04QiMLoYxi7KpidWzP63H\n\tJ4eDTyNZ6cYIPfMBB0VqWklz9Zi45hPLCVKiKhtkz+tGLe0DXUBfhWDC+BqlA+HIX4vT\n\tRpa6cmHI/1DD1GttXwjX/1U7QhEh3j5cBPsH3PJdORGAp/aUZgKaI4SjvFhwDLckgEza\n\tR37usg17SDpXVnBDHiRbVoCf8/raeTJo90dSwUftMAeWl6b6gpZBPeVFvRSj4e/p7E8W\n\tLg9A==","X-Gm-Message-State":"AHPjjUhb+diRomirooafXuDZcJD3osl0gWCT4ydXiDbHGqEoiB8cErTw\n\t/OOeOuTSQQt2T981","X-Google-Smtp-Source":"AOwi7QBrph6MRnWtKbs+j22XMlEhaTsZsxf3zRpnRQJ9xlaiXl1VEx/KfrkKUohoRE5LxSgkrgyO2w==","X-Received":"by 10.55.72.81 with SMTP id v78mr25320821qka.333.1505325760415; \n\tWed, 13 Sep 2017 11:02:40 -0700 (PDT)","To":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ,\n\tqemu-devel@nongnu.org","References":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>\n\t<150506107741.19604.8328467942268087647.stgit@frigg.lan>","From":"Richard Henderson ","Message-ID":"<3fb9d3ac-db86-2ff7-d6e1-988982d1eb18@linaro.org>","Date":"Wed, 13 Sep 2017 10:34:05 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<150506107741.19604.8328467942268087647.stgit@frigg.lan>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c09::236","Subject":"Re: [Qemu-devel] [PATCH 5/7] trace: Add event \"guest_bbl_after\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tPeter Crosthwaite ,\n\tStefan Hajnoczi ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768670,"web_url":"http://patchwork.ozlabs.org/comment/1768670/","msgid":"<8760clpaqv.fsf@frigg.lan>","list_archive_url":null,"date":"2017-09-14T15:20:56","subject":"Re: [Qemu-devel] [PATCH 5/7] trace: Add event \"guest_bbl_after\"","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"content":"Richard Henderson writes:\n\n> On 09/10/2017 09:31 AM, Lluís Vilanova wrote:\n>> +void translator__gen_goto_tb(TCGContext *ctx)\n>> +{\n>> + if (ctx->disas.in_guest_code &&\n>> + (TRACE_GUEST_BBL_AFTER_ENABLED)) {\n>> + if (ctx->disas.inline_label == NULL) {\n>> + ctx->disas.inline_label = gen_new_inline_label();\n>> + }\n>> + gen_set_inline_point(ctx->disas.inline_label);\n>> + /* disable next exit_tb */\n>> + ctx->disas.seen_goto_tb = true;\n>> + }\n>> +}\n>> +\n>> +void translator__gen_exit_tb(TCGContext *ctx)\n>> +{\n>> + if (ctx->disas.in_guest_code && !ctx->disas.seen_goto_tb &&\n>> + (TRACE_GUEST_BBL_AFTER_ENABLED)) {\n>> + if (ctx->disas.inline_label == NULL) {\n>> + ctx->disas.inline_label = gen_new_inline_label();\n>> + }\n>> + gen_set_inline_point(ctx->disas.inline_label);\n>> + /* enable next exit_tb */\n>> + ctx->disas.seen_goto_tb = false;\n>> + }\n>> +}\n\n> I don't understand why you wouldn't just modify tcg_gen_goto_tb and\n> tcg_gen_exit_tb instead.\n\nI prefer to keep all generic translation-related tracing on a single file, where\nit is easier to reason about.\n\nCheers,\n Lluis","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtMjH3KQ0z9sPk\n\tfor ;\n\tFri, 15 Sep 2017 01:22:43 +1000 (AEST)","from localhost ([::1]:48386 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsVyT-0004Si-JV\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 11:22:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42075)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsVx2-00039r-PC\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 11:21:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsVww-0006eZ-Qr\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 11:21:12 -0400","from roura.ac.upc.es ([147.83.33.10]:53474)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsVww-0006e8-Fy\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 11:21:06 -0400","from correu-2.ac.upc.es (correu-2.ac.upc.es [147.83.30.92])\n\tby roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id v8EFL2Tp020008;\n\tThu, 14 Sep 2017 17:21:02 +0200","from localhost (unknown [132.68.50.201])\n\tby correu-2.ac.upc.es (Postfix) with ESMTPSA id 1C49B203;\n\tThu, 14 Sep 2017 17:20:56 +0200 (CEST)"],"From":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ","To":"Richard Henderson ","References":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>\n\t<150506107741.19604.8328467942268087647.stgit@frigg.lan>\n\t<3fb9d3ac-db86-2ff7-d6e1-988982d1eb18@linaro.org>","Mail-Followup-To":"Richard Henderson ,\n\tqemu-devel@nongnu.org, Paolo Bonzini , Richard\n\tHenderson , Stefan Hajnoczi ,\n\tPeter Crosthwaite ","Date":"Thu, 14 Sep 2017 18:20:56 +0300","In-Reply-To":"<3fb9d3ac-db86-2ff7-d6e1-988982d1eb18@linaro.org> (Richard\n\tHenderson's message of \"Wed, 13 Sep 2017 10:34:05 -0700\")","Message-ID":"<8760clpaqv.fsf@frigg.lan>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"147.83.33.10","Subject":"Re: [Qemu-devel] [PATCH 5/7] trace: Add event \"guest_bbl_after\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tPeter Crosthwaite ,\n\tqemu-devel@nongnu.org, Stefan Hajnoczi ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768714,"web_url":"http://patchwork.ozlabs.org/comment/1768714/","msgid":"","list_archive_url":null,"date":"2017-09-14T16:16:56","subject":"Re: [Qemu-devel] [PATCH 5/7] trace: Add event \"guest_bbl_after\"","submitter":{"id":2222,"url":"http://patchwork.ozlabs.org/api/people/2222/","name":"Richard Henderson","email":"rth@twiddle.net"},"content":"On 09/14/2017 08:20 AM, Lluís Vilanova wrote:\n>> I don't understand why you wouldn't just modify tcg_gen_goto_tb and\n>> tcg_gen_exit_tb instead.\n> \n> I prefer to keep all generic translation-related tracing on a single file, where\n> it is easier to reason about.\n\nMy point here was more about the inline_points. Discussed elsewhere now.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nJNM3Ti3\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtNwL1hCFz9ryQ\n\tfor ;\n\tFri, 15 Sep 2017 02:17:22 +1000 (AEST)","from localhost ([::1]:48815 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsWpM-0006mv-Ac\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 12:17:20 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46629)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsWp4-0006mX-PV\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 12:17:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsWp1-00008m-JD\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 12:17:02 -0400","from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:38423)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dsWp1-000087-Di\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 12:16:59 -0400","by mail-pg0-x241.google.com with SMTP id m30so1926967pgn.5\n\tfor ; Thu, 14 Sep 2017 09:16:59 -0700 (PDT)","from bigtime.twiddle.net (97-126-103-167.tukw.qwest.net.\n\t[97.126.103.167]) by smtp.googlemail.com with ESMTPSA id\n\tz1sm27306128pge.45.2017.09.14.09.16.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 14 Sep 2017 09:16:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=SQq1bromytnz8+sFiHumf/dceuJglNGD69ZhzYOlssI=;\n\tb=nJNM3Ti3w6j9Fv98IBPLlI91jkJtZ4uVdpGty5HeZvl/xDnyhG3yyyxx6vz2v323Lz\n\tGzjoX7I8nfCDM1vkX00bDOP3IObdeVmeRDOegxkOz7GIA+aDaTPHIPZE4AzHydPXRJOM\n\txdmWMHQxSA0ymugnObv6mU51N3nUlvJfhBN3XrN57LuYkiU6GKV2O8aPWPPukFADIyJM\n\tnZX0Y4PZCmWZY7aL8DoQuOAg29KGwYl/3fYxYzZcCAcslflDg9CXqGkf6qT0XAuHITJx\n\tKFTfoIrPcIHAigTzmm0r67xSVufsBWVqi/TikOY7C3LJjC9RXOkqjtGiNXSSNj4/2ml1\n\tfSow==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=SQq1bromytnz8+sFiHumf/dceuJglNGD69ZhzYOlssI=;\n\tb=tYrg3YcxlSsz+DdTmQl7jGPEMw5vXyMqRAz23rUyk63eNNxtRJ2y6vLhkl6gD7w3bd\n\tQqre1ECvIeB4D31hgWDJPhgjaPtb01FEiJZ7pItr+5zj6KIoRVGZWAB400cUY7PIkrQH\n\tW/Jf2BxrqyhiwOIlh8H4QGLiB3hw3DyYZOAq0m6yuRPe6SMqnKaHjw4ZxWpQe8DlBj25\n\tKl2gDoY37W3fqCEe2em+q0QT1GcouPfDbDopcqKOSwmhUeMYOUIBjNRMEgLHEybIH01k\n\tNCILGWwnN4We/tA/4xPJ8qRx5VEbqWCCiv+7lU/qWMlRSfQNm/oAuidjge94bOkrdyBJ\n\tqAgA==","X-Gm-Message-State":"AHPjjUgyHOQqU1CbxXfPZJ77MT5VmI0evG7dbPS2cqtvOKmYFnWDGJcp\n\tF5qF8loG6aJ9MuYeQmo=","X-Google-Smtp-Source":"ADKCNb4GxTkaCtaL8D/jluoMJxTm5d7N/OndH/NideUIIlt8JzHa7qecLHd00kcXXAhB2BCwYADBrA==","X-Received":"by 10.98.211.200 with SMTP id z69mr21292947pfk.112.1505405818553;\n\tThu, 14 Sep 2017 09:16:58 -0700 (PDT)","To":"Richard Henderson , qemu-devel@nongnu.org, \n\tPaolo Bonzini ,\n\tStefan Hajnoczi , \n\tPeter Crosthwaite ","References":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>\n\t<150506107741.19604.8328467942268087647.stgit@frigg.lan>\n\t<3fb9d3ac-db86-2ff7-d6e1-988982d1eb18@linaro.org>\n\t<8760clpaqv.fsf@frigg.lan>","From":"Richard Henderson ","Message-ID":"","Date":"Thu, 14 Sep 2017 09:16:56 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<8760clpaqv.fsf@frigg.lan>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::241","Subject":"Re: [Qemu-devel] [PATCH 5/7] trace: Add event \"guest_bbl_after\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]