[{"id":1768034,"web_url":"http://patchwork.ozlabs.org/comment/1768034/","msgid":"<0250ce97-bef3-1feb-d9a9-4e4a91084fa7@linaro.org>","list_archive_url":null,"date":"2017-09-13T17:07:44","subject":"Re: [Qemu-devel] [PATCH 3/7] trace: Add event\n\t\"guest_inst_info_before\"","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/10/2017 09:23 AM, Lluís Vilanova wrote:\n> Signed-off-by: Lluís Vilanova \n> ---\n> accel/tcg/translator.c | 18 ++++++++++++++++++\n> trace-events | 9 +++++++++\n> 2 files changed, 27 insertions(+)\n> \n> diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c\n> index 287d27b4f7..6598931171 100644\n> --- a/accel/tcg/translator.c\n> +++ b/accel/tcg/translator.c\n> @@ -70,6 +70,8 @@ void translator_loop(const TranslatorOps *ops, DisasContextBase *db,\n> \n> while (true) {\n> target_ulong pc_insn = db->pc_next;\n> + TCGv_i32 insn_size_tcg = 0;\n> + int insn_size_opcode_idx;\n\nInitializing a TCGv_i32 is wrong.\nAnd surely insn_size_opcode is surely uninitialized?\n\n> + if (TRACE_GUEST_INST_INFO_BEFORE_EXEC_ENABLED) {\n> + insn_size_tcg = tcg_temp_new_i32();\n> + insn_size_opcode_idx = tcg_op_buf_count();\n> + tcg_gen_movi_i32(insn_size_tcg, 0xdeadbeef);\n> +\n> + trace_guest_inst_info_before_tcg(\n> + cpu, tcg_ctx.tcg_env, pc_insn, insn_size_tcg);\n> +\n> + tcg_temp_free_i32(insn_size_tcg);\n\nThere's no reason you can't declare insn_size_tcg right here and avoid the\nincorrect initialization above.\n\nIs there a reason to have both \"guest_insn\" and \"guest_insn_info\"?\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"KMinFl3P\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsp5y0yfHz9s9Y\n\tfor ;\n\tThu, 14 Sep 2017 03:08:37 +1000 (AEST)","from localhost ([::1]:43711 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsB9P-0008WC-6Z\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 13:08:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57975)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsB8h-0008UV-Ax\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:07:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsB8e-0005XX-Kx\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:07:51 -0400","from mail-pg0-x231.google.com ([2607:f8b0:400e:c05::231]:45477)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsB8e-0005WF-Eh\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:07:48 -0400","by mail-pg0-x231.google.com with SMTP id 188so1515398pgb.2\n\tfor ; Wed, 13 Sep 2017 10:07:48 -0700 (PDT)","from bigtime.twiddle.net (97-126-103-167.tukw.qwest.net.\n\t[97.126.103.167]) by smtp.gmail.com with ESMTPSA id\n\tx13sm16934377pgt.16.2017.09.13.10.07.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 10:07:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=jQq6BCs3VvOsmkwcb/ld0bqOEEhrvFq5YBMWuMHMsnY=;\n\tb=KMinFl3PA4tQIhkCA1E9sZEo78fhQVEV4rs+fVytCgCax2mji97We8mO3lykNnfwEs\n\tmv0PxYrjYxZBrRxellaVb2PLk151KpQ7gpC5S3B/sXJP3k9rnQm4LLO64DOxnVv1oisa\n\tLzd3FNHWHvgzW/B9RJQ3B6DwoHP9CnNccLBF8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=jQq6BCs3VvOsmkwcb/ld0bqOEEhrvFq5YBMWuMHMsnY=;\n\tb=jPPhOZHvqiAWguS92Lgb7wTMR4zQndmtdS5ZWFobnuQolnYdxCMQBsXDQkKhvc5Qj5\n\tuN2pPxZ0ZiivPC7nphdVndXhrzU0Oha5xr+rWL0tZklRu5b6/zOMAXWFJZ2DIYSSEsgw\n\t0IB9gHezbrc6xojJpxwLldVwbFAQ/4BWCGM5tggnsuF7u7D0ehhlVIFF0MmzJpO4zEYI\n\tj3YOe7iXLYzTKaJA79Fh8qX0nECxAPNQvCtFrcjkvCSFDWVZ82cNkSHAYZ8hUCTctQ7B\n\tFkSODRH3nn4SHCr7i8bazjZQrxAl0mav12NcL+HvM1exeg5Nmoiai0zff4Hc76h7pMdJ\n\tcnqw==","X-Gm-Message-State":"AHPjjUhvAZO2nLK8aLrTGYkxaiR5jLULk6LI7SiMtwsSpZ5SiG7MmMGt\n\tmU/S+M10yBQz62U9","X-Google-Smtp-Source":"ADKCNb5V1xROz6aC09jfufQvfoznic5lQu9NAZTDkxmIkFxcGH+MaVM/qkRxIyy5OPIh4KLNTCOtmA==","X-Received":"by 10.84.232.199 with SMTP id x7mr21712947plm.191.1505322467561; \n\tWed, 13 Sep 2017 10:07:47 -0700 (PDT)","To":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ,\n\tqemu-devel@nongnu.org","References":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>\n\t<150506059354.19604.5050182852156612042.stgit@frigg.lan>","From":"Richard Henderson ","Message-ID":"<0250ce97-bef3-1feb-d9a9-4e4a91084fa7@linaro.org>","Date":"Wed, 13 Sep 2017 10:07:44 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<150506059354.19604.5050182852156612042.stgit@frigg.lan>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::231","Subject":"Re: [Qemu-devel] [PATCH 3/7] trace: Add event\n\t\"guest_inst_info_before\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tPeter Crosthwaite ,\n\tStefan Hajnoczi ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768660,"web_url":"http://patchwork.ozlabs.org/comment/1768660/","msgid":"<87inglpbpu.fsf@frigg.lan>","list_archive_url":null,"date":"2017-09-14T14:59:57","subject":"Re: [Qemu-devel] [PATCH 3/7] trace: Add event\n\t\"guest_inst_info_before\"","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"content":"Richard Henderson writes:\n\n> On 09/10/2017 09:23 AM, Lluís Vilanova wrote:\n>> Signed-off-by: Lluís Vilanova \n>> ---\n>> accel/tcg/translator.c | 18 ++++++++++++++++++\n>> trace-events | 9 +++++++++\n>> 2 files changed, 27 insertions(+)\n>> \n>> diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c\n>> index 287d27b4f7..6598931171 100644\n>> --- a/accel/tcg/translator.c\n>> +++ b/accel/tcg/translator.c\n>> @@ -70,6 +70,8 @@ void translator_loop(const TranslatorOps *ops, DisasContextBase *db,\n>> \n>> while (true) {\n>> target_ulong pc_insn = db->pc_next;\n>> + TCGv_i32 insn_size_tcg = 0;\n>> + int insn_size_opcode_idx;\n\n> Initializing a TCGv_i32 is wrong.\n> And surely insn_size_opcode is surely uninitialized?\n\n>> + if (TRACE_GUEST_INST_INFO_BEFORE_EXEC_ENABLED) {\n>> + insn_size_tcg = tcg_temp_new_i32();\n>> + insn_size_opcode_idx = tcg_op_buf_count();\n>> + tcg_gen_movi_i32(insn_size_tcg, 0xdeadbeef);\n>> +\n>> + trace_guest_inst_info_before_tcg(\n>> + cpu, tcg_ctx.tcg_env, pc_insn, insn_size_tcg);\n>> +\n>> + tcg_temp_free_i32(insn_size_tcg);\n\n> There's no reason you can't declare insn_size_tcg right here and avoid the\n> incorrect initialization above.\n\nYes, I guess I did not move the declaration here by error after refactoring the\ncode.\n\n\n> Is there a reason to have both \"guest_insn\" and \"guest_insn_info\"?\n\nI initially wanted to have a bare-bones event with simple information, and an\n*_info variant with more detailed information like register usage and physical\n addresses (which would be disabled by default to avoid performance impact).\n\nWe had a discussion long time ago that led to decide that register usage\ninformation as I implemented it was only partial (it did not capture register\nusage helpers), and thus was not worth adding.\n\nSince physical address information is not gonna be added in this series (if at\nall), what do you say about hoisting instruction length info into\nguest_insn_before/after and dropping the *_info variants?\n\n\nThanks,\n Lluis","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtMQk6Bjsz9sP1\n\tfor ;\n\tFri, 15 Sep 2017 01:10:06 +1000 (AEST)","from localhost ([::1]:48332 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsVmG-0002Ld-Pm\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 11:10:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57410)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsVcm-0002T0-Ek\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 11:00:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsVcg-000746-Fl\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 11:00:16 -0400","from roura.ac.upc.es ([147.83.33.10]:43158)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsVcg-00071k-5d\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 11:00:10 -0400","from correu-2.ac.upc.es (correu-2.ac.upc.es [147.83.30.92])\n\tby roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id v8EF04Bt019384;\n\tThu, 14 Sep 2017 17:00:04 +0200","from localhost (unknown [132.68.50.201])\n\tby correu-2.ac.upc.es (Postfix) with ESMTPSA id A6D3E358;\n\tThu, 14 Sep 2017 16:59:58 +0200 (CEST)"],"From":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ","To":"Richard Henderson ","References":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>\n\t<150506059354.19604.5050182852156612042.stgit@frigg.lan>\n\t<0250ce97-bef3-1feb-d9a9-4e4a91084fa7@linaro.org>","Mail-Followup-To":"Richard Henderson ,\n\tqemu-devel@nongnu.org, Paolo Bonzini , Richard\n\tHenderson , Stefan Hajnoczi ,\n\tPeter Crosthwaite ","Date":"Thu, 14 Sep 2017 17:59:57 +0300","In-Reply-To":"<0250ce97-bef3-1feb-d9a9-4e4a91084fa7@linaro.org> (Richard\n\tHenderson's message of \"Wed, 13 Sep 2017 10:07:44 -0700\")","Message-ID":"<87inglpbpu.fsf@frigg.lan>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"147.83.33.10","Subject":"Re: [Qemu-devel] [PATCH 3/7] trace: Add event\n\t\"guest_inst_info_before\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tPeter Crosthwaite ,\n\tqemu-devel@nongnu.org, Stefan Hajnoczi ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768707,"web_url":"http://patchwork.ozlabs.org/comment/1768707/","msgid":"<80d88121-3a7d-12a2-11f0-f6b0f474c7b6@twiddle.net>","list_archive_url":null,"date":"2017-09-14T16:12:30","subject":"Re: [Qemu-devel] [PATCH 3/7] trace: Add event\n\t\"guest_inst_info_before\"","submitter":{"id":2222,"url":"http://patchwork.ozlabs.org/api/people/2222/","name":"Richard Henderson","email":"rth@twiddle.net"},"content":"On 09/14/2017 07:59 AM, Lluís Vilanova wrote:\n> Since physical address information is not gonna be added in this series (if at\n> all), what do you say about hoisting instruction length info into\n> guest_insn_before/after and dropping the *_info variants?\n\nThat should be fine.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aup5J/fS\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtNqN72jhz9sPk\n\tfor ;\n\tFri, 15 Sep 2017 02:13:03 +1000 (AEST)","from localhost ([::1]:48792 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsWlB-0003qG-Dy\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 12:13:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43768)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsWkq-0003q6-T2\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 12:12:41 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsWkm-0003cW-UO\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 12:12:40 -0400","from mail-pf0-x231.google.com ([2607:f8b0:400e:c00::231]:44456)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dsWkm-0003ab-Nq\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 12:12:36 -0400","by mail-pf0-x231.google.com with SMTP id e1so4756836pfk.1\n\tfor ; Thu, 14 Sep 2017 09:12:35 -0700 (PDT)","from bigtime.twiddle.net (97-126-103-167.tukw.qwest.net.\n\t[97.126.103.167]) by smtp.googlemail.com with ESMTPSA id\n\to30sm27230682pgc.83.2017.09.14.09.12.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 14 Sep 2017 09:12:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=Rf0kA8auqThPsVTweLvaELdbnFhSAyFOUzYCPEwoBTE=;\n\tb=aup5J/fSjIU1nrHSYbrocOL1z4mvy6Qnzplq1QY7RydEvb4DUEfyO/LIDIa4/hSRzw\n\trTMx1+HCi4Nub8vkP/CMCGyeJJ5+yMmE7tDH71kMHAf4a6IW7wjYfvJZhxdAv2kTj8mh\n\t/K0mqGlCZpdJufUNg1FZFxkwSolewV03HZ7LDSvYJPcT6E0ws17lW3tkB0IW0Z/Tn7Ne\n\tkQgP9Q5hAkNFwkxmnu1olWZFJGiOGZV5eKAsB1km899Y3Sx06C6lyAp3ET+Xa8rOcIqz\n\t36Rh7b1w3qMtcpxtjrK7dfyARzdeLvRjMdG1Wi/OzHz3jcKdAlTD8ctjyFhXofVb+Vwg\n\t/iBg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=Rf0kA8auqThPsVTweLvaELdbnFhSAyFOUzYCPEwoBTE=;\n\tb=T42awxwPOkN74nFcvfQsz0cbDCcEPtaxlsaLQVu3SJbJ4ZAlXcP4B0I/OTpPA9+Xps\n\t5ToAIcao7vh+GUdc0zClawWiQKjODjcyIoUrwBsBn/Yk8d0hPgcXyHFuqBzwPTpSYm4z\n\tyRBBasudOWZoAj8sloxAoQikMDzPjVNAnYlWDeT5zVcMxVezIPtbz73P+LnZecjLqdBV\n\tMK+wW3ZIB3Wq23IilyhGH5gpfTDaINsnPBM5rErqERiHsnlhcxbNgbTpRS5/nl+vDO4q\n\tFWu1WAJv9kZappYrzCqaANV5DyW4doFsDfWkS8woW+uFVTLCtL2Pkrjl8T/yroTnlKxv\n\tnBpA==","X-Gm-Message-State":"AHPjjUgOF+RyRPvoeZCil7XIVs2Vv8MnTEJN3gqXeAuddRgCQuRLaDjf\n\t7lPISljMHii5MQ==","X-Google-Smtp-Source":"ADKCNb4wk6+l8BZzQOhRaEjAY8UY3ad3xisW7zEFTJuCkJ2scjagbotD4cZP6ngT7jR6ayICy6zD5A==","X-Received":"by 10.84.254.74 with SMTP id a10mr24505663pln.71.1505405554544; \n\tThu, 14 Sep 2017 09:12:34 -0700 (PDT)","To":"Richard Henderson , qemu-devel@nongnu.org, \n\tPaolo Bonzini ,\n\tStefan Hajnoczi , \n\tPeter Crosthwaite ","References":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>\n\t<150506059354.19604.5050182852156612042.stgit@frigg.lan>\n\t<0250ce97-bef3-1feb-d9a9-4e4a91084fa7@linaro.org>\n\t<87inglpbpu.fsf@frigg.lan>","From":"Richard Henderson ","Message-ID":"<80d88121-3a7d-12a2-11f0-f6b0f474c7b6@twiddle.net>","Date":"Thu, 14 Sep 2017 09:12:30 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<87inglpbpu.fsf@frigg.lan>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::231","Subject":"Re: [Qemu-devel] [PATCH 3/7] trace: Add event\n\t\"guest_inst_info_before\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]