[{"id":1768028,"web_url":"http://patchwork.ozlabs.org/comment/1768028/","msgid":"<6ded11bd-dcae-2e98-5af6-3f2cc77706d8@linaro.org>","list_archive_url":null,"date":"2017-09-13T17:02:58","subject":"Re: [Qemu-devel] [PATCH 2/7] trace: Add event \"guest_inst_before\"","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/10/2017 09:19 AM, Lluís Vilanova wrote:\n> while (true) {\n> + target_ulong pc_insn = db->pc_next;\n\nWhy not just \"pc\"?\n\n> +\n> db->num_insns++;\n> ops->insn_start(db, cpu);\n> tcg_debug_assert(db->is_jmp == DISAS_NEXT); /* no early exit */\n> @@ -96,6 +98,7 @@ void translator_loop(const TranslatorOps *ops, DisasContextBase *db,\n> if (db->num_insns == 1) {\n> trace_guest_bbl_before_tcg(cpu, tcg_ctx.tcg_env, db->pc_first);\n> }\n> + trace_guest_inst_before_tcg(cpu, tcg_ctx.tcg_env, pc_insn);\n\nI prefer \"insn\" over \"inst\". There are enough other words that begin with\n\"inst\" (e.g. instance) to possibly be confusing. Either that or it's my 20\nyears working on gcc that ingrained \"insn\". ;-)\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ABmDXzZn\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsp062nHMz9s9Y\n\tfor ;\n\tThu, 14 Sep 2017 03:03:34 +1000 (AEST)","from localhost ([::1]:43695 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsB4W-00066z-7N\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 13:03:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54810)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsB48-00066u-38\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:03:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsB42-0000xx-Bc\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:03:08 -0400","from mail-pf0-x22e.google.com ([2607:f8b0:400e:c00::22e]:46670)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsB42-0000xO-5y\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 13:03:02 -0400","by mail-pf0-x22e.google.com with SMTP id e199so1170931pfh.3\n\tfor ; Wed, 13 Sep 2017 10:03:02 -0700 (PDT)","from bigtime.twiddle.net (97-126-103-167.tukw.qwest.net.\n\t[97.126.103.167]) by smtp.gmail.com with ESMTPSA id\n\tp1sm27111678pfb.53.2017.09.13.10.02.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Sep 2017 10:03:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=9UBvgpGKxfomutomh2ZaSDRsesSiWr5sd70GW3irvAU=;\n\tb=ABmDXzZnUqjrBanfcKJBoWymrKl3R3AO2BbU+uscEzDXZ7vcC8lB3v9Kv6CCT5d2e+\n\t1B0TmQknK2k6qp2rIq114VlMlqpsX1NhDFv7HHi+MmPF89mJ8U+ywpEXarxxVW9o9Rlo\n\tB30sVpHraRz4PMqiFHhu4mgJJw9jLww1OKy74=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=9UBvgpGKxfomutomh2ZaSDRsesSiWr5sd70GW3irvAU=;\n\tb=AYDp1G0pndT+93KoJCHn7o7e4BRPqzmE5zMbM3gVljgrDKy+mm5IZy4EOkxafVEvzf\n\tTJrN5fxwYtpYmFV5pGzvtVz05b1YpfoifnXXlfyeBovusflo8/w5ay9eG00FddSBGwyt\n\tRypTybkPjBskJmos+Wg8ipWsz7ZEpgHkutWUqNz5VYhFyKdtdUTqFZCpLvK9PhyuPHgm\n\tQdFb3jvv7cxd4lMCxpk0ifbEIcyYWS4KwVhAcbYDZknYQoqY58xnCKQtPMgK9Lc2ks5d\n\thkMrE5i5whChWQF5pkZ2NKLOkLJP5W2yj1EJdGgflShur1X7zPNor+SbUTIgxBdbArKx\n\tpvhA==","X-Gm-Message-State":"AHPjjUjDFFTD0e2ZKghpFM+rBM+Baichi1FpmciCz8zaHF2tT54pitBp\n\tIm7m9yOo2vw0EsZX","X-Google-Smtp-Source":"AOwi7QDqXyGVqcXAVSf6bl0C8P6KZZhNJJLUDb5gn0bi8p7fyofYojC2dJPFrrSOi0la+R5gColV2A==","X-Received":"by 10.159.253.152 with SMTP id q24mr6485696pls.166.1505322181165;\n\tWed, 13 Sep 2017 10:03:01 -0700 (PDT)","To":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ,\n\tqemu-devel@nongnu.org","References":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>\n\t<150506035158.19604.740046564057160055.stgit@frigg.lan>","From":"Richard Henderson ","Message-ID":"<6ded11bd-dcae-2e98-5af6-3f2cc77706d8@linaro.org>","Date":"Wed, 13 Sep 2017 10:02:58 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<150506035158.19604.740046564057160055.stgit@frigg.lan>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::22e","Subject":"Re: [Qemu-devel] [PATCH 2/7] trace: Add event \"guest_inst_before\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tPeter Crosthwaite ,\n\tStefan Hajnoczi ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768639,"web_url":"http://patchwork.ozlabs.org/comment/1768639/","msgid":"<871sn9qr6h.fsf@frigg.lan>","list_archive_url":null,"date":"2017-09-14T14:40:38","subject":"Re: [Qemu-devel] [PATCH 2/7] trace: Add event \"guest_inst_before\"","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"content":"Richard Henderson writes:\n\n> On 09/10/2017 09:19 AM, Lluís Vilanova wrote:\n>> while (true) {\n>> + target_ulong pc_insn = db->pc_next;\n\n> Why not just \"pc\"?\n\n>> +\ndb-> num_insns++;\nops-> insn_start(db, cpu);\n>> tcg_debug_assert(db->is_jmp == DISAS_NEXT); /* no early exit */\n>> @@ -96,6 +98,7 @@ void translator_loop(const TranslatorOps *ops, DisasContextBase *db,\n>> if (db->num_insns == 1) {\n>> trace_guest_bbl_before_tcg(cpu, tcg_ctx.tcg_env, db->pc_first);\n>> }\n>> + trace_guest_inst_before_tcg(cpu, tcg_ctx.tcg_env, pc_insn);\n\n> I prefer \"insn\" over \"inst\". There are enough other words that begin with\n> \"inst\" (e.g. instance) to possibly be confusing. Either that or it's my 20\n> years working on gcc that ingrained \"insn\". ;-)\n\nBoth work for me, so no problem in switching to pc and insn.\n\nThanks,\n Lluis","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtLny4yRKz9sPk\n\tfor ;\n\tFri, 15 Sep 2017 00:41:42 +1000 (AEST)","from localhost ([::1]:48167 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsVKm-0005Y8-Ed\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 10:41:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46189)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsVK0-0005Vx-Il\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:40:53 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsVJv-0002J3-JE\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:40:52 -0400","from roura.ac.upc.es ([147.83.33.10]:42258)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsVJv-0002Hf-8j\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 10:40:47 -0400","from correu-2.ac.upc.es (correu-2.ac.upc.es [147.83.30.92])\n\tby roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id v8EEeimZ018841;\n\tThu, 14 Sep 2017 16:40:44 +0200","from localhost (unknown [132.68.50.201])\n\tby correu-2.ac.upc.es (Postfix) with ESMTPSA id 5CBD5EF;\n\tThu, 14 Sep 2017 16:40:39 +0200 (CEST)"],"From":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ","To":"Richard Henderson ","References":"<150505986682.19604.11937392314067517230.stgit@frigg.lan>\n\t<150506035158.19604.740046564057160055.stgit@frigg.lan>\n\t<6ded11bd-dcae-2e98-5af6-3f2cc77706d8@linaro.org>","Mail-Followup-To":"Richard Henderson ,\n\tqemu-devel@nongnu.org, Paolo Bonzini , Richard\n\tHenderson , Stefan Hajnoczi ,\n\tPeter Crosthwaite ","Date":"Thu, 14 Sep 2017 17:40:38 +0300","In-Reply-To":"<6ded11bd-dcae-2e98-5af6-3f2cc77706d8@linaro.org> (Richard\n\tHenderson's message of \"Wed, 13 Sep 2017 10:02:58 -0700\")","Message-ID":"<871sn9qr6h.fsf@frigg.lan>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"147.83.33.10","Subject":"Re: [Qemu-devel] [PATCH 2/7] trace: Add event \"guest_inst_before\"","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ,\n\tPeter Crosthwaite ,\n\tqemu-devel@nongnu.org, Stefan Hajnoczi ,\n\tRichard Henderson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]