[{"id":1766973,"web_url":"http://patchwork.ozlabs.org/comment/1766973/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:30:16","subject":"Re: [U-Boot] [PATCH v1 10/12] dm: video: Add basic ANSI escape\n\tsequence support","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Rob,\n\nOn 10 September 2017 at 07:22, Rob Clark wrote:\n> Really just the subset that is needed by efi_console. Perhaps more will\n> be added later, for example color support would be useful to implement\n> efi_cout_set_attribute().\n>\n> Signed-off-by: Rob Clark \n> ---\n> drivers/video/vidconsole-uclass.c | 112 ++++++++++++++++++++++++++++++++++++++\n> drivers/video/video-uclass.c | 4 +-\n> include/video.h | 7 +++\n> include/video_console.h | 11 ++++\n> 4 files changed, 131 insertions(+), 3 deletions(-)\n\nCan we put this behind an option (perhaps default on) to reduce code\nsize? Also please update test/dm/video.c to add a test.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"aLd8YBVa\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"aK6U+r/R\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4Xm3SBDz9t60\n\tfor ;\n\tTue, 12 Sep 2017 22:55:51 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 304A7C2218C; Tue, 12 Sep 2017 12:42:59 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 4FEF9C2208F;\n\tTue, 12 Sep 2017 12:42:57 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid E1800C220C5; Tue, 12 Sep 2017 12:30:42 +0000 (UTC)","from mail-qt0-f174.google.com (mail-qt0-f174.google.com\n\t[209.85.216.174])\n\tby lists.denx.de (Postfix) with ESMTPS id 3B77DC21FF7\n\tfor ; Tue, 12 Sep 2017 12:30:38 +0000 (UTC)","by mail-qt0-f174.google.com with SMTP id i50so25179924qtf.0\n\tfor ; Tue, 12 Sep 2017 05:30:38 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:30:16 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=HoMJQg8jmf0wVmg5NmgDvfefllDp5QnN3ilTk94eSzY=;\n\tb=aLd8YBVaoFFvyYYT4Ai904+p1uxwCIxNgyG4KKX2lbevAx90b/Z0kgd/jzkNJQRjAx\n\tmNeQ+oPaubVVXrrFcj6Vlz468FI7AtBtreItPX1MSb60kDxDNjt5H7jTpegXK/FbJdL+\n\tdMtpGGSaCTMbmwyUXF/gxygyVJQbKBxlqUvJehI+q9KrvVDpIS0M411Xhs4d0XfF0v1H\n\tdtg+PgQC/jb6YEpzrhWUQYpSniKaS+BKI3ceVwmczOBg2uYSNJBThV9/uUrI14D8Kk0R\n\t6SjCvGOGKWSwXDfHTqD8ZjNaPKWoIxDrBKtSuvf2JXP1nEM7j4IkU+VHDBZSZ2iwRjO/\n\twRPQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=HoMJQg8jmf0wVmg5NmgDvfefllDp5QnN3ilTk94eSzY=;\n\tb=aK6U+r/Riuf8oRxgBhXKZuVW1YKDLqoI1yHp8pSJyyedq16LCTAApNfmxlL3wAIPPf\n\tVpSVivKUCrUkIsuPFOlUgMeM6INI/QIM23gi0Uo4F6eOEAACEqZVa7rkm3XYOnRlb4n+\n\tkMnGz1AeTqd26llEybhwd439VSDdUy88IKHGY="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=HoMJQg8jmf0wVmg5NmgDvfefllDp5QnN3ilTk94eSzY=;\n\tb=FyhMocbaHvGHvIjIW7ZTIllPuoWIuSV3uEWGcDuvMCYEYq9vYMCAZHV0zb53ryctEi\n\tPU8Nup7V3T8IoyF3U58FNRN+hmDL3pxT9dYQjceCZlY/7cd4gLD7YSyQjpkWDQBeAqBf\n\tyfdoV36I0G98JABcAj/CyXV4ObJDUuYv8wZk+rWCslm/COoIQPwWgXiCGYAtBSXEqxJB\n\tVokETt0n6yZc/zh9mGPFRLV1j1d0HmZ1uQl8wA/c5shwSZysGvUS2oVX/5PDXtfqFwCF\n\tJaavBqKZlxCLdSscMRo1zsedb0ZQ+i38bB5zCmPzZSRdbHDxyyBUvIiqDvHBFaYr0g0c\n\tEluA==","X-Gm-Message-State":"AHPjjUjLgqNEsODGNodAxadUW4E0a+GO+eueSmYW/wSTOj1VfE7NcruV\n\tuFcGMTDmBs0qZ1gQYl91t8EhnYhmX8nZgViTlCJHxg==","X-Google-Smtp-Source":"AOwi7QDCpsyCaOpQCJlLKyCCxiRNquIK+zhi3crM3Tp9B6uZWZHLInkJ764aHBrz9O0ohFJfB/l/SjDMiU0f5BtrvmI=","X-Received":"by 10.200.41.239 with SMTP id 44mr19804008qtt.138.1505219436965; \n\tTue, 12 Sep 2017 05:30:36 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170910132236.14318-11-robdclark@gmail.com>","References":"<20170910132236.14318-1-robdclark@gmail.com>\n\t<20170910132236.14318-11-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:30:16 -0600","X-Google-Sender-Auth":"zGpWXTdhMTyfUW3kpOsXTpt2GD0","Message-ID":"","To":"Rob Clark ","Cc":"U-Boot Mailing List ,\n\tLeif Lindholm ,\n\tHeinrich Schuchardt ","Subject":"Re: [U-Boot] [PATCH v1 10/12] dm: video: Add basic ANSI escape\n\tsequence support","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1767017,"web_url":"http://patchwork.ozlabs.org/comment/1767017/","msgid":"","list_archive_url":null,"date":"2017-09-12T13:06:01","subject":"Re: [U-Boot] [PATCH v1 10/12] dm: video: Add basic ANSI escape\n\tsequence support","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Tue, Sep 12, 2017 at 8:30 AM, Simon Glass wrote:\n> Hi Rob,\n>\n> On 10 September 2017 at 07:22, Rob Clark wrote:\n>> Really just the subset that is needed by efi_console. Perhaps more will\n>> be added later, for example color support would be useful to implement\n>> efi_cout_set_attribute().\n>>\n>> Signed-off-by: Rob Clark \n>> ---\n>> drivers/video/vidconsole-uclass.c | 112 ++++++++++++++++++++++++++++++++++++++\n>> drivers/video/video-uclass.c | 4 +-\n>> include/video.h | 7 +++\n>> include/video_console.h | 11 ++++\n>> 4 files changed, 131 insertions(+), 3 deletions(-)\n>\n> Can we put this behind an option (perhaps default on) to reduce code\n> size? Also please update test/dm/video.c to add a test.\n\nyup, already done.. I'll resend this and the other video patches\nseparately, so you can drop this one from the set.\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"A+ogCOAO\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4mg5D3Bz9s0g\n\tfor ;\n\tTue, 12 Sep 2017 23:06:11 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 5A4EFC21FED; Tue, 12 Sep 2017 13:06:06 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B0CABC21FC2;\n\tTue, 12 Sep 2017 13:06:04 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid C8299C21FC2; Tue, 12 Sep 2017 13:06:02 +0000 (UTC)","from mail-lf0-f50.google.com (mail-lf0-f50.google.com\n\t[209.85.215.50])\n\tby lists.denx.de (Postfix) with ESMTPS id 6ADB0C21DE1\n\tfor ; Tue, 12 Sep 2017 13:06:02 +0000 (UTC)","by mail-lf0-f50.google.com with SMTP id d17so26200886lfe.2\n\tfor ; Tue, 12 Sep 2017 06:06:02 -0700 (PDT)","by 10.46.29.20 with HTTP; Tue, 12 Sep 2017 06:06:01 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Y8R72TEz5zuHkMRjqRrjZo3M/cdOuQ6r1T93hbQCLSo=;\n\tb=A+ogCOAO5ZLgItr0k+sbL8WBFGT58Fv9hbtRVaUVpvJWl3B2g0XrrjSKn4ct0eSTqO\n\tfFb0oKNY4RtLtfl9T5/8HdiOt4fm3bpbRmiPnFlYGLKe9znISbv8uMimHRRiBAvmFpoW\n\tlq3AjJCI5S57295uG0vzWl4PE5KEDcKFj62VUKPJQsvmPF7vQtlTalcsIREq5jaiPi2l\n\tx+STab7z+zds5rUz+3WjctLpze6KXaeCEL3z5pl47aYnrrSeL/MBNnLJ7JrTywPdSg2W\n\tk3ZzVu2TqKRs61c06TdWUnh7MIHyoBw2rDp3LMb1o98Sv8if2G6nQfJW30rh+t6zDhNz\n\tqdMQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Y8R72TEz5zuHkMRjqRrjZo3M/cdOuQ6r1T93hbQCLSo=;\n\tb=YGIwWZI8fSQp6KDQngp8X3c8aYmz63Br+mP5d61x9r70G3V1u8ESI4SaCc8pMgsrER\n\tVyHRpU1eMq0bfnFVMyKys4DbjrEaA1YrubHvchGp3EE4KGecmRbalvFdIdLz8Rv07UbV\n\t2zuBe834wbznYUT1inwYvEg1tRdt0H2m/I3NC3K3tFs/K6k4XVLgoJtlM28GKMjG0LKx\n\tyBBUUCb1/RtdggYgdR5Kz9ufTKQs+tbcbgMDUbYGxBY90hH0bpRaeOQK51C5zXHba3tW\n\t06izhnuEllJQI67w9P/EYzm0Cqny8/INq46RnyEPiOe2L3jq7sJtdczUlcIQouq6j+sv\n\tRy8g==","X-Gm-Message-State":"AHPjjUiHf5hW84+fV5ZiNQOfyLVDolD41IyH7N96OM+NNLlwrnycWizw\n\t/yZBeZ+EAur8vGP6hgwUaieimCbqpQ==","X-Google-Smtp-Source":"AOwi7QDOjiqrG7aGark5KC0RMY1SPRJKgqi0yq2zq8fZX/Zg4wnj6zImOcs9J49BROHApAAPJ0IJ5MJY6hNavSE4DHU=","X-Received":"by 10.25.213.71 with SMTP id m68mr4695564lfg.214.1505221561977; \n\tTue, 12 Sep 2017 06:06:01 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170910132236.14318-1-robdclark@gmail.com>\n\t<20170910132236.14318-11-robdclark@gmail.com>\n\t","From":"Rob Clark ","Date":"Tue, 12 Sep 2017 09:06:01 -0400","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List ,\n\tLeif Lindholm ,\n\tHeinrich Schuchardt ","Subject":"Re: [U-Boot] [PATCH v1 10/12] dm: video: Add basic ANSI escape\n\tsequence support","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]