[{"id":1780088,"web_url":"http://patchwork.ozlabs.org/comment/1780088/","msgid":"<35f23711-91b6-a52f-7765-acd043e6d001@gmx.de>","list_archive_url":null,"date":"2017-10-04T19:29:07","subject":"Re: [U-Boot] [PATCH v1 09/12] dm: video: Fix cache flushes","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 09/10/2017 03:22 PM, Rob Clark wrote:\n> Content can come to screen via putc() and we cannot always rely on\n> updates ending with a puts().\n\nThe commit message does not explain why you are modifying videconsole_puts.\n\nProbably you wanted to refer to a newline character '\\n' which leads to\ncalling video_sync without your patch. Please, update the commit message.\n\nThe code change looks correct to me.\n\nAcked-by: Heinrich Schuchardt \n\n> This is the case with efi_console output\n> to vidconsole. Fixes corruption with Shell.efi.\n> \n> Signed-off-by: Rob Clark \n> ---\n> drivers/video/vidconsole-uclass.c | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/drivers/video/vidconsole-uclass.c b/drivers/video/vidconsole-uclass.c\n> index b5afd72227..e081d5a0ee 100644\n> --- a/drivers/video/vidconsole-uclass.c\n> +++ b/drivers/video/vidconsole-uclass.c\n> @@ -163,6 +163,7 @@ static void vidconsole_putc(struct stdio_dev *sdev, const char ch)\n> \tstruct udevice *dev = sdev->priv;\n> \n> \tvidconsole_put_char(dev, ch);\n> +\tvideo_sync(dev->parent);\n> }\n> \n> static void vidconsole_puts(struct stdio_dev *sdev, const char *s)\n> @@ -260,6 +261,8 @@ static int do_video_puts(cmd_tbl_t *cmdtp, int flag, int argc,\n> \tfor (s = argv[1]; *s; s++)\n> \t\tvidconsole_put_char(dev, *s);\n> \n> +\tvideo_sync(dev->parent);\n> +\n> \treturn 0;\n> }\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y6mGC5mW9z9t79\n\tfor ;\n\tThu, 5 Oct 2017 06:30:42 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid D460DC21FA0; Wed, 4 Oct 2017 19:30:35 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5398DC21DA6;\n\tWed, 4 Oct 2017 19:30:33 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid EAE83C21DAB; Wed, 4 Oct 2017 19:30:31 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\tby lists.denx.de (Postfix) with ESMTPS id 8695DC21DA6\n\tfor ; Wed, 4 Oct 2017 19:30:31 +0000 (UTC)","from [192.168.123.82] ([94.114.42.150]) by mail.gmx.com (mrgmx002\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id\n\t0Ldq55-1dZo1u0gSp-00j5HE; Wed, 04 Oct 2017 21:30:29 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM\n\tautolearn=unavailable autolearn_force=no version=3.4.0","To":"Rob Clark ,\n\tU-Boot Mailing List ","References":"<20170910132236.14318-1-robdclark@gmail.com>\n\t<20170910132236.14318-10-robdclark@gmail.com>","From":"Heinrich Schuchardt ","Message-ID":"<35f23711-91b6-a52f-7765-acd043e6d001@gmx.de>","Date":"Wed, 4 Oct 2017 21:29:07 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170910132236.14318-10-robdclark@gmail.com>","Content-Language":"en-US","X-Provags-ID":"V03:K0:BWeI2lk+l/1zZyFJSdoVt5on8y6mAvKqLSwrXBaVKxbZSHHkTG/\n\tExZl8IHLDmPTrZaHCbNMxY2LNsBrJ4c0kGAZg/kZH2aWQC6hWDyPNB09FHopp+LW/KhH3j8\n\tX+Idw44yIKg+uslZybWCzKrZCW8Nj32lV2Ct2QXNVh5x+yflq8ekMHRSgZI0rDyRYKwrzv7\n\t2u+CJ6aZB2mzq5p6EIYKQ==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:WN8K1AXfOhk=:qhBtkTt+qYMEFEaJaEbwhR\n\tilFn+wU8okBC34+N8+n9KsVA5UvLCLTiOit+/V7x5sA5sRQfXyLqSLd/BCqbze3kIGp12uXfb\n\t0eI77D6bAtadTxH4Tv/x/72dwkVvh27No0cAJ//UNZsflH+ZOqpOPiefvlpX3jr+om9P+BLDl\n\tKPd5MOO4ubrNMKrmK1ZdcRuX6DahdQGOzfkdIOu+XQs4JtJnXk9IlpBeFVaWdeVLIjUmxSv0w\n\tgclyOK0nLSEEWezr+mgjpUHMWW9dRBi9qiSW3UN6mMcBnu53N5DrjYoBA8ulVNGsDhSldGMrc\n\t1u0ITaanYlNpvOT7vz+fZPJKiiZ5KsiN/TbqpJ7ytwOCgHEVHU9+Q5duvjdAdiVuUAJiWwaVK\n\t+9TCJFNXVJL/zKclOtvdczzhtIJfaCJM+pToPSh/2rzm7U7pu2Z4Fc6SNfEvhZRADLd/QOBQZ\n\tW81O9McG8uLlQgF+U2nPm1oWktp1liOSDKTQdqIanB9kCdVdQzuu7KsuyDwbEuwgk8TojWBnL\n\tPARECwrLVykaYRRE5sBiY0Hwqr1cyfxnlC7DfvwFCnLTfGr4Ny6E2rS3GgHrf0aprSZE60sQP\n\tjOcWbIl+LmWyqWaLGFnJehGsaexicqGpiTZQMUmKdjgoXPyVRgPR4YsHNN1qCiyNaiD54qlEj\n\t8skQ2wx9HXz2y3B7orqpNmyxvWlzZ+ggWRC8+tKnNhmVSRKwhKHBnNOx881rtZ6gOrrgyaUAB\n\tWayEf770yTKVNkFO3GIP/d921eFzTrTPx1B7o+u17Jryc67K+U+LDbmciLbO5D0iwe7d4V4Hl\n\t2We78DBNyeoH6DmZcNz5rbzAvt4q+0gTyBe7jOFs7EjTHuGeeU=","Cc":"Leif Lindholm ","Subject":"Re: [U-Boot] [PATCH v1 09/12] dm: video: Fix cache flushes","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]