[{"id":1770256,"web_url":"http://patchwork.ozlabs.org/comment/1770256/","msgid":"<20170918153347.GA28198@salvia>","list_archive_url":null,"date":"2017-09-18T15:33:47","subject":"Re: [PATCH] netfilter: nat: Do not use ARRAY_SIZE() on spinlocks to\n\tfix zero div","submitter":{"id":1315,"url":"http://patchwork.ozlabs.org/api/people/1315/","name":"Pablo Neira Ayuso","email":"pablo@netfilter.org"},"content":"On Sun, Sep 10, 2017 at 01:41:41PM +0200, Geert Uytterhoeven wrote:\n> If no spinlock debugging options (CONFIG_GENERIC_LOCKBREAK,\n> CONFIG_DEBUG_SPINLOCK, CONFIG_DEBUG_LOCK_ALLOC) are enabled on a UP\n> platform (e.g. m68k defconfig), arch_spinlock_t is an empty struct,\n> hence using ARRAY_SIZE(nf_nat_locks) causes a division by zero:\n> \n> net/netfilter/nf_nat_core.c: In function ‘nf_nat_setup_info’:\n> net/netfilter/nf_nat_core.c:432: warning: division by zero\n> net/netfilter/nf_nat_core.c: In function ‘__nf_nat_cleanup_conntrack’:\n> net/netfilter/nf_nat_core.c:535: warning: division by zero\n> net/netfilter/nf_nat_core.c:537: warning: division by zero\n> net/netfilter/nf_nat_core.c: In function ‘nf_nat_init’:\n> net/netfilter/nf_nat_core.c:810: warning: division by zero\n> net/netfilter/nf_nat_core.c:811: warning: division by zero\n> net/netfilter/nf_nat_core.c:824: warning: division by zero\n> \n> Fix this by using the CONNTRACK_LOCKS definition instead.\n\nApplied.\n--\nTo unsubscribe from this list: send the line \"unsubscribe netfilter-devel\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwqn15lhgz9s78\n\tfor ;\n\tTue, 19 Sep 2017 01:34:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754148AbdIRPeL (ORCPT );\n\tMon, 18 Sep 2017 11:34:11 -0400","from ganesha.gnumonks.org ([213.95.27.120]:35887 \"EHLO\n\tganesha.gnumonks.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753400AbdIRPeI (ORCPT\n\t);\n\tMon, 18 Sep 2017 11:34:08 -0400","from 129.166.216.87.static.jazztel.es ([87.216.166.129]\n\thelo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dty3a-0004GS-3g; Mon, 18 Sep 2017 17:34:01 +0200"],"Date":"Mon, 18 Sep 2017 17:33:47 +0200","From":"Pablo Neira Ayuso ","To":"Geert Uytterhoeven ","Cc":"Jozsef Kadlecsik ,\n\tFlorian Westphal ,\n\t\"David S . Miller\" ,\n\tArnd Bergmann , netfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] netfilter: nat: Do not use ARRAY_SIZE() on spinlocks to\n\tfix zero div","Message-ID":"<20170918153347.GA28198@salvia>","References":"<1505043701-13255-1-git-send-email-geert@linux-m68k.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<1505043701-13255-1-git-send-email-geert@linux-m68k.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Score":"-2.9 (--)","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"}}]