[{"id":1766974,"web_url":"http://patchwork.ozlabs.org/comment/1766974/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:30:35","subject":"Re: [U-Boot] [PATCH v2 21/21] efi_loader: Some console improvements\n\tfor vidconsole","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 10 September 2017 at 05:21, Rob Clark wrote:\n> 1) use fputs() to reduce cache flushes from once-per-char to\n> once-per-string\n> 2) handle \\r, \\t, and \\b in addition to just \\n for tracking\n> cursor position\n> 3) cursor row/col are zero based, not one based\n>\n> Signed-off-by: Rob Clark \n> ---\n> include/efi_api.h | 6 +++--\n> lib/efi_loader/efi_console.c | 58 ++++++++++++++++++++++++++------------------\n> 2 files changed, 39 insertions(+), 25 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"kAae+o3Q\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"e91enRb8\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4Xm3vbxz9t7q\n\tfor ;\n\tTue, 12 Sep 2017 22:55:51 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid BFFD8C22071; Tue, 12 Sep 2017 12:34:01 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 4192AC22034;\n\tTue, 12 Sep 2017 12:32:34 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid B17CBC22033; Tue, 12 Sep 2017 12:31:00 +0000 (UTC)","from mail-qt0-f172.google.com (mail-qt0-f172.google.com\n\t[209.85.216.172])\n\tby lists.denx.de (Postfix) with ESMTPS id 02E2BC21FFA\n\tfor ; Tue, 12 Sep 2017 12:30:57 +0000 (UTC)","by mail-qt0-f172.google.com with SMTP id m35so25138150qte.1\n\tfor ; Tue, 12 Sep 2017 05:30:56 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:30:35 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=bpP7zaBBLY8Kjw9QUHQwTq/GPx7OrPiGUssw4WGIzoM=;\n\tb=kAae+o3Q+MRovQ/BJ+pF6lkobBexAaQGNNVYBHFnImHjQUraY269EdT2tt7VhCAEpP\n\tH8ZEcoghchwLEqmKqnPY8QKbujV/yayc6HaAKNhfZRK4qhjOG4nmio8wz/jipVuPOG0s\n\trPHzXXEORq4DkkaNQAVr2TflvASvQNZRZ0l5gNe3F78s8fOXezZ7VqGHQnEZB3V/wo01\n\t+3JDnfYtZrHP+PBiVi3epo4qmEUglpXfuX0f6VlbGCexPyQEiGpCWQ0fyJFdrmSq8z8O\n\tS4/+v+Ba0MUDTBEzHrr9hYpL2oPVHG+xet6CzSgRZH7dPUC4ZVn0MN8NQH5J2L06g/UR\n\tLBrw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=bpP7zaBBLY8Kjw9QUHQwTq/GPx7OrPiGUssw4WGIzoM=;\n\tb=e91enRb8KNKklh+SUs4JyIQajU/9gVr2cHYNzHojZ9iXYTyV/WLHK2co+8MxWMXoab\n\tX5+QW4Iafb4Nhwvt/5NdoL6pXTPLYXgH+CDViWV3xzwPDBowW4R79YZyWv14AjEsZGgP\n\tXRny2FW6b7cOYYT6DQaVLUcJScY2y7fzYaKPM="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=bpP7zaBBLY8Kjw9QUHQwTq/GPx7OrPiGUssw4WGIzoM=;\n\tb=Zb456rYN9SL9uyWQDdGRvzVjcjhWBGi4Fp5iefqUy17v+mwXpYCcvCi1mNs9+OfS6E\n\tPXBMBp8kJxrb3jF4l3XXNzFK2rNX3f1Cyfb1PHlkzGf2ItkWd8yh7yXVR/BFOdOL9JkG\n\tmjtSYnGjg0Tnd7y3R9LDMm20ufb6eqEub2nRykWaNKeNyN+wg6qGduFmCmr60TCxGY7Q\n\t3re/HhZEL+J47tx+2eddzt5qs1eSCpHiezhItMuUf3vfZeIv4HAIiJR/Bsj882P2++3p\n\tsh1Hsx2xBpChlD8RHY1wVBFFgbBP91j8fjwG6uxcycfsVfznuS/illdazmVMQQNt6tZT\n\t82tA==","X-Gm-Message-State":"AHPjjUjEV1OoFb0fPXqZmMOpz3Y6JZdMPbmWqpYcrm+fcrVHC33K6odn\n\tUYvFPGM/iRJ7qcvOb5NIVRWwKGiDlp9Y0TBPnISuzb7f","X-Google-Smtp-Source":"AOwi7QA8eJUMk+PMNZepek2AcYvju9V5BGSepv6w6iam68Cd6SD5kLOGFXmV8IyT9DMZJHfqetsH7P1MfwF/Lp83cyQ=","X-Received":"by 10.200.63.154 with SMTP id d26mr20962601qtk.212.1505219455755;\n\tTue, 12 Sep 2017 05:30:55 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170910112149.21358-31-robdclark@gmail.com>","References":"<20170910112149.21358-1-robdclark@gmail.com>\n\t<20170910112149.21358-31-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:30:35 -0600","X-Google-Sender-Auth":"ojwO1PfthTxCvgsgxl03oz9Gw2A","Message-ID":"","To":"Rob Clark ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ,\n\tPeter Jones ","Subject":"Re: [U-Boot] [PATCH v2 21/21] efi_loader: Some console improvements\n\tfor vidconsole","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]