[{"id":1766975,"web_url":"http://patchwork.ozlabs.org/comment/1766975/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:30:22","subject":"Re: [U-Boot] [PATCH v2 11/21] efi_loader: add file/filesys support","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 10 September 2017 at 05:21, Rob Clark wrote:\n> fallback.efi (and probably other things) use UEFI's simple-file-system\n> protocol and file support to search for OS's to boot.\n>\n> Signed-off-by: Rob Clark \n> ---\n> include/efi.h | 2 +\n> include/efi_api.h | 65 +++++\n> include/efi_loader.h | 13 +\n> lib/efi_loader/Makefile | 1 +\n> lib/efi_loader/efi_disk.c | 32 +++\n> lib/efi_loader/efi_file.c | 556 ++++++++++++++++++++++++++++++++++++++\n> lib/efi_loader/efi_image_loader.c | 3 +\n> 7 files changed, 672 insertions(+)\n> create mode 100644 lib/efi_loader/efi_file.c\n\nWhat does sanitize_path() do? Please add a comment.\n\nHow do we test all this code?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"betjgBe8\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"cgG5d4sq\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4Xn0WVvz9t7s\n\tfor ;\n\tTue, 12 Sep 2017 22:55:51 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 34EBBC21FED; Tue, 12 Sep 2017 12:39:21 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id EDC62C220B4;\n\tTue, 12 Sep 2017 12:39:17 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 23A4BC22038; Tue, 12 Sep 2017 12:30:49 +0000 (UTC)","from mail-qk0-f176.google.com (mail-qk0-f176.google.com\n\t[209.85.220.176])\n\tby lists.denx.de (Postfix) with ESMTPS id 2364FC21FF5\n\tfor ; Tue, 12 Sep 2017 12:30:45 +0000 (UTC)","by mail-qk0-f176.google.com with SMTP id a128so24577431qkc.5\n\tfor ; Tue, 12 Sep 2017 05:30:45 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:30:22 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=TucjDw4iWd3ycKSp1AAfhn/r2kQHjK3qEVlLE7WS0EQ=;\n\tb=betjgBe8BttW7knKRG1F7M2JrRXbtNAyl7SJ1tGddFKbztVApZnjFE5celXNB2EfFQ\n\tVpyTd/VNn6ctBG16ElFCXXtSThfmGHke0FhR+aKc6kJQzNofcDJ7btRj5FylUczFfT9u\n\tbPa2Hv4EiolvMMAjX1uro7qojj45/KztmLDanSfd+btbJM9ZWQlCJ8byzWXAS6QolVgI\n\tL1p6UidEzpZuS1aBYjtUfEcDFOqhPxe7n+6f3UzWIsyJIU2Zi2wdRDtpOvNHungbw0bG\n\t87OnNN1XqZGWda9silFwgYCRvl6KuMJMzguTxnokOfhcLbBFk1G8zBnwmG98yvTBgORf\n\tyJhA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=TucjDw4iWd3ycKSp1AAfhn/r2kQHjK3qEVlLE7WS0EQ=;\n\tb=cgG5d4sqTpwD1wJ+rNj9Toqc1TorMb505EQh18YKTbyDAj1ht2xALs91PqvTncm/qd\n\tpzOrUC1MO9VOXUzs69Rwm1irODuSK+qXu4+Z6M1e8lr3GQw75Xx0MEVH/Iwh3KGNzpXL\n\teSPQk20+FS2yf1YTzo/Id1atvgqEOBJOlnQTk="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=TucjDw4iWd3ycKSp1AAfhn/r2kQHjK3qEVlLE7WS0EQ=;\n\tb=kRnr3OGRE8/OZkZagD0RwriMKqY5dxnHO4VETfsu4zljY9FGHB/0ijFrzuWQdYQ5fd\n\tvuZGMTeOKS8Jgv2bIHy24gr/JgvpYTVHp0oNGq3d9w5dy2qlCH/TkB7QQX6jm5NMgLqS\n\tQ372+ch9j/1tIlMO/yDyVi0UeAqY8zDxXd1FL90jh26cLiPME3CxK8g+wlt9cpn+qYUZ\n\thrEJDSilA4A45HEnNGgs32Nv+wq/bvEme4Vk/Lxa7MKIACOGHMmbbnFUrXgVm7HbU0JO\n\t2oEASbHwJOJKQwYs+uUjH3nqltj1Wk7EVCtdxCYWIcX+5xXkqlFkwhSRuicT432qytj6\n\t7Xmw==","X-Gm-Message-State":"AHPjjUi6ZjsqWDOcZkfFUXrNFRI9pX5az/AyrtPMjTKXY1JV4BVR3I8F\n\tVlhHql6c46pg/I6lodGfAo9IOTHqKGElsE1dJsg3QcTD","X-Google-Smtp-Source":"AOwi7QAmlkAQ+JYbblRRB18yJCRxlTapPAUGDGQ16ce3PQXsdk7XHHT/4e2kqXB9v9m8d0kBg3zvF+i8XJy07jbpWsU=","X-Received":"by 10.55.146.198 with SMTP id\n\tu189mr18763647qkd.317.1505219443606; \n\tTue, 12 Sep 2017 05:30:43 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170910112149.21358-21-robdclark@gmail.com>","References":"<20170910112149.21358-1-robdclark@gmail.com>\n\t<20170910112149.21358-21-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:30:22 -0600","X-Google-Sender-Auth":"_JUGaNFBGGwd1Ww5uiTaU1z0Zgc","Message-ID":"","To":"Rob Clark ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ,\n\tPeter Jones ","Subject":"Re: [U-Boot] [PATCH v2 11/21] efi_loader: add file/filesys support","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]