[{"id":1767020,"web_url":"http://patchwork.ozlabs.org/comment/1767020/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:30:31","subject":"Re: [U-Boot] [PATCH v2 15/21] efi_loader: add bootmgr","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 10 September 2017 at 05:21, Rob Clark wrote:\n> Similar to a \"real\" UEFI implementation, the bootmgr looks at the\n> BootOrder and BootXXXX variables to try to find an EFI payload to load\n> and boot. This is added as a sub-command of bootefi.\n>\n> The idea is that the distro bootcmd would first try loading a payload\n> via the bootmgr, and then if that fails (ie. first boot or corrupted\n> EFI variables) it would fallback to loading bootaa64.efi. (Which\n> would then load fallback.efi which would look for \\EFI\\*\\boot.csv and\n> populate BootOrder and BootXXXX based on what it found.)\n>\n> Signed-off-by: Rob Clark \n> ---\n> cmd/bootefi.c | 48 ++++++++++-\n> include/config_distro_bootcmd.h | 5 ++\n> include/efi_api.h | 4 +\n> include/efi_loader.h | 6 ++\n> lib/efi_loader/Makefile | 2 +-\n> lib/efi_loader/efi_bootmgr.c | 169 ++++++++++++++++++++++++++++++++++++++\n> lib/efi_loader/efi_boottime.c | 6 +-\n> lib/efi_loader/efi_image_loader.c | 1 +\n> 8 files changed, 235 insertions(+), 6 deletions(-)\n> create mode 100644 lib/efi_loader/efi_bootmgr.c\n\nPlease can you add function comments to your static functions?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"lwY520Ed\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"LLoQVWWr\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4sz4Yc4z9s0g\n\tfor ;\n\tTue, 12 Sep 2017 23:10:47 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9B26AC220A1; Tue, 12 Sep 2017 12:34:17 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 0E40BC2200D;\n\tTue, 12 Sep 2017 12:32:52 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 602C5C2201D; Tue, 12 Sep 2017 12:30:59 +0000 (UTC)","from mail-qt0-f170.google.com (mail-qt0-f170.google.com\n\t[209.85.216.170])\n\tby lists.denx.de (Postfix) with ESMTPS id 41D52C21DF7\n\tfor ; Tue, 12 Sep 2017 12:30:53 +0000 (UTC)","by mail-qt0-f170.google.com with SMTP id t46so1338661qtj.2\n\tfor ; Tue, 12 Sep 2017 05:30:53 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:30:31 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=abfKGg5KDlh2uo8Pjz01Otbb/AYT4urYCdSLUsxZ4m4=;\n\tb=lwY520Edhux+BWcQRpi8Y/sPq2MzC/uXPUvQL5NQvwYKFBQCVkITV+B4u778nD6IcW\n\tEbh/WRn5q66VxdlfsjqN1UQNU0qDXmOrdcSxnv2pi6In7Xwf/C8dIthcxtD5m78Ag1Vn\n\tJuse+Uv4PE5S14Gr9xsSETj3f5ivwmItD7xG6KioMJ5h5uYG4UIk5/iczcwgg1PNScGO\n\tqxA3PUHDlS22iX4yb5Ynbh8CfYOf6gGEQVGr7YGlSX+QMDO+NiPtgv/dILLk/osjIG/Z\n\tvBXyh0fuXCMQqe3M6Iv3Ehpxaa5VsKTfnBV1FtdICaPKKFZqnsNaNGZoBHiZRBt/xwFT\n\tGxbA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=abfKGg5KDlh2uo8Pjz01Otbb/AYT4urYCdSLUsxZ4m4=;\n\tb=LLoQVWWrsTkZ3XLwsZk19TA93qySyTit3q85oz5DSYXmrT9ydV+Os65qoP2Dig++/t\n\tvXV/gXjUvMwaDxsiYT4vln4oEtxraqqx5Fxm31fXhWpzEYccuxzHwa0NjbDTmOkWQ6w6\n\tCoQxCD2RjQlXQyMJTof9w4cXtrpRC9zC9rf9s="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=abfKGg5KDlh2uo8Pjz01Otbb/AYT4urYCdSLUsxZ4m4=;\n\tb=KS+KiBI+rmv+L/Z+axJuQKjzG3t23LgIVrUR2XoRPmYPeEU1bhrahJwWmH/cmo0V0r\n\tIQbee+C/hn477Imt1mcJNlSb2sVVcy4uyjgrSt1SIgY7DxBrgtfRT1P3m+mDhLeXJ1M1\n\tZthSEExm7tJ41eo8APtb7tlChhKSDojqb/L9kkIpnaHo+gsYdbiYxxVVJ/sY0oCSjIRQ\n\tOG91G70eqrTq4XGutLGbgIjxN98prhGMGqJA8fzBDD7UGUTmrLTEB+nz0QF3HR4P5Fp3\n\tzg6egWOlAstMW6yKY+9A31naQX6Vx0mFuHqJM/+shbO5LIdVCbkSNDp/9bJeknjRWKPg\n\toWOw==","X-Gm-Message-State":"AHPjjUh/Mziu6pA+vKn4pRvnNWFOX9pMp5BgjES26EVpwjo03MC9Pbsl\n\tt97H4/QtDC1HJBfg6MR7IT9dJKEam5FvUGO1dcs8HD+S","X-Google-Smtp-Source":"AOwi7QDxnocO18pDyqdhfdRxt3reIMc9PfjHA4fF/SWG6d6jclkwe5EgE+5569scAkBa0maRBFl6pIRYW8WGMNjknAo=","X-Received":"by 10.237.37.182 with SMTP id x51mr20197876qtc.5.1505219451981; \n\tTue, 12 Sep 2017 05:30:51 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170910112149.21358-25-robdclark@gmail.com>","References":"<20170910112149.21358-1-robdclark@gmail.com>\n\t<20170910112149.21358-25-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:30:31 -0600","X-Google-Sender-Auth":"lfnj0DxsZvOCI8FB17QhjRoRC0M","Message-ID":"","To":"Rob Clark ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ,\n\tPeter Jones ","Subject":"Re: [U-Boot] [PATCH v2 15/21] efi_loader: add bootmgr","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]